From nobody@FreeBSD.org  Fri Aug 16 03:02:29 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTP id 02011307
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 16 Aug 2013 03:02:29 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id CA9D529AB
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 16 Aug 2013 03:02:28 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r7G32ST3034767
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 16 Aug 2013 03:02:28 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r7G32SN5034765;
	Fri, 16 Aug 2013 03:02:28 GMT
	(envelope-from nobody)
Message-Id: <201308160302.r7G32SN5034765@oldred.freebsd.org>
Date: Fri, 16 Aug 2013 03:02:28 GMT
From: nemysis <nemysis@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] devel/qmake4: Fix port test and Tinderbox, trim ${LN}
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         181335
>Category:       ports
>Synopsis:       [PATCH] devel/qmake4: Fix port test and Tinderbox, trim ${LN}
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kde
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 16 03:10:01 UTC 2013
>Closed-Date:    Wed Oct 16 22:26:34 UTC 2013
>Last-Modified:  Wed Oct 16 22:26:34 UTC 2013
>Originator:     nemysis
>Release:        FreeBSD 9.1-RELEASE-p17 amd64
>Organization:
>Environment:
FreeBSD FreeBSD_Ports 9.1-RELEASE-p17 FreeBSD 9.1-RELEASE-p17 #0: Sun Jul 28 00:39:53 UTC 2013
>Description:
- Remove MAKE_JOBS_SAFE
- Correctly use -sf flags for ${LN}
- Fix port test and Tinderbox
- Trim pkg-plist
>How-To-Repeat:
Build log

https://redports.org/buildarchive/20130816020800-12276/
>Fix:


Patch attached with submission follows:

Original version does not exist at /usr/ports/devel/qt4-qmake
Using /usr/ports/devel/qmake4 instead
===> Generating patch
===> Viewing diff with more
diff -ruN /usr/ports/devel/qmake4/Makefile ./Makefile
--- /usr/ports/devel/qmake4/Makefile	2013-06-02 19:00:13.000000000 +0200
+++ ./Makefile	2013-08-16 04:07:34.000000000 +0200
@@ -16,7 +16,6 @@
 WRKSRC=		${WRKDIR}/${DISTNAME}/${PORTNAME}
 MAKEFILE=	${FILESDIR}/Makefile.bsd
 MAKE_ENV+=	FILESDIR="${FILESDIR}"
-MAKE_JOBS_SAFE=	yes
 TODAY_CMD=	/bin/date +%Y-%m-%d
 
 EXTRACT_AFTER_ARGS= \
@@ -72,9 +71,10 @@
 		< ${FILESDIR}/qconfig.cpp \
 		> ${WRKSRC:H}/src/corelib/global/qconfig.cpp
 	${ECHO} '/* empty */' > ${WRKSRC}/qconfig.h
-	${LN} ${WRKSRC}/qconfig.h ${WRKSRC}/../src/corelib/global/qconfig.h
+	${LN} -sf ${WRKSRC}/qconfig.h ${WRKSRC}/../src/corelib/global/qconfig.h
 
 post-install:
-	${LN} -sf ${PREFIX}/share/qt4/mkspecs/freebsd-${QMAKE_BASE_COMPILER} ${PREFIX}/share/qt4/mkspecs/default
+	@${MKDIR} ${PREFIX}/share/qt4/mkspecs/default/
+	${LN} -sf ${PREFIX}/share/qt4/mkspecs/freebsd-${QMAKE_BASE_COMPILER} ${PREFIX}/share/qt4/mkspecs/default/
 
 .include <bsd.port.mk>
diff -ruN /usr/ports/devel/qmake4/pkg-plist ./pkg-plist
--- /usr/ports/devel/qmake4/pkg-plist	2013-06-02 19:00:13.000000000 +0200
+++ ./pkg-plist	2013-08-16 03:52:52.000000000 +0200
@@ -81,7 +81,7 @@
 share/qt4/mkspecs/cygwin-g++/qplatformdefs.h
 share/qt4/mkspecs/darwin-g++/qmake.conf
 share/qt4/mkspecs/darwin-g++/qplatformdefs.h
-share/qt4/mkspecs/default
+share/qt4/mkspecs/default/freebsd-g++
 share/qt4/mkspecs/features/build_pass.prf
 share/qt4/mkspecs/features/dbusadaptors.prf
 share/qt4/mkspecs/features/dbusinterfaces.prf
@@ -720,6 +720,8 @@
 @dirrm share/qt4/mkspecs/features/symbian
 @dirrm share/qt4/mkspecs/features/mac
 @dirrmtry share/qt4/mkspecs/features
+@dirrm share/qt4/mkspecs/default/freebsd-g++
+@dirrm share/qt4/mkspecs/default
 @dirrm share/qt4/mkspecs/darwin-g++
 @dirrm share/qt4/mkspecs/cygwin-g++
 @dirrm share/qt4/mkspecs/common/wince
===> Done


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->kde 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Aug 16 03:10:14 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181335 

From: Raphael Kubo da Costa <rakuco@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc: nemesys@FreeBSD.org
Subject: Re: ports/181335: [PATCH] devel/qmake4: Fix port test and Tinderbox, trim ${LN}
Date: Sun, 08 Sep 2013 02:03:30 +0300

 +nemesys, now with the right email address.

From: Raphael Kubo da Costa <rakuco@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc: nemesys@FreeSBD.org, kde@FreeBSD.org
Subject: Re: ports/181335: [PATCH] devel/qmake4: Fix port test and Tinderbox, trim ${LN}
Date: Sun, 08 Sep 2013 02:00:58 +0300

 Hi,
 
 I'm not sure I'm following what you're trying to fix here: was the first
 `ln' call failing without anyone noticing? The second change also looks
 strange, as mkspecs/default itself is supposed to be a symlink.

From: Raphael Kubo da Costa <rakuco@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc: nemysis@FreeBSD.org
Subject: Re: ports/181335: [PATCH] devel/qmake4: Fix port test and Tinderbox, trim ${LN}
Date: Sun, 08 Sep 2013 21:52:21 +0300

 +nemysis, hopefully I got his nick correctly after two attempts :-)

From: nemysis <nemysis@FreeBSD.org>
To: bug-followup@FreeBSD.org, rakuco@FreeBSD.org
Cc: nemysis@FreeBSD.org
Subject: ports/181335: [PATCH] devel/qmake4: Fix port test and Tinderbox,
 trim ${LN}
Date: Tue, 10 Sep 2013 17:18:49 +0200

 > +nemysis, hopefully I got his nick correctly after two attempts :-)
 
 @rakuco, yes this is right now :-)
 
 This pr is not needed, please close it.
State-Changed-From-To: open->closed 
State-Changed-By: nemysis 
State-Changed-When: Wed Oct 16 22:26:34 UTC 2013 
State-Changed-Why:  
This pr is not needed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181335 
>Unformatted:
