From dann@bigphred.greycat.com  Thu Apr 20 23:46:07 2000
Return-Path: <dann@bigphred.greycat.com>
Received: from bigphred.greycat.com (bigphred.greycat.com [207.173.133.2])
	by hub.freebsd.org (Postfix) with ESMTP id 2258137B5C1
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 20 Apr 2000 23:46:02 -0700 (PDT)
	(envelope-from dann@bigphred.greycat.com)
Received: (from dann@localhost)
	by bigphred.greycat.com (8.9.3/8.9.3) id XAA66078;
	Thu, 20 Apr 2000 23:46:26 -0700 (PDT)
	(envelope-from dann)
Message-Id: <200004210646.XAA66078@bigphred.greycat.com>
Date: Thu, 20 Apr 2000 23:46:26 -0700 (PDT)
From: dann@greycat.com
Sender: dann@bigphred.greycat.com
Reply-To: dann@greycat.com
To: FreeBSD-gnats-submit@freebsd.org
Subject: Wine build failure on 4.0-STABLE; bison vs. byacc
X-Send-Pr-Version: 3.2

>Number:         18125
>Category:       ports
>Synopsis:       Wine build failure on 4.0-STABLE, works on 3.4.  Byacc vs bison
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Apr 20 23:50:01 PDT 2000
>Closed-Date:    Sat Apr 29 16:40:12 PDT 2000
>Last-Modified:  Sat Apr 29 16:41:01 PDT 2000
>Originator:     Dann Lunsford
>Release:        FreeBSD 4.0-STABLE i386
>Organization:
You're kidding, right?
>Environment:

4.0-STABLE as of 18-APR-2000.4.0-STABLE as of 18-APR-2000.4.0-STABLE as of 18-APR-2000.4.0-STABLE as of 18-APR-2000.

>Description:

The Wine port build fails on 4-STABLE.  There's a missing ';' in tools/wrc/parser.y,
causing a syntax error.  Under 3-STABLE, bison is used to process this file,
which apparently corrects the error, producing a y.tab.c that's correct.
Under 4-STABLE, byacc is used, which does NOT correct the error, causing
the build failure.  

>How-To-Repeat:

	build Wine from ports on a 4-STABLE system.

>Fix:
 The fix is to make sure that tools/wrc/parser.y is correct. Diff follows:
--- tools/wrc/parser.y.orig	Thu Apr 20 23:24:05 2000
+++ tools/wrc/parser.y	Thu Apr 20 23:25:51 2000
@@ -1621,7 +1621,7 @@
 e_expr	: /* Empty */	{ $$ = 0; }
 	| expr		{ $$ = new_int($1); }
 	;
-expr	: xpr	{ $$ = ($1) }
+expr	: xpr	{ $$ = ($1); }
 	;
 
 xpr	: xpr '+' xpr	{ $$ = ($1) + ($3); }

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: steve 
State-Changed-When: Sat Apr 29 16:40:12 PDT 2000 
State-Changed-Why:  
Committed, thanks! 
>Unformatted:
