From john.marshall@riverwillow.com.au  Tue Aug 13 06:34:57 2013
Return-Path: <john.marshall@riverwillow.com.au>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTP id 18D39B7A
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 13 Aug 2013 06:34:57 +0000 (UTC)
	(envelope-from john.marshall@riverwillow.com.au)
Received: from mail1.riverwillow.net.au (mail1.riverwillow.net.au [203.58.93.36])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id 970052C9E
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 13 Aug 2013 06:34:55 +0000 (UTC)
Received: from rwsrv08.mby.riverwillow.net.au (localhost [127.0.0.1])
	by mail1.riverwillow.net.au (8.14.7/8.14.7) with ESMTP id r7D6JbkP018745
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 13 Aug 2013 16:19:37 +1000 (EST)
Received: (from john@localhost)
	by rwsrv08.mby.riverwillow.net.au (8.14.7/8.14.7/Submit) id r7D6Jbxb018744;
	Tue, 13 Aug 2013 16:19:37 +1000 (EST)
Message-Id: <201308130619.r7D6Jbxb018744@rwsrv08.mby.riverwillow.net.au>
Date: Tue, 13 Aug 2013 16:19:37 +1000 (EST)
From: John Marshall <john.marshall@riverwillow.com.au>
Reply-To: John Marshall <john.marshall@riverwillow.com.au>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] print/cups-base Disable INSTALLS_ICONS for non-X11
X-Send-Pr-Version: 3.114
X-GNATS-Notify: c.petrik.sosa@gmail.com

>Number:         181248
>Category:       ports
>Synopsis:       [PATCH] print/cups-base Disable INSTALLS_ICONS for non-X11
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 13 06:40:00 UTC 2013
>Closed-Date:    Sat Apr 26 12:26:25 UTC 2014
>Last-Modified:  Sat Apr 26 12:26:25 UTC 2014
>Originator:     John Marshall
>Release:        FreeBSD 9.2-RC1 amd64
>Organization:
Riverwillow Pty Ltd
>Environment:
System: FreeBSD rwsrv08.mby.riverwillow.net.au 9.2-RC1 FreeBSD 9.2-RC1 #0 r254103: Fri Aug 9 09:30:29 AEST 2013 root@rwsrv08.mby.riverwillow.net.au:/usr/obj/usr/src/sys/RWSRV08 amd64


	
>Description:

r324269 introduced INSTALLS_ICONS to the Makefile.  This has the
wonderful side-effect of pulling in the entire GNOME toolchain on a
server.  How about wrapping this baby in a conditional blanket so that
more server admin's don't have to spend ages trying to figure out what
pulled in all those GUI ports?

>How-To-Repeat:

cd /usr/ports/print/cups-base
make depends

>Fix:

Neither r324269 (which introduced INSTALLS_ICONS) nor r324428 (which
moved its location) bumped PORTREVISION, so this patch doesn't either.

--- cups-base_324646.diff begins here ---
Index: print/cups-base/Makefile
===================================================================
--- print/cups-base/Makefile	(revision 324646)
+++ print/cups-base/Makefile	(working copy)
@@ -67,7 +67,9 @@
 LICENSE=	LGPL21
 OPTIONS_DEFINE=	GNUTLS
 .else
+.if !defined(WITHOUT_X11)
 INSTALLS_ICONS=	yes
+.endif
 PORTREVISION=	1
 CUPS_SUFFIX=	-base
 OPTIONS_DEFINE=	GNUTLS LIBPAPER PHP PYTHON PAM LDAP DBUS LIBUSB XDG_OPEN GHOSTSCRIPT XPDF AVAHI MDNSRESPONDER
--- cups-base_324646.diff ends here ---


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Aug 13 06:40:09 UTC 2013 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181248 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: c.petrik.sosa@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/181248: [PATCH] print/cups-base Disable INSTALLS_ICONS for non-X11
Date: Tue, 13 Aug 2013 06:40:09 UT

 Maintainer of print/cups-base,
 
 Please note that PR ports/181248 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/181248
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Derek Kulinski <takeda@takeda.tk>
To: bug-followup@FreeBSD.org, john.marshall@riverwillow.com.au
Cc:  
Subject: Re: ports/181248: [PATCH] print/cups-base Disable INSTALLS_ICONS for non-X11
Date: Tue, 20 Aug 2013 18:42:31 -0700

 Thanks John, for the fix I noticed it when I tried to update cups and
 portmaster showed me a huge list of ports that it'll install.
 
 I too would like to have this patch included, though I'm wondering if
 there was a reason not moving INSTALLS_ICONS in XDG_OPEN block as
 follows: 
 
 .if !defined(CUPS_CLIENT) && !defined(CUPS_IMAGE) && ${PORT_OPTIONS:MXDG_OPEN}
 RUN_DEPENDS+=           xdg-open:${PORTSDIR}/devel/xdg-utils
 INSTALLS_ICONS=true
 .endif
 
 As I understand this the part which adds X11 dependency, and as I
 understand WITHOUT_X11 is a legacy option.
 It also possibly fixes what commit 324428 was trying to fix, which is
 to make sure that this variable should be only defined for the
 cups-base.
 
 Best regards,
 Derek
 
Responsible-Changed-From-To: freebsd-ports-bugs->bsam 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sat Jan 4 05:46:49 UTC 2014 
Responsible-Changed-Why:  
Over to new maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181248 
Responsible-Changed-From-To: bsam->freebsd-ports-bugs 
Responsible-Changed-By: bsam 
Responsible-Changed-When: Sun Feb 16 21:20:07 UTC 2014 
Responsible-Changed-Why:  
I do t maintain the port any more. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181248 
State-Changed-From-To: feedback->closed 
State-Changed-By: bsam 
State-Changed-When: Sat Apr 26 12:25:22 UTC 2014 
State-Changed-Why:  
An options has been introduced at r352145. Thanks for the PR! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181248 
>Unformatted:
