From nobody@FreeBSD.org  Sat Aug 10 11:54:12 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTP id C1D45CD3
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 10 Aug 2013 11:54:12 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id 3454827ED
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 10 Aug 2013 11:54:12 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r7ABsCWs025218
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 10 Aug 2013 11:54:12 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r7ABsC6l025213;
	Sat, 10 Aug 2013 11:54:12 GMT
	(envelope-from nobody)
Message-Id: <201308101154.r7ABsC6l025213@oldred.freebsd.org>
Date: Sat, 10 Aug 2013 11:54:12 GMT
From: Boris Samorodov <bsam@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] audio/twolame: add ftp/curl dependency
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         181213
>Category:       ports
>Synopsis:       [patch] audio/twolame: add ftp/curl dependency
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    wg
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Aug 10 12:00:00 UTC 2013
>Closed-Date:    Thu Oct 31 19:38:46 UTC 2013
>Last-Modified:  Thu Oct 31 19:38:46 UTC 2013
>Originator:     Boris Samorodov
>Release:        FreeBSD 10-amd64
>Organization:
BSDprint
>Environment:
FreeBSD BB049.int.wart.ru 10.0-CURRENT FreeBSD 10.0-CURRENT #50 r253993: Tue Aug  6 20:03:20 SAMT 2013     bsam@BB049.int.wart.ru:/usr/obj/usr/src/sys/BB64X  amd64
>Description:
After recent ftp/curl upgrade I get this:
-----
% pkg_libchk -a
twolame-0.3.13: /usr/local/bin/twolame misses libFLAC.so.10
-----

Analysis:
The port has a direct dependency (showed above). And the dependency should be listed at audio/twolame itself. And this port should bump PORTREVISION if library at audio/flac changes.
>How-To-Repeat:
Upgrade audio/flac to new version while having audio/twolame built with an older audio/flac version.
>Fix:
. add audio/flac to LIB_DEPENDS;
. bump PORTREVISION (for audio/flac library version change).

Patch attached with submission follows:

Index: Makefile
===================================================================
--- Makefile	(revision 324469)
+++ Makefile	(working copy)
@@ -7,6 +7,7 @@
 
 PORTNAME=	twolame
 PORTVERSION=	0.3.13
+PORTREVISION=	1
 CATEGORIES=	audio
 MASTER_SITES=	SF \
 		http://www.ecs.soton.ac.uk/~njh/twolame/
@@ -14,7 +15,8 @@
 MAINTAINER=	multimedia@FreeBSD.org
 COMMENT=	MPEG Audio Layer 2 encoder
 
-LIB_DEPENDS=	sndfile.1:${PORTSDIR}/audio/libsndfile
+LIB_DEPENDS=	sndfile.1:${PORTSDIR}/audio/libsndfile \
+		FLAC:${PORTSDIR}/audio/flac
 
 USE_GMAKE=	yes
 USE_GNOME=	gnomehack pkgconfig


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->freebsd-multimedia 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Aug 10 12:00:09 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181213 
Responsible-Changed-From-To: freebsd-multimedia->wg 
Responsible-Changed-By: wg 
Responsible-Changed-When: Thu Oct 31 12:50:39 UTC 2013 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181213 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/181213: commit references a PR
Date: Thu, 31 Oct 2013 13:00:47 +0000 (UTC)

 Author: wg
 Date: Thu Oct 31 13:00:38 2013
 New Revision: 332237
 URL: http://svnweb.freebsd.org/changeset/ports/332237
 
 Log:
   audio/twolame: bring additional lib dependencies
   
   - FLAC, vorbis and ogg and linked with bin/twolame [1] (based on)
   
   PR:		ports/181213 [1]
   Submitted by:	bsam
 
 Modified:
   head/audio/twolame/Makefile
 
 Modified: head/audio/twolame/Makefile
 ==============================================================================
 --- head/audio/twolame/Makefile	Thu Oct 31 12:56:19 2013	(r332236)
 +++ head/audio/twolame/Makefile	Thu Oct 31 13:00:38 2013	(r332237)
 @@ -3,6 +3,7 @@
  
  PORTNAME=	twolame
  PORTVERSION=	0.3.13
 +PORTREVISION=	1
  CATEGORIES=	audio
  MASTER_SITES=	SF \
  		http://www.ecs.soton.ac.uk/~njh/twolame/
 @@ -10,7 +11,10 @@ MASTER_SITES=	SF \
  MAINTAINER=	multimedia@FreeBSD.org
  COMMENT=	MPEG Audio Layer 2 encoder
  
 -LIB_DEPENDS=	libsndfile.so:${PORTSDIR}/audio/libsndfile
 +LIB_DEPENDS=	libsndfile.so:${PORTSDIR}/audio/libsndfile \
 +		libFLAC.so:${PORTSDIR}/audio/flac \
 +		libvorbis.so:${PORTSDIR}/audio/livorbis \
 +		libogg.so:${PORTSDIR}/audio/libogg
  
  USES=		gmake pathfix pkgconfig
  USE_LDCONFIG=	yes
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: wg 
State-Changed-When: Thu Oct 31 19:38:45 UTC 2013 
State-Changed-Why:  
Fixed, thanksa 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181213 
>Unformatted:
