From wg@FreeBSD.org  Thu Jul 25 13:08:58 2013
Return-Path: <wg@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTP id 0ACB435A
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 25 Jul 2013 13:08:58 +0000 (UTC)
	(envelope-from wg@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id EBDD72832
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 25 Jul 2013 13:08:57 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r6PD8v7E026689
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 25 Jul 2013 13:08:57 GMT
	(envelope-from wg@freefall.freebsd.org)
Received: (from wg@localhost)
	by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r6PD8v3X026688;
	Thu, 25 Jul 2013 13:08:57 GMT
	(envelope-from wg)
Message-Id: <201307251308.r6PD8v3X026688@freefall.freebsd.org>
Date: Thu, 25 Jul 2013 13:08:57 GMT
From: William Grzybowski <wg@FreeBSD.org>
Reply-To: William Grzybowski <wg@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] net-mgmt/collectd5: fix PYTHON option
X-Send-Pr-Version: 3.114
X-GNATS-Notify: ports@bsdserwis.com

>Number:         180838
>Category:       ports
>Synopsis:       [PATCH] net-mgmt/collectd5: fix PYTHON option
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    wg
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 25 13:10:02 UTC 2013
>Closed-Date:    Sun Aug 04 13:10:41 UTC 2013
>Last-Modified:  Sun Aug 04 13:10:41 UTC 2013
>Originator:     William Grzybowski
>Release:        FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
System: FreeBSD freefall.freebsd.org 10.0-CURRENT FreeBSD 10.0-CURRENT #1 r251226: Sat Jun 1 21:56:43 UTC 2013 peter@freefall.freebsd.org:/usr/obj/usr/src/sys/FREEFALL amd64

>Description:

	Fix PYTHON option (wont build), add NOTIFYEMAIL missing in OPTIONS_DEFINE

>How-To-Repeat:

>Fix:

	See attached patch



--- collectd5.patch begins here ---
Index: Makefile
===================================================================
--- Makefile	(revision 323639)
+++ Makefile	(working copy)
@@ -3,7 +3,7 @@
 
 PORTNAME=	collectd
 PORTVERSION=	5.3.0
-PORTREVISION=	3
+PORTREVISION=	4
 CATEGORIES=	net-mgmt
 MASTER_SITES=	http://collectd.org/files/
 
@@ -17,7 +17,7 @@
 
 LATEST_LINK=	collectd5
 
-OPTIONS_DEFINE=		CGI CURL DEBUG DBI GCRYPT JSON MEMCACHEC MODBUS MYSQL NUTUPS PGSQL PING PYTHON REDIS ROUTEROS RRDTOOL SNMP STATGRAB TOKYOTYRANT VIRT XML XMMS
+OPTIONS_DEFINE=		CGI CURL DEBUG DBI GCRYPT JSON MEMCACHEC MODBUS MYSQL NOTIFYEMAIL NUTUPS PGSQL PING PYTHON REDIS ROUTEROS RRDTOOL SNMP STATGRAB TOKYOTYRANT VIRT XML XMMS
 
 CGI_DESC=		Install collection.cgi (requires rrdtool)
 CURL_DESC=		Enable curl-based plugins (apache, nginx, etc)
@@ -99,7 +99,6 @@
 		--without-libyajl \
 		--without-oracle \
 		--without-perl-bindings \
-		--without-python
 
 # NOTE: Plugins without external dependencies
 CONFIGURE_ARGS+=	\
@@ -275,9 +274,10 @@
 
 .if ${PORT_OPTIONS:MPYTHON}
 USE_PYTHON=	yes
-CONFIGURE_ARGS+=--with-python=${LOCALBASE} --enable-python
+CONFIGURE_ARGS+=--with-python=${PYTHON_CMD} --enable-python
 PLIST_SUB+=	PYTHON=""
 .else
+CONFIGURE_ARGS+=--without-python
 PLIST_SUB+=	PYTHON="@comment "
 .endif
 
--- collectd5.patch ends here ---

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Jul 25 13:10:16 UTC 2013 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=180838 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: ports@bsdserwis.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/180838: [PATCH] net-mgmt/collectd5: fix PYTHON option
Date: Thu, 25 Jul 2013 13:10:15 UT

 Maintainer of net-mgmt/collectd5,
 
 Please note that PR ports/180838 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/180838
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: freebsd-ports-bugs->wg 
Responsible-Changed-By: wg 
Responsible-Changed-When: Fri Jul 26 13:03:57 UTC 2013 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=180838 

From: Krzysztof Stryjek <ports@bsdserwis.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/180838: [PATCH] net-mgmt/collectd5: fix PYTHON option
Date: Sat, 3 Aug 2013 23:07:39 +0200

 Hello,
 
 On Thu, Jul 25, 2013 at 01:10:15PM +0000, Edwin Groothuis wrote:
 > Maintainer of net-mgmt/collectd5,
 > 
 > Please note that PR ports/180838 has just been submitted.
 > 
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 > 
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/180838
 > 
 > -- 
 > Edwin Groothuis via the GNATS Auto Assign Tool
 > edwin@FreeBSD.org
 > 
 Yes, I approve this patch. Sorry for delay, but I was on vacation :-)))
 
 Greetings,
 -- 
 Krzysztof Stryjek
 UNIX administrator/Juniper Networks Specialist
 email: wtp (at) bsdserwis (dot) com
 http://www.linkedin.com/in/KrzysztofStryjek
 GPG fingerprint: 8BD7 40CE 8994 0BBE CE6C  91CD 1292 8959 DC61 0E76
 
 In theory, there is no difference between theory and practice.
 In practice, there is.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/180838: commit references a PR
Date: Sun,  4 Aug 2013 13:05:57 +0000 (UTC)

 Author: wg
 Date: Sun Aug  4 13:05:44 2013
 New Revision: 324229
 URL: http://svnweb.freebsd.org/changeset/ports/324229
 
 Log:
   net-mgmt/collectd5: fix PYTHON option
   
   - Fix PYTHON option (use ${PYTHON_CMD})
   
   PR:		ports/180838
   Submitted by:	wg (myself)
   Approved by:	maintainer
 
 Modified:
   head/net-mgmt/collectd5/Makefile
 
 Modified: head/net-mgmt/collectd5/Makefile
 ==============================================================================
 --- head/net-mgmt/collectd5/Makefile	Sun Aug  4 13:04:54 2013	(r324228)
 +++ head/net-mgmt/collectd5/Makefile	Sun Aug  4 13:05:44 2013	(r324229)
 @@ -3,7 +3,7 @@
  
  PORTNAME=	collectd
  PORTVERSION=	5.3.0
 -PORTREVISION=	3
 +PORTREVISION=	4
  CATEGORIES=	net-mgmt
  MASTER_SITES=	http://collectd.org/files/
  
 @@ -17,7 +17,7 @@ USE_AUTOTOOLS=	autoconf autoheader autom
  
  LATEST_LINK=	collectd5
  
 -OPTIONS_DEFINE=		CGI CURL DEBUG DBI GCRYPT JSON MEMCACHEC MODBUS MYSQL NUTUPS PGSQL PING PYTHON REDIS ROUTEROS RRDTOOL SNMP STATGRAB TOKYOTYRANT VIRT XML XMMS
 +OPTIONS_DEFINE=		CGI CURL DEBUG DBI GCRYPT JSON MEMCACHEC MODBUS MYSQL NOTIFYEMAIL NUTUPS PGSQL PING PYTHON REDIS ROUTEROS RRDTOOL SNMP STATGRAB TOKYOTYRANT VIRT XML XMMS
  
  CGI_DESC=		Install collection.cgi (requires rrdtool)
  CURL_DESC=		Enable curl-based plugins (apache, nginx, etc)
 @@ -99,7 +99,6 @@ CONFIGURE_ARGS=	--localstatedir=/var \
  		--without-libyajl \
  		--without-oracle \
  		--without-perl-bindings \
 -		--without-python
  
  # NOTE: Plugins without external dependencies
  CONFIGURE_ARGS+=	\
 @@ -275,12 +274,12 @@ PLIST_SUB+=	PING="@comment "
  
  .if ${PORT_OPTIONS:MPYTHON}
  USE_PYTHON=	yes
 -CONFIGURE_ARGS+=--with-python=${LOCALBASE} --enable-python
 +CONFIGURE_ARGS+=--with-python=${PYTHON_CMD} --enable-python
  PLIST_SUB+=	PYTHON=""
  .else
 +CONFIGURE_ARGS+=--without-python
  PLIST_SUB+=	PYTHON="@comment "
  .endif
 -
  .if ${PORT_OPTIONS:MREDIS}
  LIB_DEPENDS+=	credis:${PORTSDIR}/databases/credis
  CONFIGURE_ARGS+=--with-libcredis=${LOCALBASE} \
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->closed 
State-Changed-By: wg 
State-Changed-When: Sun Aug 4 13:10:40 UTC 2013 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=180838 
>Unformatted:
