From nobody@FreeBSD.org  Thu Jul 18 03:52:46 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	by hub.freebsd.org (Postfix) with ESMTP id 75D5059B
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 18 Jul 2013 03:52:46 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121])
	by mx1.freebsd.org (Postfix) with ESMTP id 4E593234
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 18 Jul 2013 03:52:46 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r6I3qjSV079865
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 18 Jul 2013 03:52:46 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r6I3qjsw079860;
	Thu, 18 Jul 2013 03:52:45 GMT
	(envelope-from nobody)
Message-Id: <201307180352.r6I3qjsw079860@oldred.freebsd.org>
Date: Thu, 18 Jul 2013 03:52:45 GMT
From: "r4721@tormail.org" <r4721@tormail.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] fix display issues in editors/chexedit
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         180623
>Category:       ports
>Synopsis:       [patch] fix display issues in editors/chexedit
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    amdmi3
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 18 04:00:00 UTC 2013
>Closed-Date:    Mon Jul 22 17:30:26 UTC 2013
>Last-Modified:  Mon Jul 22 17:30:26 UTC 2013
>Originator:     r4721@tormail.org
>Release:        
>Organization:
>Environment:
>Description:
* remove patch hunk from patch-src-file.c that alters timestamp format. this was apparently to work around some issue in ncurses from freebsd 4 which is no longer present and today causes the timestamps to overflow their field in the directory view.

* add use_default_colors() call to patch-src-init.c to handle some changed default actions in ncurses over the years. this fixes the blank windows that occur with chexedit in some terminal programs like rxvt-unicode when background and foreground are set.

* add LICENSE
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: editors/chexedit/Makefile
===================================================================
--- editors/chexedit/Makefile	(revision 323155)
+++ editors/chexedit/Makefile	(working copy)
@@ -12,6 +12,9 @@
 MAINTAINER=	amdmi3@FreeBSD.org
 COMMENT=	Full screen text mode Hex editor using the [n]curses library
 
+LICENSE=	GPLv2
+LICENSE_FILE=	${WRKSRC}/COPYING
+
 GNU_CONFIGURE=	yes
 PLIST_FILES=	bin/chexedit
 
Index: editors/chexedit/files/patch-src-file.c
===================================================================
--- editors/chexedit/files/patch-src-file.c	(revision 323155)
+++ editors/chexedit/files/patch-src-file.c	(working copy)
@@ -8,14 +8,3 @@
  #include <grp.h>
  #include <pwd.h>
  
-@@ -618,8 +619,8 @@
- 
-          wprintw (Globals.wmain,
-    /* why does it seem like on OpenBSD this is broken? */
--#if defined(__OpenBSD__) || defined(BROKEN)
--            "%s %-8s %-8s %10ld %1d\b2d-%02d-%02d %02d:%02d ",
-+#if defined(__OpenBSD__) || defined(__FreeBSD__) || defined(BROKEN)
-+            "%s %-8s %-8s %10ld %1d\b%04d-%02d-%02d %02d:%02d ",
- #else
-             "%s %-8s %-8s %10ld %d-%02d-%02d %02d:%02d ",
- #endif
Index: editors/chexedit/files/patch-src-init.c
===================================================================
--- editors/chexedit/files/patch-src-init.c	(revision 323155)
+++ editors/chexedit/files/patch-src-init.c	(working copy)
@@ -12,7 +12,15 @@
  extern char **environ;
  
  
-@@ -463,7 +468,7 @@
+@@ -250,6 +255,7 @@
+    if (color_term != -1)
+    {
+       start_color ();
++      use_default_colors();
+       if ((color_term = has_colors ()))
+       {
+          color_term = 1;
+@@ -463,7 +469,7 @@
        filestat.st_size = DEFAULT_BUFFER_SIZE;
     }
  


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->amdmi3 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Jul 18 04:00:07 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=180623 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/180623: commit references a PR
Date: Mon, 22 Jul 2013 17:28:51 +0000 (UTC)

 Author: amdmi3
 Date: Mon Jul 22 17:28:38 2013
 New Revision: 323482
 URL: http://svnweb.freebsd.org/changeset/ports/323482
 
 Log:
   - Fix timestamp display in file view
   - Fix colors on some terminals
   - Add LICENSE
   
   PR:		180623
   Submitted by:	"r4721@tormail.org" <r4721@tormail.org>
 
 Modified:
   head/editors/chexedit/Makefile
   head/editors/chexedit/files/patch-src-file.c
   head/editors/chexedit/files/patch-src-init.c
 
 Modified: head/editors/chexedit/Makefile
 ==============================================================================
 --- head/editors/chexedit/Makefile	Mon Jul 22 17:24:50 2013	(r323481)
 +++ head/editors/chexedit/Makefile	Mon Jul 22 17:28:38 2013	(r323482)
 @@ -12,6 +12,9 @@ DISTNAME=	hexedit-${PORTVERSION}
  MAINTAINER=	amdmi3@FreeBSD.org
  COMMENT=	Full screen text mode Hex editor using the [n]curses library
  
 +LICENSE=	GPLv2
 +LICENSE_FILE=	${WRKSRC}/COPYING
 +
  GNU_CONFIGURE=	yes
  PLIST_FILES=	bin/chexedit
  
 
 Modified: head/editors/chexedit/files/patch-src-file.c
 ==============================================================================
 --- head/editors/chexedit/files/patch-src-file.c	Mon Jul 22 17:24:50 2013	(r323481)
 +++ head/editors/chexedit/files/patch-src-file.c	Mon Jul 22 17:28:38 2013	(r323482)
 @@ -8,14 +8,3 @@
   #include <grp.h>
   #include <pwd.h>
   
 -@@ -618,8 +619,8 @@
 - 
 -          wprintw (Globals.wmain,
 -    /* why does it seem like on OpenBSD this is broken? */
 --#if defined(__OpenBSD__) || defined(BROKEN)
 --            "%s %-8s %-8s %10ld %1d\b2d-%02d-%02d %02d:%02d ",
 -+#if defined(__OpenBSD__) || defined(__FreeBSD__) || defined(BROKEN)
 -+            "%s %-8s %-8s %10ld %1d\b%04d-%02d-%02d %02d:%02d ",
 - #else
 -             "%s %-8s %-8s %10ld %d-%02d-%02d %02d:%02d ",
 - #endif
 
 Modified: head/editors/chexedit/files/patch-src-init.c
 ==============================================================================
 --- head/editors/chexedit/files/patch-src-init.c	Mon Jul 22 17:24:50 2013	(r323481)
 +++ head/editors/chexedit/files/patch-src-init.c	Mon Jul 22 17:28:38 2013	(r323482)
 @@ -12,7 +12,15 @@
   extern char **environ;
   
   
 -@@ -463,7 +468,7 @@
 +@@ -250,6 +255,7 @@
 +    if (color_term != -1)
 +    {
 +       start_color ();
 ++      use_default_colors();
 +       if ((color_term = has_colors ()))
 +       {
 +          color_term = 1;
 +@@ -463,7 +469,7 @@
         filestat.st_size = DEFAULT_BUFFER_SIZE;
      }
   
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: amdmi3 
State-Changed-When: Mon Jul 22 17:30:25 UTC 2013 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=180623 
>Unformatted:
