From nobody@FreeBSD.org  Tue Jul  9 11:58:04 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id 61C456A
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  9 Jul 2013 11:58:04 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121])
	by mx1.freebsd.org (Postfix) with ESMTP id 541C01B1F
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  9 Jul 2013 11:58:04 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r69Bw3Ir006396
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 9 Jul 2013 11:58:03 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r69Bw3ME006395;
	Tue, 9 Jul 2013 11:58:03 GMT
	(envelope-from nobody)
Message-Id: <201307091158.r69Bw3ME006395@oldred.freebsd.org>
Date: Tue, 9 Jul 2013 11:58:03 GMT
From: Kalten <kalten@gmx.at>
To: freebsd-gnats-submit@FreeBSD.org
Subject: audio/musicpd: Radio buttons: shoutcast, tremor, vorbis
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         180412
>Category:       ports
>Synopsis:       audio/musicpd: Radio buttons: shoutcast, tremor, vorbis
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    crees
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 09 12:00:00 UTC 2013
>Closed-Date:    Fri Aug 09 12:25:05 UTC 2013
>Last-Modified:  Fri Aug  9 12:30:00 UTC 2013
>Originator:     Kalten
>Release:        9.1-RELEASE
>Organization:
>Environment:
FreeBSD freeHugin.Walhalla.Leben 9.1-RELEASE-p4 FreeBSD 9.1-RELEASE-p4 #0: Mon Jun 17 11:42:37 UTC 2013     root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
I think we nedd some OPTIONS_RADIO entries for shoutcast, tremor and vorbis.

---SCHNIPP---
===>  musicpd-0.17.3_1 shoutcast and tremor do not coexist; use vorbis instead.
*** [all] Error code 1

Stop in /usr/ports.portsnap/audio/musicpd.
---schnapp---

Maybe someone could correct this. :-)
>How-To-Repeat:
``make config'' and select (SHOUTCAST and TREMOR) or (SHOUTCAST and TREMOR and VORBIS), then ``make''.
>Fix:
selecting either (SHOUTCAST and no-TREMOR and VORBIS) or (no-SHOUTCAST and TREMOR and VORBIS)---the problem screams for OPTIONS_RADIO and may be some comment about it in the knobs' descriptions.

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->crees 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Jul 9 12:00:08 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=180412 
State-Changed-From-To: open->feedback 
State-Changed-By: crees 
State-Changed-When: Wed Jul 10 19:07:03 UTC 2013 
State-Changed-Why:  
I don't think a radio button is right here.  Vorbis has nothing to do 
with the conflicts, it just solves it.  Are you suggesting a radio 
between SHOUTCAST and TREMOR? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=180412 

From: Kalten <kalten@gmx.at>
To: crees@FreeBSD.org
Cc: bug-followup@FreeBSD.org, kalten@gmx.at
Subject: Re: ports/180412: audio/musicpd: Radio buttons: shoutcast, tremor, vorbis
Date: Sat, 13 Jul 2013 17:03:47 +0200

 Hello Crees!
 
 >> shoutcast and tremor do not coexist; use vorbis instead.
 > I don't think a radio button is right here.  Vorbis has nothing to do
 > with the conflicts, it just solves it.
 If it solves it, it does not have nothing to do with it ;-)
 And the error messages suggests to ``use vorbis instead'' so why no
 radio button, or the error message is totally misleading. :-(
 
 > Are you suggesting a radio between SHOUTCAST and TREMOR?
 Well: if ``shoutcast and tremor do not coexist'', sure, it would reflect
 the error message.
 
 Anyway: the user should be able to know what to do ere he hits OK in the
 options dialog and not have to wait for the compiler to tell him, his
 choice had been wrong after getting up from bed and being, lets say,
 ``unhappy'' about the fact, that there is not everything done. At least
 one could describe the conflict and its solution in some way allready in
 the descriptions of the knobs.
 
 ru,
  Kalten
 -- 
State-Changed-From-To: feedback->closed 
State-Changed-By: crees 
State-Changed-When: Fri Aug 9 12:25:04 UTC 2013 
State-Changed-Why:  
I've changed the description of the TREMOR option to  make the situation 
clear. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=180412 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/180412: commit references a PR
Date: Fri,  9 Aug 2013 12:21:49 +0000 (UTC)

 Author: crees
 Date: Fri Aug  9 12:21:41 2013
 New Revision: 324431
 URL: http://svnweb.freebsd.org/changeset/ports/324431
 
 Log:
   Improve TREMOR description to make it explicit that it may not be used with
   SHOUTCAST
   
   PR:		ports/180412
 
 Modified:
   head/audio/musicpd/Makefile
 
 Modified: head/audio/musicpd/Makefile
 ==============================================================================
 --- head/audio/musicpd/Makefile	Fri Aug  9 12:16:33 2013	(r324430)
 +++ head/audio/musicpd/Makefile	Fri Aug  9 12:21:41 2013	(r324431)
 @@ -8,7 +8,7 @@ MASTER_SITES=	SF/${PORTNAME}/mpd/${PORTV
  DISTNAME=	mpd-${PORTVERSION}
  
  MAINTAINER=	crees@FreeBSD.org
 -COMMENT=	A remote-controllable music daemon
 +COMMENT=	Remote-controllable music daemon
  
  LIB_DEPENDS+=	mad.2:${PORTSDIR}/audio/libmad \
  		curl:${PORTSDIR}/ftp/curl
 @@ -41,6 +41,8 @@ OPTIONS_DEFINE=	ID3TAG IPV6 FLAC VORBIS 
  OPTIONS_RADIO=	ZEROCONF
  OPTIONS_RADIO_ZEROCONF=	AVAHI MDNSRESPONDER
  
 +TREMOR_DESC=	Tremor decoder (not with SHOUTCAST; use VORBIS)
 +
  OPTIONS_DEFAULT=ID3TAG IPV6 FLAC VORBIS WAV FFMPEG SNDFILE
  LAME_DESC=	Support for MP3 Icecast Streams
  
 @@ -171,7 +173,9 @@ LIB_DEPENDS+=	id3tag.0:${PORTSDIR}/audio
  CONFIGURE_ARGS+=--disable-id3
  .endif
  
 -.if empty(PORT_OPTIONS:MIPV6)
 +.if ${PORT_OPTIONS:MIPV6}
 +CONFIGURE_ARGS+=--enable-ipv6
 +.else
  CONFIGURE_ARGS+=--disable-ipv6
  .endif
  
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
