From tijl@coosemans.org  Thu Jul  4 15:28:42 2013
Return-Path: <tijl@coosemans.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id B0DE18CF
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  4 Jul 2013 15:28:42 +0000 (UTC)
	(envelope-from tijl@coosemans.org)
Received: from mailrelay007.isp.belgacom.be (mailrelay007.isp.belgacom.be [195.238.6.173])
	by mx1.freebsd.org (Postfix) with ESMTP id 531731C9D
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  4 Jul 2013 15:28:41 +0000 (UTC)
Received: from 139.159-241-81.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([81.241.159.139])
  by relay.skynet.be with ESMTP; 04 Jul 2013 17:27:33 +0200
Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1])
	by kalimero.tijl.coosemans.org (8.14.7/8.14.7) with ESMTP id r64FRRZV007047
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 4 Jul 2013 17:27:27 +0200 (CEST)
	(envelope-from tijl@kalimero.tijl.coosemans.org)
Received: (from tijl@localhost)
	by kalimero.tijl.coosemans.org (8.14.7/8.14.7/Submit) id r64FRQ50007046;
	Thu, 4 Jul 2013 17:27:26 +0200 (CEST)
	(envelope-from tijl)
Message-Id: <201307041527.r64FRQ50007046@kalimero.tijl.coosemans.org>
Date: Thu, 4 Jul 2013 17:27:26 +0200 (CEST)
From: Tijl Coosemans <tijl@FreeBSD.org>
Reply-To: Tijl Coosemans <tijl@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] net-mgmt/dhcdrop: add USE_CSTD=gnu89 for clang
X-Send-Pr-Version: 3.114
X-GNATS-Notify: ffault@gmail.com

>Number:         180263
>Category:       ports
>Synopsis:       [patch] net-mgmt/dhcdrop: add USE_CSTD=gnu89 for clang
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    tijl
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 04 15:30:00 UTC 2013
>Closed-Date:    Tue Jul 23 15:51:33 CEST 2013
>Last-Modified:  Tue Jul 23 15:51:33 CEST 2013
>Originator:     Tijl Coosemans
>Release:        FreeBSD 10.0-CURRENT i386
>Organization:
>Environment:
>Description:
Problems with inline and clang are because clang defaults to C99.
By adding USE_CSTD=gnu89 the post-patch target can be removed.
>How-To-Repeat:
>Fix:

--- dhcdrop.patch begins here ---
Index: net-mgmt/dhcdrop/Makefile
===================================================================
--- net-mgmt/dhcdrop/Makefile	(revision 322214)
+++ net-mgmt/dhcdrop/Makefile	(working copy)
@@ -10,6 +10,7 @@ MAINTAINER=	ffault@gmail.com
 COMMENT=	Tool for searching and suppressing false DHCP servers
 
 USE_BZIP2=	yes
+USE_CSTD=	gnu89
 GNU_CONFIGURE=	yes
 
 MAN8=		${PORTNAME}.8
@@ -26,9 +27,4 @@ STATIC_DESC=	Build a static version of d
 CONFIGURE_ARGS+=--enable-static-build
 .endif
 
-post-patch:
-	@${REINPLACE_CMD} -e \
-		's,inline void rand_ether_addr,static void rand_ether_addr,' \
-			${WRKSRC}/src/dhcdrop.[c,h]
-
 .include <bsd.port.mk>
--- dhcdrop.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->miwi 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Jul 4 15:30:08 UTC 2013 
Responsible-Changed-Why:  
miwi@ wants this submitter's PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=180263 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Jul 4 15:30:09 UTC 2013 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=180263 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: ffault@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/180263: [patch] net-mgmt/dhcdrop: add USE_CSTD=gnu89 for clang
Date: Thu, 4 Jul 2013 15:30:09 UT

 Maintainer of net-mgmt/dhcdrop,
 
 Please note that PR ports/180263 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/180263
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: miwi->tijl 
Responsible-Changed-By: tijl 
Responsible-Changed-When: Thu Jul 4 21:28:49 CEST 2013 
Responsible-Changed-Why:  
Take my own PR. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=180263 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/180263: commit references a PR
Date: Tue, 23 Jul 2013 09:47:43 +0000 (UTC)

 Author: tijl
 Date: Tue Jul 23 09:47:30 2013
 New Revision: 323523
 URL: http://svnweb.freebsd.org/changeset/ports/323523
 
 Log:
   Add USE_CSTD=gnu89 for clang instead of removing inline.
   
   PR:		180263
   Approved by:	maintainer timeout (19 days)
 
 Modified:
   head/net-mgmt/dhcdrop/Makefile   (contents, props changed)
 Directory Properties:
   head/net-mgmt/dhcdrop/distinfo   (props changed)
   head/net-mgmt/dhcdrop/pkg-descr   (props changed)
 
 Modified: head/net-mgmt/dhcdrop/Makefile
 ==============================================================================
 --- head/net-mgmt/dhcdrop/Makefile	Tue Jul 23 08:48:04 2013	(r323522)
 +++ head/net-mgmt/dhcdrop/Makefile	Tue Jul 23 09:47:30 2013	(r323523)
 @@ -3,6 +3,7 @@
  
  PORTNAME=	dhcdrop
  PORTVERSION=	0.5
 +PORTREVISION=	1
  CATEGORIES=	net-mgmt sysutils
  MASTER_SITES=	http://www.netpatch.ru/projects/dhcdrop/
  
 @@ -10,6 +11,7 @@ MAINTAINER=	ffault@gmail.com
  COMMENT=	Tool for searching and suppressing false DHCP servers
  
  USE_BZIP2=	yes
 +USE_CSTD=	gnu89
  GNU_CONFIGURE=	yes
  
  MAN8=		${PORTNAME}.8
 @@ -26,9 +28,4 @@ STATIC_DESC=	Build a static version of d
  CONFIGURE_ARGS+=--enable-static-build
  .endif
  
 -post-patch:
 -	@${REINPLACE_CMD} -e \
 -		's,inline void rand_ether_addr,static void rand_ether_addr,' \
 -			${WRKSRC}/src/dhcdrop.[c,h]
 -
  .include <bsd.port.mk>
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->closed 
State-Changed-By: tijl 
State-Changed-When: Tue Jul 23 15:50:24 CEST 2013 
State-Changed-Why:  
Committed in r323523. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=180263 
>Unformatted:
