From nobody@FreeBSD.org  Tue Jul  2 13:27:11 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id 61A34F3D
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  2 Jul 2013 13:27:11 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121])
	by mx1.freebsd.org (Postfix) with ESMTP id 5514B1D91
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  2 Jul 2013 13:27:11 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r62DRBVZ095520
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 2 Jul 2013 13:27:11 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r62DRBoL095519;
	Tue, 2 Jul 2013 13:27:11 GMT
	(envelope-from nobody)
Message-Id: <201307021327.r62DRBoL095519@oldred.freebsd.org>
Date: Tue, 2 Jul 2013 13:27:11 GMT
From: Rene Ladan <rene@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: graphics/pfstools : remove support for QT3
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: darius@dons.net.au

>Number:         180200
>Category:       ports
>Synopsis:       graphics/pfstools : remove support for QT3
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    rene
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 02 13:30:01 UTC 2013
>Closed-Date:    Tue Jul 02 19:07:36 UTC 2013
>Last-Modified:  Tue Jul  2 19:10:01 UTC 2013
>Originator:     Rene Ladan
>Release:        FreeBSD 9.1-amd64
>Organization:
>Environment:
FreeBSD 9.1-amd64
Ports Tree r322167

>Description:
KDE 3 and QT 3 expired on 2013-07-01, and this port provides optional support for QT3 via the QT option.

Remove this option from the Makefile.
>How-To-Repeat:
`find /usr/ports/ -mindepth 2 -maxdepth 3 Makefile\* | xargs grep bsd.kde.mk` finds this port. (bsd.kde.mk is for KDE 3, bsd.kde4.mk is for KDE 4)
>Fix:


Patch attached with submission follows:

Index: Makefile
===================================================================
--- Makefile	(revision 322167)
+++ Makefile	(working copy)
@@ -29,8 +29,7 @@
 USE_LDCONFIG=	yes
 USES=	pkgconfig
 
-OPTIONS_DEFINE=	NETPBM OPENEXR TIFF QT IMAGEMAGICK OCTAVE OPENGL
-QT_DESC=	QT library support
+OPTIONS_DEFINE=	NETPBM OPENEXR TIFF IMAGEMAGICK OCTAVE OPENGL
 OCTAVE_DESC=	Compile octave interface functions
 
 OPTIONS_DEFAULT=	TIFF
@@ -100,17 +99,8 @@
 PLIST_SUB+=	TIFF="@comment "
 .endif
 
-.if ${PORT_OPTIONS:MQT}
-CONFIGURE_ARGS+=--enable-qt
-USE_QT_VER=	3
-.include "${PORTSDIR}/Mk/bsd.kde.mk"
-PLIST_SUB+=	QT=""
-MAN1+=		pfsview.1 \
-		pfsv.1
-.else
 CONFIGURE_ARGS+=--disable-qt
 PLIST_SUB+=	QT="@comment "
-.endif
 
 .if ${PORT_OPTIONS:MIMAGEMAGICK}
 CONFIGURE_ARGS+=--enable-imagemagick


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Jul 2 13:30:14 UTC 2013 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=180200 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: darius@dons.net.au
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/180200: graphics/pfstools : remove support for QT3
Date: Tue, 2 Jul 2013 13:30:14 UT

 Maintainer of graphics/pfstools,
 
 Please note that PR ports/180200 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/180200
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: "Daniel O'Connor" <darius@dons.net.au>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/180200: graphics/pfstools : remove support for QT3
Date: Tue, 2 Jul 2013 23:20:35 +0930

 On 02/07/2013, at 23:00, Edwin Groothuis <edwin@FreeBSD.org> wrote:
 > Maintainer of graphics/pfstools,
 >=20
 > Please note that PR ports/180200 has just been submitted.
 >=20
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >=20
 > The full text of the PR can be found at:
 >    http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/180200
 
 
 Looks good.
 I don't use pfstools any more so if someone else wants to take it be my =
 guest.
 
 --
 Daniel O'Connor software and network engineer
 for Genesis Software - http://www.gsoft.com.au
 "The nice thing about standards is that there
 are so many of them to choose from."
   -- Andrew Tanenbaum
 GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C
 
 
 
 
 
 
State-Changed-From-To: feedback->closed 
State-Changed-By: rene 
State-Changed-When: Tue Jul 2 19:07:07 UTC 2013 
State-Changed-Why:  
Committed, thanks 


Responsible-Changed-From-To: freebsd-ports-bugs->rene 
Responsible-Changed-By: rene 
Responsible-Changed-When: Tue Jul 2 19:07:07 UTC 2013 
Responsible-Changed-Why:  
Committed, thanks 

http://www.freebsd.org/cgi/query-pr.cgi?pr=180200 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/180200: commit references a PR
Date: Tue,  2 Jul 2013 19:06:42 +0000 (UTC)

 Author: rene
 Date: Tue Jul  2 19:06:29 2013
 New Revision: 322192
 URL: http://svnweb.freebsd.org/changeset/ports/322192
 
 Log:
   Remove the QT option as it depends on the expired QT3 port.
   
   The maintainer does not use this port any longer, new volunteers are welcome.
   
   PR:		ports/180200
   Submitted by:	myself
   Approved by:	Daniel O'Connor <darius@dons.net.au> (maintainer)
 
 Modified:
   head/graphics/pfstools/Makefile
 
 Modified: head/graphics/pfstools/Makefile
 ==============================================================================
 --- head/graphics/pfstools/Makefile	Tue Jul  2 19:04:18 2013	(r322191)
 +++ head/graphics/pfstools/Makefile	Tue Jul  2 19:06:29 2013	(r322192)
 @@ -29,8 +29,7 @@ USE_GMAKE=	yes
  USE_LDCONFIG=	yes
  USES=	pkgconfig
  
 -OPTIONS_DEFINE=	NETPBM OPENEXR TIFF QT IMAGEMAGICK OCTAVE OPENGL
 -QT_DESC=	QT library support
 +OPTIONS_DEFINE=	NETPBM OPENEXR TIFF IMAGEMAGICK OCTAVE OPENGL
  OCTAVE_DESC=	Compile octave interface functions
  
  OPTIONS_DEFAULT=	TIFF
 @@ -100,17 +99,8 @@ CONFIGURE_ARGS+=--disable-tiff
  PLIST_SUB+=	TIFF="@comment "
  .endif
  
 -.if ${PORT_OPTIONS:MQT}
 -CONFIGURE_ARGS+=--enable-qt
 -USE_QT_VER=	3
 -.include "${PORTSDIR}/Mk/bsd.kde.mk"
 -PLIST_SUB+=	QT=""
 -MAN1+=		pfsview.1 \
 -		pfsv.1
 -.else
  CONFIGURE_ARGS+=--disable-qt
  PLIST_SUB+=	QT="@comment "
 -.endif
  
  .if ${PORT_OPTIONS:MIMAGEMAGICK}
  CONFIGURE_ARGS+=--enable-imagemagick
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
