From nemysis@gmx.ch  Sat Jun 29 22:35:13 2013
Return-Path: <nemysis@gmx.ch>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id 20BA2C47
	for <freebsd-gnats-submit@freebsd.org>; Sat, 29 Jun 2013 22:35:13 +0000 (UTC)
	(envelope-from nemysis@gmx.ch)
Received: from mout.gmx.net (mout.gmx.net [212.227.15.19])
	by mx1.freebsd.org (Postfix) with ESMTP id 9D097188F
	for <freebsd-gnats-submit@freebsd.org>; Sat, 29 Jun 2013 22:35:12 +0000 (UTC)
Received: from mailout-de.gmx.net ([10.1.76.20]) by mrigmx.server.lan
 (mrigmx001) with ESMTP (Nemesis) id 0MHJbp-1V5PwK33sh-00E9qN for
 <FreeBSD-gnats-submit@freebsd.org>; Sun, 30 Jun 2013 00:35:11 +0200
Received: (qmail invoked by alias); 29 Jun 2013 22:35:10 -0000
Received: from 5-80.77-83.cust.bluewin.ch (EHLO something.email.com) [83.77.80.5]
  by mail.gmx.net (mp020) with SMTP; 30 Jun 2013 00:35:10 +0200
Received: by something.email.com (sSMTP sendmail emulation); Sun, 30 Jun 2013 00:35:08 +0200
Message-Id: <20130629223513.20BA2C47@hub.freebsd.org>
Date: Sun, 30 Jun 2013 00:35:08 +0200
From: nemysis <nemysis@gmx.ch>
To: FreeBSD-gnats-submit@freebsd.org
Cc: jpaetzel@FreeBSD.org
Subject: [MAINTAINER] x11/florence: Add missing dependency, trim NLS
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         180113
>Category:       ports
>Synopsis:       [MAINTAINER] x11/florence: Add missing dependency, trim NLS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    wg
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jun 29 22:40:00 UTC 2013
>Closed-Date:    Wed Jul 03 12:44:20 UTC 2013
>Last-Modified:  Wed Jul  3 12:50:00 UTC 2013
>Originator:     nemysis
>Release:        FreeBSD 9.1-RELEASE-p8 amd64
>Organization:
>Environment:
System: FreeBSD FreeBSD_Ports 9.1-RELEASE-p8 FreeBSD 9.1-RELEASE-p8 #0: Tue Jun 18 15:25:28 UTC 2013
>Description:

- Add run dependency for accessibility/at-spi2-core
- New world order USES: desktop-file-utils iconv pathfix
- Add DOCS Option
- Trim NLS

Generated and tested manually, tested with port test and with RedPorts, sent with FreeBSD Port Tools 0.99_8 (mode: change, diff: ports)
>How-To-Repeat:

kwm@ have said to add this dependency

Build log

https://redports.org/buildarchive/20130629203300-39123/

>Fix:

--- florence-0.6.0.patch begins here ---
diff -ruN /usr/ports/x11/florence/Makefile ./Makefile
--- /usr/ports/x11/florence/Makefile	2013-06-20 23:07:45.000000000 +0200
+++ ./Makefile	2013-06-30 00:29:16.000000000 +0200
@@ -4,7 +4,7 @@
 PORTNAME=	florence
 PORTVERSION=	0.6.0
 CATEGORIES=	x11
-MASTER_SITES=	SF/florence/florence/${PORTVERSION}
+MASTER_SITES=	SF/florence/florence/${PORTVERSION}/
 
 MAINTAINER=	nemysis@gmx.ch
 COMMENT=	Extensible scalable virtual keyboard
@@ -14,9 +14,10 @@
 
 LIB_DEPENDS=	notify:${PORTSDIR}/devel/libnotify
 BUILD_DEPENDS=	${LOCALBASE}/libexec/at-spi2-registryd:${PORTSDIR}/accessibility/at-spi2-core
+RUN_DEPENDS:=	${BUILD_DEPENDS}
 
 USE_BZIP2=	yes
-USES=		desktop-file-utils gettext iconv pathfix
+USES=		desktop-file-utils iconv pathfix
 USE_XORG=	xtst xext
 USE_GNOME=	gtk30 cairo intlhack gnomedocutils librsvg2
 USE_GSTREAMER=	yes
@@ -31,16 +32,12 @@
 
 PORTDOCS=	AUTHORS ChangeLog NEWS README
 
-OPTIONS_DEFINE=	NLS
+OPTIONS_DEFINE=	DOCS NLS
+OPTIONS_SUB=	yes
 
-.include <bsd.port.options.mk>
+NLS_USES=	gettext
 
-.if ${PORT_OPTIONS:MNLS}
-USES+=		gettext
-PLIST_SUB+=	NLS=""
-.else
-PLIST_SUB+=	NLS="@comment "
-.endif
+.include <bsd.port.options.mk>
 
 post-patch:
 	@${REINPLACE_CMD} -e 's|^Categories=.*|Categories=Application;Accessibility;System;|' \
--- florence-0.6.0.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->wg 
Responsible-Changed-By: wg 
Responsible-Changed-When: Wed Jul 3 01:33:20 UTC 2013 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=180113 
State-Changed-From-To: open->closed 
State-Changed-By: wg 
State-Changed-When: Wed Jul 3 12:44:20 UTC 2013 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=180113 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/180113: commit references a PR
Date: Wed,  3 Jul 2013 12:44:25 +0000 (UTC)

 Author: wg
 Date: Wed Jul  3 12:44:17 2013
 New Revision: 322227
 URL: http://svnweb.freebsd.org/changeset/ports/322227
 
 Log:
   x11/florence: fix run depends
   
   - BUILD_DEPENDS is RUN_DEPENDS as well
   - Add DOCS option
   - Use OPTIONS_SUB
   
   PR:		ports/180113
   Submitted by:	nemysis <nemysis@gmx.ch> (maintainer)
 
 Modified:
   head/x11/florence/Makefile
 
 Modified: head/x11/florence/Makefile
 ==============================================================================
 --- head/x11/florence/Makefile	Wed Jul  3 12:41:28 2013	(r322226)
 +++ head/x11/florence/Makefile	Wed Jul  3 12:44:17 2013	(r322227)
 @@ -4,7 +4,7 @@
  PORTNAME=	florence
  PORTVERSION=	0.6.0
  CATEGORIES=	x11
 -MASTER_SITES=	SF/florence/florence/${PORTVERSION}
 +MASTER_SITES=	SF/florence/florence/${PORTVERSION}/
  
  MAINTAINER=	nemysis@gmx.ch
  COMMENT=	Extensible scalable virtual keyboard
 @@ -14,9 +14,10 @@ LICENSE_COMB=	dual
  
  LIB_DEPENDS=	notify:${PORTSDIR}/devel/libnotify
  BUILD_DEPENDS=	${LOCALBASE}/libexec/at-spi2-registryd:${PORTSDIR}/accessibility/at-spi2-core
 +RUN_DEPENDS:=	${BUILD_DEPENDS}
  
  USE_BZIP2=	yes
 -USES=		desktop-file-utils gettext iconv pathfix
 +USES=		desktop-file-utils iconv pathfix
  USE_XORG=	xtst xext
  USE_GNOME=	gtk30 cairo intlhack gnomedocutils librsvg2
  USE_GSTREAMER=	yes
 @@ -31,16 +32,12 @@ MAN1=		${PORTNAME}.1 ${PORTNAME}_applet.
  
  PORTDOCS=	AUTHORS ChangeLog NEWS README
  
 -OPTIONS_DEFINE=	NLS
 +OPTIONS_DEFINE=	DOCS NLS
 +OPTIONS_SUB=	yes
  
 -.include <bsd.port.options.mk>
 +NLS_USES=	gettext
  
 -.if ${PORT_OPTIONS:MNLS}
 -USES+=		gettext
 -PLIST_SUB+=	NLS=""
 -.else
 -PLIST_SUB+=	NLS="@comment "
 -.endif
 +.include <bsd.port.options.mk>
  
  post-patch:
  	@${REINPLACE_CMD} -e 's|^Categories=.*|Categories=Application;Accessibility;System;|' \
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
