From nobody@FreeBSD.org  Mon Jun 24 19:01:13 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id 7C9AEDE2
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 24 Jun 2013 19:01:13 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121])
	by mx1.freebsd.org (Postfix) with ESMTP id 6F05A193D
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 24 Jun 2013 19:01:13 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r5OJ1CDm098238
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 24 Jun 2013 19:01:12 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r5OJ1C37098197;
	Mon, 24 Jun 2013 19:01:12 GMT
	(envelope-from nobody)
Message-Id: <201306241901.r5OJ1C37098197@oldred.freebsd.org>
Date: Mon, 24 Jun 2013 19:01:12 GMT
From: Evgeni Dimitrov <evgeni.dimitrov@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: mail/courier fails to build if devel/pkgconf is not present
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: bsd@dino.sk

>Number:         179934
>Category:       ports
>Synopsis:       mail/courier fails to build if devel/pkgconf is not present
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bdrewery
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 24 19:10:00 UTC 2013
>Closed-Date:    Fri Aug 30 08:18:08 CDT 2013
>Last-Modified:  Fri Aug 30 13:20:00 UTC 2013
>Originator:     Evgeni Dimitrov
>Release:        9.1-STABLE
>Organization:
TheZone ISP, Bulgaria
>Environment:
FreeBSD [[redacted]] 9.1-STABLE FreeBSD 9.1-STABLE #0: Fri Jun 21 01:58:40 EEST 2013     root@[[redacted]]:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
There is a PKG_CHECK_MODULES macro in ${WRKSRC}/rfc822/configure.in, line 44 that fails to expand if devel/pkgconf is not installed for example when building the port with poudriere. The result is an invalid ${WRKSRC}/rfc822/configure script.
>How-To-Repeat:
Try building mail/courier without having devel/pkgconf installed.
>Fix:
The attached patch adds devel/pkgconf to BUILD_DEPEND.

Patch attached with submission follows:

Index: Makefile
===================================================================
--- Makefile	(revision 321685)
+++ Makefile	(working copy)
@@ -10,7 +10,8 @@
 MAINTAINER=	bsd@dino.sk
 COMMENT=	Courier SMTP IMAP POP3 HTTP mail server suite
 
-BUILD_DEPENDS=	courierauthconfig:${PORTSDIR}/security/courier-authlib-base
+BUILD_DEPENDS=	courierauthconfig:${PORTSDIR}/security/courier-authlib-base \
+		pkg-config:${PORTSDIR}/devel/pkgconf
 LIB_DEPENDS=	pcre:${PORTSDIR}/devel/pcre
 RUN_DEPENDS=	courierauthconfig:${PORTSDIR}/security/courier-authlib-base \
 		${LOCALBASE}/share/sysconftool/sysconftool:${PORTSDIR}/devel/sysconftool \


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Mon Jun 24 19:10:07 UTC 2013 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=179934 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: bsd@dino.sk
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/179934: mail/courier fails to build if devel/pkgconf is not present
Date: Mon, 24 Jun 2013 19:10:07 UT

 Maintainer of mail/courier,
 
 Please note that PR ports/179934 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/179934
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Alex Kozlov <spam@rm-rf.kiev.ua>
To: bug-followup@FreeBSD.org, evgeni.dimitrov@gmail.com, bsd@dino.sk
Cc:  
Subject: Re: ports/179934: mail/courier fails to build if devel/pkgconf is
 not present
Date: Thu, 27 Jun 2013 01:43:30 +0300

 Hi
 
 It's better to use USES= pkgconfig instead of BUILD_DEPENDS.
 
 
 -- 
 Alex
Responsible-Changed-From-To: freebsd-ports-bugs->bdrewery 
Responsible-Changed-By: bdrewery 
Responsible-Changed-When: Fri Aug 30 08:18:01 CDT 2013 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=179934 
State-Changed-From-To: feedback->closed 
State-Changed-By: bdrewery 
State-Changed-When: Fri Aug 30 08:18:08 CDT 2013 
State-Changed-Why:  
Fixed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=179934 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/179934: commit references a PR
Date: Fri, 30 Aug 2013 13:18:05 +0000 (UTC)

 Author: bdrewery
 Date: Fri Aug 30 13:17:53 2013
 New Revision: 325688
 URL: http://svnweb.freebsd.org/changeset/ports/325688
 
 Log:
   - Fix build after autotools update [1]
   - Add missing pkgconfig dependency [2]
   
   Reported by:	Marat Bakeev <hawara@Hawara.com> via ports@ [1]
   PR:		ports/179934 [2]
   Reported by:	Evgeni Dimitrov <evgeni.dimitrov@gmail.com> [2]
   Approved by:	maintainer timeout
 
 Modified:
   head/mail/courier/Makefile
 
 Modified: head/mail/courier/Makefile
 ==============================================================================
 --- head/mail/courier/Makefile	Fri Aug 30 13:15:31 2013	(r325687)
 +++ head/mail/courier/Makefile	Fri Aug 30 13:17:53 2013	(r325688)
 @@ -57,12 +57,12 @@ CALENDIR=	/var/spool/calendar
  MIMETYPES=	${LOCALBASE}/etc/mime.types
  WITH_TRANSPORT=	local esmtp dsn
  
 -USE_AUTOTOOLS=	libtool aclocal
 +USE_AUTOTOOLS=	libtool aclocal automake
  AUTOMAKE_ARGS=	--add-missing
  USE_BZIP2=	yes
  USE_GCC=	any
  USE_FAM=	yes
 -USES=		gettext
 +USES=		gettext pkgconfig
  USE_GMAKE=	yes
  USE_OPENSSL=	yes
  USE_PERL5=	yes
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
