From tijl@coosemans.org  Mon Jun 24 17:45:09 2013
Return-Path: <tijl@coosemans.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	by hub.freebsd.org (Postfix) with ESMTP id 8DE7AE72
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 24 Jun 2013 17:45:09 +0000 (UTC)
	(envelope-from tijl@coosemans.org)
Received: from mailrelay020.isp.belgacom.be (Mailrelay020.isp.belgacom.be [195.238.6.95])
	by mx1.freebsd.org (Postfix) with ESMTP id 312FD15C0
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 24 Jun 2013 17:45:08 +0000 (UTC)
Received: from 2.122-242-81.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([81.242.122.2])
  by relay.skynet.be with ESMTP; 24 Jun 2013 19:45:01 +0200
Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1])
	by kalimero.tijl.coosemans.org (8.14.7/8.14.7) with ESMTP id r5OHix60048802
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 24 Jun 2013 19:45:00 +0200 (CEST)
	(envelope-from tijl@kalimero.tijl.coosemans.org)
Received: (from tijl@localhost)
	by kalimero.tijl.coosemans.org (8.14.7/8.14.7/Submit) id r5OHixmc048801;
	Mon, 24 Jun 2013 19:44:59 +0200 (CEST)
	(envelope-from tijl)
Message-Id: <201306241744.r5OHixmc048801@kalimero.tijl.coosemans.org>
Date: Mon, 24 Jun 2013 19:44:59 +0200 (CEST)
From: Tijl Coosemans <tijl@FreeBSD.org>
Reply-To: Tijl Coosemans <tijl@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] www/serf: remove gmake dependency
X-Send-Pr-Version: 3.114
X-GNATS-Notify:

>Number:         179933
>Category:       ports
>Synopsis:       [patch] www/serf: remove gmake dependency
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    apache
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 24 17:50:00 UTC 2013
>Closed-Date:    Sat Jul 06 09:25:32 UTC 2013
>Last-Modified:  Sat Jul 06 09:25:32 UTC 2013
>Originator:     Tijl Coosemans
>Release:        FreeBSD 10.0-CURRENT i386
>Organization:
>Environment:
>Description:
I'm going over devel/subversion dependencies to see if any can be
removed. The attached patch removes gmake from www/serf and some
other small changes:
- Put PROJECTHOST together with MASTER_SITES.
- Replace NOPORTDOCS with DOCS option.
- Remove USE_GMAKE.
- Silence post-patch.
- Rename check target to regression-test such that pointyhat runs
  the tests.
- Put parentheses around "cd <dir> && <command>" as recommended
  by make(1).
>How-To-Repeat:
>Fix:

--- serf.patch begins here ---
Index: www/serf/Makefile
===================================================================
--- www/serf/Makefile	(revision 321639)
+++ www/serf/Makefile	(working copy)
@@ -6,33 +6,35 @@ PORTVERSION=	1.2.1
 CATEGORIES=	www
 MASTER_SITES=	GOOGLE_CODE
 MASTER_SITE_SUBDIR=	db
+PROJECTHOST=	serf
 
 MAINTAINER=	apache@FreeBSD.org
 COMMENT=	Serf HTTP client library
 
 LIB_DEPENDS+=	apr-1:${PORTSDIR}/devel/apr1
 
-MAKE_JOBS_SAFE=	yes
+OPTIONS_DEFINE=	DOCS
 
-PROJECTHOST=	serf
+MAKE_JOBS_SAFE=	yes
 USE_BZIP2=	yes
-USE_GMAKE=	yes
 USES=	pathfix
 GNU_CONFIGURE=	yes
 USE_LDCONFIG=	yes
 CONFIGURE_ARGS+=	--with-apr=${LOCALBASE}/bin/apr-1-config \
 			--with-apr-util=${LOCALBASE}/bin/apu-1-config
 
+.include <bsd.port.options.mk>
+
 post-patch:
-	${REINPLACE_CMD} -e '/^Requires.private/d' ${WRKSRC}/serf.pc.in
+	@${REINPLACE_CMD} -e '/^Requires.private/d' ${WRKSRC}/serf.pc.in
 
 post-install:
-.if !defined(NOPORTDOCS)
+.if ${PORT_OPTIONS:MDOCS}
 	${MKDIR} ${DOCSDIR}
 	${INSTALL_DATA} ${WRKSRC}/design-guide.txt ${DOCSDIR}
 .endif
 
-check:
-	@cd ${WRKSRC}/ && ${MAKE} check
+regression-test:
+	@(cd ${WRKSRC} && ${MAKE} check)
 
 .include <bsd.port.mk>
--- serf.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->apache 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Jun 24 17:50:14 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=179933 

From: Tijl Coosemans <tijl@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/179933: [patch] www/serf: remove gmake dependency
Date: Thu, 04 Jul 2013 11:09:37 +0200

 If there are no objections I'd like to commit this Sunday.
 http://www.freebsd.org/cgi/query-pr.cgi?pr=179933

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/179933: commit references a PR
Date: Sat,  6 Jul 2013 08:50:35 +0000 (UTC)

 Author: ohauer
 Date: Sat Jul  6 08:50:22 2013
 New Revision: 322369
 URL: http://svnweb.freebsd.org/changeset/ports/322369
 
 Log:
   - remove gmake dependency
   - bump PORTREVISION
   
   PR:		ports/179933
   Submitted by:	Tijl Coosemans tijl@
 
 Modified:
   head/www/serf/Makefile
 
 Modified: head/www/serf/Makefile
 ==============================================================================
 --- head/www/serf/Makefile	Sat Jul  6 08:46:39 2013	(r322368)
 +++ head/www/serf/Makefile	Sat Jul  6 08:50:22 2013	(r322369)
 @@ -3,6 +3,7 @@
  
  PORTNAME=	serf
  PORTVERSION=	1.2.1
 +PORTREVISION=	1
  CATEGORIES=	www
  MASTER_SITES=	GOOGLE_CODE
  MASTER_SITE_SUBDIR=	db
 @@ -13,26 +14,27 @@ COMMENT=	Serf HTTP client library
  LIB_DEPENDS+=	apr-1:${PORTSDIR}/devel/apr1
  
  MAKE_JOBS_SAFE=	yes
 -
 -PROJECTHOST=	serf
  USE_BZIP2=	yes
 -USE_GMAKE=	yes
 -USES=	pathfix
 +USES=		pathfix
  GNU_CONFIGURE=	yes
  USE_LDCONFIG=	yes
  CONFIGURE_ARGS+=	--with-apr=${LOCALBASE}/bin/apr-1-config \
  			--with-apr-util=${LOCALBASE}/bin/apu-1-config
  
 +OPTIONS_DEFINE=	DOCS
 +
 +.include <bsd.port.options.mk>
 +
  post-patch:
 -	${REINPLACE_CMD} -e '/^Requires.private/d' ${WRKSRC}/serf.pc.in
 +	@${REINPLACE_CMD} -e '/^Requires.private/d' ${WRKSRC}/serf.pc.in
  
  post-install:
 -.if !defined(NOPORTDOCS)
 -	${MKDIR} ${DOCSDIR}
 +.if ${PORT_OPTIONS:MDOCS}
 +	@${MKDIR} ${DOCSDIR}
  	${INSTALL_DATA} ${WRKSRC}/design-guide.txt ${DOCSDIR}
  .endif
  
 -check:
 -	@cd ${WRKSRC}/ && ${MAKE} check
 +regression-test:
 +	@(cd ${WRKSRC} && ${MAKE} check)
  
  .include <bsd.port.mk>
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: ohauer 
State-Changed-When: Sat Jul 6 09:25:09 UTC 2013 
State-Changed-Why:  
Committed, 
Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=179933 
>Unformatted:
