From amdmi3@amdmi3.ru  Mon Jun 24 10:43:40 2013
Return-Path: <amdmi3@amdmi3.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	by hub.freebsd.org (Postfix) with ESMTP id 08EC2BC0
	for <freebsd-gnats-submit@freebsd.org>; Mon, 24 Jun 2013 10:43:40 +0000 (UTC)
	(envelope-from amdmi3@amdmi3.ru)
Received: from smtp.timeweb.ru (smtp.timeweb.ru [92.53.116.10])
	by mx1.freebsd.org (Postfix) with ESMTP id BE5C61C56
	for <freebsd-gnats-submit@freebsd.org>; Mon, 24 Jun 2013 10:43:39 +0000 (UTC)
Received: from [213.148.20.85] (helo=hive.panopticon)
	by smtp.timeweb.ru with esmtpsa (TLS1.0:DHE_RSA_CAMELLIA_256_CBC_SHA1:256)
	(Exim 4.80)
	(envelope-from <amdmi3@amdmi3.ru>)
	id 1Ur4F9-0003Sq-I6; Mon, 24 Jun 2013 14:43:31 +0400
Received: from hades.panopticon (hades.panopticon [192.168.0.32])
	by hive.panopticon (Postfix) with ESMTP id C6D76C94;
	Mon, 24 Jun 2013 14:43:30 +0400 (MSK)
Received: by hades.panopticon (Postfix, from userid 1000)
	id ACBD8BDF; Mon, 24 Jun 2013 14:43:30 +0400 (MSK)
Message-Id: <20130624104330.ACBD8BDF@hades.panopticon>
Date: Mon, 24 Jun 2013 14:43:30 +0400 (MSK)
From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc: knyght@gmail.com
Subject: [PATCH] emulators/dosbox: add OPTIONS to enable internal debugger
X-Send-Pr-Version: 3.113
X-GNATS-Notify: knyght@gmail.com

>Number:         179924
>Category:       ports
>Synopsis:       [PATCH] emulators/dosbox: add OPTIONS to enable internal debugger
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    lippe
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 24 10:50:00 UTC 2013
>Closed-Date:    Mon Jul 08 21:33:25 UTC 2013
>Last-Modified:  Mon Jul 08 21:33:25 UTC 2013
>Originator:     Dmitry Marakasov
>Release:        FreeBSD 9.1-RELEASE-p2 amd64
>Organization:
>Environment:
System: FreeBSD hades.panopticon 9.1-RELEASE-p2 FreeBSD 9.1-RELEASE-p2 #0 r249077: Thu Apr  4 10:42:30
>Description:
Add OPTIONS to enable internal debugger

Port maintainer (knyght@gmail.com) is cc'd.

Generated with FreeBSD Port Tools 0.99_8 (mode: change, diff: SVN)
>How-To-Repeat:
>Fix:

--- dosbox-0.74_4.patch begins here ---
Index: Makefile
===================================================================
--- Makefile	(revision 321673)
+++ Makefile	(working copy)
@@ -27,8 +27,19 @@
 		"" "dosbox" \
 		"System;Emulator;" "true"
 
+OPTIONS_RADIO=	DEBUGGER
+OPTIONS_RADIO_DEBUGGER=DEBUGGER_ENABLE DEBUGGER_HEAVY
+DEBUGGER_ENABLE_DESC=Enable internal debugger
+DEBUGGER_HEAVY_DESC=Enable internal debugger with extra features
+
 .include <bsd.port.options.mk>
 
+.if ${PORT_OPTIONS:MDEBUGGER_ENABLE}
+CONFIGURE_ARGS+=	--enable-debug=yes
+.elif ${PORT_OPTIONS:MDEBUGGER_HEAVY}
+CONFIGURE_ARGS+=	--enable-debug=heavy
+.endif
+
 post-patch:
 	@${REINPLACE_CMD} -e 's#\/usr\/share\/doc\/dosbox#${DOCSDIR}#g' \
 		${WRKSRC}/docs/dosbox.1
--- dosbox-0.74_4.patch ends here ---

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Mon Jun 24 10:50:08 UTC 2013 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=179924 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: knyght@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/179924: [PATCH] emulators/dosbox: add OPTIONS to enable internal debugger
Date: Mon, 24 Jun 2013 10:50:07 UT

 Maintainer of emulators/dosbox,
 
 Please note that PR ports/179924 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/179924
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: freebsd-ports-bugs->lippe 
Responsible-Changed-By: lippe 
Responsible-Changed-When: Fri Jun 28 18:25:11 UTC 2013 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=179924 

From: Tom Carrick <knyght@gmail.com>
To: bug-followup@freebsd.org, amdmi3@amdmi3.ru
Cc:  
Subject: Re: ports/179924: [PATCH] emulators/dosbox: add OPTIONS to enable
 internal debugger
Date: Mon, 1 Jul 2013 21:29:31 +0100

 --047d7b41cba82b1a9c04e0791792
 Content-Type: text/plain; charset=UTF-8
 
 I'm not sure how many people need this, but I don't have a problem with it.
 
 --047d7b41cba82b1a9c04e0791792
 Content-Type: text/html; charset=UTF-8
 
 <div dir="ltr">I&#39;m not sure how many people need this, but I don&#39;t have a problem with it.</div>
 
 --047d7b41cba82b1a9c04e0791792--

From: Felippe de Meirelles Motta <lippe@FreeBSD.org>
To: bug-followup@FreeBSD.org, amdmi3@amdmi3.ru
Cc:  
Subject: Re: ports/179924: [PATCH] emulators/dosbox: add OPTIONS to enable
 internal debugger
Date: Mon, 1 Jul 2013 17:43:09 -0300

 --14dae9cc955cc6c24d04e07946ac
 Content-Type: text/plain; charset=ISO-8859-1
 
 Tom,
 
 I could consider this an "Approved", sure ?
 
 --14dae9cc955cc6c24d04e07946ac
 Content-Type: text/html; charset=ISO-8859-1
 
 Tom,<br><br>I could consider this an &quot;Approved&quot;, sure ?<br>
 
 --14dae9cc955cc6c24d04e07946ac--

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/179924: commit references a PR
Date: Mon,  8 Jul 2013 21:28:41 +0000 (UTC)

 Author: lippe
 Date: Mon Jul  8 21:28:28 2013
 New Revision: 322539
 URL: http://svnweb.freebsd.org/changeset/ports/322539
 
 Log:
   - Add OPTIONS to enable internal debugger
   
   PR:		ports/179924
   Submitted by:	Dmitry Marakasov <amdmi3@amdmi3.ru>
   Approved by:	Tom Carrick <knyght@gmail.com> (maintainer)
 
 Modified:
   head/emulators/dosbox/Makefile
 
 Modified: head/emulators/dosbox/Makefile
 ==============================================================================
 --- head/emulators/dosbox/Makefile	Mon Jul  8 20:22:33 2013	(r322538)
 +++ head/emulators/dosbox/Makefile	Mon Jul  8 21:28:28 2013	(r322539)
 @@ -27,8 +27,19 @@ DESKTOP_ENTRIES="DOSBox" "${COMMENT}" \
  		"" "dosbox" \
  		"System;Emulator;" "true"
  
 +OPTIONS_RADIO=	DEBUGGER
 +OPTIONS_RADIO_DEBUGGER=DEBUGGER_ENABLE DEBUGGER_HEAVY
 +DEBUGGER_ENABLE_DESC=Enable internal debugger
 +DEBUGGER_HEAVY_DESC=Enable internal debugger with extra features
 +
  .include <bsd.port.options.mk>
  
 +.if ${PORT_OPTIONS:MDEBUGGER_ENABLE}
 +CONFIGURE_ARGS+=	--enable-debug=yes
 +.elif ${PORT_OPTIONS:MDEBUGGER_HEAVY}
 +CONFIGURE_ARGS+=	--enable-debug=heavy
 +.endif
 +
  post-patch:
  	@${REINPLACE_CMD} -e 's#\/usr\/share\/doc\/dosbox#${DOCSDIR}#g' \
  		${WRKSRC}/docs/dosbox.1
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->closed 
State-Changed-By: lippe 
State-Changed-When: Mon Jul 8 21:33:24 UTC 2013 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=179924 
>Unformatted:
