From nobody@FreeBSD.org  Sun Jun 23 15:43:20 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id C1C76C3E
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 23 Jun 2013 15:43:20 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121])
	by mx1.freebsd.org (Postfix) with ESMTP id B54DC11AE
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 23 Jun 2013 15:43:20 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r5NFhKQ3038463
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 23 Jun 2013 15:43:20 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r5NFhKQU038462;
	Sun, 23 Jun 2013 15:43:20 GMT
	(envelope-from nobody)
Message-Id: <201306231543.r5NFhKQU038462@oldred.freebsd.org>
Date: Sun, 23 Jun 2013 15:43:20 GMT
From: John Marino <draco@marino.st>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] games/thegrind: unbreak (bad dependency)
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: nemysis@gmx.ch

>Number:         179882
>Category:       ports
>Synopsis:       [PATCH] games/thegrind: unbreak (bad dependency)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    wg
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jun 23 15:50:00 UTC 2013
>Closed-Date:    Mon Jun 24 13:55:17 UTC 2013
>Last-Modified:  Mon Jun 24 14:00:01 UTC 2013
>Originator:     John Marino
>Release:        
>Organization:
>Environment:
>Description:
thegame requests the dynamic library "radius" from radius-engine, but this isn't listed in the package list.  THe attached patch lists the static library radius-engine.a instead to fix it.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- Makefile.orig	2013-06-23 15:28:03.000000000 +0000
+++ Makefile
@@ -12,8 +12,8 @@ COMMENT=	A simple game about escaping fr
 
 LICENSE=	GPLv2
 
-LIB_DEPENDS=	radius:${PORTSDIR}/graphics/radius-engine \
-		lua-5.1:${PORTSDIR}/lang/lua \
+BUILD_DEPENDS=	${LOCALBASE}/lib/libradius-engine.a:${PORTSDIR}/graphics/radius-engine
+LIB_DEPENDS=	lua-5.1:${PORTSDIR}/lang/lua \
 		png15:${PORTSDIR}/graphics/png \
 		physfs.1:${PORTSDIR}/devel/physfs
 RUN_DEPENDS=	zip:${PORTSDIR}/archivers/zip


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sun Jun 23 15:50:13 UTC 2013 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=179882 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: nemysis@gmx.ch
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/179882: [PATCH] games/thegrind: unbreak (bad dependency)
Date: Sun, 23 Jun 2013 15:50:12 UT

 Maintainer of games/thegrind,
 
 Please note that PR ports/179882 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/179882
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: freebsd-ports-bugs->wg 
Responsible-Changed-By: wg 
Responsible-Changed-When: Sun Jun 23 20:56:59 UTC 2013 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=179882 

From: nemysis <nemysis@gmx.ch>
To: bug-followup@FreeBSD.org
Cc: jpaetzel@FreeBSD.org, wg@FreeBSD.org
Subject: Re: ports/179882: [PATCH] games/thegrind: unbreak (bad dependency)
Date: Sun, 23 Jun 2013 22:54:20 +0200

 --MP_/h/HXbnYzJ6LlYq/vu9CDpi7
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 - Trim Makefile header
 - Remove leading article from COMMENT
 - Trim dependency for graphics/radius-engine
 - Trim PLIST_FILES and PLIST_DIRS
 - Trim typo
 
 
 Build log
 
 https://redports.org/buildarchive/20130623191400-7766/
 --MP_/h/HXbnYzJ6LlYq/vu9CDpi7
 Content-Type: text/x-patch
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment; filename=thegrind.diff
 
 ===> Generating patch
 ===> Viewing diff with more
 diff -ruN /usr/ports/games/thegrind/Makefile ./Makefile
 --- /usr/ports/games/thegrind/Makefile	2013-06-02 18:54:51.000000000 +0200
 +++ ./Makefile	2013-06-23 20:11:38.000000000 +0200
 @@ -1,4 +1,4 @@
 -# Created by: nemysis@gmx.ch
 +# Created by: nemysis <nemysis@gmx.ch>
  # $FreeBSD: head/games/thegrind/Makefile 316343 2013-04-23 10:47:02Z bapt $
  
  PORTNAME=	thegrind
 @@ -8,38 +8,39 @@
  MASTER_SITES=	SF/radius-engine/ld21/
  
  MAINTAINER=	nemysis@gmx.ch
 -COMMENT=	A simple game about escaping from work
 +COMMENT=	Simple game about escaping from work
  
  LICENSE=	GPLv2
  
 -LIB_DEPENDS=	radius:${PORTSDIR}/graphics/radius-engine \
 -		lua-5.1:${PORTSDIR}/lang/lua \
 +BUILD_DEPENDS=	${LOCALBASE}/lib/libradius-engine.a:${PORTSDIR}/graphics/radius-engine
 +LIB_DEPENDS=	lua-5.1:${PORTSDIR}/lang/lua \
  		png15:${PORTSDIR}/graphics/png \
  		physfs.1:${PORTSDIR}/devel/physfs
  RUN_DEPENDS=	zip:${PORTSDIR}/archivers/zip
  
  USES=		pkgconfig
 -GNU_CONFIGURE=	yes
 -ALL_TARGET=	${PORTNAME}
  USE_SDL=	sdl sound
  USE_GL=		glu
 +GNU_CONFIGURE=	yes
 +ALL_TARGET=	${PORTNAME}
 +
  MAKE_JOBS_SAFE=	yes
  
  PLIST_FILES=	bin/${PORTNAME} \
  		share/applications/${PORTNAME}.desktop \
 -		share/pixmaps/${PORTNAME}.png
 +		share/pixmaps/${PORTNAME}.png \
 +		%%DATADIR%%/${PORTNAME}.zip
 +PLIST_DIRS=	%%DATADIR%%
  PLIST_DIRSTRY=	share/applications
  
 -PORTDATA=	*
  PORTDOCS=	ChangeLog
  
  .include <bsd.port.options.mk>
  
  post-install:
 -# Documentation
  .if ${PORT_OPTIONS:MDOCS}
 -	${MKDIR} ${DOCSDIR}
 -	${INSTALL_DATA} ${WRKSRC}/ChangeLog ${DOCSDIR}
 +	@${MKDIR} ${DOCSDIR}
 +	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
  .endif
  
  .include <bsd.port.mk>
 ===> Done
 
 --MP_/h/HXbnYzJ6LlYq/vu9CDpi7--

From: nemysis <nemysis@gmx.ch>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/179882: [PATCH] games/thegrind: unbreak (bad dependency)
Date: Mon, 24 Jun 2013 12:05:49 +0200

 --MP_/XhiptuVOJSjO_b=utFiGDP7
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 Sorry have forged to add Options for DOCS
 
 - Add DOCS Option
 --MP_/XhiptuVOJSjO_b=utFiGDP7
 Content-Type: text/x-patch
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment; filename=thegrind.diff
 
 ===> Generating patch
 ===> Viewing diff with more
 diff -ruN /usr/ports/games/thegrind/Makefile ./Makefile
 --- /usr/ports/games/thegrind/Makefile	2013-06-02 18:54:51.000000000 +0200
 +++ ./Makefile	2013-06-24 11:42:31.000000000 +0200
 @@ -1,4 +1,4 @@
 -# Created by: nemysis@gmx.ch
 +# Created by: nemysis <nemysis@gmx.ch>
  # $FreeBSD: head/games/thegrind/Makefile 316343 2013-04-23 10:47:02Z bapt $
  
  PORTNAME=	thegrind
 @@ -8,38 +8,41 @@
  MASTER_SITES=	SF/radius-engine/ld21/
  
  MAINTAINER=	nemysis@gmx.ch
 -COMMENT=	A simple game about escaping from work
 +COMMENT=	Simple game about escaping from work
  
  LICENSE=	GPLv2
  
 -LIB_DEPENDS=	radius:${PORTSDIR}/graphics/radius-engine \
 -		lua-5.1:${PORTSDIR}/lang/lua \
 +BUILD_DEPENDS=	${LOCALBASE}/lib/libradius-engine.a:${PORTSDIR}/graphics/radius-engine
 +LIB_DEPENDS=	lua-5.1:${PORTSDIR}/lang/lua \
  		png15:${PORTSDIR}/graphics/png \
  		physfs.1:${PORTSDIR}/devel/physfs
  RUN_DEPENDS=	zip:${PORTSDIR}/archivers/zip
  
  USES=		pkgconfig
 -GNU_CONFIGURE=	yes
 -ALL_TARGET=	${PORTNAME}
  USE_SDL=	sdl sound
  USE_GL=		glu
 +GNU_CONFIGURE=	yes
 +ALL_TARGET=	${PORTNAME}
 +
  MAKE_JOBS_SAFE=	yes
  
  PLIST_FILES=	bin/${PORTNAME} \
  		share/applications/${PORTNAME}.desktop \
 -		share/pixmaps/${PORTNAME}.png
 +		share/pixmaps/${PORTNAME}.png \
 +		%%DATADIR%%/${PORTNAME}.zip
 +PLIST_DIRS=	%%DATADIR%%
  PLIST_DIRSTRY=	share/applications
  
 -PORTDATA=	*
  PORTDOCS=	ChangeLog
  
 +OPTIONS_DEFINE=	DOCS
 +
  .include <bsd.port.options.mk>
  
  post-install:
 -# Documentation
  .if ${PORT_OPTIONS:MDOCS}
 -	${MKDIR} ${DOCSDIR}
 -	${INSTALL_DATA} ${WRKSRC}/ChangeLog ${DOCSDIR}
 +	@${MKDIR} ${DOCSDIR}
 +	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
  .endif
  
  .include <bsd.port.mk>
 ===> Done
 
 --MP_/XhiptuVOJSjO_b=utFiGDP7--
State-Changed-From-To: feedback->closed 
State-Changed-By: wg 
State-Changed-When: Mon Jun 24 13:55:15 UTC 2013 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=179882 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/179882: commit references a PR
Date: Mon, 24 Jun 2013 13:54:30 +0000 (UTC)

 Author: wg
 Date: Mon Jun 24 13:54:22 2013
 New Revision: 321682
 URL: http://svnweb.freebsd.org/changeset/ports/321682
 
 Log:
   games/thegrind: fix build depends
   
   - Fix BUILD_DEPENDS: needs a static library [1]
   - Remove leading article in COMMENT [2]
   - Add maintainer alias in Makefile [2]
   - Add DOCS option and unmute docs mkdir [2]
   
   PR:		ports/179882
   Submitted by:	John Marino <draco@marino.st> [1], maintainer [2]
 
 Modified:
   head/games/thegrind/Makefile
 
 Modified: head/games/thegrind/Makefile
 ==============================================================================
 --- head/games/thegrind/Makefile	Mon Jun 24 13:53:29 2013	(r321681)
 +++ head/games/thegrind/Makefile	Mon Jun 24 13:54:22 2013	(r321682)
 @@ -1,4 +1,4 @@
 -# Created by: nemysis@gmx.ch
 +# Created by: nemysis <nemysis@gmx.ch>
  # $FreeBSD$
  
  PORTNAME=	thegrind
 @@ -8,38 +8,41 @@ CATEGORIES=	games
  MASTER_SITES=	SF/radius-engine/ld21/
  
  MAINTAINER=	nemysis@gmx.ch
 -COMMENT=	A simple game about escaping from work
 +COMMENT=	Simple game about escaping from work
  
  LICENSE=	GPLv2
  
 -LIB_DEPENDS=	radius:${PORTSDIR}/graphics/radius-engine \
 -		lua-5.1:${PORTSDIR}/lang/lua \
 +BUILD_DEPENDS=	${LOCALBASE}/lib/libradius-engine.a:${PORTSDIR}/graphics/radius-engine
 +LIB_DEPENDS=	lua-5.1:${PORTSDIR}/lang/lua \
  		png15:${PORTSDIR}/graphics/png \
  		physfs.1:${PORTSDIR}/devel/physfs
  RUN_DEPENDS=	zip:${PORTSDIR}/archivers/zip
  
  USES=		pkgconfig
 -GNU_CONFIGURE=	yes
 -ALL_TARGET=	${PORTNAME}
  USE_SDL=	sdl sound
  USE_GL=		glu
 +GNU_CONFIGURE=	yes
 +ALL_TARGET=	${PORTNAME}
 +
  MAKE_JOBS_SAFE=	yes
  
  PLIST_FILES=	bin/${PORTNAME} \
  		share/applications/${PORTNAME}.desktop \
 -		share/pixmaps/${PORTNAME}.png
 +		share/pixmaps/${PORTNAME}.png \
 +		%%DATADIR%%/${PORTNAME}.zip
 +PLIST_DIRS=	%%DATADIR%%
  PLIST_DIRSTRY=	share/applications
  
 -PORTDATA=	*
  PORTDOCS=	ChangeLog
  
 +OPTIONS_DEFINE=	DOCS
 +
  .include <bsd.port.options.mk>
  
  post-install:
 -# Documentation
  .if ${PORT_OPTIONS:MDOCS}
 -	${MKDIR} ${DOCSDIR}
 -	${INSTALL_DATA} ${WRKSRC}/ChangeLog ${DOCSDIR}
 +	@${MKDIR} ${DOCSDIR}
 +	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
  .endif
  
  .include <bsd.port.mk>
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
