From nobody@FreeBSD.org  Sat Jun 15 10:47:43 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id C2569B5
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 15 Jun 2013 10:47:43 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121])
	by mx1.freebsd.org (Postfix) with ESMTP id 998B51154
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 15 Jun 2013 10:47:43 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r5FAlhJm062225
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 15 Jun 2013 10:47:43 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r5FAlhao062224;
	Sat, 15 Jun 2013 10:47:43 GMT
	(envelope-from nobody)
Message-Id: <201306151047.r5FAlhao062224@oldred.freebsd.org>
Date: Sat, 15 Jun 2013 10:47:43 GMT
From: "O. Hartmann" <ohartman@zedat.fu-berlin.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: textproc/refdb: Fatal error: Call-time pass-by-reference has been removed in /usr/local/share/refdb/www/index.php on line 1531
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         179569
>Category:       ports
>Synopsis:       textproc/refdb: Fatal error: Call-time pass-by-reference has been removed in /usr/local/share/refdb/www/index.php on line 1531
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    clsung
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jun 15 10:50:00 UTC 2013
>Closed-Date:    Sun Mar 23 17:49:51 UTC 2014
>Last-Modified:  Sun Mar 23 17:49:51 UTC 2014
>Originator:     O. Hartmann
>Release:        FreeBSD 10..0-CURRENT/amd64 FreeBSD 9.1-STABLE/amd64
>Organization:
FU Berlin
>Environment:
>Description:
If someone is using texproc/refdb's PHP web interface which is in some cases very convenient, this one will run into problems on more modern php5 implementations, since the index.php file of refdb's web interface complains about a call by reference failure (it seems to be YAZ, but I'm not sure).

I simply circumvented this problem by following the PHP error logs advice to check and correct and I "corrected" the call by reference simply by removing the ampersand in the call shown in the patch attached.
>How-To-Repeat:
Install textproc/refdb on a modern FreeBSD 9/10 by using most recent PHP5, yaz and Apache22 or Apache24.
>Fix:
Modify line 1531 in phpweb/index.php.in as shown in the attached patch.

Patch attached with submission follows:

diff -Nur refdb.orig/files/patch-phpweb-index.php.in refdb/files/patch-phpweb-index.php.in
--- refdb.orig/files/patch-phpweb-index.php.in	1970-01-01 01:00:00.000000000 +0100
+++ refdb/files/patch-phpweb-index.php.in	2013-06-15 12:39:03.000000000 +0200
@@ -0,0 +1,18 @@
+--- phpweb/index.php.in.orig	2013-06-15 12:37:55.000000000 +0200
++++ phpweb/index.php.in	2013-06-15 12:38:21.000000000 +0200
+@@ -1528,7 +1528,7 @@
+ 	 // Mapping CCL terms to RPN as defined above (bib1) for each search 
+ 	 yaz_ccl_conf($id[$i], $bib1);
+ 	 // Parse input against yaz_ccl_conf; if error report message; defines cclresult as output of parsing
+-	 if (!yaz_ccl_parse($id[$i], $term, &$cclresult)) {
++	 if (!yaz_ccl_parse($id[$i], $term, $cclresult)) {
+ 	   echo '<p>Error: ' . $cclresult["errorstring"] . '</p><p><a href=\"index.php?thisPage=External databases\">Clear results</a></p>';
+ 	   continue;
+ 	 }
+@@ -1791,4 +1791,4 @@
+ // close out the html
+ echo "    </body>\n";
+ echo "</html>\n";
+-?>
+\ No newline at end of file
++?>


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->clsung 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Jun 15 10:50:08 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=179569 
State-Changed-From-To: open->closed 
State-Changed-By: linimon 
State-Changed-When: Sun Mar 23 17:49:08 UTC 2014 
State-Changed-Why:  
see ports/187271. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=179569 
>Unformatted:
