From nobody@FreeBSD.org  Tue Jun 11 21:39:00 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id 138A5DA8
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 11 Jun 2013 21:39:00 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121])
	by mx1.freebsd.org (Postfix) with ESMTP id E090F1E90
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 11 Jun 2013 21:38:59 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r5BLcweF012231
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 11 Jun 2013 21:38:58 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r5BLcwga012230;
	Tue, 11 Jun 2013 21:38:58 GMT
	(envelope-from nobody)
Message-Id: <201306112138.r5BLcwga012230@oldred.freebsd.org>
Date: Tue, 11 Jun 2013 21:38:58 GMT
From: "Christopher J. Ruwe" <cjr@cruwe.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: finance/gnucash does not install database dependencies
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         179500
>Category:       ports
>Synopsis:       finance/gnucash does not install database dependencies
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 11 21:40:04 UTC 2013
>Closed-Date:    Fri Feb 07 09:07:18 UTC 2014
>Last-Modified:  Fri Feb 07 09:07:18 UTC 2014
>Originator:     Christopher J. Ruwe
>Release:        9.1-RELEASE
>Organization:
>Environment:
FreeBSD dijkstra.cruwe.de 9.1-RELEASE FreeBSD 9.1-RELEASE #2: Tue Nov 27 03:45:16 UTC 2012     root@darkstar:/usr/obj/pcbsd-build90/fbsd-source/9.1/sys/GENERIC  amd64

>Description:
finance/gnucash is a program for private and small to medium business accounting

The config-flag "DATABASE" is said to "Enable SQL database backends". The pkg-message informs after installation that to actually use DBs, manually installing databses/libdbi-drivers is required.

This is non-optimal. Typically, users associate "enable" with "actually usable", not, as in this case, "theoretically usable if you manually do this and that".
>How-To-Repeat:
Install finance/gnucash and read pkg-message. Alternatively, just cat it.
>Fix:
add databases/libdbi-drivers as RUN_DEPENDS

Patch attached with submission follows:

diff -uNr /poudriere/ports/default/finance/gnucash/Makefile finance/gnucash/Makefile
--- /poudriere/ports/default/finance/gnucash/Makefile	2013-04-27 16:50:56.873912995 +0200
+++ finance/gnucash/Makefile	2013-06-11 23:13:10.292359027 +0200
@@ -3,7 +3,7 @@
 
 PORTNAME=	gnucash
 PORTVERSION=	2.4.11
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	finance gnome
 MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}%20%28stable%29/${PORTVERSION}
 
@@ -89,6 +89,7 @@
 .if ${PORT_OPTIONS:MDATABASE}
 CONFIGURE_ARGS+=--enable-dbi
 LIB_DEPENDS+=	dbi:${PORTSDIR}/databases/libdbi
+RUN_DEPENDS+=	${LOCALBASE}/lib/dbd:${PORTSDIR}/databases/libdbi-drivers
 PLIST_SUB+=	DATABASE=""
 .else
 CONFIGURE_ARGS+=--disable-dbi
diff -uNr /poudriere/ports/default/finance/gnucash/pkg-message finance/gnucash/pkg-message
--- /poudriere/ports/default/finance/gnucash/pkg-message	2012-09-12 21:15:34.640673883 +0200
+++ finance/gnucash/pkg-message	2013-06-11 23:14:27.416354343 +0200
@@ -1,11 +1,8 @@
 ###############################################################################
 
-If you have enabled the DATABASE option and want to use any of the supported
-database backends, you also need to install:
-
-databases/libdbi-drivers
-
-And select the database type(s) you want to use.
+If you have enabled the DATABASE option, databases/libdbi-drivers is
+pulled in as a dependency. Database types should be en- or disabled in
+databases/libdbi-drivers's options.
 
 MySQL, PostgreSQL, and SQLite3 are supported in GnuCash.
 


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gnome 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Jun 11 21:40:21 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=179500 
State-Changed-From-To: open->closed 
State-Changed-By: kwm 
State-Changed-When: Fri Feb 7 09:05:51 UTC 2014 
State-Changed-Why:  
A runtime dependacy on libdbi-drivers was added in the 2.6.0 update of  
gnucash. I forgot to close this pr. thanks for reporting.  

http://www.freebsd.org/cgi/query-pr.cgi?pr=179500 
>Unformatted:
