From nobody@FreeBSD.org  Tue Jun 11 12:37:29 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id DDD29A5C
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 11 Jun 2013 12:37:29 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121])
	by mx1.freebsd.org (Postfix) with ESMTP id D09B81073
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 11 Jun 2013 12:37:29 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r5BCbTaA048757
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 11 Jun 2013 12:37:29 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r5BCbTs7048745;
	Tue, 11 Jun 2013 12:37:29 GMT
	(envelope-from nobody)
Message-Id: <201306111237.r5BCbTs7048745@oldred.freebsd.org>
Date: Tue, 11 Jun 2013 12:37:29 GMT
From: Spil <spil.oss@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [net/dlna] minidlna-1.1.0,1 does not create pid directory
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         179487
>Category:       ports
>Synopsis:       net/minidlna: minidlna-1.1.0,1 does not create pid directory
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    wg
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 11 12:40:00 UTC 2013
>Closed-Date:    Wed Jun 19 20:35:18 UTC 2013
>Last-Modified:  Wed Jun 19 20:40:00 UTC 2013
>Originator:     Spil
>Release:        FreeBSD 9.1
>Organization:
n.a.
>Environment:
FreeBSD gw.example.org 9.1-RELEASE FreeBSD 9.1-RELEASE #1 r243787: Mon Dec  3 18:52:28 CET 2012     root@gw.example.org:/usr/obj/usr/src/sys/BEASTIE91  i386
>Description:
After upgrading minidlna from minidlna-1.0.25_1,1 to the latest version, it fails to start with the message

/usr/local/etc/rc.d/minidlna: WARNING: /var/run/minidlna is not a directory.
/usr/local/etc/rc.d/minidlna: WARNING: failed precmd routine for minidlna

>How-To-Repeat:
Upgrade minidlna-1.0.25_1,1 to minidlna-1.1.0,1
>Fix:
--- pkg-plist.orig      2013-06-11 14:31:55.000000000 +0200
+++ pkg-plist   2013-06-11 14:33:37.000000000 +0200
@@ -14,3 +14,8 @@
 %%NLS%%share/locale/ru/LC_MESSAGES/minidlna.mo
 %%NLS%%share/locale/sl/LC_MESSAGES/minidlna.mo
 %%NLS%%share/locale/sv/LC_MESSAGES/minidlna.mo
+@exec /usr/bin/install -d -m 755 -o minidlna -g minidlna /var/run/minidlna
+@cwd /var/run
+@unexec rm -f %D/minidlna/minidlna.pid 2>/dev/null || true
+@dirrmtry minidlna


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->wg 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Jun 17 01:03:57 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=179487 

From: William Grzybowski <william88@gmail.com>
To: bug-followup@FreeBSD.org, spil.oss@gmail.com
Cc:  
Subject: Re: ports/179487: net/minidlna: minidlna-1.1.0,1 does not create pid directory
Date: Sun, 16 Jun 2013 22:42:25 -0300

 That patch does not make sense, it installs a dir using unexistent
 users (minidlna).
 
 Also there is already a MKDIR command in Makefile post-install.
 
 You error seems to indicated you have a file already created called
 /var/run/minidlna, how is that possible?
 
 --
 William Grzybowski
 ------------------------------------------
 Curitiba/PR - Brasil

From: Spil Oss <spil.oss@gmail.com>
To: William Grzybowski <william88@gmail.com>
Cc: bug-followup@freebsd.org
Subject: Re: ports/179487: net/minidlna: minidlna-1.1.0,1 does not create pid directory
Date: Wed, 19 Jun 2013 21:46:36 +0200

 Hi William,
 
 Sorry for that, looks like a package problem only. I ran into trouble
 after the upgrade using a package that minidlna wouldn't start due to
 the fact that the /var/run/minidlna directory did not exist.
 
 from rc.d/minidlna
 pidfile="/var/run/minidlna/minidlna.pid"
 
 start_precmd="rm -f $pidfile"
 stop_postcmd=$start_precmd
 
 That's why it complained
 /usr/local/etc/rc.d/minidlna: WARNING: /var/run/minidlna is not a directory.
 /usr/local/etc/rc.d/minidlna: WARNING: failed precmd routine for minidlna
 
 There was still an old minidlna.pid
 -rw-r--r--  1 root  wheel  6 Mar 17 15:53 /var/run/minidlna.pid
 
 Re-built and packaged minidlna-1.1.0,1 and it still fails, and no pid
 dir is created
 ls: /var/run/minidlna*: No such file or directory
 
 Building and installing does create the /var/run/minidlna dir so a
 package-only problem, hence I modified the pkg-plist using an example
 from fetchmail(?)
 
 Kind regards,
 
 Spil.
 
 On Mon, Jun 17, 2013 at 3:42 AM, William Grzybowski <william88@gmail.com> wrote:
 > That patch does not make sense, it installs a dir using unexistent
 > users (minidlna).
 >
 > Also there is already a MKDIR command in Makefile post-install.
 >
 > You error seems to indicated you have a file already created called
 > /var/run/minidlna, how is that possible?
 >
 > --
 > William Grzybowski
 > ------------------------------------------
 > Curitiba/PR - Brasil
State-Changed-From-To: open->closed 
State-Changed-By: wg 
State-Changed-When: Wed Jun 19 20:35:18 UTC 2013 
State-Changed-Why:  
Should be fixed, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=179487 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/179487: commit references a PR
Date: Wed, 19 Jun 2013 20:35:10 +0000 (UTC)

 Author: wg
 Date: Wed Jun 19 20:34:57 2013
 New Revision: 321321
 URL: http://svnweb.freebsd.org/changeset/ports/321321
 
 Log:
   net/minidlna: fix run dir for packages
   
   - Use rc.d script to install /var/{db,run}/minidlna as precmd
   - Fix order (rclint)
   
   PR:		ports/179487
   Submitted by:	crees
   Approved by:	culot / jpaetzel (mentors, implicit)
 
 Modified:
   head/net/minidlna/Makefile
   head/net/minidlna/files/minidlna.in
 
 Modified: head/net/minidlna/Makefile
 ==============================================================================
 --- head/net/minidlna/Makefile	Wed Jun 19 20:12:38 2013	(r321320)
 +++ head/net/minidlna/Makefile	Wed Jun 19 20:34:57 2013	(r321321)
 @@ -49,9 +49,6 @@ post-install:
  	${INSTALL_MAN} ${MAN5:S,^,${WRKSRC}/,} ${MANPREFIX}/man/man5/
  	${INSTALL_MAN} ${MAN8:S,^,${WRKSRC}/,} ${MANPREFIX}/man/man8/
  	${INSTALL_DATA} ${WRKSRC}/minidlna.conf ${PREFIX}/etc/minidlna.conf.sample
 -	@${MKDIR} /var/run/minidlna
 -	@${MKDIR} /var/db/minidlna
 -	@${CHOWN} ${USERS} /var/db/minidlna
  	@${FMT} ${PKGMESSAGE}
  
  .include <bsd.port.mk>
 
 Modified: head/net/minidlna/files/minidlna.in
 ==============================================================================
 --- head/net/minidlna/files/minidlna.in	Wed Jun 19 20:12:38 2013	(r321320)
 +++ head/net/minidlna/files/minidlna.in	Wed Jun 19 20:34:57 2013	(r321321)
 @@ -1,4 +1,5 @@
  #!/bin/sh
 +#
  # $FreeBSD$
  #
  # PROVIDE: minidlna
 @@ -13,21 +14,21 @@
  
  name=minidlna
  rcvar=minidlna_enable
 -command=%%PREFIX%%/sbin/minidlnad
  
  load_rc_config $name
  
  minidlna_enable=${minidlna_enable-"NO"}
  minidlna_uid=${minidlna_uid-"%%USER%%"}
  
 +command=%%PREFIX%%/sbin/minidlnad
  pidfile="/var/run/minidlna/minidlna.pid"
 +command_args="-P $pidfile -u $minidlna_uid -f %%PREFIX%%/etc/minidlna.conf"
 +required_dirs="/var/run/minidlna /var/db/minidlna"
  
 -start_precmd="rm -f $pidfile"
 -stop_postcmd=$start_precmd
 +start_precmd="install -d -o $minidlna_uid ${pidfile%/*} /var/db/minidlna"
 +stop_postcmd="rm -f $pidfile"
  
 -command_args="-P $pidfile -u $minidlna_uid -f %%PREFIX%%/etc/minidlna.conf"
  extra_commands=rescan
  rescan_cmd="$command -R -u $minidlna_uid -f %%PREFIX%%/etc/minidlna.conf"
 -required_dirs="/var/run/minidlna /var/db/minidlna"
  
  run_rc_command $1
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
