From nemysis@gmx.ch  Mon Jun  3 03:07:03 2013
Return-Path: <nemysis@gmx.ch>
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
	by hub.freebsd.org (Postfix) with ESMTP id 67FE26D3
	for <freebsd-gnats-submit@freebsd.org>; Mon,  3 Jun 2013 03:07:03 +0000 (UTC)
	(envelope-from nemysis@gmx.ch)
Received: from mout.gmx.net (mout.gmx.net [212.227.15.18])
	by mx1.freebsd.org (Postfix) with ESMTP id 1564D1343
	for <freebsd-gnats-submit@freebsd.org>; Mon,  3 Jun 2013 03:07:02 +0000 (UTC)
Received: from mailout-de.gmx.net ([10.1.76.32]) by mrigmx.server.lan
 (mrigmx001) with ESMTP (Nemesis) id 0MQ9JV-1UoaIf04nb-005G3e for
 <FreeBSD-gnats-submit@freebsd.org>; Mon, 03 Jun 2013 05:07:02 +0200
Received: (qmail invoked by alias); 03 Jun 2013 03:07:00 -0000
Received: from 5-80.77-83.cust.bluewin.ch (EHLO something.email.com) [83.77.80.5]
  by mail.gmx.net (mp032) with SMTP; 03 Jun 2013 05:07:00 +0200
Received: by something.email.com (sSMTP sendmail emulation); Mon, 03 Jun 2013 05:07:00 +0200
Message-Id: <20130603030703.67FE26D3@hub.freebsd.org>
Date: Mon, 03 Jun 2013 05:07:00 +0200
From: nemysis <nemysis@gmx.ch>
To: FreeBSD-gnats-submit@freebsd.org
Cc: gahr@FreeBSD.org
Subject: [PATCH] devel/dparser: Fix docs, cleanup Makefile
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         179244
>Category:       ports
>Synopsis:       [PATCH] devel/dparser: Fix docs, cleanup Makefile
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gahr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 03 03:10:00 UTC 2013
>Closed-Date:    Mon Mar 31 11:46:46 UTC 2014
>Last-Modified:  Mon Mar 31 11:46:46 UTC 2014
>Originator:     nemysis
>Release:        FreeBSD 9.1-RELEASE-p3 amd64
>Organization:
>Environment:
System: FreeBSD FreeBSD_Ports 9.1-RELEASE-p3 FreeBSD 9.1-RELEASE-p3 #0: Mon Apr 29 18:27:25 UTC 2013
>Description:

- Remove DOCS Option
- Fix docs
- Cleanup Makefile
- Trim files/patch-Makefile

Port maintainer (gahr@FreeBSD.org) is cc'd.

Generated and tested manually, tested with port test and with RedPorts, sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
>How-To-Repeat:

Build log

https://redports.org/buildarchive/20130603022801-13245/

>Fix:

--- dparser-1.30.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/devel/dparser/Makefile ./Makefile
--- /usr/ports/devel/dparser/Makefile	2013-06-02 18:59:46.000000000 +0200
+++ ./Makefile	2013-06-03 04:26:22.000000000 +0200
@@ -10,7 +10,7 @@
 MAINTAINER=	gahr@FreeBSD.org
 COMMENT=	Simple but powerful tool for parsing
 
-OPTIONS_DEFINE=	BOEHM DOCS
+OPTIONS_DEFINE=	BOEHM
 BOEHM_DESC=	Boehm garbage collector support
 
 WRKSRC=		${WRKDIR}/d
@@ -26,6 +26,9 @@
 
 .include <bsd.port.options.mk>
 
+post-patch:
+	${REINPLACE_CMD} -e 's|%%PREFIX%%|${PREFIX}|' ${WRKSRC}/Makefile
+
 .if ${PORT_OPTIONS:MBOEHM}
 LIB_DEPENDS+=	gc:${PORTSDIR}/devel/boehm-gc
 MAKE_ARGS+=	D_USE_GC=1 \
@@ -41,12 +44,12 @@
 
 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/make_dparser ${PREFIX}/bin
-	${INSTALL_MAN} ${WRKSRC}/make_dparser.1 ${MANPREFIX}/man/man1
-	${INSTALL_DATA} ${WRKSRC}/dparse.h ${PREFIX}/include
-	${INSTALL_DATA} ${WRKSRC}/dparse_tables.h ${PREFIX}/include
-	${INSTALL_DATA} ${WRKSRC}/dparse_tree.h ${PREFIX}/include
-	${INSTALL_DATA} ${WRKSRC}/dsymtab.h ${PREFIX}/include
+	${INSTALL_MAN} ${WRKSRC}/${MAN1} ${MAN1PREFIX}/man/man1
+.for f in dparse.h dparse_tables.h dparse_tree.h dsymtab.h
+	(cd ${WRKSRC} && ${INSTALL_DATA} ${f} ${PREFIX}/include)
+.endfor
 	${INSTALL_DATA} ${WRKSRC}/${LIBDPARSE} ${PREFIX}/lib
+
 .if ${PORT_OPTIONS:MDOCS}
 	@${MKDIR} ${DOCSDIR}
 	${INSTALL_DATA} ${WRKSRC}/*.html ${DOCSDIR}
diff -ruN --exclude=CVS /usr/ports/devel/dparser/files/patch-Makefile ./files/patch-Makefile
--- /usr/ports/devel/dparser/files/patch-Makefile	2013-06-02 18:59:46.000000000 +0200
+++ ./files/patch-Makefile	2013-04-04 02:03:12.000000000 +0200
@@ -1,6 +1,6 @@
---- Makefile.orig	2013-04-02 10:00:17.000000000 +0200
-+++ Makefile	2013-04-02 10:01:34.000000000 +0200
-@@ -11,7 +11,7 @@
+--- Makefile.orig	2013-03-02 22:22:20.000000000 +0100
++++ Makefile	2013-04-04 01:59:35.000000000 +0200
+@@ -11,10 +11,10 @@
  MINOR=30
  RELEASE=$(MAJOR).$(MINOR)
  
@@ -8,7 +8,11 @@
 +CC ?= gcc
  
  ifndef PREFIX
- PREFIX=/usr/local
+-PREFIX=/usr/local
++PREFIX=%%PREFIX%%
+ endif
+ 
+ .PHONY: all gram test install myexample
 @@ -38,7 +38,7 @@
    ARCH = x86
  endif
@@ -41,12 +45,3 @@
  d/grammar.g d/sample.g d/my.g 
  
  LIB_SRCS = arg.c parse.c scan.c symtab.c util.c read_binary.c dparse_tree.c
-@@ -141,7 +141,7 @@
- 
- ALL_SRCS = $(MAKE_PARSER_SRCS) $(BASE_SAMPLE_PARSER_SRCS) $(LIB_SRCS) $(MK_LIB_SRCS)
- 
--all: $(EXECS) $(LIBRARIES) D_BUILD_VERSION make_dparser.cat
-+all: $(EXECS) $(LIBRARIES) make_dparser.cat
- 
- version:
- 	echo $(OS_TYPE) $(OS_VERSION)
diff -ruN --exclude=CVS /usr/ports/devel/dparser/files/patch-arg.c ./files/patch-arg.c
--- /usr/ports/devel/dparser/files/patch-arg.c	2013-06-02 18:59:46.000000000 +0200
+++ ./files/patch-arg.c	2013-04-04 02:03:41.000000000 +0200
@@ -1,5 +1,5 @@
---- arg.c.orig	Fri Nov  7 03:03:52 2003
-+++ arg.c	Mon Feb  2 18:35:43 2004
+--- arg.c.orig	2013-01-23 03:14:58.000000000 +0100
++++ arg.c	2013-04-04 02:02:01.000000000 +0200
 @@ -40,7 +40,7 @@
            *(double *)desc[i].location = atof(arg);
            break;
--- dparser-1.30.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gahr 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Jun 3 03:10:09 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=179244 

From: Pietro Cerutti <gahr@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/179244: [PATCH] devel/dparser: Fix docs, cleanup Makefile
Date: Mon, 3 Jun 2013 12:59:23 +0200

 --UthUFkbMtH2ceUK2
 Content-Type: text/plain; charset=utf-8
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 Nemysis,
 
 I don't see a reason to apply any of this. Especially, I don't see why
 the DOCS options should be removed, and what you mean by "- Fix docs" ?
 
 Thanks for explaining what you're trying to achieve here.
 
 --=20
 Pietro Cerutti
 The FreeBSD Project
 gahr@FreeBSD.org
 
 PGP Public Key:
 http://gahr.ch/pgp
 
 --UthUFkbMtH2ceUK2
 Content-Type: application/pgp-signature
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.19 (FreeBSD)
 
 iEYEARECAAYFAlGsdwoACgkQwMJqmJVx947C7wCeLnCTtwsInAhNOBP7gXTEGKOZ
 L24AnilyTHOq7Ctg+fcwIv9uYGQtpwHu
 =BVjw
 -----END PGP SIGNATURE-----
 
 --UthUFkbMtH2ceUK2--
State-Changed-From-To: open->feedback 
State-Changed-By: gahr 
State-Changed-When: Mon Aug 26 12:22:28 UTC 2013 
State-Changed-Why:  
Ask for clarification of intent from submitter. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=179244 

From: nemysis <nemysis@FreeBSD.org>
To: bug-followup@FreeBSD.org, gahr@FreeBSD.org
Cc: nemysis@FreeBSD.org
Subject: ports/179244: [PATCH] devel/dparser: Fix docs, cleanup Makefile
Date: Thu, 12 Sep 2013 20:22:39 +0200

 --mP3DRpeJDSE+ciuQ
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 > Nemysis,
 > 
 > I don't see a reason to apply any of this. Especially, I don't see why
 > the DOCS options should be removed, and what you mean by "- Fix docs" ?
 > 
 > Thanks for explaining what you're trying to achieve here.
 
 Sorry have make mistake with "- Fix docs" and removing DOCS option.
 
 - Use the new format for LIB_DEPENDS
 - Add post-patch
 - Simplify do-install
 - Change files/patch-Makefile /usr/local --> %%PREFIX%%
 
 
 Build log
 
 https://redports.org/buildarchive/20130912175600-31005/
 
 
 Please approve these changes.
 
 --mP3DRpeJDSE+ciuQ
 Content-Type: text/x-diff; charset=us-ascii
 Content-Disposition: attachment; filename="dparser.diff"
 
 ===> Generating patch
 ===> Viewing diff with more
 diff -ruN /usr/ports/devel/dparser/Makefile ./Makefile
 --- /usr/ports/devel/dparser/Makefile	2013-09-08 23:33:19.000000000 +0200
 +++ ./Makefile	2013-09-12 12:58:18.000000000 +0200
 @@ -13,6 +13,10 @@
  OPTIONS_DEFINE=	BOEHM DOCS
  BOEHM_DESC=	Boehm garbage collector support
  
 +OPTIONS_SUB=	yes
 +
 +BOEHM_LIB_DEPENDS=	libgc.so:${PORTSDIR}/devel/boehm-gc
 +
  WRKSRC=		${WRKDIR}/d
  
  EXTRACT_AFTER_ARGS=	--exclude "*my*"
 @@ -27,7 +31,6 @@
  .include <bsd.port.options.mk>
  
  .if ${PORT_OPTIONS:MBOEHM}
 -LIB_DEPENDS+=	gc:${PORTSDIR}/devel/boehm-gc
  MAKE_ARGS+=	D_USE_GC=1 \
  		GC_CFLAGS="-I${LOCALBASE}/include -L${LOCALBASE}/lib"
  LIBDPARSE=	libdparse_gc.a
 @@ -39,14 +42,17 @@
  BROKEN=		Does not build on ia64
  .endif
  
 +post-patch:
 +	@${REINPLACE_CMD} -e 's|%%PREFIX%%|${PREFIX}|' ${WRKSRC}/Makefile
 +
  do-install:
 -	${INSTALL_PROGRAM} ${WRKSRC}/make_dparser ${PREFIX}/bin
 -	${INSTALL_MAN} ${WRKSRC}/make_dparser.1 ${MANPREFIX}/man/man1
 -	${INSTALL_DATA} ${WRKSRC}/dparse.h ${PREFIX}/include
 -	${INSTALL_DATA} ${WRKSRC}/dparse_tables.h ${PREFIX}/include
 -	${INSTALL_DATA} ${WRKSRC}/dparse_tree.h ${PREFIX}/include
 -	${INSTALL_DATA} ${WRKSRC}/dsymtab.h ${PREFIX}/include
 -	${INSTALL_DATA} ${WRKSRC}/${LIBDPARSE} ${PREFIX}/lib
 +	${INSTALL_PROGRAM} ${WRKSRC}/make_dparser ${PREFIX}/bin/
 +	${INSTALL_MAN} ${WRKSRC}/${MAN1} ${MAN1PREFIX}/man/man1/
 +.for f in dparse.h dparse_tables.h dparse_tree.h dsymtab.h
 +	@(cd ${WRKSRC} && ${INSTALL_DATA} ${f} ${PREFIX}/include)
 +.endfor
 +	${INSTALL_DATA} ${WRKSRC}/${LIBDPARSE} ${PREFIX}/lib/
 +
  .if ${PORT_OPTIONS:MDOCS}
  	@${MKDIR} ${DOCSDIR}
  	${INSTALL_DATA} ${WRKSRC}/*.html ${DOCSDIR}
 diff -ruN /usr/ports/devel/dparser/files/patch-Makefile ./files/patch-Makefile
 --- /usr/ports/devel/dparser/files/patch-Makefile	2013-08-15 23:02:19.000000000 +0200
 +++ ./files/patch-Makefile	2013-09-12 19:42:46.000000000 +0200
 @@ -1,6 +1,6 @@
 ---- Makefile.orig	2013-04-02 10:00:17.000000000 +0200
 -+++ Makefile	2013-04-02 10:01:34.000000000 +0200
 -@@ -11,7 +11,7 @@
 +--- Makefile.orig	2013-03-02 22:22:20.000000000 +0100
 ++++ Makefile	2013-09-12 19:35:27.000000000 +0200
 +@@ -11,10 +11,10 @@
   MINOR=30
   RELEASE=$(MAJOR).$(MINOR)
   
 @@ -8,7 +8,11 @@
  +CC ?= gcc
   
   ifndef PREFIX
 - PREFIX=/usr/local
 +-PREFIX=/usr/local
 ++PREFIX=%%PREFIX%%
 + endif
 + 
 + .PHONY: all gram test install myexample
  @@ -38,7 +38,7 @@
     ARCH = x86
   endif
 diff -ruN /usr/ports/devel/dparser/files/patch-arg.c ./files/patch-arg.c
 --- /usr/ports/devel/dparser/files/patch-arg.c	2013-08-15 23:02:19.000000000 +0200
 +++ ./files/patch-arg.c	2013-09-12 19:43:29.000000000 +0200
 @@ -1,5 +1,5 @@
 ---- arg.c.orig	Fri Nov  7 03:03:52 2003
 -+++ arg.c	Mon Feb  2 18:35:43 2004
 +--- arg.c.orig	2013-01-23 03:14:58.000000000 +0100
 ++++ arg.c	2013-09-12 19:38:48.000000000 +0200
  @@ -40,7 +40,7 @@
             *(double *)desc[i].location = atof(arg);
             break;
 ===> Done
 
 --mP3DRpeJDSE+ciuQ--

From: Pietro Cerutti <gahr@FreeBSD.org>
To: nemysis <nemysis@FreeBSD.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/179244: [PATCH] devel/dparser: Fix docs, cleanup Makefile
Date: Thu, 12 Sep 2013 20:49:35 +0200

 --/WwmFnJnmDyWGHa4
 Content-Type: text/plain; charset=utf-8
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 I'm going to comment the patch chunk by chunk.
 
 1)
 +OPTIONS_SUB=3D yes
 
 This is useless. BOEHM isn't used in plist.
 
 2)
 +BOEHM_LIB_DEPENDS=3D       libgc.so:${PORTSDIR}/devel/boehm-gc
 and consequent
 -LIB_DEPENDS+=3D gc:${PORTSDIR}/devel/boehm-gca
 
 Nice, accepted.
 
 3)
 +post-patch:
 + @${REINPLACE_CMD} -e 's|%%PREFIX%%|${PREFIX}|' ${WRKSRC}/Makefile
 and consequent change to files/patch-Makefile
 
 This is useless. MAKE_ENV already sets PREFIX, and we don't use the
 software's own install target anyway. On the other hand, I wouldn't mind
 removing -DPREFIX=3D${PREFIX} from MAKE_ARGS.
 
 4)
 The changes to the do-install target are cosmetics. I don't have a
 strong opinion here.
 
 5)
 I think the change to files/patch-arg.c was included by error, wasn't
 it?
 
 At the end, it boils down to committing 2) and 4). If you really feel
 the urge to put them in, feel free to commit those. Please do *not*
 commit 1), 3), or 5).
 
 Thank you!
 
 --=20
 Pietro Cerutti
 The FreeBSD Project
 gahr@FreeBSD.org
 
 PGP Public Key:
 http://gahr.ch/pgp
 
 --/WwmFnJnmDyWGHa4
 Content-Type: application/pgp-signature
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.21 (FreeBSD)
 
 iEYEARECAAYFAlIyDL8ACgkQwMJqmJVx947aigCgms8BmMH1S+bPOaq5fbRaFsUr
 GUsAoN7Qq4aa1CBB/lOfm9vwhL6+rF3J
 =Mecg
 -----END PGP SIGNATURE-----
 
 --/WwmFnJnmDyWGHa4--
State-Changed-From-To: feedback->closed 
State-Changed-By: gahr 
State-Changed-When: Mon Mar 31 11:46:45 UTC 2014 
State-Changed-Why:  
No reply from the OP. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=179244 
>Unformatted:
