From nemysis@gmx.ch  Thu May 30 21:32:26 2013
Return-Path: <nemysis@gmx.ch>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id EA690D64
	for <freebsd-gnats-submit@freebsd.org>; Thu, 30 May 2013 21:32:26 +0000 (UTC)
	(envelope-from nemysis@gmx.ch)
Received: from mout.gmx.net (mout.gmx.net [212.227.17.22])
	by mx1.freebsd.org (Postfix) with ESMTP id 7CB5FABB
	for <freebsd-gnats-submit@freebsd.org>; Thu, 30 May 2013 21:32:26 +0000 (UTC)
Received: from mailout-de.gmx.net ([10.1.76.35]) by mrigmx.server.lan
 (mrigmx001) with ESMTP (Nemesis) id 0Lgszg-1U2pgi2w3a-00oEsC for
 <FreeBSD-gnats-submit@freebsd.org>; Thu, 30 May 2013 23:32:18 +0200
Received: (qmail invoked by alias); 30 May 2013 21:32:17 -0000
Received: from 5-80.77-83.cust.bluewin.ch (EHLO something.email.com) [83.77.80.5]
  by mail.gmx.net (mp035) with SMTP; 30 May 2013 23:32:17 +0200
Received: by something.email.com (sSMTP sendmail emulation); Thu, 30 May 2013 23:32:17 +0200
Message-Id: <20130530213226.EA690D64@hub.freebsd.org>
Date: Thu, 30 May 2013 23:32:17 +0200
From: nemysis <nemysis@gmx.ch>
To: FreeBSD-gnats-submit@freebsd.org
Cc: jpaetzel@freebsd.org
Subject: [PATCH] multimedia/vcdgear: Convert to OptionsNG, trim comment and docs
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         179130
>Category:       ports
>Synopsis:       [PATCH] multimedia/vcdgear: Convert to OptionsNG, trim comment and docs
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    nemysis
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 30 21:40:00 UTC 2013
>Closed-Date:    Fri Feb 07 22:41:15 UTC 2014
>Last-Modified:  Fri Feb  7 22:50:00 UTC 2014
>Originator:     nemysis
>Release:        FreeBSD 9.1-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD FreeBSD_Ports 9.1-RELEASE FreeBSD 9.1-RELEASE #0: Tue Jan 29 15:02:50 EST 2013
>Description:

- Shorten header
- Trim comment
- Convert to OptionsNG
- Trim docs
- Remove pkg-plist

Removed file(s):
- pkg-plist

Generated and tested manually, tested with port test and with RedPorts, sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
>How-To-Repeat:

Build log

https://redports.org/buildarchive/20130530202301-46110/

>Fix:

--- vcdgear-1.6d.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/multimedia/vcdgear/Makefile ./Makefile
--- /usr/ports/multimedia/vcdgear/Makefile	2013-01-14 17:54:56.000000000 +0100
+++ ./Makefile	2013-05-30 23:29:41.000000000 +0200
@@ -1,9 +1,5 @@
-# New ports collection makefile for:	vcdgear
-# Date created:	 	06 January 1999
-# Whom:			Chris Piazza <cpiazza@FreeBSD.org>
-#
+# Created by: Chris Piazza <cpiazza@FreeBSD.org>
 # $FreeBSD: head/multimedia/vcdgear/Makefile 300896 2012-07-14 13:54:48Z beat $
-#
 
 PORTNAME=	vcdgear
 PORTVERSION=	1.6d
@@ -11,11 +7,16 @@
 MASTER_SITES=	http://www.vcdgear.com/files/
 
 MAINTAINER=	ports@FreeBSD.org
-COMMENT=	A tool to convert VCDs from cue/bin format to mpeg
+COMMENT=	Tool to convert VCDs from cue/bin format to mpeg
 
 ONLY_FOR_ARCHS=	alpha i386 amd64
 
+PLIST_FILES=	bin/${PORTNAME}
+
+PORTDOCS=	faq.txt manual.txt whatsnew.txt
+
 .include <bsd.port.pre.mk>
+.include <bsd.port.options.mk>
 
 .if ${ARCH} == i386 || ${ARCH} == amd64
 DISTNAME=	${PORTNAME}16d_i386_freebsd42
@@ -27,12 +28,10 @@
 WRKSRC=		${WRKDIR}/vcdgear16
 
 do-install:
-	${INSTALL_PROGRAM} ${WRKSRC}/vcdgear16_static ${PREFIX}/bin/vcdgear
-.if !defined(NOPORTDOCS)
+	${INSTALL_PROGRAM} ${WRKSRC}/vcdgear16_static ${PREFIX}/bin/${PORTNAME}
+.if ${PORT_OPTIONS:MDOCS}
 	@${MKDIR} ${DOCSDIR}
-.for file in faq.txt manual.txt whatsnew.txt
-	${INSTALL_DATA} ${WRKSRC}/${file} ${DOCSDIR}
-.endfor
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
 .endif
 
 .include <bsd.port.post.mk>
diff -ruN --exclude=CVS /usr/ports/multimedia/vcdgear/distinfo ./distinfo
--- /usr/ports/multimedia/vcdgear/distinfo	2013-01-14 17:54:56.000000000 +0100
+++ ./distinfo	2013-03-29 16:29:12.000000000 +0100
@@ -1,4 +1,2 @@
-SHA256 (vcdgear16d_alpha_freebsd41.tar.gz) = cedce8180bd7e4959aaa3b26d4e83d0804c156c94168a1ef7f0f7259f91159e8
-SIZE (vcdgear16d_alpha_freebsd41.tar.gz) = 121796
 SHA256 (vcdgear16d_i386_freebsd42.tar.gz) = c90cc63ff402ab6bcfc545d9b534bd3ce86954d8a5b2069554174073b73bf432
 SIZE (vcdgear16d_i386_freebsd42.tar.gz) = 98035
diff -ruN --exclude=CVS /usr/ports/multimedia/vcdgear/pkg-plist ./pkg-plist
--- /usr/ports/multimedia/vcdgear/pkg-plist	2013-01-14 17:54:56.000000000 +0100
+++ ./pkg-plist	1970-01-01 01:00:00.000000000 +0100
@@ -1,5 +0,0 @@
-bin/vcdgear
-%%PORTDOCS%%share/doc/vcdgear/faq.txt
-%%PORTDOCS%%share/doc/vcdgear/manual.txt
-%%PORTDOCS%%share/doc/vcdgear/whatsnew.txt
-%%PORTDOCS%%@dirrm share/doc/vcdgear
--- vcdgear-1.6d.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->beech 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu May 30 21:40:14 UTC 2013 
Responsible-Changed-Why:  
beech@ wants this submitter's PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=179130 
Responsible-Changed-From-To: beech->nemysis 
Responsible-Changed-By: tabthorpe 
Responsible-Changed-When: Fri Jan 10 03:34:45 UTC 2014 
Responsible-Changed-Why:  
Submitter is committer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=179130 
State-Changed-From-To: open->closed 
State-Changed-By: nemysis 
State-Changed-When: Fri Feb 7 22:41:15 UTC 2014 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=179130 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/179130: commit references a PR
Date: Fri,  7 Feb 2014 22:47:35 +0000 (UTC)

 Author: nemysis
 Date: Fri Feb  7 22:47:27 2014
 New Revision: 343303
 URL: http://svnweb.freebsd.org/changeset/ports/343303
 QAT: https://qat.redports.org/buildarchive/r343303/
 
 Log:
   - Remove leading article from COMMENT
   - Use PLIST_FILES instead of pkg-plist
   - Change DOCS, add DOCS Option
   - Support STAGEDIR
   
   PR:		ports/179130
   Submitted by:	nemysis (self)
 
 Deleted:
   head/multimedia/vcdgear/pkg-plist
 Modified:
   head/multimedia/vcdgear/Makefile
   head/multimedia/vcdgear/distinfo
 
 Modified: head/multimedia/vcdgear/Makefile
 ==============================================================================
 --- head/multimedia/vcdgear/Makefile	Fri Feb  7 22:30:46 2014	(r343302)
 +++ head/multimedia/vcdgear/Makefile	Fri Feb  7 22:47:27 2014	(r343303)
 @@ -7,11 +7,19 @@ CATEGORIES=	multimedia
  MASTER_SITES=	http://www.vcdgear.com/files/
  
  MAINTAINER=	ports@FreeBSD.org
 -COMMENT=	A tool to convert VCDs from cue/bin format to mpeg
 +COMMENT=	Tool to convert VCDs from cue/bin format to mpeg 
 +
 +WRKSRC=		${WRKDIR}/vcdgear16
 +NO_BUILD=	true
 +
 +PLIST_FILES=	bin/${PORTNAME}
 +
 +PORTDOCS=	faq.txt manual.txt whatsnew.txt
 +
 +OPTIONS_DEFINE=	DOCS
  
  ONLY_FOR_ARCHS=	alpha i386 amd64
  
 -NO_STAGE=	yes
  .include <bsd.port.pre.mk>
  
  .if ${ARCH} == i386 || ${ARCH} == amd64
 @@ -20,16 +28,11 @@ DISTNAME=	${PORTNAME}16d_i386_freebsd42
  DISTNAME=	${PORTNAME}16d_alpha_freebsd41
  .endif
  
 -NO_BUILD=	true
 -WRKSRC=		${WRKDIR}/vcdgear16
 -
  do-install:
 -	${INSTALL_PROGRAM} ${WRKSRC}/vcdgear16_static ${PREFIX}/bin/vcdgear
 -.if !defined(NOPORTDOCS)
 -	@${MKDIR} ${DOCSDIR}
 -.for file in faq.txt manual.txt whatsnew.txt
 -	${INSTALL_DATA} ${WRKSRC}/${file} ${DOCSDIR}
 -.endfor
 -.endif
 +	${INSTALL_PROGRAM} ${WRKSRC}/vcdgear16_static \
 +		${STAGEDIR}${PREFIX}/bin/${PORTNAME}
 +
 +	@${MKDIR} ${STAGEDIR}${DOCSDIR}
 +	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${STAGEDIR}${DOCSDIR}
  
  .include <bsd.port.post.mk>
 
 Modified: head/multimedia/vcdgear/distinfo
 ==============================================================================
 --- head/multimedia/vcdgear/distinfo	Fri Feb  7 22:30:46 2014	(r343302)
 +++ head/multimedia/vcdgear/distinfo	Fri Feb  7 22:47:27 2014	(r343303)
 @@ -1,4 +1,2 @@
 -SHA256 (vcdgear16d_alpha_freebsd41.tar.gz) = cedce8180bd7e4959aaa3b26d4e83d0804c156c94168a1ef7f0f7259f91159e8
 -SIZE (vcdgear16d_alpha_freebsd41.tar.gz) = 121796
  SHA256 (vcdgear16d_i386_freebsd42.tar.gz) = c90cc63ff402ab6bcfc545d9b534bd3ce86954d8a5b2069554174073b73bf432
  SIZE (vcdgear16d_i386_freebsd42.tar.gz) = 98035
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
