From nobody@FreeBSD.org  Mon May 20 06:35:42 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id D70BD1B9
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 20 May 2013 06:35:42 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.FreeBSD.org (oldred.freebsd.org [8.8.178.121])
	by mx1.freebsd.org (Postfix) with ESMTP id CB07FF25
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 20 May 2013 06:35:42 +0000 (UTC)
Received: from oldred.FreeBSD.org ([127.0.1.6])
	by oldred.FreeBSD.org (8.14.5/8.14.5) with ESMTP id r4K6ZgUg022608
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 20 May 2013 06:35:42 GMT
	(envelope-from nobody@oldred.FreeBSD.org)
Received: (from nobody@localhost)
	by oldred.FreeBSD.org (8.14.5/8.14.5/Submit) id r4K6ZgLK022601;
	Mon, 20 May 2013 06:35:42 GMT
	(envelope-from nobody)
Message-Id: <201305200635.r4K6ZgLK022601@oldred.FreeBSD.org>
Date: Mon, 20 May 2013 06:35:42 GMT
From: Andreas Tobler <andreast@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] enable PowerPC support in devel/gdb
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: luca.pizzamiglio@gmail.com

>Number:         178784
>Category:       ports
>Synopsis:       [patch] enable PowerPC support in devel/gdb
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 20 06:40:00 UTC 2013
>Closed-Date:    Sun Sep 01 22:32:40 UTC 2013
>Last-Modified:  Sun Sep  1 22:40:02 UTC 2013
>Originator:     Andreas Tobler
>Release:        -CURRENT
>Organization:
none
>Environment:
>Description:
The latest gdb, 7.6, brings native PowerPC FreeBSD support. We just need enable it in ports.
There is a minor glitch which needs patching gdb itself. Namely, ALL_TARGET_OBJ is missing ppcfbsd-tdep.o. This part is already sent upstream.

The attached patch enables PowerPC support in gdb.
The patch is made with svn diff in the devel/gdb directory.
>How-To-Repeat:
-
>Fix:
Apply the attached patch :)

Patch attached with submission follows:

Index: Makefile
===================================================================
--- Makefile	(revision 318568)
+++ Makefile	(working copy)
@@ -30,7 +30,7 @@
 PLIST_SUB=	VER=${VER}
 MAN1=	gdb${VER}.1
 
-ONLY_FOR_ARCHS=	i386 amd64	# untested elsewhere, might work
+ONLY_FOR_ARCHS=	i386 amd64 powerpc powerpc64	# untested elsewhere, might work
 
 OPTIONS_DEFINE=	DEBUG EXPAT PYTHON THREADS TUI GDB_LINK
 OPTIONS_SINGLE_READLINE=	BASE_READLINE BUNDLED_READLINE PORT_READLINE
Index: files/extrapatch-gdb-Makefile.in
===================================================================
--- files/extrapatch-gdb-Makefile.in	(revision 318568)
+++ files/extrapatch-gdb-Makefile.in	(working copy)
@@ -1,14 +1,25 @@
---- gdb/Makefile.in.orig	2012-07-02 17:29:33.000000000 +0200
-+++ gdb/Makefile.in	2012-08-26 21:01:45.589052997 +0200
-@@ -573,6 +573,7 @@
+--- gdb/Makefile.in.orig	2013-04-02 19:38:43.000000000 +0200
++++ gdb/Makefile.in	2013-05-18 13:08:47.000000000 +0200
+@@ -566,8 +566,8 @@
+ 	moxie-tdep.o \
+ 	mt-tdep.o \
+ 	nto-tdep.o \
+-	ppc-linux-tdep.o ppcnbsd-tdep.o ppcobsd-tdep.o ppc-sysv-tdep.o \
+-	ppc64-tdep.o rl78-tdep.o \
++	ppc-linux-tdep.o ppcfbsd-tdep.o ppcnbsd-tdep.o ppcobsd-tdep.o \
++	ppc-sysv-tdep.o ppc64-tdep.o rl78-tdep.o \
+ 	rs6000-aix-tdep.o rs6000-tdep.o ppc-ravenscar-thread.o \
+ 	rs6000-lynx178-tdep.o \
+ 	rx-tdep.o \
+@@ -585,6 +585,7 @@
  	xtensa-config.o xtensa-tdep.o xtensa-linux-tdep.o \
  	glibc-tdep.o \
-	bsd-uthread.o \
+ 	bsd-uthread.o \
 +	fbsd-threads.o \
  	nbsd-tdep.o obsd-tdep.o \
  	sol2-tdep.o \
  	solib-frv.o solib-irix.o solib-svr4.o \
-@@ -1164,7 +1164,7 @@
+@@ -1173,7 +1174,7 @@
  # Removing the old gdb first works better if it is running, at least on SunOS.
  gdb$(EXEEXT): gdb.o $(LIBGDB_OBS) $(ADD_DEPS) $(CDEPS) $(TDEPLIBS)
  	rm -f gdb$(EXEEXT)
@@ -17,7 +28,7 @@
  		-o gdb$(EXEEXT) gdb.o $(LIBGDB_OBS) \
  		$(TDEPLIBS) $(TUI_LIBRARY) $(CLIBS) $(LOADLIBES)
  
-@@ -1429,7 +1429,7 @@
+@@ -1442,7 +1443,7 @@
  	armnbsd-nat.c armbsd-tdep.c armnbsd-tdep.c armobsd-tdep.c \
  	avr-tdep.c \
  	bfin-linux-tdep.c bfin-tdep.c \
Index: files/extrapatch-gdb-configure.tgt
===================================================================
--- files/extrapatch-gdb-configure.tgt	(revision 318568)
+++ files/extrapatch-gdb-configure.tgt	(working copy)
@@ -1,6 +1,6 @@
---- gdb/configure.tgt.orig	2012-08-01 21:48:44.000000000 +0200
-+++ gdb/configure.tgt	2012-08-22 16:47:02.000000000 +0200
-@@ -176,7 +176,7 @@
+--- gdb/configure.tgt.orig	2013-03-05 14:37:10.000000000 +0100
++++ gdb/configure.tgt	2013-05-18 13:11:06.000000000 +0200
+@@ -188,7 +188,7 @@
  i[34567]86-*-freebsd* | i[34567]86-*-kfreebsd*-gnu)
  	# Target: FreeBSD/i386
  	gdb_target_obs="i386-tdep.o i387-tdep.o i386bsd-tdep.o i386fbsd-tdep.o \
@@ -9,12 +9,21 @@
  	;;
  i[34567]86-*-netbsd* | i[34567]86-*-knetbsd*-gnu)
  	# Target: NetBSD/i386
-@@ -606,7 +606,7 @@
+@@ -398,7 +398,7 @@
+ powerpc*-*-freebsd*)
+ 	# Target: FreeBSD/powerpc
+ 	gdb_target_obs="rs6000-tdep.o ppc-sysv-tdep.o ppc64-tdep.o \
+-		        ppcfbsd-tdep.o solib-svr4.o \
++		        ppcfbsd-tdep.o solib-svr4.o fbsd-threads.o \
+ 			ravenscar-thread.o ppc-ravenscar-thread.o"
+ 	;;
+ 
+@@ -650,7 +650,7 @@
  	# Target: FreeBSD/amd64
  	gdb_target_obs="amd64-tdep.o amd64fbsd-tdep.o i386-tdep.o \
  			i387-tdep.o i386bsd-tdep.o i386fbsd-tdep.o \
 -			bsd-uthread.o solib-svr4.o"
 +			fbsd-threads.o solib-svr4.o"
  	;;
- x86_64-*-mingw*)
+ x86_64-*-mingw* | x86_64-*-cygwin*)
          # Target: MingW/amd64


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Mon May 20 06:40:16 UTC 2013 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=178784 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: luca.pizzamiglio@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/178784: [patch] enable PowerPC support in devel/gdb
Date: Mon, 20 May 2013 06:40:15 UT

 Maintainer of devel/gdb,
 
 Please note that PR ports/178784 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/178784
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Luca Pizzamiglio <luca.pizzamiglio@gmail.com>
To: bug-followup@FreeBSD.org
Cc: Edwin Groothuis <edwin@FreeBSD.org>
Subject: Re: ports/178784: [patch] enable PowerPC support in devel/gdb
Date: Wed, 22 May 2013 14:02:36 +0200

 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA256
 
 I tested the patch and I found no problems, then patch approved!
 Thanks for the help!
 
 Luca
 
 On 05/20/13 08:40, Edwin Groothuis wrote:
 > Maintainer of devel/gdb,
 >
 > Please note that PR ports/178784 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/178784
 >
 -----BEGIN PGP SIGNATURE-----
 Version: APG v1.0.8
 
 iQJLBAEBCAA1BQJRnLPcLhxMdWNhIFBpenphbWlnbGlvIDxsdWNhLnBpenphbWln
 bGlvQGdtYWlsLmNvbT4ACgkQ1r9Hhyzd6UVWOxAAi1pMdjnP6EiqgQyWFLhyirnz
 VUcyuzDtojI6t8YGwOtVFJK2t1uhchH1o3upFsb//W1kBukJPMFTfm3oCrdyKu31
 oPFrwsi1b27JvTPSmnrYMkFEaP+X8AEKRQZojgXrYIGiqN12+t0Xilaox18lM6+M
 +EemO4bkWsHNvS7MVRBR20Ch3JXlzJqfyhlZi8Q6qJNc3rOxqn/BSp6CxtJj2ZGp
 t+oebLqG6QsniphFgVDoZ+s956zMthw3AzL19EeFEx46ixm7YfitmCus6vn02faG
 DGjxTojHo5Q98w90/YUT8p4htKdC9rvxaGX7dY834zWerWz9CKf1IikLiuRFbFO2
 14nkhhWCHeIfHPb0zjDYxYGaK9pPEMzGBO+521loSduABElZmHo/vGBCltGPIxnJ
 DKspevcX7tSloIiKW4QYLhI23CXAd5NT4yNDo/AgS2cf234gJzuMLD6eVG80BC7x
 ZQTelfVrXzdZLCw4JLb0UxvZUXkzqSdyTQR2D1Le14oxzMn0sFf8CCge9tel2WLl
 F8tOOEm/VzL2VjxOE6RUX1MeH7dZI91GR12NilQrlo4Q9gz9OQvNBnzpRb3qZtWD
 I5RkgA0Ne1vk3YJ63kufMxLolhbH3VBF5RCn2kCoVroAHgKyR8BiHUaZNqkM96if
 ylSBjOZhpEG99dJY5NY=
 =TRxd
 -----END PGP SIGNATURE-----
 
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Wed May 22 21:20:51 UTC 2013 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=178784 
State-Changed-From-To: open->closed 
State-Changed-By: rakuco 
State-Changed-When: Sun Sep 1 22:32:40 UTC 2013 
State-Changed-Why:  
Committed, thank you. I trimmed the original diff a bit so as not to 
touch unrelated parts. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=178784 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/178784: commit references a PR
Date: Sun,  1 Sep 2013 22:31:57 +0000 (UTC)

 Author: rakuco
 Date: Sun Sep  1 22:31:44 2013
 New Revision: 325922
 URL: http://svnweb.freebsd.org/changeset/ports/325922
 
 Log:
   Enable PowerPC support.
   
   The latest gdb, 7.6, brings native PowerPC FreeBSD support. We just need
   enable it in ports.
   
   There is a minor glitch which needs patching gdb itself. Namely,
   ALL_TARGET_OBJ is missing ppcfbsd-tdep.o. This part is already sent
   upstream.
   
   PR:		ports/178784
   Submitted by:	andreast
   Approved by:	Luca Pizzamiglio <luca.pizzamiglio@gmail.com>
 
 Modified:
   head/devel/gdb/Makefile
   head/devel/gdb/files/extrapatch-gdb-Makefile.in
   head/devel/gdb/files/extrapatch-gdb-configure.tgt
 
 Modified: head/devel/gdb/Makefile
 ==============================================================================
 --- head/devel/gdb/Makefile	Sun Sep  1 22:07:00 2013	(r325921)
 +++ head/devel/gdb/Makefile	Sun Sep  1 22:31:44 2013	(r325922)
 @@ -31,7 +31,7 @@ VER=	${PORTVERSION:S/.//g}
  PLIST_SUB=	VER=${VER}
  MAN1=	gdb${VER}.1
  
 -ONLY_FOR_ARCHS=	i386 amd64	# untested elsewhere, might work
 +ONLY_FOR_ARCHS=	i386 amd64 powerpc powerpc64	# untested elsewhere, might work
  
  OPTIONS_DEFINE=	DEBUG EXPAT PYTHON THREADS TUI GDB_LINK
  OPTIONS_SINGLE_READLINE=	BASE_READLINE BUNDLED_READLINE PORT_READLINE
 
 Modified: head/devel/gdb/files/extrapatch-gdb-Makefile.in
 ==============================================================================
 --- head/devel/gdb/files/extrapatch-gdb-Makefile.in	Sun Sep  1 22:07:00 2013	(r325921)
 +++ head/devel/gdb/files/extrapatch-gdb-Makefile.in	Sun Sep  1 22:31:44 2013	(r325922)
 @@ -1,9 +1,20 @@
 ---- gdb/Makefile.in.orig	2012-07-02 17:29:33.000000000 +0200
 -+++ gdb/Makefile.in	2012-08-26 21:01:45.589052997 +0200
 -@@ -573,6 +573,7 @@
 +--- gdb/Makefile.in.orig	2013-04-02 19:38:43.000000000 +0200
 ++++ gdb/Makefile.in	2013-05-18 13:08:47.000000000 +0200
 +@@ -566,8 +566,8 @@
 + 	moxie-tdep.o \
 + 	mt-tdep.o \
 + 	nto-tdep.o \
 +-	ppc-linux-tdep.o ppcnbsd-tdep.o ppcobsd-tdep.o ppc-sysv-tdep.o \
 +-	ppc64-tdep.o rl78-tdep.o \
 ++	ppc-linux-tdep.o ppcfbsd-tdep.o ppcnbsd-tdep.o ppcobsd-tdep.o \
 ++	ppc-sysv-tdep.o ppc64-tdep.o rl78-tdep.o \
 + 	rs6000-aix-tdep.o rs6000-tdep.o ppc-ravenscar-thread.o \
 + 	rs6000-lynx178-tdep.o \
 + 	rx-tdep.o \
 +@@ -585,6 +585,7 @@
   	xtensa-config.o xtensa-tdep.o xtensa-linux-tdep.o \
   	glibc-tdep.o \
 -	bsd-uthread.o \
 + 	bsd-uthread.o \
  +	fbsd-threads.o \
   	nbsd-tdep.o obsd-tdep.o \
   	sol2-tdep.o \
 
 Modified: head/devel/gdb/files/extrapatch-gdb-configure.tgt
 ==============================================================================
 --- head/devel/gdb/files/extrapatch-gdb-configure.tgt	Sun Sep  1 22:07:00 2013	(r325921)
 +++ head/devel/gdb/files/extrapatch-gdb-configure.tgt	Sun Sep  1 22:31:44 2013	(r325922)
 @@ -1,6 +1,6 @@
 ---- gdb/configure.tgt.orig	2012-08-01 21:48:44.000000000 +0200
 -+++ gdb/configure.tgt	2012-08-22 16:47:02.000000000 +0200
 -@@ -176,7 +176,7 @@
 +--- gdb/configure.tgt.orig	2013-03-05 14:37:10.000000000 +0100
 ++++ gdb/configure.tgt	2013-05-18 13:11:06.000000000 +0200
 +@@ -188,7 +188,7 @@
   i[34567]86-*-freebsd* | i[34567]86-*-kfreebsd*-gnu)
   	# Target: FreeBSD/i386
   	gdb_target_obs="i386-tdep.o i387-tdep.o i386bsd-tdep.o i386fbsd-tdep.o \
 @@ -9,7 +9,16 @@
   	;;
   i[34567]86-*-netbsd* | i[34567]86-*-knetbsd*-gnu)
   	# Target: NetBSD/i386
 -@@ -606,7 +606,7 @@
 +@@ -398,7 +398,7 @@
 + powerpc*-*-freebsd*)
 + 	# Target: FreeBSD/powerpc
 + 	gdb_target_obs="rs6000-tdep.o ppc-sysv-tdep.o ppc64-tdep.o \
 +-		        ppcfbsd-tdep.o solib-svr4.o \
 ++		        ppcfbsd-tdep.o solib-svr4.o fbsd-threads.o \
 + 			ravenscar-thread.o ppc-ravenscar-thread.o"
 + 	;;
 + 
 +@@ -650,7 +650,7 @@
   	# Target: FreeBSD/amd64
   	gdb_target_obs="amd64-tdep.o amd64fbsd-tdep.o i386-tdep.o \
   			i387-tdep.o i386bsd-tdep.o i386fbsd-tdep.o \
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
