From nobody@FreeBSD.org  Thu May 16 22:50:41 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
	by hub.freebsd.org (Postfix) with ESMTP id 79A7EC62
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 16 May 2013 22:50:41 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.FreeBSD.org (oldred.freebsd.org [8.8.178.121])
	by mx1.freebsd.org (Postfix) with ESMTP id 6C9FA257
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 16 May 2013 22:50:41 +0000 (UTC)
Received: from oldred.FreeBSD.org ([127.0.1.6])
	by oldred.FreeBSD.org (8.14.5/8.14.5) with ESMTP id r4GMofiG093795
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 16 May 2013 22:50:41 GMT
	(envelope-from nobody@oldred.FreeBSD.org)
Received: (from nobody@localhost)
	by oldred.FreeBSD.org (8.14.5/8.14.5/Submit) id r4GMofoI093787;
	Thu, 16 May 2013 22:50:41 GMT
	(envelope-from nobody)
Message-Id: <201305162250.r4GMofoI093787@oldred.FreeBSD.org>
Date: Thu, 16 May 2013 22:50:41 GMT
From: Benjamin Lee <ben@b1c1l1.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [regression] net-mgmt/collectd5 no longer builds with WITHOUT_X11
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: ports@bsdserwis.com

>Number:         178697
>Category:       ports
>Synopsis:       [regression] net-mgmt/collectd5 no longer builds with WITHOUT_X11
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bsam
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 16 23:00:00 UTC 2013
>Closed-Date:    Mon May 20 06:15:50 UTC 2013
>Last-Modified:  Mon May 20 06:20:01 UTC 2013
>Originator:     Benjamin Lee
>Release:        9.1-RELEASE
>Organization:
>Environment:
FreeBSD eclipse.b1c1l1.com 9.1-RELEASE FreeBSD 9.1-RELEASE #0 r243826: Tue Dec  4 06:55:39 UTC 2012     root@obrian.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
The addition of libnotify to LIB_DEPENDS in net-mgmt/collectd5 means net-mgmt/collectd5 no longer builds on systems that have WITHOUT_X11 defined in /etc/make.conf.

The LIB_DEPENDS change causes a new dependency to be added, graphics/gtk-update-icon-cache, which refuses to build if cairo does not have X11 support.

This is a regression since collectd has always worked fine without libnotify and X11.  It should not be a mandatory dependency.
>How-To-Repeat:
Define WITHOUT_X11=yes in /etc/make.conf
Try to build net-mgmt/collectd5 on a clean system
>Fix:
Revert last commit to net-mgmt/collectd5 (remove libnotify from LIB_DEPENDS)

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu May 16 23:00:08 UTC 2013 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=178697 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: ports@bsdserwis.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/178697: [regression] net-mgmt/collectd5 no longer builds with WITHOUT_X11
Date: Thu, 16 May 2013 23:00:07 UT

 Maintainer of net-mgmt/collectd5,
 
 Please note that PR ports/178697 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/178697
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Krzysztof Stryjek <ports@bsdserwis.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/178697: [regression] net-mgmt/collectd5 no longer builds
 with WITHOUT_X11
Date: Fri, 17 May 2013 09:14:53 +0200

 --4ZLFUWh1odzi/v6L
 Content-Type: text/plain; charset=iso-8859-2
 Content-Disposition: inline
 
 Hello,
 
 On Thu, May 16, 2013 at 11:00:07PM +0000, Edwin Groothuis wrote:
 > Maintainer of net-mgmt/collectd5,
 > 
 > Please note that PR ports/178697 has just been submitted.
 > 
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 > 
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/178697
 > 
 > -- 
 > Edwin Groothuis via the GNATS Auto Assign Tool
 > edwin@FreeBSD.org
 > 
 Yes, my fault - I don't check very careful last PR. I've made a patch
 for Makefile that will be much better for collectd5 and email
 notification.
 
 Greetings,
 -- 
 Krzysztof Stryjek
 UNIX administrator/Juniper Networks Specialist
 email: wtp (at) bsdserwis (dot) com
 http://www.linkedin.com/in/KrzysztofStryjek
 GPG fingerprint: 8BD7 40CE 8994 0BBE CE6C  91CD 1292 8959 DC61 0E76
 
 In theory, there is no difference between theory and practice.
 In practice, there is.
 
 --4ZLFUWh1odzi/v6L
 Content-Type: text/x-diff; charset=iso-8859-2
 Content-Disposition: attachment; filename="collectd5.patch"
 
 --- Makefile.orig	2013-05-15 13:38:21.000000000 +0200
 +++ Makefile	2013-05-17 09:12:42.000000000 +0200
 @@ -3,15 +3,13 @@
  
  PORTNAME=	collectd
  PORTVERSION=	5.2.1
 -PORTREVISION=	2
 +PORTREVISION=	3
  CATEGORIES=	net-mgmt
  MASTER_SITES=	http://collectd.org/files/
  
  MAINTAINER=	ports@bsdserwis.com
  COMMENT=	Systems & network statistics collection daemon
  
 -LIB_DEPENDS=	notify:${PORTSDIR}/devel/libnotify
 -
  USE_BZIP2=	yes
  USE_GMAKE=	yes
  GNU_CONFIGURE=	yes
 @@ -50,7 +48,7 @@
  MEMCACHED_DESC=		Memcached
  MODBUS_DESC=		Modbus support via libmodbus
  MYSQL_DESC=		MySQL
 -NOTIFYEMAIL_DESC=	Email notifications (libesmtp)
 +NOTIFYEMAIL_DESC=	Email notifications (libesmtp, libnotify)
  NGINX_DESC=		Nginx
  OPENVPN_DESC=		OpenVPN statistics
  PDNS_DESC=		PowerDNS
 @@ -120,7 +118,6 @@
  		--disable-netlink \
  		--disable-nfs \
  		--disable-notify_desktop \
 -		--disable-notify_email \
  		--disable-olsrd \
  		--disable-onewire \
  		--disable-oracle \
 @@ -320,6 +317,7 @@
  
  .if ${PORT_OPTIONS:MNOTIFYEMAIL}
  LIB_DEPENDS+=	esmtp:${PORTSDIR}/mail/libesmtp
 +LIB_DEPENDS+=	notify:${PORTSDIR}/devel/libnotify
  CONFIGURE_ARGS+=--enable-notify_email
  CONFIGURE_ARGS+=--with-libesmtp=${PREFIX}
  PLIST_SUB+=	NOTIFYEMAIL=""
 
 --4ZLFUWh1odzi/v6L--
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Fri May 17 08:07:33 UTC 2013 
State-Changed-Why:  
maintainer has replied with patch to fix the problem. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=178697 

From: Raphael Kubo da Costa <rakuco@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc: bsam@FreeBSD.org, Benjamin Lee <ben@b1c1l1.com>, Krzysztof Stryjek <ports@bsdserwis.com>
Subject: Re: ports/178697: [regression] net-mgmt/collectd5 no longer builds with WITHOUT_X11
Date: Sun, 19 May 2013 01:12:32 +0300

 CC'ing bsam since he added the dependency in r318238.
 
 Additionally, doesn't the patch in this PR also apply to net-mgmt/collectd?

From: Boris Samorodov <bsam@passap.ru>
To: Raphael Kubo da Costa <rakuco@FreeBSD.org>
Cc: bug-followup@FreeBSD.org, Benjamin Lee <ben@b1c1l1.com>, 
 Krzysztof Stryjek <ports@bsdserwis.com>
Subject: Re: ports/178697: [regression] net-mgmt/collectd5 no longer builds
 with WITHOUT_X11
Date: Sun, 19 May 2013 10:32:17 +0400

 19.05.2013 02:12, Raphael Kubo da Costa пишет:
 
 > CC'ing bsam since he added the dependency in r318238.
 
 The dependency was added because the there is a message
 at the log that libnotify is needed. If it may be used
 as an option -- well, that's good.
 
 Nevertheless, it smells like a bug if libnotify unconditionally
 depends upon X11.
 
 -- 
 WBR, Boris Samorodov (bsam)
 FreeBSD Committer, http://www.FreeBSD.org The Power To Serve
Responsible-Changed-From-To: freebsd-ports-bugs->bsam 
Responsible-Changed-By: bsam 
Responsible-Changed-When: Mon May 20 05:50:24 UTC 2013 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=178697 
State-Changed-From-To: open->closed 
State-Changed-By: bsam 
State-Changed-When: Mon May 20 06:15:49 UTC 2013 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=178697 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/178697: commit references a PR
Date: Mon, 20 May 2013 06:14:16 +0000 (UTC)

 Author: bsam
 Date: Mon May 20 06:14:09 2013
 New Revision: 318574
 URL: http://svnweb.freebsd.org/changeset/ports/318574
 
 Log:
   Optionify libnotify dependency.
   
   PR:		ports/178697
   Submitted by:	Benjamin Lee <ben@b1c1l1.com>
   Patch by:	Krzysztof Stryjek <ports@bsdserwis.com> (maintainer)
 
 Modified:
   head/net-mgmt/collectd5/Makefile
 
 Modified: head/net-mgmt/collectd5/Makefile
 ==============================================================================
 --- head/net-mgmt/collectd5/Makefile	Mon May 20 06:11:46 2013	(r318573)
 +++ head/net-mgmt/collectd5/Makefile	Mon May 20 06:14:09 2013	(r318574)
 @@ -3,15 +3,13 @@
  
  PORTNAME=	collectd
  PORTVERSION=	5.2.1
 -PORTREVISION=	2
 +PORTREVISION=	3
  CATEGORIES=	net-mgmt
  MASTER_SITES=	http://collectd.org/files/
  
  MAINTAINER=	ports@bsdserwis.com
  COMMENT=	Systems & network statistics collection daemon
  
 -LIB_DEPENDS=	notify:${PORTSDIR}/devel/libnotify
 -
  USE_BZIP2=	yes
  USE_GMAKE=	yes
  GNU_CONFIGURE=	yes
 @@ -50,7 +48,7 @@ MBMON_DESC=		MBMon 
  MEMCACHED_DESC=		Memcached
  MODBUS_DESC=		Modbus support via libmodbus
  MYSQL_DESC=		MySQL
 -NOTIFYEMAIL_DESC=	Email notifications (libesmtp)
 +NOTIFYEMAIL_DESC=	Email notifications (libesmtp, libnotify)
  NGINX_DESC=		Nginx
  OPENVPN_DESC=		OpenVPN statistics
  PDNS_DESC=		PowerDNS
 @@ -120,7 +118,6 @@ CONFIGURE_ARGS=	--localstatedir=/var \
  		--disable-netlink \
  		--disable-nfs \
  		--disable-notify_desktop \
 -		--disable-notify_email \
  		--disable-olsrd \
  		--disable-onewire \
  		--disable-oracle \
 @@ -320,6 +317,7 @@ PLIST_SUB+=	IPMI="@comment "
  
  .if ${PORT_OPTIONS:MNOTIFYEMAIL}
  LIB_DEPENDS+=	esmtp:${PORTSDIR}/mail/libesmtp
 +LIB_DEPENDS+=	notify:${PORTSDIR}/devel/libnotify
  CONFIGURE_ARGS+=--enable-notify_email
  CONFIGURE_ARGS+=--with-libesmtp=${PREFIX}
  PLIST_SUB+=	NOTIFYEMAIL=""
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
