From nobody@FreeBSD.org  Tue May 14 16:41:12 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id 42000115
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 14 May 2013 16:41:12 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.FreeBSD.org (oldred.freebsd.org [8.8.178.121])
	by mx1.freebsd.org (Postfix) with ESMTP id 33E3A983
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 14 May 2013 16:41:12 +0000 (UTC)
Received: from oldred.FreeBSD.org ([127.0.1.6])
	by oldred.FreeBSD.org (8.14.5/8.14.5) with ESMTP id r4EGfBJu094497
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 14 May 2013 16:41:11 GMT
	(envelope-from nobody@oldred.FreeBSD.org)
Received: (from nobody@localhost)
	by oldred.FreeBSD.org (8.14.5/8.14.5/Submit) id r4EGfBKl094496;
	Tue, 14 May 2013 16:41:11 GMT
	(envelope-from nobody)
Message-Id: <201305141641.r4EGfBKl094496@oldred.FreeBSD.org>
Date: Tue, 14 May 2013 16:41:11 GMT
From: Chris Petrik <c.petrik.sosa@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] mark games/viruskiller broken on amd64
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         178636
>Category:       ports
>Synopsis:       [PATCH] mark games/viruskiller broken on amd64
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bdrewery
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 14 16:50:00 UTC 2013
>Closed-Date:    Thu May 16 08:56:04 CDT 2013
>Last-Modified:  Thu May 16 14:00:02 UTC 2013
>Originator:     Chris Petrik
>Release:        
>Organization:
NA
>Environment:
>Description:

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: viruskiller/Makefile
===================================================================
--- viruskiller/Makefile	(revision 318122)
+++ viruskiller/Makefile	(working copy)
@@ -13,6 +13,9 @@
 
 LICENSE=	GPLv2
 
+OPTIONS_DEFINE=	DOCS
+OPTIONS_DEFAULT=	DOCS
+
 USE_SDL=	mixer image ttf net
 USE_GMAKE=	yes
 
@@ -22,11 +25,17 @@
 
 MAKEFILE=	makefile
 
+.include <bsd.port.pre.mk>
+
+.if ${ARCH} == "amd64"
+BROKEN=	Does not build with new libz
+.endif
+
 post-patch:
 	# Remove non-free restricted files:
 	${RM} -f ${WRKSRC}/music/* ${WRKSRC}/sound/*
 
-.if defined(NOPORTDOCS)
+.if ${PORT_OPTIONS:MDOCS}
 	@${REINPLACE_CMD} -e "s|^.*install.*DOCS.*||g" \
 		-e "s|^.*mkdir.*DOCDIR.*||g" \
 		${WRKSRC}/makefile


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->bdrewery 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue May 14 16:50:13 UTC 2013 
Responsible-Changed-Why:  
bdrewery@ wants this submitter's PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=178636 
State-Changed-From-To: open->closed 
State-Changed-By: bdrewery 
State-Changed-When: Thu May 16 08:56:04 CDT 2013 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=178636 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/178636: commit references a PR
Date: Thu, 16 May 2013 13:55:58 +0000 (UTC)

 Author: bdrewery
 Date: Thu May 16 13:55:51 2013
 New Revision: 318316
 URL: http://svnweb.freebsd.org/changeset/ports/318316
 
 Log:
   - Mark broken on amd64
   - Convert to new options framework
   
   PR:		ports/178636
   Submitted by:	Chris Petrik <c.petrik.sosa@gmail.com> (maintainer)
 
 Modified:
   head/games/viruskiller/Makefile
 
 Modified: head/games/viruskiller/Makefile
 ==============================================================================
 --- head/games/viruskiller/Makefile	Thu May 16 13:53:13 2013	(r318315)
 +++ head/games/viruskiller/Makefile	Thu May 16 13:55:51 2013	(r318316)
 @@ -13,6 +13,8 @@ COMMENT=	Arcade game that relies on quic
  
  LICENSE=	GPLv2
  
 +OPTIONS_DEFINE=	DOCS
 +
  USE_SDL=	mixer image ttf net
  USE_GMAKE=	yes
  
 @@ -22,11 +24,17 @@ WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVER
  
  MAKEFILE=	makefile
  
 +.include <bsd.port.options.mk>
 +
 +.if ${ARCH} == "amd64"
 +BROKEN=	Does not build with new libz
 +.endif
 +
  post-patch:
  	# Remove non-free restricted files:
  	${RM} -f ${WRKSRC}/music/* ${WRKSRC}/sound/*
  
 -.if defined(NOPORTDOCS)
 +.if ${PORT_OPTIONS:MDOCS}
  	@${REINPLACE_CMD} -e "s|^.*install.*DOCS.*||g" \
  		-e "s|^.*mkdir.*DOCDIR.*||g" \
  		${WRKSRC}/makefile
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 

From: Bryan Drewery <bdrewery@FreeBSD.org>
To: bug-followup@FreeBSD.org, c.petrik.sosa@gmail.com
Cc:  
Subject: Re: ports/178636: [PATCH] mark games/viruskiller broken on amd64
Date: Thu, 16 May 2013 09:55:03 -0400

 This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
 ------enig2JPBJRGDEUHOVFVOQWBXL
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: quoted-printable
 
 Including bsd.port.pre.mk requires changing the bsd.port.mk line to be
 bsd.port.post.mk. Otherwise it breaks the i386 build:
 
 > viruskiller-1.03_3: Makefile error: you cannot include bsd.port[.pre].m=
 k twice
 
 
 Another option is to use bsd.port.options.mk instead of bsd.port.pre.mk,
 which does not require using bsd.port.post.mk.
 
 I'll commit it with bsd.options.mk.
 
 Also, DOCS is already default so it's not needed to add to OPTIONS_DEFAUL=
 T.
 
 Bryan
 
 
 ------enig2JPBJRGDEUHOVFVOQWBXL
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: OpenPGP digital signature
 Content-Disposition: attachment; filename="signature.asc"
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.10 (MingW32)
 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
 
 iQIcBAEBAgAGBQJRlOU3AAoJEG54KsA8mwz5GEQP/2kF+cOBS8x+YbHBbB/lzCHA
 8z90QKJ/zDRZhDmDYhA7hwHiroPEscjPsZsFnxubrfDV+LSI0avuZXPOywu9jBjP
 8WFQJ93CdVX3vd9AQIeS7/e0ko+BuJ0G8lvDkveu7UE5hGDgyprTk0Ut4d2Elde3
 DBVcBVuJNEmpY1RfavSEQac6ZtzrV9Swf5reKwXdAqmhdenEXQmI6zQ8ehsH8QVU
 TIPuexwfk4HFfx52tupbTWgd23CeCwJTRaA7uXWrrl1oR6mMi8o9hE4DHqtItFgg
 ZLs1Gbw04vcL48Kz7bLlkUGDwNA+VmXE5HrThWs+xpCZkUlmkFXm4B0AVnmRoQ4V
 asTgsymmOFBSE191+90a01xWJ6Bl5cQJIZG5VKg+49n3I6cn4NZsyQs89td7s4WV
 PYY0wK/85QlMFICSSjom1JNx2ulj4gwVzsYdXVivTtNZ5yk487YIqcKlhvcod61M
 vA8WCymZ9+PVehY94Y+QMzsYf0/iWEqcyfdRSabOYTJx8Cu0VssCL3623ljMVMZE
 3l7WP1yYqiWyV2NyKTKxLStEW6rU2KCokxU8WQELafSwg/6n3kY4c/CDUIpiLyXm
 ajkbYJ2/2aAzIsiy8CDE2YS8OwfNGrGxLN8EalDG7Et1mv4lbfg98a/N16Y+xyQ2
 lcRqPv/ooeSwMzSWbwrt
 =CYhM
 -----END PGP SIGNATURE-----
 
 ------enig2JPBJRGDEUHOVFVOQWBXL--
>Unformatted:
