From nobody@FreeBSD.org  Mon May 13 09:00:58 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id 3ADD2962
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 13 May 2013 09:00:58 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.FreeBSD.org (oldred.freebsd.org [8.8.178.121])
	by mx1.freebsd.org (Postfix) with ESMTP id 1402BFAA
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 13 May 2013 09:00:58 +0000 (UTC)
Received: from oldred.FreeBSD.org ([127.0.1.6])
	by oldred.FreeBSD.org (8.14.5/8.14.5) with ESMTP id r4D90vDW042866
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 13 May 2013 09:00:57 GMT
	(envelope-from nobody@oldred.FreeBSD.org)
Received: (from nobody@localhost)
	by oldred.FreeBSD.org (8.14.5/8.14.5/Submit) id r4D90v7i042863;
	Mon, 13 May 2013 09:00:57 GMT
	(envelope-from nobody)
Message-Id: <201305130900.r4D90v7i042863@oldred.FreeBSD.org>
Date: Mon, 13 May 2013 09:00:57 GMT
From: Pietro Cerutti <gahr@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] x11-toolkits/tix -- fix build with Tcl 8.6
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: doconnor@gsoft.com.au

>Number:         178563
>Category:       ports
>Synopsis:       [patch] x11-toolkits/tix -- fix build with Tcl 8.6
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 13 09:10:00 UTC 2013
>Closed-Date:    Mon May 13 15:43:27 UTC 2013
>Last-Modified:  Wed May 15 06:20:05 UTC 2013
>Originator:     Pietro Cerutti
>Release:        
>Organization:
The FreeBSD Project
>Environment:
>Description:
The following patch fixes the build of x11-toolkits/tix with Tcl/Tk 8.6. Also, I have fixed the Makefile header as per the new guidelines.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: Makefile
===================================================================
--- Makefile	(revision 313650)
+++ Makefile	(working copy)
@@ -1,9 +1,5 @@
-# New ports collection makefile for:	tix
-# Date created:		22 December 1996
-# Whom:			Thomas Gellekum <tg@freebsd.org>
-#
+# Created by: Thomas Gellekum <tg@freebsd.org>
 # $FreeBSD$
-#
 
 PORTNAME=	tix
 PORTVERSION=	8.4.3
@@ -23,7 +19,9 @@
 		--with-tclconfig="${TCL_LIBDIR}" \
 		--with-tkconfig="${TK_LIBDIR}" \
 		--with-tclinclude="${TCL_INCLUDEDIR}" \
-		--with-tkinclude="${TK_INCLUDEDIR}"
+		--with-tkinclude="${TK_INCLUDEDIR}" \
+		--prefix=${PREFIX} \
+		--exec-prefix=${PREFIX}
 # this should probably be added to bsd.port.mk
 CONFIGURE_ENV=	PREFIX=${PREFIX}
 MANN=		TixIntro.n compound.n pixmap.n tix.n tixBalloon.n \
@@ -49,7 +47,7 @@
 pre-configure:
 	@(cd ${WRKSRC} && \
 	    CC="${CC}" ac_cv_path_CC="${CC}" CFLAGS="${CFLAGS}" \
-	    INSTALL="/usr/bin/install -c -o ${BINOWN} -g ${BINGRP}" \
+	    INSTALL="${INSTALL} -c -o ${BINOWN} -g ${BINGRP}" \
 	    INSTALL_PROGRAM="${INSTALL_PROGRAM}" \
 	    INSTALL_SCRIPT="${INSTALL_SCRIPT}" \
 	    ${CONFIGURE_ENV} ./${CONFIGURE_SCRIPT} ${CONFIGURE_ARGS})
Index: files/patch-generic_tixGrSort.c
===================================================================
--- files/patch-generic_tixGrSort.c	(revision 0)
+++ files/patch-generic_tixGrSort.c	(working copy)
@@ -0,0 +1,13 @@
+--- generic/tixGrSort.c.orig	2013-05-13 10:52:04.000000000 +0200
++++ generic/tixGrSort.c	2013-05-13 10:53:38.000000000 +0200
+@@ -447,8 +447,8 @@
+ 	 * Parse the result of the command.
+ 	 */
+ 
+-	order = strtol(sortInterp->result, &end, 0);
+-	if ((end == sortInterp->result) || (*end != 0)) {
++	order = strtol(Tcl_GetStringResult(sortInterp), &end, 0);
++	if ((end == Tcl_GetStringResult(sortInterp)) || (*end != 0)) {
+ 	    Tcl_ResetResult(sortInterp);
+ 	    Tcl_AppendResult(sortInterp,
+ 		    "comparison command returned non-numeric result",

Property changes on: files/patch-generic_tixGrSort.c
___________________________________________________________________
Added: svn:mime-type
## -0,0 +1 ##
+text/plain
\ No newline at end of property
Added: fbsd:nokeywords
## -0,0 +1 ##
+yes
\ No newline at end of property
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Mon May 13 09:10:09 UTC 2013 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=178563 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: doconnor@gsoft.com.au
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/178563: [patch] x11-toolkits/tix -- fix build with Tcl 8.6
Date: Mon, 13 May 2013 09:10:08 UT

 Maintainer of x11-toolkits/tix,
 
 Please note that PR ports/178563 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/178563
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
State-Changed-From-To: feedback->closed 
State-Changed-By: gahr 
State-Changed-When: Mon May 13 15:43:26 UTC 2013 
State-Changed-Why:  
Committed (portmgr@ approval) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=178563 

From: Pietro Cerutti <gahr@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: ports/178563: [patch] x11-toolkits/tix -- fix build with Tcl 8.6
Date: Mon, 13 May 2013 09:00:57 GMT

 >Number:         178563
 >Category:       ports
 >Synopsis:       [patch] x11-toolkits/tix -- fix build with Tcl 8.6
 >Confidential:   no
 >Severity:       non-critical
 >Priority:       low
 >Responsible:    freebsd-ports-bugs
 >State:          open
 >Quarter:        
 >Keywords:       
 >Date-Required:
 >Class:          sw-bug
 >Submitter-Id:   current-users
 >Arrival-Date:   Mon May 13 09:10:00 UTC 2013
 >Closed-Date:
 >Last-Modified:
 >Originator:     Pietro Cerutti
 >Release:        
 >Organization:
 The FreeBSD Project
 >Environment:
 >Description:
 The following patch fixes the build of x11-toolkits/tix with Tcl/Tk 8.6. Also, I have fixed the Makefile header as per the new guidelines.
 >How-To-Repeat:
 
 >Fix:
 
 
 Patch attached with submission follows:
 
 Index: Makefile
 ===================================================================
 --- Makefile	(revision 313650)
 +++ Makefile	(working copy)
 @@ -1,9 +1,5 @@
 -# New ports collection makefile for:	tix
 -# Date created:		22 December 1996
 -# Whom:			Thomas Gellekum <tg@freebsd.org>
 -#
 +# Created by: Thomas Gellekum <tg@freebsd.org>
  # $FreeBSD$
 -#
  
  PORTNAME=	tix
  PORTVERSION=	8.4.3
 @@ -23,7 +19,9 @@
  		--with-tclconfig="${TCL_LIBDIR}" \
  		--with-tkconfig="${TK_LIBDIR}" \
  		--with-tclinclude="${TCL_INCLUDEDIR}" \
 -		--with-tkinclude="${TK_INCLUDEDIR}"
 +		--with-tkinclude="${TK_INCLUDEDIR}" \
 +		--prefix=${PREFIX} \
 +		--exec-prefix=${PREFIX}
  # this should probably be added to bsd.port.mk
  CONFIGURE_ENV=	PREFIX=${PREFIX}
  MANN=		TixIntro.n compound.n pixmap.n tix.n tixBalloon.n \
 @@ -49,7 +47,7 @@
  pre-configure:
  	@(cd ${WRKSRC} && \
  	    CC="${CC}" ac_cv_path_CC="${CC}" CFLAGS="${CFLAGS}" \
 -	    INSTALL="/usr/bin/install -c -o ${BINOWN} -g ${BINGRP}" \
 +	    INSTALL="${INSTALL} -c -o ${BINOWN} -g ${BINGRP}" \
  	    INSTALL_PROGRAM="${INSTALL_PROGRAM}" \
  	    INSTALL_SCRIPT="${INSTALL_SCRIPT}" \
  	    ${CONFIGURE_ENV} ./${CONFIGURE_SCRIPT} ${CONFIGURE_ARGS})
 Index: files/patch-generic_tixGrSort.c
 ===================================================================
 --- files/patch-generic_tixGrSort.c	(revision 0)
 +++ files/patch-generic_tixGrSort.c	(working copy)
 @@ -0,0 +1,13 @@
 +--- generic/tixGrSort.c.orig	2013-05-13 10:52:04.000000000 +0200
 ++++ generic/tixGrSort.c	2013-05-13 10:53:38.000000000 +0200
 +@@ -447,8 +447,8 @@
 + 	 * Parse the result of the command.
 + 	 */
 + 
 +-	order = strtol(sortInterp->result, &end, 0);
 +-	if ((end == sortInterp->result) || (*end != 0)) {
 ++	order = strtol(Tcl_GetStringResult(sortInterp), &end, 0);
 ++	if ((end == Tcl_GetStringResult(sortInterp)) || (*end != 0)) {
 + 	    Tcl_ResetResult(sortInterp);
 + 	    Tcl_AppendResult(sortInterp,
 + 		    "comparison command returned non-numeric result",
 
 Property changes on: files/patch-generic_tixGrSort.c
 ___________________________________________________________________
 Added: svn:mime-type
 ## -0,0 +1 ##
 +text/plain
 \ No newline at end of property
 Added: fbsd:nokeywords
 ## -0,0 +1 ##
 +yes
 \ No newline at end of property
 Added: svn:eol-style
 ## -0,0 +1 ##
 +native
 \ No newline at end of property
 
 
 >Release-Note:
 >Audit-Trail:
 >Unformatted:
 _______________________________________________
 freebsd-ports-bugs@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
 To unsubscribe, send any mail to "freebsd-ports-bugs-unsubscribe@freebsd.org"

From: Pietro Cerutti <gahr@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: ports/178563: [patch] x11-toolkits/tix -- fix build with Tcl 8.6
Date: Mon, 13 May 2013 09:00:57 GMT

 >Number:         178563
 >Category:       ports
 >Synopsis:       [patch] x11-toolkits/tix -- fix build with Tcl 8.6
 >Confidential:   no
 >Severity:       non-critical
 >Priority:       low
 >Responsible:    freebsd-ports-bugs
 >State:          open
 >Quarter:        
 >Keywords:       
 >Date-Required:
 >Class:          sw-bug
 >Submitter-Id:   current-users
 >Arrival-Date:   Mon May 13 09:10:00 UTC 2013
 >Closed-Date:
 >Last-Modified:
 >Originator:     Pietro Cerutti
 >Release:        
 >Organization:
 The FreeBSD Project
 >Environment:
 >Description:
 The following patch fixes the build of x11-toolkits/tix with Tcl/Tk 8.6. Also, I have fixed the Makefile header as per the new guidelines.
 >How-To-Repeat:
 
 >Fix:
 
 
 Patch attached with submission follows:
 
 Index: Makefile
 ===================================================================
 --- Makefile	(revision 313650)
 +++ Makefile	(working copy)
 @@ -1,9 +1,5 @@
 -# New ports collection makefile for:	tix
 -# Date created:		22 December 1996
 -# Whom:			Thomas Gellekum <tg@freebsd.org>
 -#
 +# Created by: Thomas Gellekum <tg@freebsd.org>
  # $FreeBSD$
 -#
  
  PORTNAME=	tix
  PORTVERSION=	8.4.3
 @@ -23,7 +19,9 @@
  		--with-tclconfig="${TCL_LIBDIR}" \
  		--with-tkconfig="${TK_LIBDIR}" \
  		--with-tclinclude="${TCL_INCLUDEDIR}" \
 -		--with-tkinclude="${TK_INCLUDEDIR}"
 +		--with-tkinclude="${TK_INCLUDEDIR}" \
 +		--prefix=${PREFIX} \
 +		--exec-prefix=${PREFIX}
  # this should probably be added to bsd.port.mk
  CONFIGURE_ENV=	PREFIX=${PREFIX}
  MANN=		TixIntro.n compound.n pixmap.n tix.n tixBalloon.n \
 @@ -49,7 +47,7 @@
  pre-configure:
  	@(cd ${WRKSRC} && \
  	    CC="${CC}" ac_cv_path_CC="${CC}" CFLAGS="${CFLAGS}" \
 -	    INSTALL="/usr/bin/install -c -o ${BINOWN} -g ${BINGRP}" \
 +	    INSTALL="${INSTALL} -c -o ${BINOWN} -g ${BINGRP}" \
  	    INSTALL_PROGRAM="${INSTALL_PROGRAM}" \
  	    INSTALL_SCRIPT="${INSTALL_SCRIPT}" \
  	    ${CONFIGURE_ENV} ./${CONFIGURE_SCRIPT} ${CONFIGURE_ARGS})
 Index: files/patch-generic_tixGrSort.c
 ===================================================================
 --- files/patch-generic_tixGrSort.c	(revision 0)
 +++ files/patch-generic_tixGrSort.c	(working copy)
 @@ -0,0 +1,13 @@
 +--- generic/tixGrSort.c.orig	2013-05-13 10:52:04.000000000 +0200
 ++++ generic/tixGrSort.c	2013-05-13 10:53:38.000000000 +0200
 +@@ -447,8 +447,8 @@
 + 	 * Parse the result of the command.
 + 	 */
 + 
 +-	order = strtol(sortInterp->result, &end, 0);
 +-	if ((end == sortInterp->result) || (*end != 0)) {
 ++	order = strtol(Tcl_GetStringResult(sortInterp), &end, 0);
 ++	if ((end == Tcl_GetStringResult(sortInterp)) || (*end != 0)) {
 + 	    Tcl_ResetResult(sortInterp);
 + 	    Tcl_AppendResult(sortInterp,
 + 		    "comparison command returned non-numeric result",
 
 Property changes on: files/patch-generic_tixGrSort.c
 ___________________________________________________________________
 Added: svn:mime-type
 ## -0,0 +1 ##
 +text/plain
 \ No newline at end of property
 Added: fbsd:nokeywords
 ## -0,0 +1 ##
 +yes
 \ No newline at end of property
 Added: svn:eol-style
 ## -0,0 +1 ##
 +native
 \ No newline at end of property
 
 
 >Release-Note:
 >Audit-Trail:
 >Unformatted:
 _______________________________________________
 freebsd-ports-bugs@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
 To unsubscribe, send any mail to "freebsd-ports-bugs-unsubscribe@freebsd.org"
>Unformatted:
