From nobody@FreeBSD.org  Fri Apr 26 17:00:03 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id 33E41A87
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 26 Apr 2013 17:00:03 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 0B37112DC
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 26 Apr 2013 17:00:03 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r3QH02Ck062228
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 26 Apr 2013 17:00:02 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id r3QH02eI062227;
	Fri, 26 Apr 2013 17:00:02 GMT
	(envelope-from nobody)
Message-Id: <201304261700.r3QH02eI062227@red.freebsd.org>
Date: Fri, 26 Apr 2013 17:00:02 GMT
From: Rainer Hurling <rhurlin@gwdg.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [maintainer][patch] math/ggobi: build problem with graphviz solved
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         178185
>Category:       ports
>Synopsis:       [maintainer][patch] math/ggobi: build problem with graphviz solved
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    glarkin
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Apr 26 17:10:00 UTC 2013
>Closed-Date:    Mon May 06 14:26:59 EDT 2013
>Last-Modified:  Mon May  6 18:30:03 UTC 2013
>Originator:     Rainer Hurling
>Release:        10.0-CURRENT (amd64)
>Organization:
>Environment:
FreeBSD xxx.xxx.xxx 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r249715M: Sun Apr 21 11:16:54 CEST 2013     xxx@xxx.xxx.xxx:/usr/obj/usr/src/sys/XXX  amd64
>Description:
With graphics/graphviz installed, math/ggobi finds this external
installation by its configure script in plugins/GraphLayout. Then it
tries to use it instead of its internal graphviz version and fails when
trying to build the port.

This has been a longstanding problem with ggobi, not detected by tinderbox etc. As a workaround, one had to deinstall graphics/graphviz before building math/ggobi and reinstall it afterwards. That should be solved now.

While here, trimming Makefiles header.
>How-To-Repeat:
Try to build math/ggobi, when graphics/graphviz is installed.
>Fix:
Greg Larkin was so kind to help me with this problem. He looked into it and gave me the hint to post-configure patch the two files. Many thanks to Greg!

Patch attached with submission follows:

diff -Naur ggobi.orig/Makefile ggobi/Makefile
--- ggobi.orig/Makefile	2012-08-03 14:33:50.000000000 +0200
+++ ggobi/Makefile	2013-04-26 18:49:15.000000000 +0200
@@ -1,9 +1,5 @@
-# Ports collection makefile for:   ggobi
-# Date created:        31 January 2010
-# Whom:                rhurlin
-#
-# $FreeBSD: head/math/ggobi/Makefile 300896 2012-07-14 13:54:48Z beat $
-#
+# Created by: Rainer Hurling <rhurlin@gwdg.de>
+# $FreeBSD$
 
 PORTNAME=	ggobi
 PORTVERSION=	2.1.9
@@ -33,6 +29,15 @@
 		${WRKSRC}/src/ggobi-renderer-factory.c \
 		${WRKSRC}/src/ggobi-renderer.c
 
+post-configure:
+# build gets irritated by the presence of an external graphviz version
+	@${REINPLACE_CMD} -e 's|#define HAVE_LIBGVC 1|/* #define HAVE_LIBGVC 1 */|' \
+		${WRKSRC}/plugins/GraphLayout/config.h
+	@${REINPLACE_CMD} -e 's|LIBGVC_CFLAGS = -I${LOCALBASE}/include/graphviz|LIBGVC_CFLAGS =|' \
+		${WRKSRC}/plugins/GraphLayout/Makefile
+	@${REINPLACE_CMD} -e 's|LIBGVC_LIBS = -L${LOCALBASE}/lib/graphviz -lgvc -lgraph -lcdt|LIBGVC_LIBS =|' \
+		${WRKSRC}/plugins/GraphLayout/Makefile
+
 post-install:
 	${MKDIR} ${PREFIX}/etc/xdg/ggobi
 	${INSTALL_DATA} ${WRKSRC}/ggobirc ${PREFIX}/etc/xdg/ggobi/ggobirc.sample


>Release-Note:
>Audit-Trail:
Class-Changed-From-To: sw-bug->maintainer-update 
Class-Changed-By: edwin 
Class-Changed-When: Fri Apr 26 17:10:09 UTC 2013 
Class-Changed-Why:  
Fix category (submitter is maintainer) (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=178185 
Responsible-Changed-From-To: freebsd-ports-bugs->glarkin 
Responsible-Changed-By: glarkin 
Responsible-Changed-When: Wed May 1 16:03:22 EDT 2013 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=178185 
State-Changed-From-To: open->closed 
State-Changed-By: glarkin 
State-Changed-When: Mon May 6 14:26:48 EDT 2013 
State-Changed-Why:  
Committed, thank you! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=178185 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/178185: commit references a PR
Date: Mon,  6 May 2013 18:26:35 +0000 (UTC)

 Author: glarkin
 Date: Mon May  6 18:26:22 2013
 New Revision: 317538
 URL: http://svnweb.freebsd.org/changeset/ports/317538
 
 Log:
   - Fix build problem with graphics/graphviz already installed [1]
   - Trim Makefile header [1]
   - Use DOCSDIR in pkg-plist
   
   PR:		ports/178185
   Submitted by:	Rainer Hurling <rhurlin@gwdg.de> (maintainer) [1]
 
 Modified:
   head/math/ggobi/Makefile
   head/math/ggobi/pkg-plist
 
 Modified: head/math/ggobi/Makefile
 ==============================================================================
 --- head/math/ggobi/Makefile	Mon May  6 18:14:33 2013	(r317537)
 +++ head/math/ggobi/Makefile	Mon May  6 18:26:22 2013	(r317538)
 @@ -1,9 +1,5 @@
 -# Ports collection makefile for:   ggobi
 -# Date created:        31 January 2010
 -# Whom:                rhurlin
 -#
 +# Created by: Rainer Hurling <rhurlin@gwdg.de>
  # $FreeBSD$
 -#
  
  PORTNAME=	ggobi
  PORTVERSION=	2.1.9
 @@ -33,6 +29,15 @@ post-patch:
  		${WRKSRC}/src/ggobi-renderer-factory.c \
  		${WRKSRC}/src/ggobi-renderer.c
  
 +post-configure:
 +# build gets irritated by the presence of an external graphviz version
 +	@${REINPLACE_CMD} -e 's|#define HAVE_LIBGVC 1|/* #define HAVE_LIBGVC 1 */|' \
 +		${WRKSRC}/plugins/GraphLayout/config.h
 +	@${REINPLACE_CMD} -e 's|LIBGVC_CFLAGS = -I${LOCALBASE}/include/graphviz|LIBGVC_CFLAGS =|' \
 +		${WRKSRC}/plugins/GraphLayout/Makefile
 +	@${REINPLACE_CMD} -e 's|LIBGVC_LIBS = -L${LOCALBASE}/lib/graphviz -lgvc -lgraph -lcdt|LIBGVC_LIBS =|' \
 +		${WRKSRC}/plugins/GraphLayout/Makefile
 +
  post-install:
  	${MKDIR} ${PREFIX}/etc/xdg/ggobi
  	${INSTALL_DATA} ${WRKSRC}/ggobirc ${PREFIX}/etc/xdg/ggobi/ggobirc.sample
 
 Modified: head/math/ggobi/pkg-plist
 ==============================================================================
 --- head/math/ggobi/pkg-plist	Mon May  6 18:14:33 2013	(r317537)
 +++ head/math/ggobi/pkg-plist	Mon May  6 18:26:22 2013	(r317538)
 @@ -129,9 +129,9 @@ share/pixmaps/ggobi.png
  @unexec if cmp -s %D/etc/xdg/ggobi/ggobirc.sample %D/etc/xdg/ggobi/ggobirc; then rm -f %D/etc/xdg/ggobi/ggobirc; fi
  etc/xdg/ggobi/ggobirc.sample
  @exec if [ ! -f %B/ggobirc ]; then cp -p %D/%F %B/ggobirc; fi
 -share/doc/ggobi/XML.pdf
 -share/doc/ggobi/manual.pdf
 -@dirrm share/doc/ggobi
 +%%DOCSDIR%%/XML.pdf
 +%%DOCSDIR%%/manual.pdf
 +@dirrm %%DOCSDIR%%
  @dirrmtry share/applications
  @dirrmtry etc/xdg/ggobi
  @dirrmtry etc/xdg
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
