From nobody@FreeBSD.org  Tue Apr  9 03:46:11 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
	by hub.freebsd.org (Postfix) with ESMTP id 120DE4F3
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  9 Apr 2013 03:46:11 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id DC667E0C
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  9 Apr 2013 03:46:10 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r393kA47053894
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 9 Apr 2013 03:46:10 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id r393kAaJ053893;
	Tue, 9 Apr 2013 03:46:10 GMT
	(envelope-from nobody)
Message-Id: <201304090346.r393kAaJ053893@red.freebsd.org>
Date: Tue, 9 Apr 2013 03:46:10 GMT
From: Edward <edward@rdtan.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] sysutils/puppet: puppet agent failed when connecting to puppet master
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         177729
>Category:       ports
>Synopsis:       [PATCH] sysutils/puppet: puppet agent failed when connecting to puppet master
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    swills
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 09 03:50:00 UTC 2013
>Closed-Date:    Thu Apr 25 01:43:57 UTC 2013
>Last-Modified:  Thu Apr 25 01:50:00 UTC 2013
>Originator:     Edward
>Release:        FreeBSD 9.1-RELEASE
>Organization:
>Environment:
FreeBSD puppet-testing-port-01.example.com 9.1-RELEASE FreeBSD 9.1-RELEASE #0 r243825: Tue Dec  4 09:23:10 UTC 2012     root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
puppet agent display the following error message when connecting to puppet master:
Info: Retrieving plugin
Error: /File[/var/puppet/lib]: Could not evaluate: Could not retrieve information from environment production source(s) puppet://puppet-testing-port-01.example.com/plugins
Info: Caching catalog for puppet-testing-port-02.example.com
Info: Applying configuration version '1365200455'

This is because the puppet master (puppet-testing-port01.example.com) has a missing directory /usr/local/etc/puppet/modules, which doesn't create by default. The attached diff of sysutils/puppet Makefile will create the directory /usr/local/etc/puppet/modules which do away the error message.
>How-To-Repeat:
On a fresh installation of sysutils/puppet (without /usr/local/etc/puppet/modules) on puppet master (puppet-testing-port01.example.com), then try to connect puppet agent (puppet-testing-port02.example.com) with it.
>Fix:


Patch attached with submission follows:

--- Makefile.original	2013-04-09 11:04:19.000000000 +0800
+++ Makefile	2013-04-09 11:05:33.000000000 +0800
@@ -95,6 +95,7 @@
 		--vardir=/var/lib/puppet \
 		--logdir=/var/log/puppet \
 		> ${ETCDIR}/puppet.conf-dist
+	${MKDIR} -p ${ETCDIR}/modules
 	@${ECHO} ${RUBY_SITELIBDIR}/puppet.rb | \
 		${SED} 's,^${PREFIX}/,,' >> ${TMPPLIST}
 	@${ECHO} ${RUBY_SITELIBDIR}/semver.rb | \


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->swills 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Apr 9 03:50:14 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=177729 
State-Changed-From-To: open->closed 
State-Changed-By: swills 
State-Changed-When: Thu Apr 25 01:43:56 UTC 2013 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=177729 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/177729: commit references a PR
Date: Thu, 25 Apr 2013 01:43:52 +0000 (UTC)

 Author: swills
 Date: Thu Apr 25 01:43:44 2013
 New Revision: 316490
 URL: http://svnweb.freebsd.org/changeset/ports/316490
 
 Log:
   - Add missing module dir
   
   PR:		ports/177729
   Submitted by:	Edward <edward@rdtan.net>
 
 Modified:
   head/sysutils/puppet/Makefile
   head/sysutils/puppet/pkg-plist
 
 Modified: head/sysutils/puppet/Makefile
 ==============================================================================
 --- head/sysutils/puppet/Makefile	Thu Apr 25 01:34:24 2013	(r316489)
 +++ head/sysutils/puppet/Makefile	Thu Apr 25 01:43:44 2013	(r316490)
 @@ -95,6 +95,7 @@ post-install:
  		--vardir=/var/lib/puppet \
  		--logdir=/var/log/puppet \
  		> ${ETCDIR}/puppet.conf-dist
 +	${MKDIR} -p ${ETCDIR}/modules
  	@${ECHO} ${RUBY_SITELIBDIR}/puppet.rb | \
  		${SED} 's,^${PREFIX}/,,' >> ${TMPPLIST}
  	@${ECHO} ${RUBY_SITELIBDIR}/semver.rb | \
 
 Modified: head/sysutils/puppet/pkg-plist
 ==============================================================================
 --- head/sysutils/puppet/pkg-plist	Thu Apr 25 01:34:24 2013	(r316489)
 +++ head/sysutils/puppet/pkg-plist	Thu Apr 25 01:43:44 2013	(r316490)
 @@ -5,9 +5,11 @@ bin/puppet
  %%RUBY_SITELIBDIR%%/hiera_puppet.rb
  %%ETCDIR%%/puppet.conf-dist
  %%ETCDIR%%/auth.conf-dist
 +@dirrmtry etc/puppet/modules
  @dirrmtry etc/puppet
  @unexec rmdir /var/puppet 2>/dev/null || true
  @exec /bin/mkdir -p /var/puppet
 +@exec /bin/mkdir -p etc/puppet/modules
  @exec /usr/sbin/chown -Rh puppet:puppet /var/puppet
  @dirrm %%RUBY_SITELIBDIR%%/hiera/backend
  @dirrm %%RUBY_SITELIBDIR%%/hiera
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
