From leres@ee.lbl.gov  Sat Apr  6 21:36:36 2013
Return-Path: <leres@ee.lbl.gov>
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
	by hub.freebsd.org (Postfix) with ESMTP id 8892F6BD
	for <FreeBSD-gnats-submit@freebsd.org>; Sat,  6 Apr 2013 21:36:36 +0000 (UTC)
	(envelope-from leres@ee.lbl.gov)
Received: from fun.ee.lbl.gov (fun.ee.lbl.gov [IPv6:2620:83:8000:102::ca])
	by mx1.freebsd.org (Postfix) with ESMTP id 5F3641F8
	for <FreeBSD-gnats-submit@freebsd.org>; Sat,  6 Apr 2013 21:36:36 +0000 (UTC)
Received: from fun.ee.lbl.gov (localhost [127.0.0.1])
	by fun.ee.lbl.gov (8.14.6/8.14.6) with ESMTP id r36Laan7090308
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Sat, 6 Apr 2013 14:36:36 -0700 (PDT)
Received: (from leres@localhost)
	by fun.ee.lbl.gov (8.14.6/8.14.6/Submit) id r36Laal8090307;
	Sat, 6 Apr 2013 14:36:36 -0700 (PDT)
Message-Id: <201304062136.r36Laal8090307@fun.ee.lbl.gov>
Date: Sat, 6 Apr 2013 14:36:36 -0700 (PDT)
From: Craig Leres <leres@ee.lbl.gov>
Reply-To: Craig Leres <leres@ee.lbl.gov>
To: FreeBSD-gnats-submit@freebsd.org
Cc: leres@ee.lbl.gov
Subject: [PATCH] net-mgmt/argus3-clients: Fix MANPAGES=no
X-Send-Pr-Version: 3.113
X-GNATS-Notify: pauls@utdallas.edu

>Number:         177675
>Category:       ports
>Synopsis:       [PATCH] net-mgmt/argus3-clients: Fix MANPAGES=no
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Apr 06 21:40:00 UTC 2013
>Closed-Date:    Sat May 11 21:38:18 UTC 2013
>Last-Modified:  Sat May 11 21:40:01 UTC 2013
>Originator:     Craig Leres
>Release:        FreeBSD 8.2-RELEASE amd64
>Organization:
Lawrence Berkeley National Laboratory
>Environment:
FreeBSD bob2.lbl.gov 8.2-RELEASE-p9 FreeBSD 8.2-RELEASE-p9 #0: Mon Jun 11 23:00:11 UTC 2012     root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
	Turning off the MANPAGES option generates lots of errors
	on install and fatal errors when attempting to create a
	package.

>How-To-Repeat:
	(With MANPAGES disasbled)

	# cd /home/u2/FreeBSD-current/ports/net-mgmt/argus3-clients && make install
	[...]
	===>   Compressing manual pages for argus-clients-sasl-3.0.6.2
	gzip: can't stat: /usr/local/man/man1/rasql.1: No such file or directory
	gzip: can't stat: /usr/local/man/man1/rasqlinsert.1: No such file or directory
	[...]
	# make package
	bob2 194 # make package
	===>  Building package for argus-clients-sasl-3.0.6.2
	tar: man/man1/rasql.1.gz: Cannot stat: No such file or directory
	tar: man/man1/rasqlinsert.1.gz: Cannot stat: No such file or directory
	[...]
	pkg_create: make_dist: tar command failed with code 256
	*** Error code 1

>Fix:
	Wrap remaining MAN1, MAN5 and MAN8 assignments with a
	".if ${PORT_OPTIONS:MMANPAGES}" test; see attached patch.

--- patch.txt begins here ---
--- Makefile.orig	2013-03-12 05:30:14.000000000 -0700
+++ Makefile	2013-04-06 14:26:54.000000000 -0700
@@ -3,6 +3,7 @@
 
 PORTNAME=	argus-clients
 PORTVERSION=	3.0.6.2
+PORTREVISION=	1
 CATEGORIES=	net-mgmt security
 MASTER_SITES=	http://qosient.com/argus/src/ \
 		ftp://qosient.com/pub/argus/src/
@@ -33,7 +34,9 @@
 .if ${PORT_OPTIONS:MMYSQL}
 USE_MYSQL=	yes
 PLIST_SUB+=	MYSQL=""
+.if ${PORT_OPTIONS:MMANPAGES}
 MAN1+=		rasql.1 rasqlinsert.1 rasqltimeindex.1
+.endif
 .else
 PLIST_SUB+=	MYSQL="@comment "
 .endif
@@ -43,11 +46,13 @@
 CONFIGURE_ARGS+=	--with-GeoIP=${LOCALBASE}
 .endif
 
+.if ${PORT_OPTIONS:MMANPAGES}
 MAN1+=	ra.1 rabins.1 racluster.1 raconvert.1 racount.1 radump.1 raevent.1 \
 	rafilteraddr.1 ragraph.1 ragrep.1 rahisto.1 ralabel.1 ranonymize.1 \
 	rapath.1 rapolicy.1 rasort.1 rasplit.1 rastream.1 rastrip.1
 MAN5=	racluster.5 radium.conf.5 ralabel.conf.5 ranonymize.5 rarc.5
 MAN8=	radium.8
+.endif
 
 do-install:
 .for i in ra rabins racluster raconvert racount radium radump raevent \
--- patch.txt ends here ---


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sat Apr 6 21:40:07 UTC 2013 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=177675 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: pauls@utdallas.edu
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/177675: [PATCH] net-mgmt/argus3-clients: Fix MANPAGES=no
Date: Sat, 6 Apr 2013 21:40:07 UT

 Maintainer of net-mgmt/argus3-clients,
 
 Please note that PR ports/177675 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/177675
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Paul Schmehl <pauls@utdallas.edu>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/177675: [PATCH] net-mgmt/argus3-clients: Fix MANPAGES=no
Date: Mon, 08 Apr 2013 10:39:48 -0500

 --==========6B827D69DA88A9D5C3E1==========
 Content-Type: text/plain; charset=us-ascii; format=flowed
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline; size=769
 
 Accepted.  The patch didn't apply cleanly for me, so an svn diff is 
 attached just in case.  I don't think we need to bump portrevision, however.
 
 -- 
 Paul Schmehl (pauls@utdallas.edu)
 Senior Information Security Analyst
 The University of Texas at Dallas
 http://www.utdallas.edu/infosecurity/
 
 --==========6B827D69DA88A9D5C3E1==========
 Content-Type: application/octet-stream; name="argus3-clients.diff"
 Content-Transfer-Encoding: base64
 Content-Disposition: attachment; filename="argus3-clients.diff"; size=855
 
 SW5kZXg6IE1ha2VmaWxlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIE1ha2VmaWxlCShyZXZpc2lvbiAzMTU3NjEp
 CisrKyBNYWtlZmlsZQkod29ya2luZyBjb3B5KQpAQCAtMzMsNyArMzMsOSBAQAogLmlmICR7UE9S
 VF9PUFRJT05TOk1NWVNRTH0KIFVTRV9NWVNRTD0JeWVzCiBQTElTVF9TVUIrPQlNWVNRTD0iIgor
 LmlmICR7UE9SVF9PUFRJT05TOk1NQU5QQUdFU30KIE1BTjErPQkJcmFzcWwuMSByYXNxbGluc2Vy
 dC4xIHJhc3FsdGltZWluZGV4LjEKKy5lbmRpZgogLmVsc2UKIFBMSVNUX1NVQis9CU1ZU1FMPSJA
 Y29tbWVudCAiCiAuZW5kaWYKQEAgLTQzLDExICs0NSwxMyBAQAogQ09ORklHVVJFX0FSR1MrPQkt
 LXdpdGgtR2VvSVA9JHtMT0NBTEJBU0V9CiAuZW5kaWYKIAorLmlmICR7UE9SVF9PUFRJT05TOk1N
 QU5QQUdFU30KIE1BTjErPQlyYS4xIHJhYmlucy4xIHJhY2x1c3Rlci4xIHJhY29udmVydC4xIHJh
 Y291bnQuMSByYWR1bXAuMSByYWV2ZW50LjEgXAogCXJhZmlsdGVyYWRkci4xIHJhZ3JhcGguMSBy
 YWdyZXAuMSByYWhpc3RvLjEgcmFsYWJlbC4xIHJhbm9ueW1pemUuMSBcCiAJcmFwYXRoLjEgcmFw
 b2xpY3kuMSByYXNvcnQuMSByYXNwbGl0LjEgcmFzdHJlYW0uMSByYXN0cmlwLjEKIE1BTjU9CXJh
 Y2x1c3Rlci41IHJhZGl1bS5jb25mLjUgcmFsYWJlbC5jb25mLjUgcmFub255bWl6ZS41IHJhcmMu
 NQogTUFOOD0JcmFkaXVtLjgKKy5lbmRpZgogCiBkby1pbnN0YWxsOgogLmZvciBpIGluIHJhIHJh
 YmlucyByYWNsdXN0ZXIgcmFjb252ZXJ0IHJhY291bnQgcmFkaXVtIHJhZHVtcCByYWV2ZW50IFwK
 
 --==========6B827D69DA88A9D5C3E1==========--
 
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Mon Apr 8 16:36:49 UTC 2013 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=177675 
State-Changed-From-To: open->closed 
State-Changed-By: rakuco 
State-Changed-When: Sat May 11 21:38:14 UTC 2013 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=177675 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/177675: commit references a PR
Date: Sat, 11 May 2013 21:38:10 +0000 (UTC)

 Author: rakuco
 Date: Sat May 11 21:37:57 2013
 New Revision: 317919
 URL: http://svnweb.freebsd.org/changeset/ports/317919
 
 Log:
   Fix building with MANPAGES=no.
   
   Turning off the MANPAGES option generates lots of errors on install and
   fatal errors when attempting to create a package.
   
   PR:		ports/177675
   Submitted by:	Craig Leres <leres@ee.lbl.gov>
   Approved by:	Paul Schmehl <pauls@utdallas.edu> (maintainer)
 
 Modified:
   head/net-mgmt/argus3-clients/Makefile
 
 Modified: head/net-mgmt/argus3-clients/Makefile
 ==============================================================================
 --- head/net-mgmt/argus3-clients/Makefile	Sat May 11 21:21:37 2013	(r317918)
 +++ head/net-mgmt/argus3-clients/Makefile	Sat May 11 21:37:57 2013	(r317919)
 @@ -33,7 +33,9 @@ CONFIGURE_ARGS+=	--with-sasl=${LOCALBASE
  .if ${PORT_OPTIONS:MMYSQL}
  USE_MYSQL=	yes
  PLIST_SUB+=	MYSQL=""
 +.if ${PORT_OPTIONS:MMANPAGES}
  MAN1+=		rasql.1 rasqlinsert.1 rasqltimeindex.1
 +.endif
  .else
  PLIST_SUB+=	MYSQL="@comment "
  .endif
 @@ -43,11 +45,13 @@ LIB_DEPENDS+=	GeoIP:${PORTSDIR}/net/GeoI
  CONFIGURE_ARGS+=	--with-GeoIP=${LOCALBASE}
  .endif
  
 +.if ${PORT_OPTIONS:MMANPAGES}
  MAN1+=	ra.1 rabins.1 racluster.1 raconvert.1 racount.1 radump.1 raevent.1 \
  	rafilteraddr.1 ragraph.1 ragrep.1 rahisto.1 ralabel.1 ranonymize.1 \
  	rapath.1 rapolicy.1 rasort.1 rasplit.1 rastream.1 rastrip.1
  MAN5=	racluster.5 radium.conf.5 ralabel.conf.5 ranonymize.5 rarc.5
  MAN8=	radium.8
 +.endif
  
  do-install:
  .for i in ra rabins racluster raconvert racount radium radump raevent \
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
