From rsmith@xs4all.nl  Sun Mar 31 10:14:21 2013
Return-Path: <rsmith@xs4all.nl>
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
	by hub.freebsd.org (Postfix) with ESMTP id 697526CD
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 31 Mar 2013 10:14:21 +0000 (UTC)
	(envelope-from rsmith@xs4all.nl)
Received: from smtp-vbr2.xs4all.nl (smtp-vbr2.xs4all.nl [194.109.24.22])
	by mx1.freebsd.org (Postfix) with ESMTP id 0F6695F9
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 31 Mar 2013 10:14:20 +0000 (UTC)
Received: from slackbox.erewhon.net (slackbox.xs4all.nl [213.84.242.160])
	by smtp-vbr2.xs4all.nl (8.13.8/8.13.8) with ESMTP id r2VAEJn3024622
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 31 Mar 2013 12:14:19 +0200 (CEST)
	(envelope-from rsmith@xs4all.nl)
Received: by slackbox.erewhon.net (Postfix, from userid 1001)
	id CCB5A1233E; Sun, 31 Mar 2013 12:14:18 +0200 (CEST)
Message-Id: <20130331101418.CCB5A1233E@slackbox.erewhon.net>
Date: Sun, 31 Mar 2013 12:14:18 +0200 (CEST)
From: Roland Smith <rsmith@xs4all.nl>
Reply-To: Roland Smith <rsmith@xs4all.nl>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] editors/emacs builds with gtk3 even if gtk2 selected
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         177518
>Category:       ports
>Synopsis:       [patch] editors/emacs builds with gtk3 even if gtk2 selected
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    ashish
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 31 10:20:00 UTC 2013
>Closed-Date:    Tue Apr 02 03:37:05 UTC 2013
>Last-Modified:  Tue Apr  2 03:40:00 UTC 2013
>Originator:     Roland Smith
>Release:        FreeBSD 9.1-RELEASE-p1 amd64
>Organization:
>Environment:
System: FreeBSD slackbox.erewhon.net 9.1-RELEASE-p1 FreeBSD 9.1-RELEASE-p1 #0 r247839: Wed Mar 6 01:08:14 CET 2013 rsmith@slackbox.erewhon.net:/usr/obj/usr/src/sys/GENERIC amd64

	
>Description:
    When building emacs-24.3,3, I realized that it used gtk3, even
	though gtk2 was selected in options. It turns out that this is a
	bug in the port Makefile, which tries to select gtk1 instead of gkt2!
>How-To-Repeat:
	Build the port with both gtk2 and gtk3 installed.
>Fix:
Apply the following small fix to the port Makefile
--- Makefile.orig	2013-03-31 12:02:39.000000000 +0200
+++ Makefile	2013-03-31 12:02:53.000000000 +0200
@@ -102,7 +102,7 @@
 
 .if ${PORT_OPTIONS:MGTK2}
 USE_GNOME+=	gtk20
-CONFIGURE_ARGS+=	--with-x-toolkit=gtk
+CONFIGURE_ARGS+=	--with-x-toolkit=gtk2
 .elif ${PORT_OPTIONS:MGTK3}
 USE_GNOME+=	gtk30
 CONFIGURE_ARGS+=	--with-x-toolkit=gtk3



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->ashish 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Mar 31 10:20:09 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=177518 

From: ashish@FreeBSD.org (Ashish SHUKLA)
To: bug-followup@FreeBSD.org,rsmith@xs4all.nl
Cc:  
Subject: Re: ports/177518: [patch] editors/emacs builds with gtk3 even if gtk2 selected
Date: Sun, 31 Mar 2013 19:11:36 +0530

 --=-=-=
 Content-Type: text/plain
 Content-Transfer-Encoding: quoted-printable
 
 Hi,
 
 Thanks for the noticing. I didn't test all toolkits, and it seems like Emacs
 team decided to change toolkit name for GTK 2.x.
 
 I'll test it, and contact portmgr to get this fix committed.
 
 Thanks
 =2D-=20
 Ashish SHUKLA      | GPG: F682 CDCC 39DC 0FEA E116  20B6 C746 CFA9 E74F A4B0
 Sent from my Emacs
 
 --=-=-=
 Content-Type: application/pgp-signature
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.19 (FreeBSD)
 
 iQIcBAEBCgAGBQJRWD0UAAoJEMdGz6nnT6SwdeMP/3S8CmmJ66+Utf7gjbgJHGku
 3z1xNrhba3z0upg3K7RpTqx+2D1hA9uIe9maJou5UFZny83kWp9h8pwsYl0COk91
 +tNXDYW9Q/SrlnotkFWTZ7ocNyDu+uj1bAfT3M9fv2gg4EloXMLQFEvwZHR4UZKd
 88dl10TkRp4r6JvvKGlJOe1PawEJwB4oD8bQ6iZElvZ9Bgv1blyvRAoG1J2CsTfJ
 PatYg2KWijovQMwVGVRjEmztMLSvqf2A6LiQEOSevn8saybnhs5ORmeFiWNvn6Vx
 FR1FPh83SwXFH2Uy05z8JMwxtqojKODIXTQOJ6eg0cAjvvfKBHhDzGnz7pGnO0sa
 0SwnXfdYW2KBt73gra88BgclluqbViCBp21pJKLgGJTTm7qxf3AQXRg0fLTHi5DD
 pAkA6fAmT4NkP1eb+y46JIjr+8gmEhPVGRsScdfMXA1fWJEfwooz8+1tvp1NkGU7
 ndxuAEXTE5O3ZRNtdutBRWOkToRrvAiRD+r6XjND9tnD79IjNsNmRCNxc/r+RBOn
 lT/eNKKyQhTKScC4o0QkQvPp3x91oQQsMk7bhpcIeZHQgiJZpR565NBSyNQCLHhZ
 eg1UD5lZhObf42ALujT3dhO+14HlArOmKAHl1HUyKIdWAAT3r9ej77LbWEyK74xi
 hiBUTTWba20lTqkZOmmj
 =K7Re
 -----END PGP SIGNATURE-----
 --=-=-=--
State-Changed-From-To: open->closed 
State-Changed-By: ashish 
State-Changed-When: Tue Apr 2 03:37:04 UTC 2013 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=177518 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/177518: commit references a PR
Date: Tue,  2 Apr 2013 03:36:39 +0000 (UTC)

 Author: ashish
 Date: Tue Apr  2 03:36:31 2013
 New Revision: 315658
 URL: http://svnweb.freebsd.org/changeset/ports/315658
 
 Log:
   - Fix dependency on GTK2 for GTK2 option
   
   PR:		ports/177518
   Submitted by:	Roland Smith <rsmith at xs4all.nl>
   Approved by:	portmgr
 
 Modified:
   head/editors/emacs/Makefile
 
 Modified: head/editors/emacs/Makefile
 ==============================================================================
 --- head/editors/emacs/Makefile	Tue Apr  2 01:48:51 2013	(r315657)
 +++ head/editors/emacs/Makefile	Tue Apr  2 03:36:31 2013	(r315658)
 @@ -102,7 +102,7 @@ CONFIGURE_ARGS+=	--without-rsvg
  
  .if ${PORT_OPTIONS:MGTK2}
  USE_GNOME+=	gtk20
 -CONFIGURE_ARGS+=	--with-x-toolkit=gtk
 +CONFIGURE_ARGS+=	--with-x-toolkit=gtk2
  .elif ${PORT_OPTIONS:MGTK3}
  USE_GNOME+=	gtk30
  CONFIGURE_ARGS+=	--with-x-toolkit=gtk3
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
