From nobody@FreeBSD.org  Fri Mar 29 16:51:30 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id E989485D
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 29 Mar 2013 16:51:30 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id C1ED7F5F
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 29 Mar 2013 16:51:30 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r2TGpUe4096772
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 29 Mar 2013 16:51:30 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id r2TGpU6E096767;
	Fri, 29 Mar 2013 16:51:30 GMT
	(envelope-from nobody)
Message-Id: <201303291651.r2TGpU6E096767@red.freebsd.org>
Date: Fri, 29 Mar 2013 16:51:30 GMT
From: Lukasz Wasikowski <lukasz@wasikowski.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: ftp/pure-ftpd start error when lang/perl5.14 has unset USE_PERL
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         177481
>Category:       ports
>Synopsis:       ftp/pure-ftpd start error when lang/perl5.14 has unset USE_PERL
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    sunpoet
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Mar 29 17:00:00 UTC 2013
>Closed-Date:    Mon May 06 17:19:30 UTC 2013
>Last-Modified:  Mon May  6 17:20:01 UTC 2013
>Originator:     Lukasz Wasikowski
>Release:        9.1-STABLE
>Organization:
>Environment:
FreeBSD vesper.wasikowski.net 9.1-STABLE FreeBSD 9.1-STABLE #27 r247781: Tue Mar  5 11:51:35 CET 2013     root@:/usr/obj/usr/src/sys/vesper  i386

>Description:
When lang/perl5.14 is installed without USE_PERL knob then perl binaries are at:

/usr/local/bin/perl
/usr/local/bin/perl5

and there's no symlinks to those in /usr/bin

ftp/pure-ftpd's config parser /usr/local/sbin/pure-config.pl use /usr/bin/env perl as shebang.

When pure-ftpd is started by invoking /usr/local/etc/rc.d/pure-ftpd script everything works ok, as /usr/bin/env perl is expanded to /usr/local/bin/perl

But when pure-ftpd is started by invoking service pure-ftpd start /usr/local/bin is not searched and startup fails.
>How-To-Repeat:
Install lang/perl5.14 with OPTIONS_FILE_UNSET+=USE_PERL

# /usr/local/etc/rc.d/pure-ftpd start
Starting pureftpd.

This worked. Stop the daemon:

# /usr/local/etc/rc.d/pure-ftpd stop
Stopping pureftpd.
Waiting for PIDS: 45876.

Start it via service:

# service pure-ftpd start
Starting pureftpd.
env: perl: No such file or directory
/usr/local/etc/rc.d/pure-ftpd: WARNING: failed to start pureftpd

>Fix:
Attached patch should help.

Patch attached with submission follows:

diff -ruN pure-ftpd.bak/Makefile pure-ftpd/Makefile
--- pure-ftpd.bak/Makefile	2012-12-30 01:46:54.000000000 +0100
+++ pure-ftpd/Makefile	2013-03-29 17:48:28.757265042 +0100
@@ -167,7 +167,7 @@
 	@${ECHO_MSG} ""
 
 post-patch:
-	@${REINPLACE_CMD} -e 's|$${exec_prefix}|${PREFIX}|g' \
+	@${REINPLACE_CMD} -e 's|$${exec_prefix}|${PREFIX}|g' -e 's|@PERL@|${PERL}|g' \
 		${WRKSRC}/configuration-file/pure-config.pl.in
 
 post-install:


>Release-Note:
>Audit-Trail:

From: =?UTF-8?B?xYF1a2FzeiBXxIVzaWtvd3NraQ==?= <lukasz@wasikowski.net>
To: bug-followup@FreeBSD.org, lukasz@wasikowski.net
Cc:  
Subject: Re: misc/177481: ftp/pure-ftpd start error when lang/perl5.14 has
 unset USE_PERL
Date: Fri, 29 Mar 2013 23:03:53 +0100

 Wrong category, please move it to ports-bugs. Sorry for the trouble,
 thank you in advance.
 
 -- 
 best regards,
 Lukasz Wasikowski
Responsible-Changed-From-To: freebsd-bugs->freebsd-ports-bugs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Fri Mar 29 22:32:15 UTC 2013 
Responsible-Changed-Why:  
ports PR. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=177481 
Responsible-Changed-From-To: freebsd-ports-bugs->sunpoet 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Mar 29 22:32:32 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=177481 
State-Changed-From-To: open->closed 
State-Changed-By: sunpoet 
State-Changed-When: Mon May 6 17:19:29 UTC 2013 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=177481 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/177481: commit references a PR
Date: Mon,  6 May 2013 17:16:17 +0000 (UTC)

 Author: sunpoet
 Date: Mon May  6 17:16:05 2013
 New Revision: 317533
 URL: http://svnweb.freebsd.org/changeset/ports/317533
 
 Log:
   - Fix shebang line for users without USE_PERL=yes
   
   PR:		ports/177481
   Submitted by:	Lukasz Wasikowski <lukasz@wasikowski.net>
 
 Modified:
   head/ftp/pure-ftpd/Makefile
 
 Modified: head/ftp/pure-ftpd/Makefile
 ==============================================================================
 --- head/ftp/pure-ftpd/Makefile	Mon May  6 16:57:13 2013	(r317532)
 +++ head/ftp/pure-ftpd/Makefile	Mon May  6 17:16:05 2013	(r317533)
 @@ -167,8 +167,7 @@ pre-fetch:
  	@${ECHO_MSG} ""
  
  post-patch:
 -	@${REINPLACE_CMD} -e 's|$${exec_prefix}|${PREFIX}|g' \
 -		${WRKSRC}/configuration-file/pure-config.pl.in
 +	@${REINPLACE_CMD} -e 's|@PERL@|${PERL}|; s|$${exec_prefix}|${PREFIX}|g' ${WRKSRC}/configuration-file/pure-config.pl.in
  
  post-install:
  	${INSTALL_DATA} ${WRKSRC}/pureftpd-ldap.conf ${PREFIX}/etc/pureftpd-ldap.conf.sample
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
