From umq.876@gmail.com  Thu Mar 21 04:43:09 2013
Return-Path: <umq.876@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id 7780C23B;
	Thu, 21 Mar 2013 04:43:09 +0000 (UTC)
	(envelope-from umq.876@gmail.com)
Received: from mail-da0-x22b.google.com (mail-da0-x22b.google.com [IPv6:2607:f8b0:400e:c00::22b])
	by mx1.freebsd.org (Postfix) with ESMTP id 4F9F280B;
	Thu, 21 Mar 2013 04:43:09 +0000 (UTC)
Received: by mail-da0-f43.google.com with SMTP id u36so1413363dak.30
        for <multiple recipients>; Wed, 20 Mar 2013 21:43:09 -0700 (PDT)
Received: from nafbsd2.m.nd.to (p057007.dynamic.ppp.asahi-net.or.jp. [221.113.57.7])
        by mx.google.com with ESMTPS id zv3sm4885037pab.0.2013.03.20.21.37.36
        (version=TLSv1 cipher=RC4-SHA bits=128/128);
        Wed, 20 Mar 2013 21:37:38 -0700 (PDT)
Message-Id: <86y5dhcqs0.wl%umq@ueo.co.jp>
Date: Thu, 21 Mar 2013 13:37:03 +0900
From: Hirohisa Yamaguchi <umq@ueo.co.jp>
Sender: Hirohisa Yamaguchi <umq.876@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc: bdrewery@FreeBSD.org
Subject: Tools/scripts/dialog4ports.sh should ignore custom PREFIX upon ports-mgmt/dialog4ports installation
X-Send-Pr-Version: 3.113

>Number:         177174
>Category:       ports
>Synopsis:       Tools/scripts/dialog4ports.sh should ignore custom PREFIX upon ports-mgmt/dialog4ports installation
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    bdrewery
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 21 04:50:00 UTC 2013
>Closed-Date:    Thu Mar 21 06:13:53 CDT 2013
>Last-Modified:  Thu Mar 21 11:20:00 UTC 2013
>Originator:     Hirohisa Yamaguchi
>Release:        FreeBSD 8.3-RELEASE-p3 amd64
>Organization:
<organization of PR author (multiple lines)>
>Environment:
System: FreeBSD **** 8.3-RELEASE-p3 FreeBSD 8.3-RELEASE-p3 #0: Tue Jun 12 00:39:29 UTC 2012 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64

>Description:
	installation of ports-mgmt/dialog4ports using dialog4ports.sh
	should ignore custom PREFIX.

>How-To-Repeat:
	for example:
		mkdir -p /var/tmp/foo
		make -C /usr/ports/print/ghostscript9 config PREFIX=/var/tmp/foo
	will be like following.

	===>  Checking if ports-mgmt/dialog4ports already installed
	install -s -o root -g wheel -m 555   dialog4ports /var/tmp/foo/bin
	install -o root -g wheel -m 444 dialog4ports.1.gz  /var/tmp/foo/man/man1
	===>   Registering installation for dialog4ports-0.1
	Installing dialog4ports-0.1... done
	===>  Cleaning for dialog4ports-0.1
	exec: /usr/local/bin/dialog4ports: not found
	===> Options unchanged

>Fix:

	dunno.
	pass PREFIX=${LOCALBASE} ?


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->portmgr 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Mar 21 04:50:09 UTC 2013 
Responsible-Changed-Why:  
portmgr@ wants this port PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=177174 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Mar 21 04:50:11 UTC 2013 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=177174 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: Cc: bug-followup@FreeBSD.org
Subject: Re: ports/177174: Tools/scripts/dialog4ports.sh should ignore custom PREFIX upon ports-mgmt/dialog4ports installation
Date: Thu, 21 Mar 2013 04:50:10 UT

 Maintainer of Tools/scripts,
 
 Please note that PR ports/177174 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/177174
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: portmgr->bdrewery 
Responsible-Changed-By: bdrewery 
Responsible-Changed-When: Thu Mar 21 05:46:58 CDT 2013 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=177174 
State-Changed-From-To: feedback->closed 
State-Changed-By: bdrewery 
State-Changed-When: Thu Mar 21 06:13:52 CDT 2013 
State-Changed-Why:  
Fixed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=177174 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/177174: commit references a PR
Date: Thu, 21 Mar 2013 11:14:02 +0000 (UTC)

 Author: bdrewery
 Date: Thu Mar 21 11:13:49 2013
 New Revision: 314836
 URL: http://svnweb.freebsd.org/changeset/ports/314836
 
 Log:
   - Fix dialog4ports missing when PREFIX!=LOCALBASE
   
   PR:		ports/177174
   Reported by:	Hirohisa Yamaguchi <umq@ueo.co.jp>
   With hat:	portmgr
 
 Modified:
   head/Mk/bsd.port.mk
   head/Tools/scripts/dialog4ports.sh
 
 Modified: head/Mk/bsd.port.mk
 ==============================================================================
 --- head/Mk/bsd.port.mk	Thu Mar 21 10:50:54 2013	(r314835)
 +++ head/Mk/bsd.port.mk	Thu Mar 21 11:13:49 2013	(r314836)
 @@ -6099,6 +6099,8 @@ D4P_ENV=	PKGNAME="${PKGNAME}" \
  		OPTIONS_RADIO="${OPTIONS_RADIO}" \
  		OPTIONS_GROUP="${OPTIONS_GROUP}" \
  		DIALOG4PORTS="${DIALOG4PORTS}" \
 +		PREFIX="${PREFIX}" \
 +		LOCALBASE="${LOCALBASE}" \
  		PORTSDIR="${PORTSDIR}" \
  		MAKE="${MAKE}" \
  		D4PHEIGHT="${D4PHEIGHT}" \
 
 Modified: head/Tools/scripts/dialog4ports.sh
 ==============================================================================
 --- head/Tools/scripts/dialog4ports.sh	Thu Mar 21 10:50:54 2013	(r314835)
 +++ head/Tools/scripts/dialog4ports.sh	Thu Mar 21 11:13:49 2013	(r314836)
 @@ -15,7 +15,9 @@ OPTIONSFILE="$1"
  
  if ! [ -e $DIALOG4PORTS ]; then
  	# If INSTALL_AS_USER is set then just build and use the WRKDIR version
 -	if [ -n "${INSTALL_AS_USER}" ]; then
 +	# Also do this if PREFIX!=LOCALBASE to avoid missing file or double
 +	# installs
 +	if [ -n "${INSTALL_AS_USER}" -o "${PREFIX}" != "${LOCALBASE}" ]; then
  		if ! [ -d "${PORTSDIR}/${DIALOGPORT}" ]; then
  			echo "===> Skipping 'config' as ${DIALOGPORT} is not checked out" >&2
  			exit 1
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
