From john.marshall@riverwillow.com.au  Tue Mar 19 01:36:52 2013
Return-Path: <john.marshall@riverwillow.com.au>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id 2AF8E3A7
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 19 Mar 2013 01:36:52 +0000 (UTC)
	(envelope-from john.marshall@riverwillow.com.au)
Received: from mail1.riverwillow.net.au (mail1.riverwillow.net.au [203.58.93.36])
	by mx1.freebsd.org (Postfix) with ESMTP id 70C529FF
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 19 Mar 2013 01:36:51 +0000 (UTC)
Received: from mail3.riverwillow.net.au (svcs1.riverwillow.net.au [203.58.93.40])
	by mail1.riverwillow.net.au (8.14.6/8.14.6) with ESMTP id r2J1adlJ084788
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 19 Mar 2013 12:36:40 +1100 (AEDT)
Received: from rwsrv08.mby.riverwillow.net.au (localhost [127.0.0.1])
	by mail3.riverwillow.net.au (8.14.6/8.14.6) with ESMTP id r2J1aZp0036219
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 19 Mar 2013 12:36:35 +1100 (EST)
Received: (from john@localhost)
	by rwsrv08.mby.riverwillow.net.au (8.14.6/8.14.6/Submit) id r2J1aYan036218;
	Tue, 19 Mar 2013 12:36:34 +1100 (EST)
Message-Id: <201303190136.r2J1aYan036218@rwsrv08.mby.riverwillow.net.au>
Date: Tue, 19 Mar 2013 12:36:34 +1100 (EST)
From: John Marshall <john.marshall@riverwillow.com.au>
Reply-To: John Marshall <john.marshall@riverwillow.com.au>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] mail/milter-greylist loses dumpfile following upgrade
X-Send-Pr-Version: 3.113
X-GNATS-Notify: m.tsatsenko@gmail.com

>Number:         177097
>Category:       ports
>Synopsis:       [PATCH] mail/milter-greylist loses dumpfile following upgrade
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    ume
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 19 01:40:00 UTC 2013
>Closed-Date:    Wed Mar 20 16:16:14 UTC 2013
>Last-Modified:  Wed Mar 20 16:16:14 UTC 2013
>Originator:     John Marshall
>Release:        FreeBSD 9.1-RELEASE-p1 amd64
>Organization:
Riverwillow Pty Ltd
>Environment:
System: FreeBSD rwsrv08.mby.riverwillow.net.au 9.1-RELEASE-p1 FreeBSD 9.1-RELEASE-p1 #0 r248445: Mon Mar 18 12:35:45 AEDT 2013 root@rwsrv08.mby.riverwillow.net.au:/usr/obj/usr/src/sys/RWSRV08 amd64


	
>Description:

Following upgrade to 4.4.1, milter-greylist looks for its dumpfile in a
different (non-existent) location...

  milter-greylist: cannot read dumpfile "/usr/local/var/milter-greylist/greylist.db"
  milter-greylist: starting with an empty greylist

The problem arises because the configure.ac defines the default dumpfile
location as ${prefix}/var...  We could patch config files but since the
port already hard-codes the expected dumpfile location in the Makefile,
I suggest we just use the configure argument to pass that location to
the build.  The attached patch addes that configure argument.

I notice that ports/176950 (4.4.3 update) is in progress.  Perhaps this
patch could augment the commit for that PR?

Thank you for maintaining this port.

>How-To-Repeat:
	
>Fix:

	

--- milter-greylist.diff begins here ---
Index: mail/milter-greylist/Makefile
===================================================================
--- mail/milter-greylist/Makefile	(revision 314609)
+++ mail/milter-greylist/Makefile	(working copy)
@@ -74,8 +74,9 @@
 LIBS+=		${PTHREAD_LIBS}
 
 GNU_CONFIGURE=	yes
-CONFIGURE_ARGS+=	--with-user=mailnull --with-libmilter=${MILTERBASE} \
-			--enable-dnsrbl --with-thread-safe-resolver
+CONFIGURE_ARGS+=	--with-user=mailnull --with-libmilter=${MILTERBASE}	\
+			--enable-dnsrbl --with-thread-safe-resolver		\
+			--with-dumpfile=/var/milter-greylist/greylist.db
 CONFIGURE_ENV+=	LIBS="${LIBS}"
 
 ALL_TARGET=	milter-greylist
--- milter-greylist.diff ends here ---


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Mar 19 01:40:09 UTC 2013 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=177097 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: m.tsatsenko@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/177097: [PATCH] mail/milter-greylist loses dumpfile following upgrade
Date: Tue, 19 Mar 2013 01:40:08 UT

 Maintainer of mail/milter-greylist,
 
 Please note that PR ports/177097 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/177097
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/177097: commit references a PR
Date: Wed, 20 Mar 2013 15:51:25 +0000 (UTC)

 Author: ume
 Date: Wed Mar 20 15:51:13 2013
 New Revision: 314741
 URL: http://svnweb.freebsd.org/changeset/ports/314741
 
 Log:
   Correct dumpfile location.
   
   PR:		ports/177097
   Submitted by:	John Marshall <john.marshall__at__riverwillow.com.au>
   Reviewed by:	Mikhail Tsatsenko <m.tsatsenko__at__gmail.com> (maintainer)
   Approved by:	Mikhail Tsatsenko <m.tsatsenko__at__gmail.com> (maintainer)
 
 Modified:
   head/mail/milter-greylist/Makefile
 
 Modified: head/mail/milter-greylist/Makefile
 ==============================================================================
 --- head/mail/milter-greylist/Makefile	Wed Mar 20 15:22:04 2013	(r314740)
 +++ head/mail/milter-greylist/Makefile	Wed Mar 20 15:51:13 2013	(r314741)
 @@ -75,7 +75,8 @@ LIBS+=		${PTHREAD_LIBS}
  
  GNU_CONFIGURE=	yes
  CONFIGURE_ARGS+=	--with-user=mailnull --with-libmilter=${MILTERBASE} \
 -			--enable-dnsrbl --with-thread-safe-resolver
 +			--enable-dnsrbl --with-thread-safe-resolver \
 +			--with-dumpfile=/var/milter-greylist/greylist.db
  CONFIGURE_ENV+=	LIBS="${LIBS}"
  
  ALL_TARGET=	milter-greylist
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->closed 
State-Changed-By: ume 
State-Changed-When: Wed Mar 20 16:14:55 UTC 2013 
State-Changed-Why:  
Thanks committed! 


Responsible-Changed-From-To: freebsd-ports-bugs->ume 
Responsible-Changed-By: ume 
Responsible-Changed-When: Wed Mar 20 16:14:55 UTC 2013 
Responsible-Changed-Why:  
Thanks committed! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=177097 
>Unformatted:
