From nemysis@gmx.ch  Fri Mar 15 21:49:51 2013
Return-Path: <nemysis@gmx.ch>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id D342EDAE
	for <freebsd-gnats-submit@freebsd.org>; Fri, 15 Mar 2013 21:49:51 +0000 (UTC)
	(envelope-from nemysis@gmx.ch)
Received: from mout.gmx.net (mout.gmx.net [212.227.15.18])
	by mx1.freebsd.org (Postfix) with ESMTP id C46E67F3
	for <freebsd-gnats-submit@freebsd.org>; Fri, 15 Mar 2013 21:49:50 +0000 (UTC)
Received: from mailout-de.gmx.net ([10.1.76.19]) by mrigmx.server.lan
 (mrigmx001) with ESMTP (Nemesis) id 0MVXbV-1UEmWq0At5-00Z19K for
 <FreeBSD-gnats-submit@freebsd.org>; Fri, 15 Mar 2013 22:49:47 +0100
Received: (qmail invoked by alias); 15 Mar 2013 21:49:45 -0000
Received: from 38-21.104-92.cust.bluewin.ch (EHLO something.email.com) [92.104.21.38]
  by mail.gmx.net (mp019) with SMTP; 15 Mar 2013 22:49:45 +0100
Received: by something.email.com (sSMTP sendmail emulation); Fri, 15 Mar 2013 22:49:45 +0100
Message-Id: <20130315214951.D342EDAE@hub.freebsd.org>
Date: Fri, 15 Mar 2013 22:49:45 +0100
From: nemysis <nemysis@gmx.ch>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [MAINTAINER] devel/allegro-devel: OptionsNG, Port is now safe with NOPORTDOCS=yes
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         177004
>Category:       ports
>Synopsis:       [MAINTAINER] devel/allegro-devel: OptionsNG, Port is now safe with NOPORTDOCS=yes
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    beech
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Mar 15 21:50:00 UTC 2013
>Closed-Date:    Sun Mar 17 05:56:25 UTC 2013
>Last-Modified:  Sun Mar 17 06:00:00 UTC 2013
>Originator:     nemysis
>Release:        FreeBSD 9.1-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD FreeBSD_Ports 9.1-RELEASE FreeBSD 9.1-RELEASE #0 r243825: Tue Dec  4 09:23:10
>Description:

Makefile changed:

+.include <bsd.port.options.mk>
+.if ${PORT_OPTIONS:MDOCS}
+.include "Makefile.man"
+PORTDOCS=	*
+INFO=		allegro
+.endif

+post-patch: <-- to not install DOCS, Man, info
+.if ! ${PORT_OPTIONS:MDOCS}
+	 @${REINPLACE_CMD} -e 's|add_subdirectory(docs)|#add_subdirectory(docs)|' ${WRKSRC}/CMakeLists.txt
+.endif

Changed and refined:
 pkg-plist <-- clean, not more PORTDOCS

Generated and tested manually, tested with port test, sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
>How-To-Repeat:

portlint -A
looks fine.

Port is now safe with NOPORTDOCS=yes in /etc/make.conf

port test: clean

>Fix:

--- allegro-devel-4.4.2_1.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/devel/allegro-devel/Makefile ./Makefile
--- /usr/ports/devel/allegro-devel/Makefile	2013-01-14 17:54:06.000000000 +0100
+++ ./Makefile	2013-03-15 22:35:17.000000000 +0100
@@ -2,6 +2,7 @@
 
 PORTNAME=	allegro
 DISTVERSION=	4.4.2
+PORTREVISION=	1
 CATEGORIES=	devel
 MASTER_SITES=	SF/alleg/allegro/${PORTVERSION}
 PKGNAMESUFFIX=	-devel
@@ -19,9 +20,6 @@
 
 MAKE_JOBS_UNSAFE=	yes
 
-.include "Makefile.man"
-INFO=		allegro
-
 CONFLICTS=	allegro-[0-9]*
 LATEST_LINK=	${PORTNAME}${PKGNAMESUFFIX}
 PLIST_SUB=	SHLIB_VER="${SHLIB_VER}"
@@ -36,8 +34,23 @@
 		jack.0:${PORTSDIR}/audio/jack \
 		png15:${PORTSDIR}/graphics/png
 
+.include <bsd.port.options.mk>
+
+.if ${PORT_OPTIONS:MDOCS}
+.include "Makefile.man"
+PORTDOCS=	*
+INFO=		allegro
+.endif
+
+post-patch:
+.if ! ${PORT_OPTIONS:MDOCS}
+	 @${REINPLACE_CMD} -e 's|add_subdirectory(docs)|#add_subdirectory(docs)|' ${WRKSRC}/CMakeLists.txt
+.endif
+
 post-install:
+.if ${PORT_OPTIONS:MDOCS}
 	@cd ${WRKSRC}/docs/man/ && \
 		${FIND} . -type f -and -name "*.3" -exec ${INSTALL_MAN} {} ${PREFIX}/man/man3/{} \;
+.endif
 
 .include <bsd.port.mk>
diff -ruN --exclude=CVS /usr/ports/devel/allegro-devel/pkg-plist ./pkg-plist
--- /usr/ports/devel/allegro-devel/pkg-plist	2013-01-14 17:54:06.000000000 +0100
+++ ./pkg-plist	2013-03-15 21:57:15.000000000 +0100
@@ -132,28 +132,6 @@
 libdata/pkgconfig/jpgalleg.pc
 libdata/pkgconfig/loadpng.pc
 libdata/pkgconfig/logg.pc
-%%PORTDOCS%%%%DOCSDIR%%/AUTHORS
-%%PORTDOCS%%%%DOCSDIR%%/CHANGES
-%%PORTDOCS%%%%DOCSDIR%%/THANKS
-%%PORTDOCS%%%%DOCSDIR%%/abi.txt
-%%PORTDOCS%%%%DOCSDIR%%/addons.txt
-%%PORTDOCS%%%%DOCSDIR%%/ahack.txt
-%%PORTDOCS%%%%DOCSDIR%%/allegro.txt
-%%PORTDOCS%%%%DOCSDIR%%/api.txt
-%%PORTDOCS%%%%DOCSDIR%%/const.txt
-%%PORTDOCS%%%%DOCSDIR%%/dat.txt
-%%PORTDOCS%%%%DOCSDIR%%/dat2c.txt
-%%PORTDOCS%%%%DOCSDIR%%/dat2s.txt
-%%PORTDOCS%%%%DOCSDIR%%/datafile.txt
-%%PORTDOCS%%%%DOCSDIR%%/faq.txt
-%%PORTDOCS%%%%DOCSDIR%%/grabber.txt
-%%PORTDOCS%%%%DOCSDIR%%/help.txt
-%%PORTDOCS%%%%DOCSDIR%%/license.txt
-%%PORTDOCS%%%%DOCSDIR%%/makedoc.txt
-%%PORTDOCS%%%%DOCSDIR%%/mistakes.txt
-%%PORTDOCS%%%%DOCSDIR%%/packfile.txt
-%%PORTDOCS%%%%DOCSDIR%%/readme.txt
-%%PORTDOCS%%@dirrm %%DOCSDIR%%
 @dirrm lib/allegro/%%SHLIB_VER%%
 @dirrm lib/allegro
 @dirrm include/allegrogl/GLext
--- allegro-devel-4.4.2_1.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->beech 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Mar 15 21:50:12 UTC 2013 
Responsible-Changed-Why:  
beech@ wants this submitter's PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=177004 

From: nemysis <nemysis@gmx.ch>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/177004: [MAINTAINER] devel/allegro-devel: OptionsNG, Port
 is now safe with NOPORTDOCS=yes
Date: Sat, 16 Mar 2013 14:37:01 +0100

 --MP_/d0bJ+8Ds1bC0AcCCDjFTioG
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 Move PORTDOCS= from .if variable to the top Makefile, sorry.
 --MP_/d0bJ+8Ds1bC0AcCCDjFTioG
 Content-Type: text/x-patch
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment; filename=allegro-devel.diff
 
 ===> Generating patch
 ===> Viewing diff with more
 diff -ruN --exclude=CVS /usr/ports/devel/allegro-devel/Makefile ./Makefile
 --- /usr/ports/devel/allegro-devel/Makefile	2013-01-14 17:54:06.000000000 +0100
 +++ ./Makefile	2013-03-16 14:19:40.000000000 +0100
 @@ -2,6 +2,7 @@
  
  PORTNAME=	allegro
  DISTVERSION=	4.4.2
 +PORTREVISION=	1
  CATEGORIES=	devel
  MASTER_SITES=	SF/alleg/allegro/${PORTVERSION}
  PKGNAMESUFFIX=	-devel
 @@ -19,8 +20,7 @@
  
  MAKE_JOBS_UNSAFE=	yes
  
 -.include "Makefile.man"
 -INFO=		allegro
 +PORTDOCS=	*
  
  CONFLICTS=	allegro-[0-9]*
  LATEST_LINK=	${PORTNAME}${PKGNAMESUFFIX}
 @@ -36,8 +36,22 @@
  		jack.0:${PORTSDIR}/audio/jack \
  		png15:${PORTSDIR}/graphics/png
  
 +.include <bsd.port.options.mk>
 +
 +.if ${PORT_OPTIONS:MDOCS}
 +.include "Makefile.man"
 +INFO=		allegro
 +.endif
 +
 +post-patch:
 +.if ! ${PORT_OPTIONS:MDOCS}
 +	 @${REINPLACE_CMD} -e 's|add_subdirectory(docs)|#add_subdirectory(docs)|' ${WRKSRC}/CMakeLists.txt
 +.endif
 +
  post-install:
 +.if ${PORT_OPTIONS:MDOCS}
  	@cd ${WRKSRC}/docs/man/ && \
  		${FIND} . -type f -and -name "*.3" -exec ${INSTALL_MAN} {} ${PREFIX}/man/man3/{} \;
 +.endif
  
  .include <bsd.port.mk>
 diff -ruN --exclude=CVS /usr/ports/devel/allegro-devel/pkg-plist ./pkg-plist
 --- /usr/ports/devel/allegro-devel/pkg-plist	2013-01-14 17:54:06.000000000 +0100
 +++ ./pkg-plist	2013-03-15 21:57:15.000000000 +0100
 @@ -132,28 +132,6 @@
  libdata/pkgconfig/jpgalleg.pc
  libdata/pkgconfig/loadpng.pc
  libdata/pkgconfig/logg.pc
 -%%PORTDOCS%%%%DOCSDIR%%/AUTHORS
 -%%PORTDOCS%%%%DOCSDIR%%/CHANGES
 -%%PORTDOCS%%%%DOCSDIR%%/THANKS
 -%%PORTDOCS%%%%DOCSDIR%%/abi.txt
 -%%PORTDOCS%%%%DOCSDIR%%/addons.txt
 -%%PORTDOCS%%%%DOCSDIR%%/ahack.txt
 -%%PORTDOCS%%%%DOCSDIR%%/allegro.txt
 -%%PORTDOCS%%%%DOCSDIR%%/api.txt
 -%%PORTDOCS%%%%DOCSDIR%%/const.txt
 -%%PORTDOCS%%%%DOCSDIR%%/dat.txt
 -%%PORTDOCS%%%%DOCSDIR%%/dat2c.txt
 -%%PORTDOCS%%%%DOCSDIR%%/dat2s.txt
 -%%PORTDOCS%%%%DOCSDIR%%/datafile.txt
 -%%PORTDOCS%%%%DOCSDIR%%/faq.txt
 -%%PORTDOCS%%%%DOCSDIR%%/grabber.txt
 -%%PORTDOCS%%%%DOCSDIR%%/help.txt
 -%%PORTDOCS%%%%DOCSDIR%%/license.txt
 -%%PORTDOCS%%%%DOCSDIR%%/makedoc.txt
 -%%PORTDOCS%%%%DOCSDIR%%/mistakes.txt
 -%%PORTDOCS%%%%DOCSDIR%%/packfile.txt
 -%%PORTDOCS%%%%DOCSDIR%%/readme.txt
 -%%PORTDOCS%%@dirrm %%DOCSDIR%%
  @dirrm lib/allegro/%%SHLIB_VER%%
  @dirrm lib/allegro
  @dirrm include/allegrogl/GLext
 ===> Done
 
 --MP_/d0bJ+8Ds1bC0AcCCDjFTioG--
State-Changed-From-To: open->closed 
State-Changed-By: beech 
State-Changed-When: Sun Mar 17 05:56:08 UTC 2013 
State-Changed-Why:  
Committed, Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=177004 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/177004: commit references a PR
Date: Sun, 17 Mar 2013 05:55:55 +0000 (UTC)

 Author: beech
 Date: Sun Mar 17 05:55:42 2013
 New Revision: 314398
 URL: http://svnweb.freebsd.org/changeset/ports/314398
 
 Log:
   - Makefile tweaks
   - Convert to OptionsNG
   
   PR:		ports/177004
   Submitted by:	nemysis <nemysis@gmx.ch> (maintainer)
 
 Modified:
   head/devel/allegro-devel/Makefile   (contents, props changed)
   head/devel/allegro-devel/pkg-plist   (contents, props changed)
 
 Modified: head/devel/allegro-devel/Makefile
 ==============================================================================
 --- head/devel/allegro-devel/Makefile	Sun Mar 17 05:53:53 2013	(r314397)
 +++ head/devel/allegro-devel/Makefile	Sun Mar 17 05:55:42 2013	(r314398)
 @@ -2,6 +2,7 @@
  
  PORTNAME=	allegro
  DISTVERSION=	4.4.2
 +PORTREVISION=	1
  CATEGORIES=	devel
  MASTER_SITES=	SF/alleg/allegro/${PORTVERSION}
  PKGNAMESUFFIX=	-devel
 @@ -19,8 +20,7 @@ USE_GL=		gl glu
  
  MAKE_JOBS_UNSAFE=	yes
  
 -.include "Makefile.man"
 -INFO=		allegro
 +PORTDOCS=	*
  
  CONFLICTS=	allegro-[0-9]*
  LATEST_LINK=	${PORTNAME}${PKGNAMESUFFIX}
 @@ -36,8 +36,22 @@ LIB_DEPENDS+=	asound.2:${PORTSDIR}/audio
  		jack.0:${PORTSDIR}/audio/jack \
  		png15:${PORTSDIR}/graphics/png
  
 +.include <bsd.port.options.mk>
 +
 +.if ${PORT_OPTIONS:MDOCS}
 +.include "Makefile.man"
 +INFO=		allegro
 +.endif
 +
 +post-patch:
 +.if ! ${PORT_OPTIONS:MDOCS}
 +	 @${REINPLACE_CMD} -e 's|add_subdirectory(docs)|#add_subdirectory(docs)|' ${WRKSRC}/CMakeLists.txt
 +.endif
 +
  post-install:
 +.if ${PORT_OPTIONS:MDOCS}
  	@cd ${WRKSRC}/docs/man/ && \
  		${FIND} . -type f -and -name "*.3" -exec ${INSTALL_MAN} {} ${PREFIX}/man/man3/{} \;
 +.endif
  
  .include <bsd.port.mk>
 
 Modified: head/devel/allegro-devel/pkg-plist
 ==============================================================================
 --- head/devel/allegro-devel/pkg-plist	Sun Mar 17 05:53:53 2013	(r314397)
 +++ head/devel/allegro-devel/pkg-plist	Sun Mar 17 05:55:42 2013	(r314398)
 @@ -132,28 +132,6 @@ libdata/pkgconfig/allegrogl.pc
  libdata/pkgconfig/jpgalleg.pc
  libdata/pkgconfig/loadpng.pc
  libdata/pkgconfig/logg.pc
 -%%PORTDOCS%%%%DOCSDIR%%/AUTHORS
 -%%PORTDOCS%%%%DOCSDIR%%/CHANGES
 -%%PORTDOCS%%%%DOCSDIR%%/THANKS
 -%%PORTDOCS%%%%DOCSDIR%%/abi.txt
 -%%PORTDOCS%%%%DOCSDIR%%/addons.txt
 -%%PORTDOCS%%%%DOCSDIR%%/ahack.txt
 -%%PORTDOCS%%%%DOCSDIR%%/allegro.txt
 -%%PORTDOCS%%%%DOCSDIR%%/api.txt
 -%%PORTDOCS%%%%DOCSDIR%%/const.txt
 -%%PORTDOCS%%%%DOCSDIR%%/dat.txt
 -%%PORTDOCS%%%%DOCSDIR%%/dat2c.txt
 -%%PORTDOCS%%%%DOCSDIR%%/dat2s.txt
 -%%PORTDOCS%%%%DOCSDIR%%/datafile.txt
 -%%PORTDOCS%%%%DOCSDIR%%/faq.txt
 -%%PORTDOCS%%%%DOCSDIR%%/grabber.txt
 -%%PORTDOCS%%%%DOCSDIR%%/help.txt
 -%%PORTDOCS%%%%DOCSDIR%%/license.txt
 -%%PORTDOCS%%%%DOCSDIR%%/makedoc.txt
 -%%PORTDOCS%%%%DOCSDIR%%/mistakes.txt
 -%%PORTDOCS%%%%DOCSDIR%%/packfile.txt
 -%%PORTDOCS%%%%DOCSDIR%%/readme.txt
 -%%PORTDOCS%%@dirrm %%DOCSDIR%%
  @dirrm lib/allegro/%%SHLIB_VER%%
  @dirrm lib/allegro
  @dirrm include/allegrogl/GLext
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
