From lchen@zen.lhaven.homeip.net  Thu Mar 14 17:56:44 2013
Return-Path: <lchen@zen.lhaven.homeip.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id 45D31695
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 14 Mar 2013 17:56:44 +0000 (UTC)
	(envelope-from lchen@zen.lhaven.homeip.net)
Received: from mho-02-ewr.mailhop.org (mho-04-ewr.mailhop.org [204.13.248.74])
	by mx1.freebsd.org (Postfix) with ESMTP id 15842FF3
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 14 Mar 2013 17:56:43 +0000 (UTC)
Received: from ip70-179-144-108.fv.ks.cox.net ([70.179.144.108] helo=zen.lhaven.homeip.net)
	by mho-02-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256)
	(Exim 4.72)
	(envelope-from <lchen@zen.lhaven.homeip.net>)
	id 1UGCOL-0001Om-JE
	for FreeBSD-gnats-submit@freebsd.org; Thu, 14 Mar 2013 17:56:37 +0000
Received: from zen.lhaven.homeip.net (localhost [127.0.0.1])
	by zen.lhaven.homeip.net (8.14.6/8.14.5) with ESMTP id r2EHuQpJ047498;
	Thu, 14 Mar 2013 12:56:26 -0500 (CDT)
	(envelope-from lchen@zen.lhaven.homeip.net)
Received: (from lchen@localhost)
	by zen.lhaven.homeip.net (8.14.6/8.14.5/Submit) id r2EHuPsh047496;
	Thu, 14 Mar 2013 12:56:25 -0500 (CDT)
	(envelope-from lchen)
Message-Id: <201303141756.r2EHuPsh047496@zen.lhaven.homeip.net>
Date: Thu, 14 Mar 2013 12:56:25 -0500 (CDT)
From: Lawrence Chen <beastie@tardisi.com>
Reply-To: Lawrence Chen <beastie@tardisi.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc: beastie_t@zen.lhaven.homeip.net
Subject: x11-toolkits/vte: need update after gtk2 update
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         176963
>Category:       ports
>Synopsis:       x11-toolkits/vte: need update after gtk2 update
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 14 18:00:00 UTC 2013
>Closed-Date:    Fri Mar 15 21:39:49 UTC 2013
>Last-Modified:  Fri Mar 15 21:40:00 UTC 2013
>Originator:     Lawrence Chen
>Release:        FreeBSD 9.1-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD zen.lhaven.homeip.net 9.1-RELEASE FreeBSD 9.1-RELEASE #0 r243825: Tue Dec 4 09:23:10 UTC 2012 root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64


	
>Description:
	After the update of gtk20, alt key is not working in gnome-terminal.
	
>How-To-Repeat:
        Run an application that uses alt keys - such as irssi in a
	gnome-terminal where alt keys used to work, update gtk20 now they don't.
	
>Fix:
	After rebuild various ports and then some online searching, I found
	this:

	https://ask.fedoraproject.org/question/7768/after-update-to-gtk2-2248-2-meta-and-alt-keys-no-longer-works/

	Where it appears this: https://bugzilla.gnome.org/show_bug.cgi?id=663779

	suggests that updating vte is needed to restore alt key usage.  The
	discussions refer to a patched 0.28.2. (not sure what the patch is yet.)

	Which is probably necessary because that's the last version that
	supports GTK2 and the fix for #663779 is in 0.32.2.

	


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gnome 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Mar 14 18:00:08 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176963 

From: The BSD Dreamer <beastie@tardisi.com>
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org
Cc:  
Subject: Re: ports/176963: x11-toolkits/vte: need update after gtk2 update
Date: Thu, 14 Mar 2013 16:16:01 -0500

 This is a multi-part message in MIME format.
 --------------030108000100010600010607
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 
 Well, I tracked down the patch for #663779 and applied it to the current
 vte-0.26.2, and starting a new gnome-terminal (and without having kill all my
 other instances) found the ALT key is working as expected in this new
 gnome-terminal.
 
 --------------030108000100010600010607
 Content-Type: text/x-csrc;
  name="patch-src_vte.c"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="patch-src_vte.c"
 
 --- src/vte.c.orig	2010-11-13 06:18:41.000000000 -0600
 +++ src/vte.c	2013-03-14 15:59:37.761401135 -0500
 @@ -4914,16 +4914,23 @@
  vte_terminal_read_modifiers (VteTerminal *terminal,
  			     GdkEvent    *event)
  {
 +	GdkKeymap *keymap;
  	GdkModifierType modifiers;
  
  	/* Read the modifiers. */
 -	if (gdk_event_get_state((GdkEvent*)event, &modifiers)) {
 -		GdkKeymap *keymap;
 -		keymap = gdk_keymap_get_for_display (
 -				gdk_drawable_get_display (((GdkEventAny *)event)->window));
 -		gdk_keymap_add_virtual_modifiers (keymap, &modifiers);
 -		terminal->pvt->modifiers = modifiers;
 -	}
 +	if (!gdk_event_get_state((GdkEvent*)event, &modifiers))
 +		return;
 +
 +	keymap = gdk_keymap_get_for_display (
 +			gdk_window_get_display (((GdkEventAny*)event)->window));
 +
 +	gdk_keymap_add_virtual_modifiers (keymap, &modifiers);
 +
 +	/* HACK! Treat ALT as META; see bug #663779. */
 +	if (modifiers & GDK_MOD1_MASK)
 +		modifiers |= VTE_META_MASK;
 +
 +	terminal->pvt->modifiers = modifiers;
  }
  
  /* Read and handle a keypress event. */
 
 --------------030108000100010600010607--
State-Changed-From-To: open->closed 
State-Changed-By: kwm 
State-Changed-When: Fri Mar 15 21:39:38 UTC 2013 
State-Changed-Why:  
Committed thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176963 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/176963: commit references a PR
Date: Fri, 15 Mar 2013 21:39:30 +0000 (UTC)

 Author: kwm
 Date: Fri Mar 15 21:39:16 2013
 New Revision: 314323
 URL: http://svnweb.freebsd.org/changeset/ports/314323
 
 Log:
   Restore alt keys after gtk20 update.
   While here convert to OptionsNG.
   
   PR:		ports/176963
   Submitted by:	Lawrence Chen <beastie@tardisi.com>
   Obtained from:	upstream git / Gnome bug 663779
 
 Added:
   head/x11-toolkits/vte/files/patch-src_vte.c   (contents, props changed)
 Modified:
   head/x11-toolkits/vte/Makefile   (contents, props changed)
 
 Modified: head/x11-toolkits/vte/Makefile
 ==============================================================================
 --- head/x11-toolkits/vte/Makefile	Fri Mar 15 21:03:16 2013	(r314322)
 +++ head/x11-toolkits/vte/Makefile	Fri Mar 15 21:39:16 2013	(r314323)
 @@ -4,7 +4,7 @@
  
  PORTNAME=	vte
  PORTVERSION=	0.26.2
 -PORTREVISION?=	3
 +PORTREVISION?=	4
  CATEGORIES=	x11-toolkits gnome
  MASTER_SITES=	GNOME
  DIST_SUBDIR=	gnome2
 @@ -30,7 +30,15 @@ CONFIGURE_ARGS?=--disable-python \
  		--disable-freetypetest
  
  .if !defined(MASTERDIR)
 -OPTIONS=	GLX	"Enable support for DRI/GLX rendering" off
 +OPTIONS_DEFINE=	GLX
 +GLX_DESC=	Support for DRI/GLX rendering
 +.endif
 +
 +.include <bsd.port.options.mk>
 +
 +.if ${PORT_OPTIONS:MGLX} && !defined(MASTERDIR)
 +CONFIGURE_ARGS+=	--with-glX
 +USE_GL=			yes
  .endif
  
  .include <bsd.port.pre.mk>
 @@ -39,11 +47,6 @@ OPTIONS=	GLX	"Enable support for DRI/GLX
  EXTRA_PATCHES+=		${FILESDIR}/extra-patch-gnome-pty-helper_gnome-utmp.c
  .endif
  
 -.if defined(WITH_GLX) && !defined(MASTERDIR)
 -CONFIGURE_ARGS+=	--with-glX
 -USE_GL=			yes
 -.endif
 -
  .include <bsd.port.post.mk>
  
  .endif
 
 Added: head/x11-toolkits/vte/files/patch-src_vte.c
 ==============================================================================
 --- /dev/null	00:00:00 1970	(empty, because file is newly added)
 +++ head/x11-toolkits/vte/files/patch-src_vte.c	Fri Mar 15 21:39:16 2013	(r314323)
 @@ -0,0 +1,33 @@
 +--- src/vte.c.orig	2010-11-13 06:18:41.000000000 -0600
 ++++ src/vte.c	2013-03-14 15:59:37.761401135 -0500
 +@@ -4914,16 +4914,23 @@
 + vte_terminal_read_modifiers (VteTerminal *terminal,
 + 			     GdkEvent    *event)
 + {
 ++	GdkKeymap *keymap;
 + 	GdkModifierType modifiers;
 + 
 + 	/* Read the modifiers. */
 +-	if (gdk_event_get_state((GdkEvent*)event, &modifiers)) {
 +-		GdkKeymap *keymap;
 +-		keymap = gdk_keymap_get_for_display (
 +-				gdk_drawable_get_display (((GdkEventAny *)event)->window));
 +-		gdk_keymap_add_virtual_modifiers (keymap, &modifiers);
 +-		terminal->pvt->modifiers = modifiers;
 +-	}
 ++	if (!gdk_event_get_state((GdkEvent*)event, &modifiers))
 ++		return;
 ++
 ++	keymap = gdk_keymap_get_for_display (
 ++			gdk_window_get_display (((GdkEventAny*)event)->window));
 ++
 ++	gdk_keymap_add_virtual_modifiers (keymap, &modifiers);
 ++
 ++	/* HACK! Treat ALT as META; see bug #663779. */
 ++	if (modifiers & GDK_MOD1_MASK)
 ++		modifiers |= VTE_META_MASK;
 ++
 ++	terminal->pvt->modifiers = modifiers;
 + }
 + 
 + /* Read and handle a keypress event. */
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
