From nobody@FreeBSD.org  Fri Mar  8 19:51:49 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id 59E10ADF
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  8 Mar 2013 19:51:49 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 4A69C170
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  8 Mar 2013 19:51:49 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r28JpnK3017201
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 8 Mar 2013 19:51:49 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id r28JpnoV017194;
	Fri, 8 Mar 2013 19:51:49 GMT
	(envelope-from nobody)
Message-Id: <201303081951.r28JpnoV017194@red.freebsd.org>
Date: Fri, 8 Mar 2013 19:51:49 GMT
From: Pawel Pekala <pawel@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] audio/dvda-author fix build with clang
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: martin.dieringer@gmx.de

>Number:         176766
>Category:       ports
>Synopsis:       [patch] audio/dvda-author fix build with clang
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pawel
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Mar 08 20:00:00 UTC 2013
>Closed-Date:    Wed Mar 13 15:31:33 UTC 2013
>Last-Modified:  Wed Mar 13 15:40:00 UTC 2013
>Originator:     Pawel Pekala
>Release:        10.0-CURRENT
>Organization:
>Environment:
FreeBSD blaviken.slowicza.org 10.0-CURRENT FreeBSD 10.0-CURRENT #7: Sat Feb 23 12:08:32 CET 2013     corn@blaviken.slowicza.org:/usr/obj/usr/src/sys/BLAVIKEN64  amd64

>Description:
Simple clang build fix
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -urN /usr/ports/audio/dvda-author/files/patch-configure audio/dvda-author/files/patch-configure
--- /usr/ports/audio/dvda-author/files/patch-configure	2009-06-22 00:09:27.000000000 +0200
+++ audio/dvda-author/files/patch-configure	2013-03-08 20:42:09.000000000 +0100
@@ -1,5 +1,5 @@
---- configure.orig      2009-06-16 03:22:04.000000000 +0200
-+++ configure   2009-06-16 03:22:17.000000000 +0200
+--- configure.orig	2009-06-16 01:35:19.000000000 +0200
++++ configure	2013-03-08 20:41:46.000000000 +0100
 @@ -13402,7 +13402,7 @@
       SOX_LIB="/usr/lib/libsox.a `echo /usr/lib/sox/libsox_*.a`"
       { $as_echo "$as_me:$LINENO: SOX_LIB= $SOX_LIB" >&5
@@ -9,3 +9,12 @@
  
  fi
  
+@@ -15088,7 +15088,7 @@
+ 
+ else
+ 
+-            CFLAGS="$CFLAGS -std=c99"
++            CFLAGS="$CFLAGS -std=gnu89"
+ 
+ fi
+ 


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->miwi 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Mar 8 20:00:13 UTC 2013 
Responsible-Changed-Why:  
miwi@ wants this submitter's PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176766 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Fri Mar 8 20:00:15 UTC 2013 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176766 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: martin.dieringer@gmx.de
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/176766: [patch] audio/dvda-author fix build with clang
Date: Fri, 8 Mar 2013 20:00:14 UT

 Maintainer of audio/dvda-author,
 
 Please note that PR ports/176766 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/176766
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Martin Dieringer <martin.dieringer@gmx.de>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/176766: [patch] audio/dvda-author fix build with clang
Date: Sat, 9 Mar 2013 11:42:19 +0100 (CET)

 results in "cc -std=gnu99 -std=gnu89 ..."
 but seems no problem
Responsible-Changed-From-To: miwi->pawel 
Responsible-Changed-By: miwi 
Responsible-Changed-When: Sun Mar 10 12:02:58 UTC 2013 
Responsible-Changed-Why:  
submitter is committer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176766 

From: =?ISO-8859-2?Q?Pawe=B3_P=EAkala?= <c0rn@o2.pl>
To: bug-followup@FreeBSD.org, pawel@FreeBSD.org, Martin Dieringer
 <martin.dieringer@gmx.de>
Cc:  
Subject: Re: ports/176766: [patch] audio/dvda-author fix build with clang
Date: Mon, 11 Mar 2013 20:17:46 +0100

 --MP_/b8DG2CmFB.TjHoAyg95DuSh
 Content-Type: text/plain; charset=ISO-8859-2
 Content-Transfer-Encoding: quoted-printable
 Content-Disposition: inline
 
 >results in "cc -std=3Dgnu99 -std=3Dgnu89 ..."
 >but seems no problem
 
 Hmm right, didn't look at buildlogs close enough. Here's improved
 version which cleanups build flags for entire build and uses
 USE_CSTD macro as it supposed to in the first place. While here I also
 allowed myself to convert option check to new options framework.
 
 Do you approve?
 
 --=20
 pozdrawiam / with regards
 Pawe=B3 P=EAkala
 
 --MP_/b8DG2CmFB.TjHoAyg95DuSh
 Content-Type: text/x-patch
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment; filename=dvda-author-v2.diff
 
 diff -urN /usr/ports/audio/dvda-author/Makefile audio/dvda-author/Makefile
 --- /usr/ports/audio/dvda-author/Makefile	2012-11-17 06:54:30.000000000 +0100
 +++ audio/dvda-author/Makefile	2013-03-11 19:09:22.000000000 +0100
 @@ -34,8 +34,19 @@
  CONFIGURE_ARGS=	--with-flac=${LOCALBASE}/lib/libFLAC.so \
  	--with-ogg=${LOCALBASE}/lib/libogg.so \
  	--enable-glibc
 -.if defined(NOPORTDOCS)
 +USE_CSTD=	gnu89
 +
 +.include <bsd.port.options.mk>
 +
 +.if ! ${PORT_OPTIONS:MDOCS}
  CONFIGURE_ARGS+=	--docdir=${WRKDIR}/doc
  .endif
  
 +post-patch:
 +	@${REINPLACE_CMD} 's|-std=c99||g' \
 +		${WRKSRC}/configure \
 +		${WRKSRC}/libats2wav/Makefile.in
 +	@${REINPLACE_CMD} 's|-std=c99 -O3||' \
 +		${WRKSRC}/fixwav/src/Makefile.in
 +
  .include <bsd.port.mk>
 
 --MP_/b8DG2CmFB.TjHoAyg95DuSh--

From: Martin Dieringer <martin.dieringer@gmx.de>
To: bug-followup@FreeBSD.org
Cc: pawel@FreeBSD.org
Subject: Re: ports/176766: [patch] audio/dvda-author fix build with clang
Date: Tue, 12 Mar 2013 21:26:13 +0100 (CET)

 now it's "cc -std=gnu89 -O2 -pipe -fno-strict-aliasing -std=gnu89 ..."
 but I wouldn't care ...
State-Changed-From-To: feedback->closed 
State-Changed-By: pawel 
State-Changed-When: Wed Mar 13 15:31:33 UTC 2013 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176766 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/176766: commit references a PR
Date: Wed, 13 Mar 2013 15:31:11 +0000 (UTC)

 Author: pawel
 Date: Wed Mar 13 15:31:03 2013
 New Revision: 314091
 URL: http://svnweb.freebsd.org/changeset/ports/314091
 
 Log:
   - Respect CFLAGS
   - Fix build with clang
   - Convert to OptionsNG
   - Trim Makefile header
   
   PR:		ports/176766
   Submitted by:	myself
   Approved by:	Martin Dieringer <martin.dieringer@gmx.de> (maintainer)
 
 Modified:
   head/audio/dvda-author/Makefile   (contents, props changed)
 
 Modified: head/audio/dvda-author/Makefile
 ==============================================================================
 --- head/audio/dvda-author/Makefile	Wed Mar 13 15:29:55 2013	(r314090)
 +++ head/audio/dvda-author/Makefile	Wed Mar 13 15:31:03 2013	(r314091)
 @@ -1,9 +1,5 @@
 -# New ports collection makefile for:   dvda-author
 -# Date created:        9 October 2007
 -# Whom:                dieringe@zedat.fu-berlin.de
 -#
 +# Created by: dieringe@zedat.fu-berlin.de
  # $FreeBSD$
 -#
  
  PORTNAME=	dvda-author
  PORTVERSION=	09.05
 @@ -34,8 +30,19 @@ GNU_CONFIGURE=	yes
  CONFIGURE_ARGS=	--with-flac=${LOCALBASE}/lib/libFLAC.so \
  	--with-ogg=${LOCALBASE}/lib/libogg.so \
  	--enable-glibc
 -.if defined(NOPORTDOCS)
 +USE_CSTD=	gnu89
 +
 +.include <bsd.port.options.mk>
 +
 +.if ! ${PORT_OPTIONS:MDOCS}
  CONFIGURE_ARGS+=	--docdir=${WRKDIR}/doc
  .endif
  
 +post-patch:
 +	@${REINPLACE_CMD} 's|-std=c99||g' \
 +		${WRKSRC}/configure \
 +		${WRKSRC}/libats2wav/Makefile.in
 +	@${REINPLACE_CMD} 's|-std=c99 -O3||' \
 +		${WRKSRC}/fixwav/src/Makefile.in
 +
  .include <bsd.port.mk>
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
