From feld@feld.me  Sun Mar  3 20:29:12 2013
Return-Path: <feld@feld.me>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id 415E374E
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  3 Mar 2013 20:29:12 +0000 (UTC)
	(envelope-from feld@feld.me)
Received: from feld.me (unknown [IPv6:2607:f4e0:100:300::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 1C3797E5
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  3 Mar 2013 20:29:11 +0000 (UTC)
Received: from feld by feld.me with local (Exim 4.80.1 (FreeBSD))
	(envelope-from <feld@feld.me>)
	id 1UCFWx-0000IY-6X
	for FreeBSD-gnats-submit@freebsd.org; Sun, 03 Mar 2013 14:29:11 -0600
Message-Id: <E1UCFWx-0000IY-6X@feld.me>
Date: Sun, 03 Mar 2013 14:29:11 -0600
From: Mark Felder <feld@feld.me>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [PATCH] net-mgmt/devmon: rc script tweaking
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         176624
>Category:       ports
>Synopsis:       [PATCH] net-mgmt/devmon: rc script tweaking
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    swills
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 03 20:30:00 UTC 2013
>Closed-Date:    Mon May 27 02:19:39 UTC 2013
>Last-Modified:  Mon May 27 02:19:39 UTC 2013
>Originator:     feld
>Release:        FreeBSD 9.1-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD mwi1.coffeenet.org 9.1-RELEASE FreeBSD 9.1-RELEASE #6 r243808: Mon Dec  3 07:51:34
>Description:
rc script changed to run as user "devmon"
pidfile stored in /var/run/devmon
make sure at start logfile exists and is writable

Below are lines to go in UIDs and GIDs files

UIDs:
devmon:*:283:283::0:0:Devmon daemon:/nonexistent:/usr/sbin/nologin

GIDs:
devmon:*:283:

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: suffix)
>How-To-Repeat:
>Fix:

--- devmon-0.3.1.b1_1.patch begins here ---
diff -ruN --exclude=CVS ../devmon.orig/Makefile ./Makefile
--- ../devmon.orig/Makefile	2013-03-02 14:20:12.000000000 -0600
+++ ./Makefile	2013-03-03 13:11:56.000000000 -0600
@@ -3,6 +3,7 @@
 
 PORTNAME=	devmon
 DISTVERSION=	0.3.1-beta1
+PORTREVISION=	1
 CATEGORIES=	net-mgmt
 MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/${DISTVERSION}
 
@@ -17,6 +18,9 @@
 NO_BUILD=	yes
 USE_RC_SUBR=	devmon
 
+USERS=	devmon
+GROUPS=	devmon
+
 OPTIONS_DEFINE=	MYSQL
 
 .include <bsd.port.options.mk>
@@ -36,8 +40,11 @@
 	(cd ${WRKSRC}/modules && ${COPYTREE_SHARE} \* ${PREFIX}/devmon/modules/)
 
 post-install:
+	${INSTALL} -d /var/run/devmon
+	${CHOWN} devmon:devmon /var/run/devmon
+	${CHOWN} devmon:devmon ${PREFIX}/devmon
 .if ${PORT_OPTIONS:MDOCS}
-	${MKDIR} ${DOCSDIR}
+	${INSTALL} -d ${DOCSDIR}
 	${INSTALL_DATA} ${WRKSRC}/CHANGELOG ${DOCSDIR}/
 	${INSTALL_DATA} ${WRKSRC}/COPYING ${DOCSDIR}/
 	${INSTALL_DATA} ${WRKSRC}/README ${DOCSDIR}/
diff -ruN --exclude=CVS ../devmon.orig/files/devmon.in ./files/devmon.in
--- ../devmon.orig/files/devmon.in	2013-03-02 14:20:12.000000000 -0600
+++ ./files/devmon.in	2013-03-03 14:23:54.000000000 -0600
@@ -8,7 +8,8 @@
 : ${devmon_enable="NO"}
 : ${devmon_config="%%PREFIX%%/devmon/devmon.cfg"}
 : ${devmon_db="%%PREFIX%%/devmon/hosts.db"}
-: ${devmon_pid="/var/run/devmon.pid"}
+: ${devmon_pid="/var/run/devmon/devmon.pid"} # match your entry in devmon.cfg
+: ${devmon_log="/var/log/devmon.log"} # match your entry in devmon.cfg
 
 . /etc/rc.subr
 
@@ -22,10 +23,11 @@
 
 stop_cmd="devmon_stopcmd"
 status_cmd="devmon_statuscmd"
+start_cmd="devmon_startcmd"
 
 devmon_statuscmd()                                                                                                                                                              
 {
-if [ ! -e $pidfile ];                                                                                                                                                      
+if [ ! -e $pidfile ];
     then
         echo "pidfile does not exist. $name is not running?";
     exit 1;
@@ -33,7 +35,8 @@
 
 if pgrep -F $pidfile >/dev/null;
     then
-        echo "$name is running.";
+	mypid=`cat $pidfile`;
+        echo "$name is running as $mypid.";
     else
         echo "$name is not running.";
     exit 1;
@@ -53,4 +56,11 @@
 fi
 }
 
+devmon_startcmd()
+{
+    touch ${devmon_log}
+    chown devmon:devmon ${devmon_log}
+    su -m devmon -c "${command_interpreter} ${command} ${command_args}"
+}
+
 run_rc_command "$1"
diff -ruN --exclude=CVS ../devmon.orig/pkg-plist ./pkg-plist
--- ../devmon.orig/pkg-plist	2013-03-02 14:20:12.000000000 -0600
+++ ./pkg-plist	2013-03-03 14:25:04.235340823 -0600
@@ -28,3 +28,4 @@
 %%PORTDOCS%%@dirrm %%DOCSDIR%%/extras
 %%PORTDOCS%%@dirrm %%DOCSDIR%%/docs
 %%PORTDOCS%%@dirrm %%DOCSDIR%%
+@unexec rmdir /var/run/devmon
--- devmon-0.3.1.b1_1.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->swills 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Mar 3 20:30:10 UTC 2013 
Responsible-Changed-Why:  
swills@ wants this submitter's PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176624 

From: Mark Felder <feld@feld.me>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/176624: [PATCH] net-mgmt/devmon: rc script tweaking
Date: Tue, 5 Mar 2013 08:45:17 -0600

 ------------bYdnr5sIkoPOnt5Rhz80VD
 Content-Type: text/plain; format=flowed; delsp=yes
 
 I prefer the use of required_files for this. Please use this patch.
 
 ------------bYdnr5sIkoPOnt5Rhz80VD
 Content-Disposition: attachment; filename="devmon-0.3.1.b1_1.patchv2"
 Content-Type: application/octet-stream; name="devmon-0.3.1.b1_1.patchv2"
 Content-Transfer-Encoding: base64
 
 LS0tIGRldm1vbi0wLjMuMS5iMV8xLnBhdGNoIGJlZ2lucyBoZXJlIC0tLQpkaWZmIC1ydU4g
 LS1leGNsdWRlPUNWUyAuLi9kZXZtb24ub3JpZy9NYWtlZmlsZSAuL01ha2VmaWxlCi0tLSAu
 Li9kZXZtb24ub3JpZy9NYWtlZmlsZQkyMDEzLTAzLTAyIDE0OjIwOjEyLjAwMDAwMDAwMCAt
 MDYwMAorKysgLi9NYWtlZmlsZQkyMDEzLTAzLTAzIDEzOjExOjU2LjAwMDAwMDAwMCAtMDYw
 MApAQCAtMyw2ICszLDcgQEAKIAogUE9SVE5BTUU9CWRldm1vbgogRElTVFZFUlNJT049CTAu
 My4xLWJldGExCitQT1JUUkVWSVNJT049CTEKIENBVEVHT1JJRVM9CW5ldC1tZ210CiBNQVNU
 RVJfU0lURVM9CVNGLyR7UE9SVE5BTUV9LyR7UE9SVE5BTUV9LyR7RElTVFZFUlNJT059CiAK
 QEAgLTE3LDYgKzE4LDkgQEAKIE5PX0JVSUxEPQl5ZXMKIFVTRV9SQ19TVUJSPQlkZXZtb24K
 IAorVVNFUlM9CWRldm1vbgorR1JPVVBTPQlkZXZtb24KKwogT1BUSU9OU19ERUZJTkU9CU1Z
 U1FMCiAKIC5pbmNsdWRlIDxic2QucG9ydC5vcHRpb25zLm1rPgpAQCAtMzYsOCArNDAsMTEg
 QEAKIAkoY2QgJHtXUktTUkN9L21vZHVsZXMgJiYgJHtDT1BZVFJFRV9TSEFSRX0gXCogJHtQ
 UkVGSVh9L2Rldm1vbi9tb2R1bGVzLykKIAogcG9zdC1pbnN0YWxsOgorCSR7SU5TVEFMTH0g
 LWQgL3Zhci9ydW4vZGV2bW9uCisJJHtDSE9XTn0gZGV2bW9uOmRldm1vbiAvdmFyL3J1bi9k
 ZXZtb24KKwkke0NIT1dOfSBkZXZtb246ZGV2bW9uICR7UFJFRklYfS9kZXZtb24KIC5pZiAk
 e1BPUlRfT1BUSU9OUzpNRE9DU30KLQkke01LRElSfSAke0RPQ1NESVJ9CisJJHtJTlNUQUxM
 fSAtZCAke0RPQ1NESVJ9CiAJJHtJTlNUQUxMX0RBVEF9ICR7V1JLU1JDfS9DSEFOR0VMT0cg
 JHtET0NTRElSfS8KIAkke0lOU1RBTExfREFUQX0gJHtXUktTUkN9L0NPUFlJTkcgJHtET0NT
 RElSfS8KIAkke0lOU1RBTExfREFUQX0gJHtXUktTUkN9L1JFQURNRSAke0RPQ1NESVJ9Lwpk
 aWZmIC1ydU4gLS1leGNsdWRlPUNWUyAuLi9kZXZtb24ub3JpZy9maWxlcy9kZXZtb24uaW4g
 Li9maWxlcy9kZXZtb24uaW4KLS0tIC4uL2Rldm1vbi5vcmlnL2ZpbGVzL2Rldm1vbi5pbgky
 MDEzLTAzLTAyIDE0OjIwOjEyLjAwMDAwMDAwMCAtMDYwMAorKysgLi9maWxlcy9kZXZtb24u
 aW4JMjAxMy0wMy0wNSAwNjozOToxMy44ODUzNTU0OTIgLTA2MDAKQEAgLTgsNyArOCw4IEBA
 CiA6ICR7ZGV2bW9uX2VuYWJsZT0iTk8ifQogOiAke2Rldm1vbl9jb25maWc9IiUlUFJFRklY
 JSUvZGV2bW9uL2Rldm1vbi5jZmcifQogOiAke2Rldm1vbl9kYj0iJSVQUkVGSVglJS9kZXZt
 b24vaG9zdHMuZGIifQotOiAke2Rldm1vbl9waWQ9Ii92YXIvcnVuL2Rldm1vbi5waWQifQor
 OiAke2Rldm1vbl9waWQ9Ii92YXIvcnVuL2Rldm1vbi9kZXZtb24ucGlkIn0gIyBtYXRjaCB5
 b3VyIGVudHJ5IGluIGRldm1vbi5jZmcKKzogJHtkZXZtb25fbG9nPSIvdmFyL2xvZy9kZXZt
 b24ubG9nIn0gIyBtYXRjaCB5b3VyIGVudHJ5IGluIGRldm1vbi5jZmcKIAogLiAvZXRjL3Jj
 LnN1YnIKIApAQCAtMTksMTMgKzIwLDE1IEBACiBjb21tYW5kX2FyZ3M9Ii1jICR7ZGV2bW9u
 X2NvbmZpZ30gLWQgJHtkZXZtb25fZGJ9IgogY29tbWFuZF9pbnRlcnByZXRlcj0iL3Vzci9i
 aW4vcGVybCIKIHBpZGZpbGU9JHtkZXZtb25fcGlkfQorcmVxdWlyZWRfZmlsZXM9JHtkZXZt
 b25fbG9nfQogCiBzdG9wX2NtZD0iZGV2bW9uX3N0b3BjbWQiCiBzdGF0dXNfY21kPSJkZXZt
 b25fc3RhdHVzY21kIgorc3RhcnRfY21kPSJkZXZtb25fc3RhcnRjbWQiCiAKIGRldm1vbl9z
 dGF0dXNjbWQoKSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
 ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
 ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
 ICAgICAgCiB7Ci1pZiBbICEgLWUgJHBpZGZpbGUgXTsgICAgICAgICAgICAgICAgICAgICAg
 ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
 ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
 ICAgICAgICAgICAgICAgICAgICAKK2lmIFsgISAtZSAkcGlkZmlsZSBdOwogICAgIHRoZW4K
 ICAgICAgICAgZWNobyAicGlkZmlsZSBkb2VzIG5vdCBleGlzdC4gJG5hbWUgaXMgbm90IHJ1
 bm5pbmc/IjsKICAgICBleGl0IDE7CkBAIC0zMyw3ICszNiw4IEBACiAKIGlmIHBncmVwIC1G
 ICRwaWRmaWxlID4vZGV2L251bGw7CiAgICAgdGhlbgotICAgICAgICBlY2hvICIkbmFtZSBp
 cyBydW5uaW5nLiI7CisJbXlwaWQ9YGNhdCAkcGlkZmlsZWA7CisgICAgICAgIGVjaG8gIiRu
 YW1lIGlzIHJ1bm5pbmcgYXMgJG15cGlkLiI7CiAgICAgZWxzZQogICAgICAgICBlY2hvICIk
 bmFtZSBpcyBub3QgcnVubmluZy4iOwogICAgIGV4aXQgMTsKQEAgLTUzLDQgKzU3LDEwIEBA
 CiBmaQogfQogCitkZXZtb25fc3RhcnRjbWQoKQoreworICAgIGNob3duIGRldm1vbjpkZXZt
 b24gJHtkZXZtb25fbG9nfQorICAgIHN1IC1tIGRldm1vbiAtYyAiJHtjb21tYW5kX2ludGVy
 cHJldGVyfSAke2NvbW1hbmR9ICR7Y29tbWFuZF9hcmdzfSIKK30KKwogcnVuX3JjX2NvbW1h
 bmQgIiQxIgpkaWZmIC1ydU4gLS1leGNsdWRlPUNWUyAuLi9kZXZtb24ub3JpZy9wa2ctcGxp
 c3QgLi9wa2ctcGxpc3QKLS0tIC4uL2Rldm1vbi5vcmlnL3BrZy1wbGlzdAkyMDEzLTAzLTAy
 IDE0OjIwOjEyLjAwMDAwMDAwMCAtMDYwMAorKysgLi9wa2ctcGxpc3QJMjAxMy0wMy0wNSAw
 Njo0MDoyNC45MjUzNDIzMjIgLTA2MDAKQEAgLTI4LDMgKzI4LDQgQEAKICUlUE9SVERPQ1Ml
 JUBkaXJybSAlJURPQ1NESVIlJS9leHRyYXMKICUlUE9SVERPQ1MlJUBkaXJybSAlJURPQ1NE
 SVIlJS9kb2NzCiAlJVBPUlRET0NTJSVAZGlycm0gJSVET0NTRElSJSUKK0B1bmV4ZWMgcm1k
 aXIgL3Zhci9ydW4vZGV2bW9uCi0tLSBkZXZtb24tMC4zLjEuYjFfMS5wYXRjaCBlbmRzIGhl
 cmUgLS0tCg==
 
 ------------bYdnr5sIkoPOnt5Rhz80VD--
State-Changed-From-To: open->closed 
State-Changed-By: swills 
State-Changed-When: Mon May 27 02:19:38 UTC 2013 
State-Changed-Why:  
Superseded by PR ports/178834 as far as I can tell, correct me if I'm 
mistaken. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176624 
>Unformatted:
