From nobody@FreeBSD.org  Fri Mar  1 21:36:59 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
	by hub.freebsd.org (Postfix) with ESMTP id A666E171
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  1 Mar 2013 21:36:59 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 879E818D9
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  1 Mar 2013 21:36:59 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r21LawUQ023872
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 1 Mar 2013 21:36:58 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id r21Lawwu023871;
	Fri, 1 Mar 2013 21:36:58 GMT
	(envelope-from nobody)
Message-Id: <201303012136.r21Lawwu023871@red.freebsd.org>
Date: Fri, 1 Mar 2013 21:36:58 GMT
From: Hon-Yu Lawrence Cheung <cheunghonyu@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] audio/cmus  fix ffmpeg depend
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: h.skuhra@gmail.com

>Number:         176592
>Category:       ports
>Synopsis:       [patch] audio/cmus  fix ffmpeg depend
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    beech
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Mar 01 21:40:00 UTC 2013
>Closed-Date:    Wed Mar 06 23:23:19 UTC 2013
>Last-Modified:  Wed Mar  6 23:30:00 UTC 2013
>Originator:     Hon-Yu Lawrence Cheung
>Release:        FreeBSD 9.1-RELEASE-p1
>Organization:
>Environment:
FreeBSD a5552.honyucheung.net 9.1-RELEASE-p1 FreeBSD 9.1-RELEASE-p1 #0 r247045: Thu Feb 21 05:44:18 HKT 2013     root@a5552.honyucheung.net:/usr/obj/usr/src/sys/A5552  amd64

>Description:
audio/cmus fails in "make configure" stage result from multimedia/ffmpeg-011 is no longer a valid port.
>How-To-Repeat:
compile audio/cmus with ffmpeg option
>Fix:
use new port multimedia/ffmpeg1 as the dependance

Patch attached with submission follows:

--- Makefile.orig       2013-03-02 04:59:56.620495780 +0800
+++ Makefile    2013-03-02 05:02:33.946531003 +0800
@@ -112,11 +112,11 @@
 CONFIGURE_ARGS+=CONFIG_WAVPACK=n
 PLIST_SUB+=    WAVPACK="@comment "
 .endif
 
 .if ${PORT_OPTIONS:MFFMPEG}
-FFMPEG_SUFFIX= -011
+FFMPEG_SUFFIX= 1
 BUILD_DEPENDS+=        ffmpeg${FFMPEG_SUFFIX}>0.11:${PORTSDIR}/multimedia/ffmpeg${FFMPEG_SUFFIX}
 RUN_DEPENDS+=  ffmpeg${FFMPEG_SUFFIX}>0.11:${PORTSDIR}/multimedia/ffmpeg${FFMPEG_SUFFIX}
 CONFIGURE_ARGS+=CONFIG_FFMPEG=y
 PLIST_SUB+=    FFMPEG=""
 .else


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-ports-bugs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Fri Mar 1 23:26:41 UTC 2013 
Responsible-Changed-Why:  
ports PR. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176592 
Responsible-Changed-From-To: freebsd-ports-bugs->beech 
Responsible-Changed-By: beech 
Responsible-Changed-When: Sun Mar 3 08:15:50 UTC 2013 
Responsible-Changed-Why:  
I'll take it 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176592 
State-Changed-From-To: open->feedback 
State-Changed-By: beech 
State-Changed-When: Sun Mar 3 19:19:28 UTC 2013 
State-Changed-Why:  
Awaiting maintainer response 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176592 

From: Beech Rintoul <beech@freebsd.org>
To: h.skuhra@gmail.com
Cc: Bug Followup <bug-followup@freebsd.org>,
 "Hon-Yu Lawrence Cheung" <cheunghonyu@gmail.com>
Subject: Re: ports/176592: [patch] audio/cmus fix ffmpeg depend
Date: Sun, 3 Mar 2013 10:20:54 -0900

 Maintainer of audio/cmus,
 
 Please note that PR ports/176592 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
 http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/17692
 
 Beech Rintoul

From: "Herbert J. Skuhra" <h.skuhra@gmail.com>
To: Beech Rintoul <beech@freebsd.org>
Cc: Bug Followup <bug-followup@freebsd.org>, 
	Hon-Yu Lawrence Cheung <cheunghonyu@gmail.com>
Subject: Re: ports/176592: [patch] audio/cmus fix ffmpeg depend
Date: Wed, 6 Mar 2013 13:22:44 +0100

 --f46d0418253cb5379704d740a59e
 Content-Type: text/plain; charset=UTF-8
 
 Hei,
 
 can you please commit the attached patch instead?
 
 It also fixes a build problem when world is built with
 'WITH_CLANG_IS_CC/WITHOUT_GCC'.
 
 Thanks.
 
 -- 
 Herbert
 
 --f46d0418253cb5379704d740a59e
 Content-Type: text/plain; charset=US-ASCII; name="patch-cmus.txt"
 Content-Disposition: attachment; filename="patch-cmus.txt"
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_hdygj7fy0
 
 SW5kZXg6IGF1ZGlvL2NtdXMvTWFrZWZpbGUKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gYXVkaW8vY211cy9NYWtl
 ZmlsZQkocmV2aXNpb24gMzEzNTA1KQorKysgYXVkaW8vY211cy9NYWtlZmlsZQkod29ya2luZyBj
 b3B5KQpAQCAtMTYsNiArMTYsNyBAQAogVVNFX05DVVJTRVM9CXllcwogVVNFX1BLR0NPTkZJRz0J
 YnVpbGQKIEhBU19DT05GSUdVUkU9CXllcworQ09ORklHVVJFX0VOVis9CUhPU1RDQz0ke0NDfQog
 Q09ORklHVVJFX0FSR1MrPXByZWZpeD0ke1BSRUZJWH0gbWFuZGlyPSR7TUFOUFJFRklYfS9tYW4g
 XAogCQlleGFtcGxlZGlyPSR7RVhBTVBMRVNESVJ9IFwKIAkJQ09ORklHX0FMU0E9biBDT05GSUdf
 Uk9BUj1uCkBAIC0xMTQsOSArMTE1LDkgQEAKIC5lbmRpZgogCiAuaWYgJHtQT1JUX09QVElPTlM6
 TUZGTVBFR30KLUZGTVBFR19TVUZGSVg9CS0wMTEKLUJVSUxEX0RFUEVORFMrPQlmZm1wZWcke0ZG
 TVBFR19TVUZGSVh9PjAuMTE6JHtQT1JUU0RJUn0vbXVsdGltZWRpYS9mZm1wZWcke0ZGTVBFR19T
 VUZGSVh9Ci1SVU5fREVQRU5EUys9CWZmbXBlZyR7RkZNUEVHX1NVRkZJWH0+MC4xMToke1BPUlRT
 RElSfS9tdWx0aW1lZGlhL2ZmbXBlZyR7RkZNUEVHX1NVRkZJWH0KK0ZGTVBFR19TVUZGSVg9CTEK
 K0JVSUxEX0RFUEVORFMrPQlmZm1wZWcke0ZGTVBFR19TVUZGSVh9Pj0xOiR7UE9SVFNESVJ9L211
 bHRpbWVkaWEvZmZtcGVnJHtGRk1QRUdfU1VGRklYfQorUlVOX0RFUEVORFMrPQlmZm1wZWcke0ZG
 TVBFR19TVUZGSVh9Pj0xOiR7UE9SVFNESVJ9L211bHRpbWVkaWEvZmZtcGVnJHtGRk1QRUdfU1VG
 RklYfQogQ09ORklHVVJFX0FSR1MrPUNPTkZJR19GRk1QRUc9eQogUExJU1RfU1VCKz0JRkZNUEVH
 PSIiCiAuZWxzZQo=
 --f46d0418253cb5379704d740a59e--
State-Changed-From-To: feedback->closed 
State-Changed-By: beech 
State-Changed-When: Wed Mar 6 23:22:49 UTC 2013 
State-Changed-Why:  
Committed (with maintainer changes), Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176592 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/176592: commit references a PR
Date: Wed,  6 Mar 2013 23:22:03 +0000 (UTC)

 Author: beech
 Date: Wed Mar  6 23:21:55 2013
 New Revision: 313556
 URL: http://svnweb.freebsd.org/changeset/ports/313556
 
 Log:
   - Fix configure with ffmpeg
   - Fix build with clang
   
   PR:		ports/176592
   Submitted by:	Hon-Yu Lawrence Cheung <cheunghonyu@gmail.com>
   Approved by:	"Herbert J. Skuhra" <h.skuhra@gmail.com> (maintainer)
 
 Modified:
   head/audio/cmus/Makefile
 
 Modified: head/audio/cmus/Makefile
 ==============================================================================
 --- head/audio/cmus/Makefile	Wed Mar  6 23:18:23 2013	(r313555)
 +++ head/audio/cmus/Makefile	Wed Mar  6 23:21:55 2013	(r313556)
 @@ -16,6 +16,7 @@ USE_ICONV=	yes
  USE_NCURSES=	yes
  USE_PKGCONFIG=	build
  HAS_CONFIGURE=	yes
 +CONFIGURE_ENV+=	HOSTCC=${CC}
  CONFIGURE_ARGS+=prefix=${PREFIX} mandir=${MANPREFIX}/man \
  		exampledir=${EXAMPLESDIR} \
  		CONFIG_ALSA=n CONFIG_ROAR=n
 @@ -114,9 +115,9 @@ PLIST_SUB+=	WAVPACK="@comment "
  .endif
  
  .if ${PORT_OPTIONS:MFFMPEG}
 -FFMPEG_SUFFIX=	-011
 -BUILD_DEPENDS+=	ffmpeg${FFMPEG_SUFFIX}>0.11:${PORTSDIR}/multimedia/ffmpeg${FFMPEG_SUFFIX}
 -RUN_DEPENDS+=	ffmpeg${FFMPEG_SUFFIX}>0.11:${PORTSDIR}/multimedia/ffmpeg${FFMPEG_SUFFIX}
 +FFMPEG_SUFFIX=	1
 +BUILD_DEPENDS+=	ffmpeg${FFMPEG_SUFFIX}>=1:${PORTSDIR}/multimedia/ffmpeg${FFMPEG_SUFFIX}
 +RUN_DEPENDS+=	ffmpeg${FFMPEG_SUFFIX}>=1:${PORTSDIR}/multimedia/ffmpeg${FFMPEG_SUFFIX}
  CONFIGURE_ARGS+=CONFIG_FFMPEG=y
  PLIST_SUB+=	FFMPEG=""
  .else
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
