From jarrod@downtools.com.au  Tue Feb 26 09:41:47 2013
Return-Path: <jarrod@downtools.com.au>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id EC3F49D1
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 26 Feb 2013 09:41:47 +0000 (UTC)
	(envelope-from jarrod@downtools.com.au)
Received: from mail.downtools.com.au (mail.downtools.com.au [123.136.33.243])
	by mx1.freebsd.org (Postfix) with ESMTP id 6B9368BF
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 26 Feb 2013 09:41:46 +0000 (UTC)
Received: from mail.downtools.com.au (mail.downtools.com.au [123.136.33.243])
	by mail.downtools.com.au (8.14.4/8.14.4) with ESMTP id r1Q9Tvwa020489
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Tue, 26 Feb 2013 19:59:57 +1030 (CST)
	(envelope-from jarrod@downtools.com.au)
Received: (from jarrod@localhost)
	by mail.downtools.com.au (8.14.4/8.14.4/Submit) id r1Q9Tvmo020488;
	Tue, 26 Feb 2013 19:59:57 +1030 (CST)
	(envelope-from jarrod)
Message-Id: <201302260929.r1Q9Tvmo020488@mail.downtools.com.au>
Date: Tue, 26 Feb 2013 19:59:57 +1030 (CST)
From: Jarrod Sayers <jarrod@downtools.com.au>
Reply-To: Jarrod Sayers <jarrod@downtools.com.au>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] graphics/p5-Imager: Restore presence of GIF modules
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         176437
>Category:       ports
>Synopsis:       [patch] graphics/p5-Imager: Restore presence of GIF modules
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    tobez
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 26 09:50:00 UTC 2013
>Closed-Date:    Mon Jun 10 15:26:34 CEST 2013
>Last-Modified:  Mon Jun 10 15:26:34 CEST 2013
>Originator:     Jarrod Sayers
>Release:        FreeBSD 9.0-RELEASE-p5 i386
>Organization:
>Environment:
System: FreeBSD mail.downtools.com.au 9.0-RELEASE-p5 FreeBSD 9.0-RELEASE-p5 #23: Sat Dec 15 08:56:43 CST 2012 root@burbank.downtools.com.au:/usr/obj/usr/src/sys/BURBANK i386
>Description:
As a part of r310176, the presence of the GIF man pages, module and binaries
was removed from the ports packing list despite graphics/giflib remaining as
a dependant library.  As seen in the listed Tinderbox log [1], these packing
lists entries are still required.

Extract from Tinderbox log:
===>   p5-Imager-0.94 depends on shared library: gif - found
..
Installing /usr/local/lib/perl5/site_perl/5.14.2/mach/auto/Imager/File/GIF/GIF.so
Installing /usr/local/lib/perl5/site_perl/5.14.2/mach/auto/Imager/File/GIF/GIF.bs
..
Installing /usr/local/lib/perl5/site_perl/5.14.2/mach/Imager/File/GIF.pm
..
Installing /usr/local/lib/perl5/5.14.2/man/man3/Imager::File::GIF.3

[1] http://www.downtools.com.au/~jarrod/FreeBSD/p5-Imager-0.94.log
>How-To-Repeat:
>Fix:
Patch attached, however can be downloaded from:
http://www.downtools.com.au/~jarrod/FreeBSD/graphics-p5-Imager-GIF.pm.diff

--- graphics-p5-Imager-GIF.pm.diff begins here ---
diff -ruN ports/graphics/p5-Imager.orig/Makefile ports/graphics/p5-Imager/Makefile
--- ports/graphics/p5-Imager.orig/Makefile	2013-02-04 18:56:38.000000000 +1030
+++ ports/graphics/p5-Imager/Makefile	2013-02-26 19:34:21.000000000 +1030
@@ -3,6 +3,7 @@
 
 PORTNAME=	Imager
 PORTVERSION=	0.94
+PORTREVISION=	1
 CATEGORIES=	graphics perl5
 MASTER_SITES=	CPAN
 PKGNAMEPREFIX=	p5-
@@ -41,6 +42,7 @@
 		Imager::Expr.3 \
 		Imager::Expr::Assem.3 \
 		Imager::ExtUtils.3 \
+		Imager::File::GIF.3 \
 		Imager::File::ICO.3 \
 		Imager::File::JPEG.3 \
 		Imager::File::PNG.3 \
diff -ruN ports/graphics/p5-Imager.orig/pkg-plist ports/graphics/p5-Imager/pkg-plist
--- ports/graphics/p5-Imager.orig/pkg-plist	2013-02-04 18:56:38.000000000 +1030
+++ ports/graphics/p5-Imager/pkg-plist	2013-02-26 19:36:22.000000000 +1030
@@ -12,6 +12,7 @@
 %%SITE_PERL%%/%%PERL_ARCH%%/Imager/Expr/Assem.pm
 %%SITE_PERL%%/%%PERL_ARCH%%/Imager/ExtUtils.pm
 %%SITE_PERL%%/%%PERL_ARCH%%/Imager/File/CUR.pm
+%%SITE_PERL%%/%%PERL_ARCH%%/Imager/File/GIF.pm
 %%SITE_PERL%%/%%PERL_ARCH%%/Imager/File/ICO.pm
 %%SITE_PERL%%/%%PERL_ARCH%%/Imager/File/JPEG.pm
 %%SITE_PERL%%/%%PERL_ARCH%%/Imager/File/PNG.pm
@@ -81,6 +82,8 @@
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/Imager/.packlist
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/Imager/CountColor/CountColor.bs
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/Imager/CountColor/CountColor.so
+%%SITE_PERL%%/%%PERL_ARCH%%/auto/Imager/File/GIF/GIF.bs
+%%SITE_PERL%%/%%PERL_ARCH%%/auto/Imager/File/GIF/GIF.so
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/Imager/File/ICO/ICO.bs
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/Imager/File/ICO/ICO.so
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/Imager/File/JPEG/JPEG.bs
--- graphics-p5-Imager-GIF.pm.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->perl 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Feb 26 09:50:08 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176437 
State-Changed-From-To: open->feedback 
State-Changed-By: tobez 
State-Changed-When: Tue Feb 26 12:39:05 CET 2013 
State-Changed-Why:  
That's not what I see when I build the port: 

GIF: main: includes found - libraries found 
GIF: incorrect header on test - 4.2.0 bug? (mode 1, buf GIF87a) 
GIF: Test code failed: wrong result: 'gif' 
GIF: Checking if the compiler can find them on its own 
GIF: Test code failed: Can't link/include 'gif_lib.h', 'stdio.h', 'errno.h', 'string.h', 'gif' 

I'll try to debug this further to find out why the port's 
configuration detects GIF support inconsistently. 


Responsible-Changed-From-To: perl->tobez 
Responsible-Changed-By: tobez 
Responsible-Changed-When: Tue Feb 26 12:39:05 CET 2013 
Responsible-Changed-Why:  
I'll handle this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176437 
State-Changed-From-To: feedback->closed 
State-Changed-By: tobez 
State-Changed-When: Mon Jun 10 15:25:40 CEST 2013 
State-Changed-Why:  
Fixed together with updating the port to 0.96. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176437 
>Unformatted:
