From nobody@FreeBSD.org  Tue Feb 12 10:07:05 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
	by hub.freebsd.org (Postfix) with ESMTP id 3E1EC62B
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 12 Feb 2013 10:07:05 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 143691DD
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 12 Feb 2013 10:07:05 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r1CA74xM038743
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 12 Feb 2013 10:07:04 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id r1CA74Ei038742;
	Tue, 12 Feb 2013 10:07:04 GMT
	(envelope-from nobody)
Message-Id: <201302121007.r1CA74Ei038742@red.freebsd.org>
Date: Tue, 12 Feb 2013 10:07:04 GMT
From: Christoph Theis <theis@gmx.at>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [maintainer-update] Hard coded path to grep in sendmail-whois-lines.conf
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         176058
>Category:       ports
>Synopsis:       [maintainer-update] security/py-fail2ban: Hard coded path to grep in sendmail-whois-lines.conf
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    rm
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 12 10:10:01 UTC 2013
>Closed-Date:    Sun Feb 17 14:45:38 UTC 2013
>Last-Modified:  Sun Feb 17 14:50:00 UTC 2013
>Originator:     Christoph Theis
>Release:        
>Organization:
>Environment:
>Description:
action.d/sendmail-whois-lines.conf used a hardcoded path to /bin/grep.
Allother actions do not use any path with grep.

Thanks to Derek Kulinski for the tip.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: Makefile
===================================================================
--- Makefile	(revision 312090)
+++ Makefile	(working copy)
@@ -3,7 +3,7 @@
 
 PORTNAME=	fail2ban
 PORTVERSION=	0.8.7.1
-PORTREVISION=   1
+PORTREVISION=   2
 CATEGORIES=	security python
 MASTER_SITES=	https://github.com/${PORTNAME}/${PORTNAME}/tarball/${PORTVERSION}/
 PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
Index: files/patch-sendmail-whois-lines.conf
===================================================================
--- files/patch-sendmail-whois-lines.conf	(revision 0)
+++ files/patch-sendmail-whois-lines.conf	(working copy)
@@ -0,0 +1,11 @@
+--- config/action.d/sendmail-whois-lines.conf.orig	2012-08-01 03:45:04.000000000 +0200
++++ config/action.d/sendmail-whois-lines.conf	2013-02-12 10:43:33.000000000 +0100
+@@ -57,7 +57,7 @@
+             Here are more information about <ip>:\n
+             `/usr/bin/whois <ip>`\n\n
+             Lines containing IP:<ip> in <logpath>\n
+-            `/bin/grep '\<<ip>\>' <logpath>`\n\n
++            `grep '\<<ip>\>' <logpath>`\n\n
+             Regards,\n
+             Fail2Ban" | /usr/sbin/sendmail -f <sender> <dest>
+ 


>Release-Note:
>Audit-Trail:

From: Mark Linimon <linimon@lonesome.com>
To: Christoph Theis <theis@gmx.at>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/176058: [maintainer-update] Hard coded path to grep in
 sendmail-whois-lines.conf
Date: Tue, 12 Feb 2013 07:46:06 -0600

 to which port does this PR apply?
 
 mcl

From: Christoph Theis <theis@gmx.at>
To: Mark Linimon <linimon@lonesome.com>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/176058: [maintainer-update] Hard coded path to grep in
 sendmail-whois-lines.conf
Date: Tue, 12 Feb 2013 15:10:53 +0100

 Am 12.02.2013 14:46, schrieb Mark Linimon:
 > to which port does this PR apply?
 
 Upps, did I forgot that?
 security/py-fail2ban
 
 
 Christoph
 
 
Responsible-Changed-From-To: freebsd-ports-bugs->rm 
Responsible-Changed-By: rm 
Responsible-Changed-When: Sun Feb 17 14:40:39 UTC 2013 
Responsible-Changed-Why:  
I will take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176058 
State-Changed-From-To: open->closed 
State-Changed-By: rm 
State-Changed-When: Sun Feb 17 14:45:37 UTC 2013 
State-Changed-Why:  
Committed, but using REINPLACE_CMD in Makefile, not using patch files. 
Thank you! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176058 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/176058: commit references a PR
Date: Sun, 17 Feb 2013 14:44:15 +0000 (UTC)

 Author: rm
 Date: Sun Feb 17 14:44:08 2013
 New Revision: 312418
 URL: http://svnweb.freebsd.org/changeset/ports/312418
 
 Log:
   - do not hardcode path to grep utility
   
   PR:		176058
   Submitted by:	Christoph Theis <theis@gmx.at> (maintainer)
 
 Modified:
   head/security/py-fail2ban/Makefile
 
 Modified: head/security/py-fail2ban/Makefile
 ==============================================================================
 --- head/security/py-fail2ban/Makefile	Sun Feb 17 14:22:56 2013	(r312417)
 +++ head/security/py-fail2ban/Makefile	Sun Feb 17 14:44:08 2013	(r312418)
 @@ -3,7 +3,7 @@
  
  PORTNAME=	fail2ban
  PORTVERSION=	0.8.7.1
 -PORTREVISION=   1
 +PORTREVISION=	2
  CATEGORIES=	security python
  MASTER_SITES=	https://github.com/${PORTNAME}/${PORTNAME}/tarball/${PORTVERSION}/
  PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
 @@ -39,6 +39,8 @@ FILES=	${WRKSRC}/fail2ban-regex \
  
  post-patch:
  	@${ECHO_CMD} ${FILES} | ${XARGS} ${REINPLACE_CMD} -e 's,/etc/fail2ban,${ETCDIR},g'
 +	@${REINPLACE_CMD} -e 's,/bin/grep,grep,g' \
 +		${WRKSRC}/config/action.d/sendmail-whois-lines.conf
  
  post-install:
  	@${CAT} ${PKGMESSAGE}
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
