From nobody@FreeBSD.org  Sat Mar 25 20:07:28 2000
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id 6FAC337B985
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 25 Mar 2000 20:07:28 -0800 (PST)
	(envelope-from nobody@FreeBSD.org)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id UAA83381;
	Sat, 25 Mar 2000 20:07:29 -0800 (PST)
	(envelope-from nobody@FreeBSD.org)
Message-Id: <200003260407.UAA83381@freefall.freebsd.org>
Date: Sat, 25 Mar 2000 20:07:29 -0800 (PST)
From: shige2@pop17.odn.ne.jp
Sender: nobody@FreeBSD.org
To: freebsd-gnats-submit@FreeBSD.org
Subject: ports/www/wwwoffle SPOOL=/home, then fail pkg/INSTALL
X-Send-Pr-Version: www-1.0

>Number:         17603
>Category:       ports
>Synopsis:       ports/www/wwwoffle SPOOL=/home, then fail pkg/INSTALL
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Mar 25 20:10:02 PST 2000
>Closed-Date:    Fri May 19 02:52:52 PDT 2000
>Last-Modified:  Fri May 19 02:54:03 PDT 2000
>Originator:     tomoShige Tashiro
>Release:        FreeBSD 4.0-20000214-CURRENT
>Organization:
Toyohashi-city Japan.
>Environment:
FreeBSD view.bsd 4.0-20000214-CURRENT FreeBSD 4.0-20000214-CURRENT #2: Thu Mar 23 22:47:03 JST 2000     root@view.bsd:/usr/src/sys/compile/BP6  i386

>Description:
ports/www/wwwoffle/pkg/INSTALL script don't refer 
ports/www/wwwoffle/Makefile SPOOL variable.
fixed SPOOL as /var/spool (in INSTALL line 9).

I don't know really if it's a bug. (^^;
I think wwwoffle/Makefile SPOOL variable designed for to enable change.
>How-To-Repeat:
cd ports/www/wwwoffle
change Makefile from
SPOOL=          /var/spool
to
SPOOL=          /home
then make install
and says
# upgrade cache, convert cache, build additional files, configure html and wwwoffle.conf
/bin/sh /usr/ports/www/wwwoffle/pkg/INSTALL wwwoffle-2.4 POST-INSTALL
/usr/ports/www/wwwoffle/pkg/INSTALL wwwoffle-2.4 POST-INSTALL
upgrading spool directory
upgrade-cache[1653] Fatal: Cannot change to the spool directory [No such file or directory]; upgrade failed.
*** Error code 2

Stop in /usr/ports/www/wwwoffle.

occur

>Fix:
I don't know...

>Release-Note:
>Audit-Trail:

From: Ben Smithurst <ben@scientia.demon.co.uk>
To: freebsd-gnats-submit@FreeBSD.org
Cc: shige2@pop17.odn.ne.jp
Subject: Re: ports/17603: ports/www/wwwoffle SPOOL=/home, then fail pkg/INSTALL
Date: Wed, 3 May 2000 16:07:25 +0100

 I've just submitted a patch which will hopefully fix this in another
 PR (sorry, it should have been a followup to this one really).  Could
 you try it?  Here it is in case you can't find the other PR...  Just do
 "make WWWOFFLE_SPOOL=/home install" rather than editing the Makefile.
 
 Index: Makefile
 ===================================================================
 RCS file: /usr/cvs/ports/www/wwwoffle/Makefile,v
 retrieving revision 1.8
 diff -u -r1.8 Makefile
 --- Makefile	2000/04/29 20:33:42	1.8
 +++ Makefile	2000/05/03 14:57:01
 @@ -21,9 +21,28 @@
  MAN5=		wwwoffle.conf.5
  MAN8=		wwwoffled.8
  
 -SPOOL=		/var/spool
 +# $SPOOL seems like a common name which could be used for other things, so
 +# use $WWWOFFLE_SPOOL as the overriding setting.
 +WWWOFFLE_SPOOL?=	/var/spool
 +SPOOL=		${WWWOFFLE_SPOOL}
  
 +PLIST_SUB+=	SPOOL=${SPOOL}
 +
 +.if ${SPOOL} != "/var/spool"
 +# If using a non-standard spool, change all the documentation (and anything
 +# else) to reflect that.
 +PKGMESSAGE=${WRKDIR}/MESSAGE
 +post-patch:
 +	find ${WRKSRC} | xargs ${CHMOD} u+w
 +	find ${WRKSRC} -type f | \
 +	  xargs perl -pi -e 's@/var/spool/wwwoffle@${SPOOL}/wwwoffle@g'
 +	sed 's@/var/spool/wwwoffle@${SPOOL}/wwwoffle@g' \
 +	  ${PKGDIR}/MESSAGE > ${PKGMESSAGE}
 +.endif
 +
  MAKE_ENV+=	SPOOL="${SPOOL}" \
 +		BINOWN="${BINOWN}" \
 +		BINGRP="${BINGRP}" \
  		INSTALL_PROGRAM="${INSTALL_PROGRAM}" \
  		INSTALL_DATA="${INSTALL_DATA}" \
  		INSTALL_MAN="${INSTALL_MAN}"
 Index: patches/patch-aa
 ===================================================================
 RCS file: /usr/cvs/ports/www/wwwoffle/patches/patch-aa,v
 retrieving revision 1.3
 diff -u -r1.3 patch-aa
 --- patch-aa	2000/04/29 20:33:43	1.3
 +++ patch-aa	2000/05/03 14:24:30
 @@ -129,6 +129,17 @@
   	  done )
   
   
 +@@ -354,8 +353,8 @@
 + 	cd $(SPOOLDIR)/html && ./fixup-install.sh $(SPOOLDIR) $(LOCALHOST) && rm ./fixup-install.sh
 + # Now fix the permissions that tar preserved, we needed to use 'tar xpf' to get round root's umask.
 + # These two will fail unless you are root, that is OK because the owner is already you.
 +-	-chown -R 0 $(SPOOLDIR)/html > /dev/null 2>&1
 +-	-chgrp -R 0 $(SPOOLDIR)/html > /dev/null 2>&1
 ++	-chown -R ${BINOWN} $(SPOOLDIR)/html > /dev/null 2>&1
 ++	-chgrp -R ${BINGRP} $(SPOOLDIR)/html > /dev/null 2>&1
 + 
 + install_config :
 + 	sed -e 's%SPOOLDIR%$(SPOOLDIR)%' -e 's%CONFDIR%$(CONFDIR)%' < wwwoffle.conf > wwwoffle.conf.install
  @@ -365,7 +364,7 @@
   	  echo "WWWOFFLE: There is already a configuration file $(CONFDIR)/wwwoffle.conf." ;\
   	  echo "WWWOFFLE: Run 'perl upgrade-config.pl $(CONFDIR)/wwwoffle.conf' to upgrade it." ;\
 Index: pkg/PLIST
 ===================================================================
 RCS file: /usr/cvs/ports/www/wwwoffle/pkg/PLIST,v
 retrieving revision 1.5
 diff -u -r1.5 PLIST
 --- PLIST	2000/04/29 20:33:44	1.5
 +++ PLIST	2000/05/03 14:06:28
 @@ -22,7 +22,7 @@
  share/doc/wwwoffle/README.win32
  share/doc/wwwoffle/UPGRADE
  @dirrm share/doc/wwwoffle
 -@cwd /var/spool
 +@cwd %%SPOOL%%
  wwwoffle/html/FAQ.html
  wwwoffle/html/Welcome.html
  wwwoffle/html/htdig/button1.gif
 
 -- 
 Ben Smithurst / ben@scientia.demon.co.uk / PGP: 0x99392F7D
 
State-Changed-From-To: open->closed 
State-Changed-By: sobomax 
State-Changed-When: Fri May 19 02:52:52 PDT 2000 
State-Changed-Why:  
Fixed in the just committed ports/18372 PR. 
>Unformatted:
