From nobody@FreeBSD.org  Thu Feb  7 18:53:22 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
	by hub.freebsd.org (Postfix) with ESMTP id C4AC3227
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  7 Feb 2013 18:53:22 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id B696C6EB
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  7 Feb 2013 18:53:22 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r17IrMgc033639
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 7 Feb 2013 18:53:22 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id r17IrMGS033638;
	Thu, 7 Feb 2013 18:53:22 GMT
	(envelope-from nobody)
Message-Id: <201302071853.r17IrMGS033638@red.freebsd.org>
Date: Thu, 7 Feb 2013 18:53:22 GMT
From: Pawel Pekala <pawel@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: x11-clocks/xclock links to iconv
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         175935
>Category:       ports
>Synopsis:       x11-clocks/xclock links to iconv
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-x11
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Feb 07 19:00:00 UTC 2013
>Closed-Date:    Thu Jun 27 13:39:30 UTC 2013
>Last-Modified:  Thu Jun 27 13:40:00 UTC 2013
>Originator:     Pawel Pekala
>Release:        10.0-CURRENT
>Organization:
>Environment:
FreeBSD blaviken.slowicza.org 10.0-CURRENT FreeBSD 10.0-CURRENT #4: Sat Feb  2 10:36:19 CET 2013     corn@blaviken.slowicza.org:/usr/obj/usr/src/sys/BLAVIKEN64  amd64
>Description:
[corn:~]> ldd /usr/local/bin/xclock | grep iconv
        libiconv.so.3 => /usr/local/lib/libiconv.so.3 (0x801242000)

This is not recorded in dependency list.

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -urN /usr/ports/x11-clocks/xclock/Makefile x11-clocks/xclock/Makefile
--- /usr/ports/x11-clocks/xclock/Makefile	2012-11-17 07:03:24.000000000 +0100
+++ x11-clocks/xclock/Makefile	2013-02-07 19:32:21.000000000 +0100
@@ -7,12 +7,14 @@
 
 PORTNAME=	xclock
 PORTVERSION=	1.0.6
+PORTREVISION=	1
 CATEGORIES=	x11-clocks
 
 MAINTAINER=	x11@FreeBSD.org
 COMMENT=	Analog and digital clock for X
 
 XORG_CAT=	app
+USE_ICONV=	yes
 USE_XORG=	xrender xft xkbfile xt xaw
 
 MAN1=		xclock.1


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->freebsd-x11 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Feb 7 19:00:08 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=175935 
Responsible-Changed-From-To: freebsd-x11->x11 
Responsible-Changed-By: pawel 
Responsible-Changed-When: Thu Feb 7 19:10:37 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=175935 

From: John Hein <jhein@symmetricom.com>
To: <pawel@FreeBSD.org>
Cc: bug-followup@freebsd.org
Subject: Re: ports/175935: x11-clocks/xclock links to iconv
Date: Thu, 7 Feb 2013 12:27:11 -0700

 xclock will use iconv if it's there, but it's optional.
 
 From xclock's configure on a system without iconv...
 
 checking for iconv... no, consider installing GNU libiconv
 
 and...
 
 % ldd /usr/local/bin/xclock | grep iconv || echo nope
 nope
 
 
 So forcing iconv into xclock's dependencies is probably wrong in this
 case.

From: Eitan Adler <lists@eitanadler.com>
To: John Hein <jhein@symmetricom.com>
Cc: x11@freebsd.org, bug-followup <bug-followup@freebsd.org>
Subject: Re: ports/175935: x11-clocks/xclock links to iconv
Date: Thu, 7 Feb 2013 14:38:57 -0500

 On 7 February 2013 14:30, John Hein <jhein@symmetricom.com> wrote:
 > The following reply was made to PR ports/175935; it has been noted by GNATS.
 >
 > From: John Hein <jhein@symmetricom.com>
 > To: <pawel@FreeBSD.org>
 > Cc: bug-followup@freebsd.org
 > Subject: Re: ports/175935: x11-clocks/xclock links to iconv
 > Date: Thu, 7 Feb 2013 12:27:11 -0700
 >
 >  xclock will use iconv if it's there, but it's optional.
 
 Many ports do this.  This is entirely a bug.  Imagine building on a
 different machine than one will be running.
 
 >  From xclock's configure on a system without iconv...
 
 The correct fix is to explicitly disable iconv, explicitly enable it,
 or make it an OPTION.
 
 As is though, is buggy.
 
 
 -- 
 Eitan Adler

From: Pawel Pekala <pawel@FreeBSD.org>
To: John Hein <jhein@symmetricom.com>
Cc: bug-followup@freebsd.org
Subject: Re: ports/175935: x11-clocks/xclock links to iconv
Date: Thu, 7 Feb 2013 20:38:14 +0100

 Dnia 2013-02-07, o godz. 12:27:11
 John Hein <jhein@symmetricom.com> napisa=B3(a):
 
 >xclock will use iconv if it's there, but it's optional.
 >
 >From xclock's configure on a system without iconv...
 >
 >checking for iconv... no, consider installing GNU libiconv
 >
 >and...
 >
 >% ldd /usr/local/bin/xclock | grep iconv || echo nope
 >nope
 >
 >
 >So forcing iconv into xclock's dependencies is probably wrong in this
 >case.
 
 On systems with iconv installed (this is pretty common package) this
 means incomplete dependency list... My patch is just a proposition and
 if maintainer decide to turn off linking with iconv it's fine too. For
 optional features we have options framework.
 
 --=20
 pozdrawiam / with regards
 Pawe=B3 P=EAkala

From: John Hein <jhein@symmetricom.com>
To: Eitan Adler <lists@eitanadler.com>
Cc: bug-followup <bug-followup@freebsd.org>
Subject: Re: ports/175935: x11-clocks/xclock links to iconv
Date: Thu, 7 Feb 2013 13:46:38 -0700

 Eitan Adler wrote at 14:38 -0500 on Feb  7, 2013:
  > The correct fix is to explicitly disable iconv, explicitly enable it,
  > or make it an OPTION.
 
 Fair enough.  OPTION it (default off - who uses iconv with xclock?).
 More work for the maintainer, but that seems like the best choice
 given our current tools.
 
 It'd be nice if we could have dynamic dependencies (dynamic at port
 build time, that is) for cases like this where the user couldn't
 really care either way about the feature, but removing a dependency
 breaks it.
Responsible-Changed-From-To: x11->freebsd-x11 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Mon Feb 11 13:08:41 UTC 2013 
Responsible-Changed-Why:  
Canonicalize assignment. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=175935 
State-Changed-From-To: open->closed 
State-Changed-By: zeising 
State-Changed-When: Thu Jun 27 13:39:30 UTC 2013 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=175935 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/175935: commit references a PR
Date: Thu, 27 Jun 2013 13:39:25 +0000 (UTC)

 Author: zeising
 Date: Thu Jun 27 13:39:18 2013
 New Revision: 321891
 URL: http://svnweb.freebsd.org/changeset/ports/321891
 
 Log:
   Add explicit dependency on iconv.
   Bump portrevision.
   
   PR:		ports/175935
   Submitted by:	Pawel Pekala <pawel@FreeBSD.org>
 
 Modified:
   head/x11-clocks/xclock/Makefile
 
 Modified: head/x11-clocks/xclock/Makefile
 ==============================================================================
 --- head/x11-clocks/xclock/Makefile	Thu Jun 27 13:37:03 2013	(r321890)
 +++ head/x11-clocks/xclock/Makefile	Thu Jun 27 13:39:18 2013	(r321891)
 @@ -2,6 +2,7 @@
  
  PORTNAME=	xclock
  PORTVERSION=	1.0.6
 +PORTREVISION=	1
  CATEGORIES=	x11-clocks
  
  MAINTAINER=	x11@FreeBSD.org
 @@ -9,6 +10,7 @@ COMMENT=	Analog and digital clock for X
  
  XORG_CAT=	app
  USE_XORG=	xrender xft xkbfile xt xaw
 +USES=		iconv
  
  MAN1=		xclock.1
  
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
