From nobody@FreeBSD.org  Sat Feb  2 20:23:15 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id A48E3C24
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  2 Feb 2013 20:23:15 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 922EE334
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  2 Feb 2013 20:23:15 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r12KNE38081264
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 2 Feb 2013 20:23:14 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id r12KNEp8081263;
	Sat, 2 Feb 2013 20:23:14 GMT
	(envelope-from nobody)
Message-Id: <201302022023.r12KNEp8081263@red.freebsd.org>
Date: Sat, 2 Feb 2013 20:23:14 GMT
From: Alex Kozlov <spam@rm-rf.kiev.ua>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] graphics/renrot remove SITE_PERL from RUN_DEPENDS
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: zeus@ibs.dn.ua

>Number:         175785
>Category:       ports
>Synopsis:       [patch] graphics/renrot remove SITE_PERL from RUN_DEPENDS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ak
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Feb 02 20:30:00 UTC 2013
>Closed-Date:    Sun Feb 17 11:28:40 UTC 2013
>Last-Modified:  Sun Feb 17 11:30:01 UTC 2013
>Originator:     Alex Kozlov
>Release:        RELENG_9
>Organization:
private
>Environment:
>Description:
- remove SITE_PERL from RUN_DEPENDS
  (see https://wiki.freebsd.org/PortsLongtermTargets#Use_of_SITE_PERL_in_dependencies)
- use ETCDIR
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: graphics/renrot/Makefile
@@ -25,14 +25,13 @@
 .include <bsd.port.options.mk>
 
 .if ${PORT_OPTIONS:MIMAGEMAGICK}
-RUN_DEPENDS+=	${SITE_PERL}/${PERL_ARCH}/Image/Magick.pm:${PORTSDIR}/graphics/ImageMagick
+RUN_DEPENDS+=	ImageMagick>=0:${PORTSDIR}/graphics/ImageMagick
 .endif
 
 post-install:
-	@${MKDIR} ${PREFIX}/etc/${PORTNAME}
+	@${MKDIR} ${ETCDIR}
 .for conf in colors.conf copyright.tag renrot.conf tags.conf
-	${INSTALL_DATA} ${WRKSRC}/etc/${conf} \
-		${PREFIX}/etc/${PORTNAME}/${conf}.sample
+	${INSTALL_DATA} ${WRKSRC}/etc/${conf} ${ETCDIR}/${conf}.sample
 .endfor
 .if ${PORT_OPTIONS:MDOCS}
 	@${MKDIR} ${DOCSDIR}


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sat Feb 2 20:30:07 UTC 2013 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=175785 
Responsible-Changed-From-To: freebsd-ports-bugs->ak 
Responsible-Changed-By: ak 
Responsible-Changed-When: Sat Feb 2 20:31:09 UTC 2013 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=175785 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: zeus@ibs.dn.ua
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/175785: [patch] graphics/renrot remove SITE_PERL from RUN_DEPENDS
Date: Sat, 2 Feb 2013 20:30:06 UT

 Maintainer of graphics/renrot,
 
 Please note that PR ports/175785 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/175785
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
State-Changed-From-To: feedback->closed 
State-Changed-By: ak 
State-Changed-When: Sun Feb 17 11:28:35 UTC 2013 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=175785 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/175785: commit references a PR
Date: Sun, 17 Feb 2013 11:27:15 +0000 (UTC)

 Author: ak
 Date: Sun Feb 17 11:27:07 2013
 New Revision: 312411
 URL: http://svnweb.freebsd.org/changeset/ports/312411
 
 Log:
   - Remove SITE_PERL from RUN_DEPENDS; don't rely on ImageMagick package name, it can be changed via PKGNAMESUFFIX
   - Use ETCDIR
   
   PR:	ports/175785
   Approved by:	maintainer timeout (2 weeks)
 
 Modified:
   head/graphics/renrot/Makefile   (contents, props changed)
 
 Modified: head/graphics/renrot/Makefile
 ==============================================================================
 --- head/graphics/renrot/Makefile	Sun Feb 17 10:43:22 2013	(r312410)
 +++ head/graphics/renrot/Makefile	Sun Feb 17 11:27:07 2013	(r312411)
 @@ -25,14 +25,13 @@ PORTDOCS=	AUTHORS README ChangeLog NEWS 
  .include <bsd.port.options.mk>
  
  .if ${PORT_OPTIONS:MIMAGEMAGICK}
 -RUN_DEPENDS+=	${SITE_PERL}/${PERL_ARCH}/Image/Magick.pm:${PORTSDIR}/graphics/ImageMagick
 +RUN_DEPENDS+=	convert:${PORTSDIR}/graphics/ImageMagick
  .endif
  
  post-install:
 -	@${MKDIR} ${PREFIX}/etc/${PORTNAME}
 +	@${MKDIR} ${ETCDIR}
  .for conf in colors.conf copyright.tag renrot.conf tags.conf
 -	${INSTALL_DATA} ${WRKSRC}/etc/${conf} \
 -		${PREFIX}/etc/${PORTNAME}/${conf}.sample
 +	${INSTALL_DATA} ${WRKSRC}/etc/${conf} ${ETCDIR}/${conf}.sample
  .endfor
  .if ${PORT_OPTIONS:MDOCS}
  	@${MKDIR} ${DOCSDIR}
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
