From brad@liquidneon.com  Wed Jan 23 21:34:17 2013
Return-Path: <brad@liquidneon.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id DB9E0E64
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 23 Jan 2013 21:34:17 +0000 (UTC)
	(envelope-from brad@liquidneon.com)
Received: from valentine.liquidneon.com (valentine.liquidneon.com [216.87.78.132])
	by mx1.freebsd.org (Postfix) with ESMTP id B5E0810B
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 23 Jan 2013 21:34:17 +0000 (UTC)
Received: by valentine.liquidneon.com (Postfix, from userid 1001)
	id 8117E8FF41; Wed, 23 Jan 2013 14:34:11 -0700 (MST)
Message-Id: <20130123213411.8117E8FF41@valentine.liquidneon.com>
Date: Wed, 23 Jan 2013 14:34:11 -0700 (MST)
From: Brad Davis <brd@FreeBSD.org>
Reply-To: Brad Davis <brd@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] net-mgmt/rackmonkey: Fix a redirect
X-Send-Pr-Version: 3.113
X-GNATS-Notify: ecrist@secure-computing.net

>Number:         175534
>Category:       ports
>Synopsis:       [patch] net-mgmt/rackmonkey: Fix a redirect
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    lippe
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 23 21:40:01 UTC 2013
>Closed-Date:    Fri Jun 28 18:21:43 UTC 2013
>Last-Modified:  Fri Jun 28 18:21:43 UTC 2013
>Originator:     Brad Davis
>Release:        FreeBSD 9.1-RELEASE i386
>Organization:
>Environment:

	
>Description:
	Fix the redirect to not drop HTTPS
>How-To-Repeat:
	
>Fix:

	

--- patch--rackmonkey.pl begins here ---
--- perl/rackmonkey.pl.ori	2013-01-23 14:28:16.000000000 -0700
+++ perl/rackmonkey.pl	2013-01-23 14:29:17.000000000 -0700
@@ -82,7 +82,7 @@
 
         my $lastCreatedId = $backend->performAct($cgi->actOn, $act, $loggedInUser, scalar($cgi->vars));
         $id = $lastCreatedId if (!$id);    # use lastCreatedId if there isn't an id
-        my $redirectUrl = "$fullURL?view=$view&view_type=$viewType";
+        my $redirectUrl = "$$conf{'wwwpath'}/?view=$view&view_type=$viewType";
         $redirectUrl .= "&id=$id"                      if ($id);
         $redirectUrl .= "&last_created_id=$lastCreatedId";
         $redirectUrl .= "&device_search=$deviceSearch" if ($deviceSearch);
--- patch--rackmonkey.pl ends here ---


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed Jan 23 21:40:08 UTC 2013 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=175534 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: ecrist@secure-computing.net
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/175534: [patch] net-mgmt/rackmonkey: Fix a redirect
Date: Wed, 23 Jan 2013 21:40:07 UT

 Maintainer of net-mgmt/rackmonkey,
 
 Please note that PR ports/175534 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/175534
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: freebsd-ports-bugs->lippe 
Responsible-Changed-By: lippe 
Responsible-Changed-When: Thu Jun 27 18:54:22 UTC 2013 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=175534 

From: Eric Crist <ecrist@secure-computing.net>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/175534: [patch] net-mgmt/rackmonkey: Fix a redirect
Date: Thu, 27 Jun 2013 14:03:02 -0500

 I need to know more about what this patch does, and whether the upstream =
 was contacted.  A patch like this a the package level isn't generally =
 appropriate unless the upstream in uncooperative.
 
 -----
 Eric F Crist
 
 
 
 On Jan 23, 2013, at 15:40:07, Edwin Groothuis <edwin@FreeBSD.org> wrote:
 
 > Maintainer of net-mgmt/rackmonkey,
 >=20
 > Please note that PR ports/175534 has just been submitted.
 >=20
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >=20
 > The full text of the PR can be found at:
 >    http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/175534
 >=20
 > --=20
 > Edwin Groothuis via the GNATS Auto Assign Tool
 > edwin@FreeBSD.org
 

From: Felippe de Meirelles Motta <lippe@FreeBSD.org>
To: bug-followup@FreeBSD.org, brd@FreeBSD.org, 
	Eric Crist <ecrist@secure-computing.net>
Cc:  
Subject: Re: ports/175534: [patch] net-mgmt/rackmonkey: Fix a redirect
Date: Fri, 28 Jun 2013 14:53:50 -0300

 --f46d04427270b5da5704e03a8fcf
 Content-Type: text/plain; charset=ISO-8859-1
 
 Brad,
 
 Could you explain more about this patch to Eric?
 
 Both,
 
 We can consider to use this patch as OPTION ?
 
 Tks
 lippe@
 
 --f46d04427270b5da5704e03a8fcf
 Content-Type: text/html; charset=ISO-8859-1
 
 Brad,<br><br>Could you explain more about this patch to Eric?<br><br>Both,<br><br>We can consider to use this patch as OPTION ?<br><br>Tks<br>lippe@<br>
 
 --f46d04427270b5da5704e03a8fcf--

From: Felippe de Meirelles Motta <lippe@FreeBSD.org>
To: Eric Crist <ecrist@secure-computing.net>
Cc: bug-followup@freebsd.org, brd@freebsd.org
Subject: Re: ports/175534: [patch] net-mgmt/rackmonkey: Fix a redirect
Date: Fri, 28 Jun 2013 15:06:57 -0300

 --089e0112c78c9cd05704e03abeb0
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: quoted-printable
 
 Ok, so I=B4ll proceed to close this PR.
 
 Thanks
 lippe@
 
 On Fri, Jun 28, 2013 at 3:02 PM, Eric Crist <ecrist@secure-computing.net>wr=
 ote:
 
 > Tks,
 >
 > Without knowing more, it's not even really an option.  I have a good
 > rapport with the main developer, so pushing patches upstream isn't
 > difficult.  Arbitrary options to appease single users doesn't really keep=
  a
 > tidy house.
 >
 > -----
 > Eric F Crist
 >
 >
 >
 > On Jun 28, 2013, at 12:53:50, Felippe de Meirelles Motta <lippe@FreeBSD.o=
 rg>
 > wrote:
 >
 > > Brad,
 > >
 > > Could you explain more about this patch to Eric?
 > >
 > > Both,
 > >
 > > We can consider to use this patch as OPTION ?
 > >
 > > Tks
 > > lippe@
 >
 >
 
 --089e0112c78c9cd05704e03abeb0
 Content-Type: text/html; charset=ISO-8859-1
 Content-Transfer-Encoding: quoted-printable
 
 Ok, so I=B4ll proceed to close this PR.<br><br>Thanks<br>lippe@<br><br><div=
  class=3D"gmail_quote">On Fri, Jun 28, 2013 at 3:02 PM, Eric Crist <span di=
 r=3D"ltr">&lt;<a href=3D"mailto:ecrist@secure-computing.net" target=3D"_bla=
 nk">ecrist@secure-computing.net</a>&gt;</span> wrote:<br>
 <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
 x #ccc solid;padding-left:1ex">Tks,<br>
 <br>
 Without knowing more, it&#39;s not even really an option. =A0I have a good =
 rapport with the main developer, so pushing patches upstream isn&#39;t diff=
 icult. =A0Arbitrary options to appease single users doesn&#39;t really keep=
  a tidy house.<br>
 
 <br>
 -----<br>
 Eric F Crist<br>
 <div class=3D"HOEnZb"><div class=3D"h5"><br>
 <br>
 <br>
 On Jun 28, 2013, at 12:53:50, Felippe de Meirelles Motta &lt;lippe@FreeBSD.=
 org&gt; wrote:<br>
 <br>
 &gt; Brad,<br>
 &gt;<br>
 &gt; Could you explain more about this patch to Eric?<br>
 &gt;<br>
 &gt; Both,<br>
 &gt;<br>
 &gt; We can consider to use this patch as OPTION ?<br>
 &gt;<br>
 &gt; Tks<br>
 &gt; lippe@<br>
 <br>
 </div></div></blockquote></div><br>
 
 --089e0112c78c9cd05704e03abeb0--

From: Eric Crist <ecrist@secure-computing.net>
To: Felippe de Meirelles Motta <lippe@FreeBSD.org>
Cc: bug-followup@FreeBSD.org,
 brd@FreeBSD.org
Subject: Re: ports/175534: [patch] net-mgmt/rackmonkey: Fix a redirect
Date: Fri, 28 Jun 2013 13:02:30 -0500

 Tks,
 
 Without knowing more, it's not even really an option.  I have a good =
 rapport with the main developer, so pushing patches upstream isn't =
 difficult.  Arbitrary options to appease single users doesn't really =
 keep a tidy house.
 
 -----
 Eric F Crist
 
 
 
 On Jun 28, 2013, at 12:53:50, Felippe de Meirelles Motta =
 <lippe@FreeBSD.org> wrote:
 
 > Brad,
 >=20
 > Could you explain more about this patch to Eric?
 >=20
 > Both,
 >=20
 > We can consider to use this patch as OPTION ?
 >=20
 > Tks
 > lippe@
 
State-Changed-From-To: feedback->closed 
State-Changed-By: lippe 
State-Changed-When: Fri Jun 28 18:21:42 UTC 2013 
State-Changed-Why:  
Closing this PR because patch was not approved by maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=175534 
>Unformatted:
