From nobody@FreeBSD.org  Wed Jan 23 11:19:06 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
	by hub.freebsd.org (Postfix) with ESMTP id 641B35CB
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 23 Jan 2013 11:19:06 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 554A1A37
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 23 Jan 2013 11:19:06 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r0NBJ53o079662
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 23 Jan 2013 11:19:05 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id r0NBJ5C8079661;
	Wed, 23 Jan 2013 11:19:05 GMT
	(envelope-from nobody)
Message-Id: <201301231119.r0NBJ5C8079661@red.freebsd.org>
Date: Wed, 23 Jan 2013 11:19:05 GMT
From: Cristiano Deana <cris@gufi.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: security/expiretable doesn't work in FreeBSD 9.x
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         175527
>Category:       ports
>Synopsis:       security/expiretable doesn't work in FreeBSD 9.x
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 23 11:20:00 UTC 2013
>Closed-Date:    Sat Jun 22 21:12:00 UTC 2013
>Last-Modified:  Sat Jun 22 21:20:00 UTC 2013
>Originator:     Cristiano Deana
>Release:        
>Organization:
>Environment:
>Description:
Due to changes in pf, expiretable doesn't work in FreeBSD 9.x

>How-To-Repeat:
Put some ip address in a table, call it "badhosts", then:

# /usr/local/sbin/expiretable -v -t 3600 badhosts
expiretable: badhosts: Failed to remove address(es).: Invalid argument
badhosts: -1 of 9 entries deleted.


>Fix:
Apply the patch below

Patch attached with submission follows:

diff -ruN expiretable.orig/Makefile expiretable/Makefile
--- expiretable.orig/Makefile	2012-11-17 07:01:03.000000000 +0100
+++ expiretable/Makefile	2013-01-23 12:07:01.000000000 +0100
@@ -7,6 +7,7 @@
 
 PORTNAME=	expiretable
 PORTVERSION=	0.6
+PORTREVISION=	1
 CATEGORIES=	security
 MASTER_SITES=	http://expiretable.fnord.se/
 
diff -ruN expiretable.orig/files/patch-expiretable expiretable/files/patch-expiretable
--- expiretable.orig/files/patch-expiretable	1970-01-01 01:00:00.000000000 +0100
+++ expiretable/files/patch-expiretable	2013-01-23 12:02:36.000000000 +0100
@@ -0,0 +1,10 @@
+--- expiretable.c.orig	2013-01-23 11:56:08.000000000 +0100
++++ expiretable.c	2013-01-23 11:56:26.000000000 +0100
+@@ -290,6 +290,7 @@
+ 			for (i = 0; i < astats_count; i++) {
+ 				if (astats[i].pfras_tzero <= min_timestamp) {
+ 					del_addrs_list[del_addrs_count] = astats[i].pfras_a;
++					del_addrs_list[del_addrs_count].pfra_fback = 0;
+ 					del_addrs_count++;
+ 				}
+ 			}


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: rakuco 
State-Changed-When: Sat Jun 22 21:11:58 UTC 2013 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=175527 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/175527: commit references a PR
Date: Sat, 22 Jun 2013 21:11:47 +0000 (UTC)

 Author: rakuco
 Date: Sat Jun 22 21:11:40 2013
 New Revision: 321592
 URL: http://svnweb.freebsd.org/changeset/ports/321592
 
 Log:
   Make the port work with FreeBSD 9.x and later.
   
   Due to changes in pf, expiretable wouldn't work on FreeBSD 9.x.
   
   PR:		ports/175527
   Submitted by:	Cristiano Deana <cris@gufi.org> (maintainer)
 
 Added:
   head/security/expiretable/files/patch-expiretable   (contents, props changed)
 Modified:
   head/security/expiretable/Makefile
 
 Modified: head/security/expiretable/Makefile
 ==============================================================================
 --- head/security/expiretable/Makefile	Sat Jun 22 21:05:04 2013	(r321591)
 +++ head/security/expiretable/Makefile	Sat Jun 22 21:11:40 2013	(r321592)
 @@ -1,12 +1,9 @@
 -# New ports collection makefile for: expiretable
 -# Date created:		7 January 2006
 -# Whom:			Cristiano Deana <cris@gufi.org>
 -#
 +# Created by: Cristiano Deana <cris@gufi.org>
  # $FreeBSD$
 -#
  
  PORTNAME=	expiretable
  PORTVERSION=	0.6
 +PORTREVISION=	1
  CATEGORIES=	security
  MASTER_SITES=	http://expiretable.fnord.se/
  
 
 Added: head/security/expiretable/files/patch-expiretable
 ==============================================================================
 --- /dev/null	00:00:00 1970	(empty, because file is newly added)
 +++ head/security/expiretable/files/patch-expiretable	Sat Jun 22 21:11:40 2013	(r321592)
 @@ -0,0 +1,10 @@
 +--- expiretable.c.orig	2013-01-23 11:56:08.000000000 +0100
 ++++ expiretable.c	2013-01-23 11:56:26.000000000 +0100
 +@@ -290,6 +290,7 @@
 + 			for (i = 0; i < astats_count; i++) {
 + 				if (astats[i].pfras_tzero <= min_timestamp) {
 + 					del_addrs_list[del_addrs_count] = astats[i].pfras_a;
 ++					del_addrs_list[del_addrs_count].pfra_fback = 0;
 + 					del_addrs_count++;
 + 				}
 + 			}
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
