From nobody@FreeBSD.org  Mon Jan 21 16:53:39 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id 0384CF3B
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 21 Jan 2013 16:53:39 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id C4B10EC5
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 21 Jan 2013 16:53:38 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r0LGrcQN086125
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 21 Jan 2013 16:53:38 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id r0LGrc41086124;
	Mon, 21 Jan 2013 16:53:38 GMT
	(envelope-from nobody)
Message-Id: <201301211653.r0LGrc41086124@red.freebsd.org>
Date: Mon, 21 Jan 2013 16:53:38 GMT
From: Fabian Keil <fk@fabiankeil.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: mail/claws-mail shouldn't enable the crash dialog if the DEBUG option is used
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         175482
>Category:       ports
>Synopsis:       mail/claws-mail shouldn't enable the crash dialog if the DEBUG option is used
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pawel
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 21 17:00:00 UTC 2013
>Closed-Date:    Thu Jan 24 16:07:01 UTC 2013
>Last-Modified:  Thu Jan 24 16:07:01 UTC 2013
>Originator:     Fabian Keil
>Release:        HEAD
>Organization:
>Environment:
FreeBSD r500.local 10.0-CURRENT FreeBSD 10.0-CURRENT #540 r+2048695: Thu Jan 17 14:09:36 CET 2013     fk@r500.local:/usr/obj/usr/src/sys/ZOEY  amd64

>Description:
In my experience claws-mail's crash dialog causes more problems than it solves.

The stack trace is usually bogus, can't be generated or claws-mail simply becomes unresponsive instead of properly creating a core dump that would actually be useful.

In case of claws-mail 3.9.0 "killall -SIGSEGV claws-mail" merely causes the
following console messages to appear:

claws.c:102:Starting Claws Mail version Claws Mail 3.9.0
main.c:2378:another Claws Mail instance is already running.

No dialog is shown and the GUI becomes unresponsive.

If http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=2862
wasn't reproducible, I wouldn't have been able to figure out the problem (which happened in the past).

Even if the crash dialog would work, I'd prefer it to be a separate option instead of being set depending on the DEBUG option. My expectation when compiling ports with DEBUG is getting usable core dumps.
>How-To-Repeat:
1. Build the claws-mail port with "DEBUG" support
2. Crash claws-mail
3. Notice that there is no core dump to analyze
>Fix:
The attached patch removes the --enable-crash-dialog configure option which solves the problem for me.

Patch attached with submission follows:

From 522f825a954e79562580b5f4fd8008fb970cc1e7 Mon Sep 17 00:00:00 2001
From: Fabian Keil <fk@fabiankeil.de>
Date: Mon, 21 Jan 2013 17:23:42 +0100
Subject: [PATCH] Don't enable the claws-mail 'crash dialog' which usually makes debugging
 harder

---
 mail/claws-mail/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mail/claws-mail/Makefile b/mail/claws-mail/Makefile
index 79b5266..c41e019 100644
--- a/mail/claws-mail/Makefile
+++ b/mail/claws-mail/Makefile
@@ -151,7 +151,7 @@ CONFIGURE_ARGS+=	--disable-pgpmime-plugin --disable-pgpcore-plugin \
 .endif
 
 .if ${PORT_OPTIONS:MDEBUG}
-CONFIGURE_ARGS+=	--enable-maintainer-mode --enable-crash-dialog
+CONFIGURE_ARGS+=	--enable-maintainer-mode
 .endif
 
 .if ${PORT_OPTIONS:MDILLO}
-- 
1.8.1



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->pawel 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Jan 21 17:00:08 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=175482 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/175482: commit references a PR
Date: Thu, 24 Jan 2013 15:51:47 +0000 (UTC)

 Author: pawel
 Date: Thu Jan 24 15:51:35 2013
 New Revision: 310935
 URL: http://svnweb.freebsd.org/changeset/ports/310935
 
 Log:
   Don't enable crash dialog when DEBUG=on - this prevents
   coredump file creation.
   
   PR:		ports/175482
   Submitted by:	Fabian Keil <fk@fabiankeil.de>
 
 Modified:
   head/mail/claws-mail/Makefile
 
 Modified: head/mail/claws-mail/Makefile
 ==============================================================================
 --- head/mail/claws-mail/Makefile	Thu Jan 24 15:48:20 2013	(r310934)
 +++ head/mail/claws-mail/Makefile	Thu Jan 24 15:51:35 2013	(r310935)
 @@ -151,7 +151,7 @@ CONFIGURE_ARGS+=	--disable-pgpmime-plugi
  .endif
  
  .if ${PORT_OPTIONS:MDEBUG}
 -CONFIGURE_ARGS+=	--enable-maintainer-mode --enable-crash-dialog
 +CONFIGURE_ARGS+=	--enable-maintainer-mode
  .endif
  
  .if ${PORT_OPTIONS:MDILLO}
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: pawel 
State-Changed-When: Thu Jan 24 16:06:59 UTC 2013 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=175482 
>Unformatted:
