From nobody@FreeBSD.org  Tue Dec 18 12:59:30 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 03177960
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 18 Dec 2012 12:59:30 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id DE56B8FC1E
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 18 Dec 2012 12:59:29 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id qBICxTQJ050907
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 18 Dec 2012 12:59:29 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id qBICxTKM050906;
	Tue, 18 Dec 2012 12:59:29 GMT
	(envelope-from nobody)
Message-Id: <201212181259.qBICxTKM050906@red.freebsd.org>
Date: Tue, 18 Dec 2012 12:59:29 GMT
From: Olivier Cochard-Labbe <olivier@cochard.me>
To: freebsd-gnats-submit@FreeBSD.org
Subject: net-mgmt/fprobe rc script patch
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         174539
>Category:       ports
>Synopsis:       net-mgmt/fprobe rc script patch
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Dec 18 13:00:00 UTC 2012
>Closed-Date:    Wed Jan 30 16:01:49 UTC 2013
>Last-Modified:  Wed Jan 30 16:10:00 UTC 2013
>Originator:     Olivier Cochard-Labbe
>Release:        9.1
>Organization:
BSD Router Project
>Environment:
FreeBSD orange.bsdrp.net 9.1-RELEASE FreeBSD 9.1-RELEASE #0 r243825: Tue Dec  4 09:23:10 UTC 2012     root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
Hi,
I've got a problem with the fprobe rc script that ignore use my own fprobe_flags in the rc.conf.
Here is a small patch that fix this problem.
>How-To-Repeat:

>Fix:
Applying this patch:

#cat patches/ports.fprobe.patch
--- net-mgmt/fprobe/files/fprobe.in.orig        2012-12-18 13:50:22.000000000 +0100
+++ net-mgmt/fprobe/files/fprobe.in     2012-12-18 13:51:43.000000000 +0100
@@ -17,9 +17,11 @@

 name="%%NAME%%"
 rcvar=%%NAME%%_enable
+load_rc_config $name
+: ${fprope_enable:=no}
+: ${fprobe_flags:="-i lo0 127.0.0.1:2055"}

 command="%%PREFIX%%/sbin/fprobe"
-command_args="-i lo0 127.0.0.1:2055"
 pidfile="/var/run/$name.pid"

 load_rc_config "$name"


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: jadawin 
State-Changed-When: Wed Jan 30 16:01:48 UTC 2013 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=174539 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/174539: commit references a PR
Date: Wed, 30 Jan 2013 16:01:52 +0000 (UTC)

 Author: jadawin
 Date: Wed Jan 30 16:01:32 2013
 New Revision: 311223
 URL: http://svnweb.freebsd.org/changeset/ports/311223
 
 Log:
   - Fix rc script for fprobe_flags
   
   PR:		ports/174539
   Submitted by:	Olivier Cochard-Labbe <olivier@cochard.me>
 
 Modified:
   head/net-mgmt/fprobe/files/fprobe.in   (contents, props changed)
 
 Modified: head/net-mgmt/fprobe/files/fprobe.in
 ==============================================================================
 --- head/net-mgmt/fprobe/files/fprobe.in	Wed Jan 30 16:01:28 2013	(r311222)
 +++ head/net-mgmt/fprobe/files/fprobe.in	Wed Jan 30 16:01:32 2013	(r311223)
 @@ -18,11 +18,12 @@
  name="%%NAME%%"
  rcvar=%%NAME%%_enable
  
 -command="%%PREFIX%%/sbin/fprobe"
 -command_args="-i lo0 127.0.0.1:2055"
 -pidfile="/var/run/$name.pid"
 -
  load_rc_config "$name"
 +
  : ${fprobe_enable="NO"}
 +: ${fprobe_flags:="-i lo0 127.0.0.1:2055"}
 +
 +command="%%PREFIX%%/sbin/fprobe"
 +pidfile="/var/run/$name.pid"
  
  run_rc_command "$1"
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
