From nobody@FreeBSD.org  Mon Dec 17 13:12:59 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id B009D361
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 17 Dec 2012 13:12:59 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 7E6E68FC18
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 17 Dec 2012 13:12:59 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id qBHDCxop077976
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 17 Dec 2012 13:12:59 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id qBHDCx6M077975;
	Mon, 17 Dec 2012 13:12:59 GMT
	(envelope-from nobody)
Message-Id: <201212171312.qBHDCx6M077975@red.freebsd.org>
Date: Mon, 17 Dec 2012 13:12:59 GMT
From: Pawel Pekala <pawel@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: x11/terminator add missing run deps
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: tom@hur.st

>Number:         174512
>Category:       ports
>Synopsis:       x11/terminator add missing run deps
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pawel
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 17 13:20:00 UTC 2012
>Closed-Date:    Fri Jan 04 21:48:38 UTC 2013
>Last-Modified:  Fri Jan  4 21:50:00 UTC 2013
>Originator:     Pawel Pekala
>Release:        10.0-CURRENT
>Organization:
>Environment:
FreeBSD blaviken.slowicza.org 10.0-CURRENT FreeBSD 10.0-CURRENT #2: Fri Nov 30 20:03:01 CET 2012     corn@blaviken.slowicza.org:/usr/obj/amd64.amd64/usr/src/sys/BLAVIKEN64  amd64

>Description:
When launching terminator from command line I get this warnings:

[corn:~]> terminator
ConfigBase::load: Unable to open /home/corn/.config/terminator/config ([Errno 2] No such file or directory: '/home/corn/.config/terminator/config')
Warning: python-keybinder is not installed. This means the hide_window shortcut will be unavailable
Unable to bind hide_window key, another instance/window has it.
ActivityWatch plugin unavailable: please install python-notify
PluginRegistry::load_plugins: Importing plugin activitywatch.py failed: 'module' object has no attribute 'AVAILABLE'

Clearly there are 2 missing run dependiences - my patch adds them.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -urN /usr/ports/x11/terminator/Makefile x11/terminator/Makefile
--- /usr/ports/x11/terminator/Makefile	2012-11-17 07:03:19.000000000 +0100
+++ x11/terminator/Makefile	2012-12-17 14:04:52.000000000 +0100
@@ -7,7 +7,7 @@
 
 PORTNAME=	terminator
 PORTVERSION=	0.96
-PORTREVISION=	3
+PORTREVISION=	4
 CATEGORIES=	x11 python
 MASTER_SITES=	http://launchpadlibrarian.net/80778747/ \
 		http://hur.st/mirror/terminator/
@@ -17,6 +17,10 @@
 
 LICENSE=	GPLv2
 
+RUN_DEPENDS=	${PYTHON_SITELIBDIR}/gtk-2.0/pynotify/_pynotify.so:${PORTSDIR}/devel/py-notify \
+		${PYTHON_SITELIBDIR}/keybinder/_keybinder.so:${PORTSDIR}/x11/keybinder \
+		${PYTHON_SITELIBDIR}/gtk-2.0/vtemodule.so:${PORTSDIR}/x11-toolkits/py-vte
+
 OPTIONS_DEFINE=	NLS GCONF
 GCONF_DESC=	Use GNOME Terminal settings
 OPTIONS_DEFAULT=	NLS GCONF
@@ -40,7 +44,6 @@
 PLIST_SUB+=	NLS=""
 .endif
 
-RUN_DEPENDS+=	${PYTHON_SITELIBDIR}/gtk-2.0/vtemodule.so:${PORTSDIR}/x11-toolkits/py-vte
 .if ${PORT_OPTIONS:MGCONF}
 USE_GNOME+=	pygnome2
 .endif


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Mon Dec 17 13:20:07 UTC 2012 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=174512 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: tom@hur.st
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/174512: x11/terminator add missing run deps
Date: Mon, 17 Dec 2012 13:20:07 UT

 Maintainer of x11/terminator,
 
 Please note that PR ports/174512 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/174512
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: freebsd-ports-bugs->pawel 
Responsible-Changed-By: pawel 
Responsible-Changed-When: Mon Dec 17 13:50:16 UTC 2012 
Responsible-Changed-Why:  
Mine 

http://www.freebsd.org/cgi/query-pr.cgi?pr=174512 
State-Changed-From-To: feedback->closed 
State-Changed-By: pawel 
State-Changed-When: Fri Jan 4 21:48:37 UTC 2013 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=174512 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/174512: commit references a PR
Date: Fri,  4 Jan 2013 21:48:34 +0000 (UTC)

 Author: pawel
 Date: Fri Jan  4 21:48:21 2013
 New Revision: 309941
 URL: http://svnweb.freebsd.org/changeset/ports/309941
 
 Log:
   - Add missing run deps
   - tab -> space WWW: line in pkg-descr
   
   PR:		ports/174512
   Submitted by:	myself
   Approved by:	maintainer timeout (2 weeks)
 
 Modified:
   head/x11/terminator/Makefile
   head/x11/terminator/pkg-descr
 
 Modified: head/x11/terminator/Makefile
 ==============================================================================
 --- head/x11/terminator/Makefile	Fri Jan  4 21:06:25 2013	(r309940)
 +++ head/x11/terminator/Makefile	Fri Jan  4 21:48:21 2013	(r309941)
 @@ -1,13 +1,9 @@
 -# New ports collection makefile for:	terminator
 -# Date created:		2008-03-14
 -# Whom:			Thomas Hurst <tom@hur.st>
 -#
 +# Created by: Thomas Hurst <tom@hur.st>
  # $FreeBSD$
 -#
  
  PORTNAME=	terminator
  PORTVERSION=	0.96
 -PORTREVISION=	3
 +PORTREVISION=	4
  CATEGORIES=	x11 python
  MASTER_SITES=	http://launchpadlibrarian.net/80778747/ \
  		http://hur.st/mirror/terminator/
 @@ -17,6 +13,10 @@ COMMENT=	Multiple GNOME terminals in one
  
  LICENSE=	GPLv2
  
 +RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}notify>=0:${PORTSDIR}/devel/py-notify \
 +		${PYTHON_SITELIBDIR}/keybinder/_keybinder.so:${PORTSDIR}/x11/keybinder \
 +		${PYTHON_PKGNAMEPREFIX}vte>=0:${PORTSDIR}/x11-toolkits/py-vte
 +
  OPTIONS_DEFINE=	NLS GCONF
  GCONF_DESC=	Use GNOME Terminal settings
  OPTIONS_DEFAULT=	NLS GCONF
 @@ -40,7 +40,6 @@ USE_GETTEXT=	yes
  PLIST_SUB+=	NLS=""
  .endif
  
 -RUN_DEPENDS+=	${PYTHON_SITELIBDIR}/gtk-2.0/vtemodule.so:${PORTSDIR}/x11-toolkits/py-vte
  .if ${PORT_OPTIONS:MGCONF}
  USE_GNOME+=	pygnome2
  .endif
 
 Modified: head/x11/terminator/pkg-descr
 ==============================================================================
 --- head/x11/terminator/pkg-descr	Fri Jan  4 21:06:25 2013	(r309940)
 +++ head/x11/terminator/pkg-descr	Fri Jan  4 21:48:21 2013	(r309941)
 @@ -2,4 +2,4 @@ Terminator is a Python terminal program,
  gnome-terminal to provide a tiled set of terminals in as little
  space as possible.
  
 -WWW:	http://www.tenshu.net/p/terminator.html
 +WWW: http://www.tenshu.net/p/terminator.html
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
