From nobody@FreeBSD.org  Fri Dec 14 13:08:03 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 2D1E4460
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 14 Dec 2012 13:08:03 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 098338FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 14 Dec 2012 13:08:03 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id qBED82JN002572
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 14 Dec 2012 13:08:02 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id qBED82We002571;
	Fri, 14 Dec 2012 13:08:02 GMT
	(envelope-from nobody)
Message-Id: <201212141308.qBED82We002571@red.freebsd.org>
Date: Fri, 14 Dec 2012 13:08:02 GMT
From: Ruslan Makhmatkhanov <rm@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: sysutils/gnome-system-tools: fix build with clang
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         174430
>Category:       ports
>Synopsis:       sysutils/gnome-system-tools: fix build with clang
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Dec 14 13:10:00 UTC 2012
>Closed-Date:    Fri Feb 08 16:55:30 UTC 2013
>Last-Modified:  Fri Feb  8 17:00:00 UTC 2013
>Originator:     Ruslan Makhmatkhanov
>Release:        10.0-CURRENT
>Organization:
>Environment:
10.0-CURRENT amd64
>Description:
Build fails with clang (3.2 (trunk 162107))

network-locations.c:1141:3: error: void function 'gst_network_locations_delete_location' should not return a value [-Wreturn-type]
  g_return_val_if_fail (GST_IS_NETWORK_LOCATIONS (locations), FALSE);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/include/glib-2.0/glib/gmessages.h:273:3: note: expanded from macro 'g_return_val_if_fail'
         return (val);                                                  \
         ^      ~~~~~
1 error generated.

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: files/patch-src-network_network-locations.c
===================================================================
--- files/patch-src-network_network-locations.c	(revision 0)
+++ files/patch-src-network_network-locations.c	(working copy)
@@ -0,0 +1,11 @@
+--- ./src/network/network-locations.c.orig	2010-05-24 21:09:57.000000000 +0400
++++ ./src/network/network-locations.c	2012-12-14 16:44:29.000000000 +0400
+@@ -1131,7 +1131,7 @@
+   return result;
+ }
+ 
+-void
++gboolean
+ gst_network_locations_delete_location (GstNetworkLocations *locations,
+ 				       const gchar         *name)
+ {

Property changes on: files/patch-src-network_network-locations.c
___________________________________________________________________
Added: svn:mime-type
## -0,0 +1 ##
+text/plain
\ No newline at end of property
Added: fbsd:nokeywords
## -0,0 +1 ##
+yes
\ No newline at end of property
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property
Index: files/patch-src-network_network-locations.h
===================================================================
--- files/patch-src-network_network-locations.h	(revision 0)
+++ files/patch-src-network_network-locations.h	(working copy)
@@ -0,0 +1,11 @@
+--- ./src/network/network-locations.h.orig	2010-05-24 21:09:57.000000000 +0400
++++ ./src/network/network-locations.h	2012-12-14 16:47:54.000000000 +0400
+@@ -62,7 +62,7 @@
+ 							      const gchar         *name);
+ gboolean               gst_network_locations_save_current    (GstNetworkLocations *locations,
+ 							      const gchar         *name);
+-void                   gst_network_locations_delete_location (GstNetworkLocations *locations,
++gboolean               gst_network_locations_delete_location (GstNetworkLocations *locations,
+ 							      const gchar         *name);
+ 
+ G_END_DECLS

Property changes on: files/patch-src-network_network-locations.h
___________________________________________________________________
Added: fbsd:nokeywords
## -0,0 +1 ##
+yes
\ No newline at end of property
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property
Added: svn:mime-type
## -0,0 +1 ##
+text/plain
\ No newline at end of property


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gnome 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Dec 14 13:10:09 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=174430 
State-Changed-From-To: open->closed 
State-Changed-By: kwm 
State-Changed-When: Fri Feb 8 16:55:18 UTC 2013 
State-Changed-Why:  
Comitted thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=174430 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/174430: commit references a PR
Date: Fri,  8 Feb 2013 16:55:20 +0000 (UTC)

 Author: kwm
 Date: Fri Feb  8 16:55:11 2013
 New Revision: 311945
 URL: http://svnweb.freebsd.org/changeset/ports/311945
 
 Log:
   Fix build with clang.
   
   PR:		ports/174430
   Submitted by:	rm@
 
 Added:
   head/sysutils/gnome-system-tools/files/patch-src_network_network-locations.c   (contents, props changed)
   head/sysutils/gnome-system-tools/files/patch-src_network_network-locations.h   (contents, props changed)
 
 Added: head/sysutils/gnome-system-tools/files/patch-src_network_network-locations.c
 ==============================================================================
 --- /dev/null	00:00:00 1970	(empty, because file is newly added)
 +++ head/sysutils/gnome-system-tools/files/patch-src_network_network-locations.c	Fri Feb  8 16:55:11 2013	(r311945)
 @@ -0,0 +1,11 @@
 +--- ./src/network/network-locations.c.orig	2010-05-24 21:09:57.000000000 +0400
 ++++ ./src/network/network-locations.c	2012-12-14 16:44:29.000000000 +0400
 +@@ -1131,7 +1131,7 @@
 +   return result;
 + }
 + 
 +-void
 ++gboolean
 + gst_network_locations_delete_location (GstNetworkLocations *locations,
 + 				       const gchar         *name)
 + {
 
 Added: head/sysutils/gnome-system-tools/files/patch-src_network_network-locations.h
 ==============================================================================
 --- /dev/null	00:00:00 1970	(empty, because file is newly added)
 +++ head/sysutils/gnome-system-tools/files/patch-src_network_network-locations.h	Fri Feb  8 16:55:11 2013	(r311945)
 @@ -0,0 +1,11 @@
 +--- ./src/network/network-locations.h.orig	2010-05-24 21:09:57.000000000 +0400
 ++++ ./src/network/network-locations.h	2012-12-14 16:47:54.000000000 +0400
 +@@ -62,7 +62,7 @@
 + 							      const gchar         *name);
 + gboolean               gst_network_locations_save_current    (GstNetworkLocations *locations,
 + 							      const gchar         *name);
 +-void                   gst_network_locations_delete_location (GstNetworkLocations *locations,
 ++gboolean               gst_network_locations_delete_location (GstNetworkLocations *locations,
 + 							      const gchar         *name);
 + 
 + G_END_DECLS
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
