From nemysis@gmx.ch  Tue Nov  6 16:29:37 2012
Return-Path: <nemysis@gmx.ch>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 59710AC5
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  6 Nov 2012 16:29:37 +0000 (UTC)
	(envelope-from nemysis@gmx.ch)
Received: from mailout-de.gmx.net (mailout-de.gmx.net [213.165.64.22])
	by mx1.freebsd.org (Postfix) with SMTP id 9D70C8FC12
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  6 Nov 2012 16:29:36 +0000 (UTC)
Received: (qmail invoked by alias); 06 Nov 2012 16:29:34 -0000
Received: from 201-230.4-85.cust.bluewin.ch (EHLO something.email.com) [85.4.230.201]
  by mail.gmx.net (mp030) with SMTP; 06 Nov 2012 17:29:34 +0100
Received: by something.email.com (sSMTP sendmail emulation); Tue, 06 Nov 2012 17:29:33 +0100
Message-Id: <20121106162937.59710AC5@hub.freebsd.org>
Date: Tue, 06 Nov 2012 17:29:33 +0100
From: nemysis <nemysis@gmx.ch>
To: FreeBSD-gnats-submit@freebsd.org
Cc: jgh@FreeBSD.org
Subject: [MAINTAINER] games/glightoff: Fixed NLS, removed notes
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         173424
>Category:       ports
>Synopsis:       [MAINTAINER] games/glightoff: Fixed NLS, removed notes
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    mva
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov 06 16:30:00 UTC 2012
>Closed-Date:    Tue Dec 25 14:28:58 UTC 2012
>Last-Modified:  Tue Dec 25 14:30:00 UTC 2012
>Originator:     nemysis
>Release:        FreeBSD 9.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD FreeBSD_Ports 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan  3 07:46:30 UTC
>Description:

Makefile changed:

Only with ! works
-.if empty(PORT_OPTIONS:MNLS)
+.if !${PORT_OPTIONS:MNLS}

Removed because is default
-NLS_DESC=	Native Language Support via gettext
-OPTIONS_DEFAULT=	NLS

Generated and tested manually, tested with port test, sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
>How-To-Repeat:

portlint -A
looks fine.

port test: clean

>Fix:

--- glightoff-1.0.0_1.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/games/glightoff/Makefile ./Makefile
--- /usr/ports/games/glightoff/Makefile	2012-08-26 01:41:32.000000000 +0200
+++ ./Makefile	2012-11-06 17:21:34.000000000 +0100
@@ -27,8 +27,6 @@
 PORTDOCS=	AUTHORS ChangeLog NEWS README TODO
 
 OPTIONS_DEFINE=	NLS
-NLS_DESC=	Native Language Support via gettext
-OPTIONS_DEFAULT=	NLS
 
 .include <bsd.port.options.mk>
 
@@ -40,17 +38,14 @@
 .endif
 
 post-configure:
 	@${REINPLACE_CMD} 's|src po|src|' ${WRKSRC}/Makefile
 .endif
 
 post-install:
-# Documentation
 .if ${PORT_OPTIONS:MDOCS}
 	${MKDIR} ${DOCSDIR}
-.  for f in ${PORTDOCS}
-	${INSTALL_DATA} ${WRKSRC}/${f} ${DOCSDIR}
-.  endfor
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
 .endif
 
 .include <bsd.port.mk>
--- glightoff-1.0.0_1.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->mva 
Responsible-Changed-By: mva 
Responsible-Changed-When: Sat Dec 22 11:03:12 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=173424 
State-Changed-From-To: open->closed 
State-Changed-By: mva 
State-Changed-When: Tue Dec 25 14:28:57 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=173424 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/173424: commit references a PR
Date: Tue, 25 Dec 2012 14:28:42 +0000 (UTC)

 Author: mva
 Date: Tue Dec 25 14:28:20 2012
 New Revision: 309484
 URL: http://svnweb.freebsd.org/changeset/ports/309484
 
 Log:
   - Fix NLS option behaviour
   
   PR:		ports/173424
   Submitted by:	nemysis <nemysis@gmx.ch> (maintainer)
 
 Modified:
   head/games/glightoff/Makefile
 
 Modified: head/games/glightoff/Makefile
 ==============================================================================
 --- head/games/glightoff/Makefile	Tue Dec 25 13:12:43 2012	(r309483)
 +++ head/games/glightoff/Makefile	Tue Dec 25 14:28:20 2012	(r309484)
 @@ -1,13 +1,9 @@
 -# New Ports collection makefile for:	glightoff
 -# Date created:		21 April 2012
 -# Whom:			nemysis@gmx.ch
 -#
 +# Created by:			nemysis@gmx.ch
  # $FreeBSD$
 -#
  
  PORTNAME=	glightoff
  PORTVERSION=	1.0.0
 -PORTREVISION=	1
 +PORTREVISION=	2
  CATEGORIES=	games
  MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/${PORTVERSION}
  
 @@ -27,8 +23,6 @@ LDFLAGS+=	-L${LOCALBASE}/lib
  PORTDOCS=	AUTHORS ChangeLog NEWS README TODO
  
  OPTIONS_DEFINE=	NLS
 -NLS_DESC=	Native Language Support via gettext
 -OPTIONS_DEFAULT=	NLS
  
  .include <bsd.port.options.mk>
  
 @@ -40,17 +34,14 @@ PLIST_SUB+=	NLS="@comment "
  .endif
  
  post-configure:
 -.if empty(PORT_OPTIONS:MNLS)
 +.if !${PORT_OPTIONS:MNLS}
  	@${REINPLACE_CMD} 's|src po|src|' ${WRKSRC}/Makefile
  .endif
  
  post-install:
 -# Documentation
  .if ${PORT_OPTIONS:MDOCS}
  	${MKDIR} ${DOCSDIR}
 -.  for f in ${PORTDOCS}
 -	${INSTALL_DATA} ${WRKSRC}/${f} ${DOCSDIR}
 -.  endfor
 +	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
  .endif
  
  .include <bsd.port.mk>
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
