From nox@saturn.kn-bremen.de  Thu Mar  9 18:08:09 2000
Return-Path: <nox@saturn.kn-bremen.de>
Received: from blaubaer.kn-bremen.de (blaubaer.kn-bremen.de [195.37.179.254])
	by hub.freebsd.org (Postfix) with ESMTP id DE26037B8D9
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  9 Mar 2000 18:07:59 -0800 (PST)
	(envelope-from nox@saturn.kn-bremen.de)
Received: from saturn.kn-bremen.de (uucp@localhost)
	by blaubaer.kn-bremen.de (8.9.1/8.9.1) with UUCP id CAA13555
	for FreeBSD-gnats-submit@freebsd.org; Fri, 10 Mar 2000 02:11:24 +0100
Received: (from nox@localhost)
	by saturn.kn-bremen.de (8.9.3/8.8.5) id CAA64413;
	Fri, 10 Mar 2000 02:09:32 +0100 (CET)
Message-Id: <200003100109.CAA64413@saturn.kn-bremen.de>
Date: Fri, 10 Mar 2000 02:09:32 +0100 (CET)
From: Juergen Lock <nox@jelal.kn-bremen.de>
Sender: nox@saturn.kn-bremen.de
Reply-To: nox@jelal.kn-bremen.de
To: FreeBSD-gnats-submit@freebsd.org
Subject: net/openh323 port broken (for -stable at least...)
X-Send-Pr-Version: 3.2

>Number:         17296
>Category:       ports
>Synopsis:       net/openh323 port broken (for -stable at least...)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    roger
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar  9 18:10:02 PST 2000
>Closed-Date:    Tue Apr 4 06:22:38 PDT 2000
>Last-Modified:  Tue Apr  4 06:26:47 PDT 2000
>Originator:     Juergen Lock
>Release:        FreeBSD 3.4-STABLE i386
>Organization:
me?  organized??
>Environment:

	3.4-STABLE i386

>Description:

	port doesn't built, for some reason its makefile doesn't
	get the OSTYPE from uname -s correctly, and the socklen_t
	typedef it does for everything < 4.x conflicts with whats
	now also in the -stable headers.

>How-To-Repeat:

	just try to build it on a fairly recent -stable box

>Fix:

Index: Makefile
@@ -22,6 +22,7 @@
 USE_BISON=	yes
 USE_GMAKE=      yes
 ALL_TARGET=	opt
+MAKE_ARGS+=	OSTYPE=FreeBSD
 MAKE_ENV=	PWLIBDIR=${WRKDIR}/pwlib \
 		OPENH323DIR=${WRKDIR}/openh323
 do-install:
Index: patches/patch-socklen
@@ -0,0 +1,10 @@
+Index: ../pwlib/include/ptlib/unix/ptlib/pmachdep.h
+@@ -127,7 +127,7 @@
+ 
+ /* socklen_t is defined in FreeBSD 4.0 and above in sys/socket.h */
+ #if (P_FREEBSD < 4)
+-typedef int socklen_t;
++typedef unsigned int socklen_t;
+ #endif
+ 
+ #define HAS_IFREQ

>Release-Note:
>Audit-Trail:

From: Bill Fenner <fenner@research.att.com>
To: nox@jelal.kn-bremen.de
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: ports/17296: net/openh323 port broken (for -stable at least...)
Date: Thu, 9 Mar 2000 18:40:08 -0800

 You need a more current -stable; socklen_t is now int.
 
   Bill
 

From: Juergen Lock <nox@jelal.kn-bremen.de>
To: Bill Fenner <fenner@research.att.com>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: ports/17296: net/openh323 port broken (for -stable at least...)
Date: Fri, 10 Mar 2000 18:27:19 +0100

 On Thu, Mar 09, 2000 at 06:40:08PM -0800, Bill Fenner wrote:
 > 
 > You need a more current -stable; socklen_t is now int.
 
 Ah, thanx. :)
 
  You happen to know something about its uname -s problem also?
 or do i just need a newer gmake too...
 
  Regards,
 -- 
 Juergen Lock <nox.foo@jelal.kn-bremen.de>
 (remove dot foo from address to reply)
 
Responsible-Changed-From-To: freebsd-ports->roger 
Responsible-Changed-By: mharo 
Responsible-Changed-When: Fri Mar 31 12:53:56 PST 2000 
Responsible-Changed-Why:  
Over to maintainer 
State-Changed-From-To: open->closed 
State-Changed-By: roger 
State-Changed-When: Tue Apr 4 06:22:38 PDT 2000 
State-Changed-Why:  
The root problem is that socklet_t is now declared in sys/socket.h in 
FreeBSD 3.4-stable, 4.x and 5.x and not in older releases of FreeBSD 
including 3.4-RELEASE. 
patches-ab and ac now implement a better os-version checking system  
to define socklen_t only for FreeBSD 3.4-release and earlier. 
This solution has already been added to the OpenH323 development 
sources and will automatically be part of the next official 
release of OpenH323 
>Unformatted:
