From brad@liquidneon.com  Sat Oct 13 07:11:46 2012
Return-Path: <brad@liquidneon.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 735996FD
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 13 Oct 2012 07:11:46 +0000 (UTC)
	(envelope-from brad@liquidneon.com)
Received: from valentine.liquidneon.com (cl-396.dal-01.us.sixxs.net [IPv6:2001:1938:80:18b::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 50B058FC0A
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 13 Oct 2012 07:11:46 +0000 (UTC)
Received: by valentine.liquidneon.com (Postfix, from userid 1001)
	id 3D8178FF30; Sat, 13 Oct 2012 01:11:39 -0600 (MDT)
Message-Id: <20121013071139.3D8178FF30@valentine.liquidneon.com>
Date: Sat, 13 Oct 2012 01:11:39 -0600 (MDT)
From: Brad Davis <brd@FreeBSD.org>
Reply-To: Brad Davis <brd@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] Clean up dependency on twisted in databases/py-carbon
X-Send-Pr-Version: 3.113
X-GNATS-Notify: bsdports@wayfair.com

>Number:         172657
>Category:       ports
>Synopsis:       [patch] Clean up dependency on twisted in databases/py-carbon
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    rm
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Oct 13 07:20:01 UTC 2012
>Closed-Date:    Fri Nov 02 14:42:48 UTC 2012
>Last-Modified:  Fri Nov 02 14:42:48 UTC 2012
>Originator:     Brad Davis
>Release:        FreeBSD
>Organization:
>Environment:


	
>Description:
	Only depend on twisted with USE_TWISTED so we just get twsited core. I tested with only core installed and it works fine, so no need to depend on the whole meta port of twisted.
>How-To-Repeat:
	
>Fix:

	

--- patch-py-carbon begins here ---
Index: Makefile
===================================================================
--- Makefile	(revision 305816)
+++ Makefile	(working copy)
@@ -18,11 +18,11 @@
 LICENSE=	AL2
 
 RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}txamqp>=0.3:${PORTSDIR}/net/py-txamqp \
-		${PYTHON_PKGNAMEPREFIX}whisper>=0.9.10:${PORTSDIR}/databases/py-whisper \
-		${PYTHON_PKGNAMEPREFIX}twisted>=11.0.0:${PORTSDIR}/devel/py-twisted
+		${PYTHON_PKGNAMEPREFIX}whisper>=0.9.10:${PORTSDIR}/databases/py-whisper
 
 USE_PYTHON=	-2.7
 USE_PYDISTUTILS=	yes
+USE_TWISTED=	yes
 FETCH_ARGS=	-pRr
 USE_RC_SUBR=	carbon
 
--- patch-py-carbon ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->freebsd-python 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Oct 13 07:20:31 UTC 2012 
Responsible-Changed-Why:  
freebsd-python@ wants this port PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172657 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sat Oct 13 07:20:33 UTC 2012 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172657 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: bsdports@wayfair.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/172657: [patch] Clean up dependency on twisted in databases/py-carbon
Date: Sat, 13 Oct 2012 07:20:32 UT

 Maintainer of databases/py-carbon,
 
 Please note that PR ports/172657 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/172657
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Ruslan Mahmatkhanov <cvs-src@yandex.ru>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/172657
Date: Tue, 16 Oct 2012 16:43:26 +0400

 Thanks, but it should be USE_TWISTED_RUN=yes however.
 Chris, would you approve?
 
 -- 
 Regards,
 Ruslan
 
 Tinderboxing kills... the drives.
Responsible-Changed-From-To: freebsd-python->rm 
Responsible-Changed-By: rm 
Responsible-Changed-When: Fri Nov 2 14:42:08 UTC 2012 
Responsible-Changed-Why:  
I will take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172657 
State-Changed-From-To: feedback->closed 
State-Changed-By: rm 
State-Changed-When: Fri Nov 2 14:42:47 UTC 2012 
State-Changed-Why:  
Committed, thank you! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172657 
>Unformatted:
