From root@cyberbotx.com  Tue Oct  9 06:13:30 2012
Return-Path: <root@cyberbotx.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 7D68098F
	for <freebsd-gnats-submit@freebsd.org>; Tue,  9 Oct 2012 06:13:30 +0000 (UTC)
	(envelope-from root@cyberbotx.com)
Received: from qmta07.emeryville.ca.mail.comcast.net (qmta07.emeryville.ca.mail.comcast.net [IPv6:2001:558:fe2d:43:76:96:30:64])
	by mx1.freebsd.org (Postfix) with ESMTP id C324B90367
	for <freebsd-gnats-submit@freebsd.org>; Mon,  8 Oct 2012 23:20:17 +0000 (UTC)
Received: from omta04.emeryville.ca.mail.comcast.net ([76.96.30.35])
	by qmta07.emeryville.ca.mail.comcast.net with comcast
	id 8gx91k0040lTkoCA7nLHNQ; Mon, 08 Oct 2012 23:20:17 +0000
Received: from kirby.cyberbotx.com ([69.244.146.119])
	by omta04.emeryville.ca.mail.comcast.net with comcast
	id 8nFG1k0012anbQt8QnFGgF; Mon, 08 Oct 2012 23:15:17 +0000
Received: by kirby.cyberbotx.com (Postfix, from userid 0)
	id 5EB4E2845D; Mon,  8 Oct 2012 19:15:15 -0400 (EDT)
Message-Id: <20121008231515.5EB4E2845D@kirby.cyberbotx.com>
Date: Mon,  8 Oct 2012 19:15:15 -0400 (EDT)
From: Naram Qashat <cyberbotx@cyberbotx.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [MAINTAINER] multimedia/transcode: Update to OptionsNG
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         172516
>Category:       ports
>Synopsis:       [MAINTAINER] multimedia/transcode: Update to OptionsNG
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    madpilot
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 09 22:30:02 UTC 2012
>Closed-Date:    Tue Oct 16 18:32:10 UTC 2012
>Last-Modified:  Tue Oct 16 18:32:10 UTC 2012
>Originator:     Naram Qashat
>Release:        FreeBSD 8.3-RELEASE-p4 amd64
>Organization:
>Environment:
System: FreeBSD kirby.cyberbotx.com 8.3-RELEASE-p4 FreeBSD 8.3-RELEASE-p4 #4: Mon Oct  1 19:56:21 EDT
>Description:
- Update to OptionsNG

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
>How-To-Repeat:
>Fix:

--- transcode-1.1.7_8.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/multimedia/transcode/Makefile ./Makefile
--- /usr/ports/multimedia/transcode/Makefile	2012-10-07 17:06:58.000000000 -0400
+++ ./Makefile	2012-10-08 19:14:39.000000000 -0400
@@ -1,9 +1,5 @@
-# New ports collection makefile for:   transcode
-# Date created: 	17 December 2001
-# Whom: 		Hendrik Scholz <hendrik@scholz.net>
-#
+# Creadted by: Hendrik Scholz <hendrik@scholz.net>
 # $FreeBSD: head/multimedia/transcode/Makefile 301407 2012-07-23 19:27:25Z mm $
-#
 
 PORTNAME=	transcode
 PORTVERSION=	1.1.7
@@ -14,7 +10,7 @@
 MAINTAINER=	cyberbotx@cyberbotx.com
 COMMENT=	A text-console utility for video stream processing
 
-LIB_DEPENDS=	avcodec.1:${PORTSDIR}/multimedia/ffmpeg
+LIB_DEPENDS=	avcodec:${PORTSDIR}/multimedia/ffmpeg
 
 USE_BZIP2=	yes
 FAKEDIR=	${WRKDIR}/fake
@@ -34,30 +30,34 @@
 	tcpvmexportd.1 tcxmlcheck.1 transcode_export.1 transcode_filter.1 \
 	transcode_import.1 tcexport.1 tcmodchain.1
 
-OPTIONS=	OPTIMIZED_CFLAGS "Build with optimizations" off \
-		X11 "Build with X11 support" off \
-		MPEG2 "Enable libmpeg2 support" off \
-		BKTR "Enable bktr support" off \
-		POSTPROC "Enable libpostproc support" off \
-		FREETYPE "Enable FreeType2 support" off \
-		LAME "Enable lame support" on \
-		XVID "Enable Xvid support" off \
-		X264 "Enable x264 support" off \
-		OGG "Enable ogg support" off \
-		VORBIS "Enable vorbis support" off \
-		THEORA "Enable theora support" off \
-		DVDREAD "Enable libdvdread support" on \
-		LIBDV "Enable libdv support" off \
-		QUICKTIME "Enable libquicktime support" off \
-		LZO "Enable LZO support" off \
-		LIBA52 "Enable a52 support (as default decoder)" off \
-		FAAC "Enable faac support" off \
-		XML "Enable libxml2 support" off \
-		MJPEG "Enable mjpegtools support" off \
-		SDL "Enable SDL support" off \
-		IMAGEMAGICK "Enable ImageMagick support" off \
-		JPEG "Enable libjpeg support" on \
-		ICONV "Enable libiconv support" on
+NO_OPTIONS_SORT=	yes
+OPTIONS_DEFINE=	OPTIMIZED_CFLAGS X11 MPEG2 BKTR POSTPROC FREETYPE LAME XVID \
+		X264 OGG VORBIS THEORA DVDREAD LIBDV QUICKTIME LZO LIBA52 \
+		FAAC XML MJPEG SDL IMAGEMAGICK JPEG ICONV
+OPTIONS_DEFAULT=	LAME DVDREAD JPEG ICONV
+X11_DESC=	Enable X11 support
+MPEG2_DESC=	Enable libmpeg2 MPEG-2 video codec support
+BKTR_DESC=	Enable bktr capture card support
+POSTPROC_DESC=	Enable libpostproc support
+FREETYPE_DESC=	Enable FreeType2 font rendering support
+LAME_DESC=	Enable LAME MP3 audio support
+XVID_DESC=	Enable Xvid MPEG-4 video codec support
+X264_DESC=	Enable x264 H.264 video codec support
+OGG_DESC=	Enable Ogg media format support
+VORBIS_DESC=	Enable Ogg Vorbis audio codec support
+THEORA_DESC=	Enable Ogg Theora video codec support
+DVDREAD_DESC=	Enable libdvdread support
+LIBDV_DESC=	Enable libdv video encoding support
+QUICKTIME_DESC=	Enable QuickTime video support
+LZO_DESC=	Enable LZO compression support
+LIBA52_DESC=	Enable a52 support (as default decoder)
+FAAC_DESC=	Enable FAAC AAC encoder support
+XML_DESC=	Enable libsml2 XML support
+MJPEG_DESC=	Enable mjpegtools support
+SDL_DESC=	Enable SDL support
+IMAGEMAGICK_DESC=	Enable ImageMagick support
+JPEG_DESC=	Enable libjpeg support
+ICONV_DESC=	Enable libiconv support
 
 .include <bsd.port.pre.mk>
 
@@ -65,158 +65,158 @@
 CONFIGURE_ENV+=	LIBAVCODEC_EXTRA_LIBS="-pthread"
 .endif
 
-.if !defined(WITHOUT_X11)
+.if ${PORT_OPTIONS:MX11}
 USE_XORG=	xv xaw xpm
 CONFIGURE_ARGS+=	--with-x
 .else
 CONFIGURE_ARGS+=	--without-x
 .endif
 
-.if defined(WITH_MPEG2)
-LIB_DEPENDS+=	mpeg2.0:${PORTSDIR}/multimedia/libmpeg2
+.if ${PORT_OPTIONS:MMPEG2}
+LIB_DEPENDS+=	mpeg2:${PORTSDIR}/multimedia/libmpeg2
 CONFIGURE_ARGS+=	--enable-libmpeg2 --enable-libmpeg2convert
 .else
 CONFIGURE_ARGS+=	--disable-libmpeg2
 .endif
 
-.if defined(WITH_BKTR)
+.if ${PORT_OPTIONS:MBKTR}
 CONFIGURE_ARGS+=	--enable-bktr
 .endif
 
-.if !defined(WITHOUT_POSTPROC)
+.if ${PORT_OPTIONS:MPOSTPROC}
 CONFIGURE_ARGS+=	--enable-libpostproc
 .else
 CONFIGURE_ARGS+=	--disable-libpostproc
 .endif
 
-.if defined(WITH_FREETYPE)
-LIB_DEPENDS+=	freetype.9:${PORTSDIR}/print/freetype2
+.if ${PORT_OPTIONS:MFREETYPE}
+LIB_DEPENDS+=	freetype:${PORTSDIR}/print/freetype2
 CONFIGURE_ARGS+=	--enable-freetype2
 .else
 CONFIGURE_ARGS+=	--disable-freetype2
 .endif
 
-.if !defined(WITHOUT_LAME)
-LIB_DEPENDS+=	mp3lame.0:${PORTSDIR}/audio/lame
+.if ${PORT_OPTIONS:MLAME}
+LIB_DEPENDS+=	mp3lame:${PORTSDIR}/audio/lame
 CONFIGURE_ARGS+=	--with-lame-prefix=${LOCALBASE} --enable-lame
 .else
 CONFIGURE_ARGS+=	--disable-lame
 .endif
 
-.if defined(WITH_XVID)
-LIB_DEPENDS+=	xvidcore.4:${PORTSDIR}/multimedia/xvid
+.if ${PORT_OPTIONS:MXVID}
+LIB_DEPENDS+=	xvidcore:${PORTSDIR}/multimedia/xvid
 CONFIGURE_ARGS+=	--with-xvid-prefix=${LOCALBASE} --enable-xvid
 .else
 CONFIGURE_ARGS+=	--disable-xvid
 .endif
 
-.if defined(WITH_X264)
-LIB_DEPENDS+=	x264.125:${PORTSDIR}/multimedia/x264
+.if ${PORT_OPTIONS:MX264}
+LIB_DEPENDS+=	x264:${PORTSDIR}/multimedia/x264
 CONFIGURE_ARGS+=	--enable-x264
 .else
 CONFIGURE_ARGS+=	--disable-x264
 .endif
 
-.if defined(WITH_OGG)
+.if ${PORT_OPTIONS:MOGG}
 LIB_DEPENDS+=	ogg:${PORTSDIR}/audio/libogg
 CONFIGURE_ARGS+=	--enable-ogg
 .else
 CONFIGURE_ARGS+=	--disable-ogg
 .endif
 
-.if defined(WITH_VORBIS)
-LIB_DEPENDS+=	vorbis.4:${PORTSDIR}/audio/libvorbis
+.if ${PORT_OPTIONS:MVORBIS}
+LIB_DEPENDS+=	vorbis:${PORTSDIR}/audio/libvorbis
 CONFIGURE_ARGS+=	--enable-vorbis
 .else
 CONFIGURE_ARGS+=	--disable-vorbis
 .endif
 
-.if defined(WITH_THEORA)
-LIB_DEPENDS+=	theora.0:${PORTSDIR}/multimedia/libtheora
+.if ${PORT_OPTIONS:MTHEORA}
+LIB_DEPENDS+=	theora:${PORTSDIR}/multimedia/libtheora
 CONFIGURE_ARGS+=	--enable-theora
 .else
 CONFIGURE_ARGS+=	--disable-theora
 .endif
 
-.if !defined(WITHOUT_DVDREAD)
-LIB_DEPENDS+=	dvdread.4:${PORTSDIR}/multimedia/libdvdread
+.if ${PORT_OPTIONS:MDVDREAD}
+LIB_DEPENDS+=	dvdread:${PORTSDIR}/multimedia/libdvdread
 CONFIGURE_ARGS+=	--with-libdvdread-prefix=${LOCALBASE} --enable-libdvdread
 .else
 CONFIGURE_ARGS+=	--disable-libdvdread
 .endif
 
-.if defined(WITH_LIBDV)
-LIB_DEPENDS+=	dv.4:${PORTSDIR}/multimedia/libdv
+.if ${PORT_OPTIONS:MLIBDV}
+LIB_DEPENDS+=	dv:${PORTSDIR}/multimedia/libdv
 CONFIGURE_ARGS+=	--enable-libdv
 .else
 CONFIGURE_ARGS+=	--disable-libdv
 .endif
 
-.if defined(WITH_QUICKTIME)
-LIB_DEPENDS+=	quicktime.0:${PORTSDIR}/multimedia/libquicktime
+.if ${PORT_OPTIONS:MQUICKTIME}
+LIB_DEPENDS+=	quicktime:${PORTSDIR}/multimedia/libquicktime
 CONFIGURE_ARGS+=	--enable-libquicktime
 .else
 CONFIGURE_ARGS+=	--disable-libquicktime
 .endif
 
-.if defined(WITH_LZO)
-LIB_DEPENDS+=	lzo2.2:${PORTSDIR}/archivers/lzo2
+.if ${PORT_OPTIONS:MLZO}
+LIB_DEPENDS+=	lzo2:${PORTSDIR}/archivers/lzo2
 CONFIGURE_ARGS+=	--with-lzo-prefix=${LOCALBASE} --with-lzo-includes=${LOCALBASE} \
 			--enable-lzo
 .else
 CONFIGURE_ARGS+=	--disable-lzo
 .endif
 
-.if defined(WITH_LIBA52)
-LIB_DEPENDS+=	a52.0:${PORTSDIR}/audio/liba52
+.if ${PORT_OPTIONS:MLIBA52}
+LIB_DEPENDS+=	a52:${PORTSDIR}/audio/liba52
 CONFIGURE_ARGS+=	--with-a52-prefix=${LOCALBASE} --enable-a52
 .else
 CONFIGURE_ARGS+=	--disable-a52
 .endif
 
-.if defined(WITH_FAAC)
-LIB_DEPENDS+=	faac.0:${PORTSDIR}/audio/faac
+.if ${PORT_OPTIONS:MFAAC}
+LIB_DEPENDS+=	faac:${PORTSDIR}/audio/faac
 CONFIGURE_ARGS+=	--with-faac-prefix=${LOCALBASE} --enable-faac
 .else
 CONFIGURE_ARGS+=	--disable-faac
 .endif
 
-.if !defined(WITHOUT_XML) && (defined(WITH_XML) || ${HAVE_GNOME:Mlibxml2}!="")
+.if ${PORT_OPTIONS:MXML}
 USE_GNOME+=	libxml2
 CONFIGURE_ARGS+=	--enable-libxml2
 .else
 CONFIGURE_ARGS+=	--disable-libxml2
 .endif
 
-.if defined(WITH_MJPEG)
-LIB_DEPENDS+=	lavjpeg-2.0.0:${PORTSDIR}/multimedia/mjpegtools
+.if ${PORT_OPTIONS:MMJPEG}
+LIB_DEPENDS+=	lavjpeg-2:${PORTSDIR}/multimedia/mjpegtools
 CONFIGURE_ARGS+=	--enable-mjpegtools
 .else
 CONFIGURE_ARGS+=	--disable-mjpegtools
 .endif
 
-.if !defined(WITHOUT_SDL) && (defined(WITH_SDL) || ${HAVE_SDL:Msdl}!="")
+.if ${PORT_OPTIONS:MSDL}
 USE_SDL+=	sdl
 CONFIGURE_ARGS+=	--enable-sdl
 .else
 CONFIGURE_ARGS+=	--disable-sdl
 .endif
 
-.if defined(WITH_IMAGEMAGICK)
-LIB_DEPENDS+=	MagickWand.5:${PORTSDIR}/graphics/ImageMagick
+.if ${PORT_OPTIONS:MIMAGEMAGICK}
+LIB_DEPENDS+=	MagickWand:${PORTSDIR}/graphics/ImageMagick
 CONFIGURE_ARGS+=	--with-imagemagick-prefix=${LOCALBASE} --enable-imagemagick
 .else
 CONFIGURE_ARGS+=	--disable-imagemagick
 .endif
 
-.if !defined(WITHOUT_JPEG)
-LIB_DEPENDS+=	jpeg.11:${PORTSDIR}/graphics/jpeg
+.if ${PORT_OPTIONS:MJPEG}
+LIB_DEPENDS+=	jpeg:${PORTSDIR}/graphics/jpeg
 CONFIGURE_ARGS+=	--with-libjpeg-prefix=${LOCALBASE} --enable-libjpeg
 .else
 CONFIGURE_ARGS+=	--disable-libjpeg
 .endif
 
-.if !defined(WITHOUT_ICONV)
+.if ${PORT_OPTIONS:MICONV}
 USE_ICONV=	yes
 CONFIGURE_ARGS+=	--with-iconv-prefix=${LOCALBASE} --enable-iconv
 .else
@@ -224,12 +224,12 @@
 .endif
 
 post-patch:
-.if defined(WITH_LZO) && !defined(WITHOUT_LZO)
+.if ${PORT_OPTIONS:MLZO}
 	@${REINPLACE_CMD} -e 's|%%NUV%%|nuv|' ${WRKSRC}/import/Makefile.in
 .else
 	@${REINPLACE_CMD} -e 's|%%NUV%%||' ${WRKSRC}/import/Makefile.in
 .endif
-.if !defined(WITH_OPTIMIZED_CFLAGS)
+.if !${PORT_OPTIONS:MOPTIMIZED_CFLAGS}
 	@${FIND} ${WRKSRC} -type f | ${XARGS} -n 10 -x ${REINPLACE_CMD} \
 		-e 's|-O[236]|${CFLAGS}|'
 .endif
--- transcode-1.1.7_8.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->madpilot 
Responsible-Changed-By: madpilot 
Responsible-Changed-When: Mon Oct 15 17:30:38 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172516 

From: Guido Falsi <madpilot@FreeBSD.org>
To: bug-followup@FreeBSD.org, cyberbotx@cyberbotx.com
Cc:  
Subject: Re: ports/172516: [MAINTAINER] multimedia/transcode: Update to OptionsNG
Date: Mon, 15 Oct 2012 21:19:30 +0200

 This is a multi-part message in MIME format.
 --------------020408000207000004010907
 Content-Type: text/plain; charset=ISO-8859-15
 Content-Transfer-Encoding: 7bit
 
 Hi,
 
 Looking at your patch I made some modifications.
 
 Is there a specific reason why you're not using the standard options
 descriptions from ports/Mk/bsd.options.desc.mk?
 
 While not strictly mandatory, unless you need to insert a very specific
 content in the description it's preferred to use those for generic
 "support" toggles.
 
 Please revise the attached patch, if it is acceptable to you.
 
 Thanks!
 
 -- 
 Guido Falsi <madpilot@FreeBSD.org>
 
 --------------020408000207000004010907
 Content-Type: text/plain; charset=us-ascii;
  name="transcode.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="transcode.diff"
 
 Index: Makefile
 ===================================================================
 --- Makefile	(revision 305927)
 +++ Makefile	(working copy)
 @@ -1,9 +1,5 @@
 -# New ports collection makefile for:   transcode
 -# Date created: 	17 December 2001
 -# Whom: 		Hendrik Scholz <hendrik@scholz.net>
 -#
 +# Creadted by: Hendrik Scholz <hendrik@scholz.net>
  # $FreeBSD$
 -#
  
  PORTNAME=	transcode
  PORTVERSION=	1.1.7
 @@ -14,7 +10,7 @@
  MAINTAINER=	cyberbotx@cyberbotx.com
  COMMENT=	A text-console utility for video stream processing
  
 -LIB_DEPENDS=	avcodec.1:${PORTSDIR}/multimedia/ffmpeg
 +LIB_DEPENDS=	avcodec:${PORTSDIR}/multimedia/ffmpeg
  
  USE_BZIP2=	yes
  FAKEDIR=	${WRKDIR}/fake
 @@ -34,30 +30,17 @@
  	tcpvmexportd.1 tcxmlcheck.1 transcode_export.1 transcode_filter.1 \
  	transcode_import.1 tcexport.1 tcmodchain.1
  
 -OPTIONS=	OPTIMIZED_CFLAGS "Build with optimizations" off \
 -		X11 "Build with X11 support" off \
 -		MPEG2 "Enable libmpeg2 support" off \
 -		BKTR "Enable bktr support" off \
 -		POSTPROC "Enable libpostproc support" off \
 -		FREETYPE "Enable FreeType2 support" off \
 -		LAME "Enable lame support" on \
 -		XVID "Enable Xvid support" off \
 -		X264 "Enable x264 support" off \
 -		OGG "Enable ogg support" off \
 -		VORBIS "Enable vorbis support" off \
 -		THEORA "Enable theora support" off \
 -		DVDREAD "Enable libdvdread support" on \
 -		LIBDV "Enable libdv support" off \
 -		QUICKTIME "Enable libquicktime support" off \
 -		LZO "Enable LZO support" off \
 -		LIBA52 "Enable a52 support (as default decoder)" off \
 -		FAAC "Enable faac support" off \
 -		XML "Enable libxml2 support" off \
 -		MJPEG "Enable mjpegtools support" off \
 -		SDL "Enable SDL support" off \
 -		IMAGEMAGICK "Enable ImageMagick support" off \
 -		JPEG "Enable libjpeg support" on \
 -		ICONV "Enable libiconv support" on
 +NO_OPTIONS_SORT=	yes
 +OPTIONS_DEFINE=	OPTIMIZED_CFLAGS X11 MPEG2 BKTR POSTPROC FREETYPE LAME XVID \
 +		X264 OGG VORBIS THEORA DVDREAD DV QUICKTIME LZO LIBA52 \
 +		FAAC XML MJPEGTOOLS SDL IMAGEMAGICK JPEG ICONV
 +OPTIONS_DEFAULT=	LAME DVDREAD JPEG ICONV
 +BKTR_DESC=	Bktr capture card support
 +POSTPROC_DESC=	Libpostproc support
 +DVDREAD_DESC=	Libdvdread support
 +LZO_DESC=	LZO compression support
 +LIBA52_DESC=	a52 support (as default decoder)
 +XML_DESC=	Libxml2 XML support
  
  .include <bsd.port.pre.mk>
  
 @@ -65,158 +48,158 @@
  CONFIGURE_ENV+=	LIBAVCODEC_EXTRA_LIBS="-pthread"
  .endif
  
 -.if !defined(WITHOUT_X11)
 +.if ${PORT_OPTIONS:MX11}
  USE_XORG=	xv xaw xpm
  CONFIGURE_ARGS+=	--with-x
  .else
  CONFIGURE_ARGS+=	--without-x
  .endif
  
 -.if defined(WITH_MPEG2)
 -LIB_DEPENDS+=	mpeg2.0:${PORTSDIR}/multimedia/libmpeg2
 +.if ${PORT_OPTIONS:MMPEG2}
 +LIB_DEPENDS+=	mpeg2:${PORTSDIR}/multimedia/libmpeg2
  CONFIGURE_ARGS+=	--enable-libmpeg2 --enable-libmpeg2convert
  .else
  CONFIGURE_ARGS+=	--disable-libmpeg2
  .endif
  
 -.if defined(WITH_BKTR)
 +.if ${PORT_OPTIONS:MBKTR}
  CONFIGURE_ARGS+=	--enable-bktr
  .endif
  
 -.if !defined(WITHOUT_POSTPROC)
 +.if ${PORT_OPTIONS:MPOSTPROC}
  CONFIGURE_ARGS+=	--enable-libpostproc
  .else
  CONFIGURE_ARGS+=	--disable-libpostproc
  .endif
  
 -.if defined(WITH_FREETYPE)
 -LIB_DEPENDS+=	freetype.9:${PORTSDIR}/print/freetype2
 +.if ${PORT_OPTIONS:MFREETYPE}
 +LIB_DEPENDS+=	freetype:${PORTSDIR}/print/freetype2
  CONFIGURE_ARGS+=	--enable-freetype2
  .else
  CONFIGURE_ARGS+=	--disable-freetype2
  .endif
  
 -.if !defined(WITHOUT_LAME)
 -LIB_DEPENDS+=	mp3lame.0:${PORTSDIR}/audio/lame
 +.if ${PORT_OPTIONS:MLAME}
 +LIB_DEPENDS+=	mp3lame:${PORTSDIR}/audio/lame
  CONFIGURE_ARGS+=	--with-lame-prefix=${LOCALBASE} --enable-lame
  .else
  CONFIGURE_ARGS+=	--disable-lame
  .endif
  
 -.if defined(WITH_XVID)
 -LIB_DEPENDS+=	xvidcore.4:${PORTSDIR}/multimedia/xvid
 +.if ${PORT_OPTIONS:MXVID}
 +LIB_DEPENDS+=	xvidcore:${PORTSDIR}/multimedia/xvid
  CONFIGURE_ARGS+=	--with-xvid-prefix=${LOCALBASE} --enable-xvid
  .else
  CONFIGURE_ARGS+=	--disable-xvid
  .endif
  
 -.if defined(WITH_X264)
 -LIB_DEPENDS+=	x264.125:${PORTSDIR}/multimedia/x264
 +.if ${PORT_OPTIONS:MX264}
 +LIB_DEPENDS+=	x264:${PORTSDIR}/multimedia/x264
  CONFIGURE_ARGS+=	--enable-x264
  .else
  CONFIGURE_ARGS+=	--disable-x264
  .endif
  
 -.if defined(WITH_OGG)
 +.if ${PORT_OPTIONS:MOGG}
  LIB_DEPENDS+=	ogg:${PORTSDIR}/audio/libogg
  CONFIGURE_ARGS+=	--enable-ogg
  .else
  CONFIGURE_ARGS+=	--disable-ogg
  .endif
  
 -.if defined(WITH_VORBIS)
 -LIB_DEPENDS+=	vorbis.4:${PORTSDIR}/audio/libvorbis
 +.if ${PORT_OPTIONS:MVORBIS}
 +LIB_DEPENDS+=	vorbis:${PORTSDIR}/audio/libvorbis
  CONFIGURE_ARGS+=	--enable-vorbis
  .else
  CONFIGURE_ARGS+=	--disable-vorbis
  .endif
  
 -.if defined(WITH_THEORA)
 -LIB_DEPENDS+=	theora.0:${PORTSDIR}/multimedia/libtheora
 +.if ${PORT_OPTIONS:MTHEORA}
 +LIB_DEPENDS+=	theora:${PORTSDIR}/multimedia/libtheora
  CONFIGURE_ARGS+=	--enable-theora
  .else
  CONFIGURE_ARGS+=	--disable-theora
  .endif
  
 -.if !defined(WITHOUT_DVDREAD)
 -LIB_DEPENDS+=	dvdread.4:${PORTSDIR}/multimedia/libdvdread
 +.if ${PORT_OPTIONS:MDVDREAD}
 +LIB_DEPENDS+=	dvdread:${PORTSDIR}/multimedia/libdvdread
  CONFIGURE_ARGS+=	--with-libdvdread-prefix=${LOCALBASE} --enable-libdvdread
  .else
  CONFIGURE_ARGS+=	--disable-libdvdread
  .endif
  
 -.if defined(WITH_LIBDV)
 -LIB_DEPENDS+=	dv.4:${PORTSDIR}/multimedia/libdv
 +.if ${PORT_OPTIONS:MDV}
 +LIB_DEPENDS+=	dv:${PORTSDIR}/multimedia/libdv
  CONFIGURE_ARGS+=	--enable-libdv
  .else
  CONFIGURE_ARGS+=	--disable-libdv
  .endif
  
 -.if defined(WITH_QUICKTIME)
 -LIB_DEPENDS+=	quicktime.0:${PORTSDIR}/multimedia/libquicktime
 +.if ${PORT_OPTIONS:MQUICKTIME}
 +LIB_DEPENDS+=	quicktime:${PORTSDIR}/multimedia/libquicktime
  CONFIGURE_ARGS+=	--enable-libquicktime
  .else
  CONFIGURE_ARGS+=	--disable-libquicktime
  .endif
  
 -.if defined(WITH_LZO)
 -LIB_DEPENDS+=	lzo2.2:${PORTSDIR}/archivers/lzo2
 +.if ${PORT_OPTIONS:MLZO}
 +LIB_DEPENDS+=	lzo2:${PORTSDIR}/archivers/lzo2
  CONFIGURE_ARGS+=	--with-lzo-prefix=${LOCALBASE} --with-lzo-includes=${LOCALBASE} \
  			--enable-lzo
  .else
  CONFIGURE_ARGS+=	--disable-lzo
  .endif
  
 -.if defined(WITH_LIBA52)
 -LIB_DEPENDS+=	a52.0:${PORTSDIR}/audio/liba52
 +.if ${PORT_OPTIONS:MLIBA52}
 +LIB_DEPENDS+=	a52:${PORTSDIR}/audio/liba52
  CONFIGURE_ARGS+=	--with-a52-prefix=${LOCALBASE} --enable-a52
  .else
  CONFIGURE_ARGS+=	--disable-a52
  .endif
  
 -.if defined(WITH_FAAC)
 -LIB_DEPENDS+=	faac.0:${PORTSDIR}/audio/faac
 +.if ${PORT_OPTIONS:MFAAC}
 +LIB_DEPENDS+=	faac:${PORTSDIR}/audio/faac
  CONFIGURE_ARGS+=	--with-faac-prefix=${LOCALBASE} --enable-faac
  .else
  CONFIGURE_ARGS+=	--disable-faac
  .endif
  
 -.if !defined(WITHOUT_XML) && (defined(WITH_XML) || ${HAVE_GNOME:Mlibxml2}!="")
 +.if ${PORT_OPTIONS:MXML}
  USE_GNOME+=	libxml2
  CONFIGURE_ARGS+=	--enable-libxml2
  .else
  CONFIGURE_ARGS+=	--disable-libxml2
  .endif
  
 -.if defined(WITH_MJPEG)
 -LIB_DEPENDS+=	lavjpeg-2.0.0:${PORTSDIR}/multimedia/mjpegtools
 +.if ${PORT_OPTIONS:MMJPEGTOOLS}
 +LIB_DEPENDS+=	lavjpeg-2:${PORTSDIR}/multimedia/mjpegtools
  CONFIGURE_ARGS+=	--enable-mjpegtools
  .else
  CONFIGURE_ARGS+=	--disable-mjpegtools
  .endif
  
 -.if !defined(WITHOUT_SDL) && (defined(WITH_SDL) || ${HAVE_SDL:Msdl}!="")
 +.if ${PORT_OPTIONS:MSDL}
  USE_SDL+=	sdl
  CONFIGURE_ARGS+=	--enable-sdl
  .else
  CONFIGURE_ARGS+=	--disable-sdl
  .endif
  
 -.if defined(WITH_IMAGEMAGICK)
 -LIB_DEPENDS+=	MagickWand.5:${PORTSDIR}/graphics/ImageMagick
 +.if ${PORT_OPTIONS:MIMAGEMAGICK}
 +LIB_DEPENDS+=	MagickWand:${PORTSDIR}/graphics/ImageMagick
  CONFIGURE_ARGS+=	--with-imagemagick-prefix=${LOCALBASE} --enable-imagemagick
  .else
  CONFIGURE_ARGS+=	--disable-imagemagick
  .endif
  
 -.if !defined(WITHOUT_JPEG)
 -LIB_DEPENDS+=	jpeg.11:${PORTSDIR}/graphics/jpeg
 +.if ${PORT_OPTIONS:MJPEG}
 +LIB_DEPENDS+=	jpeg:${PORTSDIR}/graphics/jpeg
  CONFIGURE_ARGS+=	--with-libjpeg-prefix=${LOCALBASE} --enable-libjpeg
  .else
  CONFIGURE_ARGS+=	--disable-libjpeg
  .endif
  
 -.if !defined(WITHOUT_ICONV)
 +.if ${PORT_OPTIONS:MICONV}
  USE_ICONV=	yes
  CONFIGURE_ARGS+=	--with-iconv-prefix=${LOCALBASE} --enable-iconv
  .else
 @@ -224,12 +207,12 @@
  .endif
  
  post-patch:
 -.if defined(WITH_LZO) && !defined(WITHOUT_LZO)
 +.if ${PORT_OPTIONS:MLZO}
  	@${REINPLACE_CMD} -e 's|%%NUV%%|nuv|' ${WRKSRC}/import/Makefile.in
  .else
  	@${REINPLACE_CMD} -e 's|%%NUV%%||' ${WRKSRC}/import/Makefile.in
  .endif
 -.if !defined(WITH_OPTIMIZED_CFLAGS)
 +.if !${PORT_OPTIONS:MOPTIMIZED_CFLAGS}
  	@${FIND} ${WRKSRC} -type f | ${XARGS} -n 10 -x ${REINPLACE_CMD} \
  		-e 's|-O[236]|${CFLAGS}|'
  .endif
 
 --------------020408000207000004010907--

From: Naram Qashat <cyberbotx@cyberbotx.com>
To: Guido Falsi <madpilot@FreeBSD.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/172516: [MAINTAINER] multimedia/transcode: Update to OptionsNG
Date: Mon, 15 Oct 2012 15:30:55 -0400

 On 10/15/12 15:19, Guido Falsi wrote:
 > Hi,
 >
 > Looking at your patch I made some modifications.
 >
 > Is there a specific reason why you're not using the standard options
 > descriptions from ports/Mk/bsd.options.desc.mk?
 >
 > While not strictly mandatory, unless you need to insert a very specific
 > content in the description it's preferred to use those for generic
 > "support" toggles.
 >
 > Please revise the attached patch, if it is acceptable to you.
 >
 > Thanks!
 >
 
 Originally I figured that the descriptions in bsd.options.desc.mk would lead to 
 more confusion when someone looked at the options for transcode, that is why I 
 overrode them in the port.  I know that using the pre-set descriptions may be 
 preferred, but I still tried to make sure that the overridden descriptions were 
 not ambiguous.
 
 Thanks,
 Naram Qashat

From: Guido Falsi <madpilot@FreeBSD.org>
To: Naram Qashat <cyberbotx@cyberbotx.com>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/172516: [MAINTAINER] multimedia/transcode: Update to
 OptionsNG
Date: Tue, 16 Oct 2012 11:24:20 +0200

 On Mon, Oct 15, 2012 at 03:30:55PM -0400, Naram Qashat wrote:
 > On 10/15/12 15:19, Guido Falsi wrote:
 > >Hi,
 > >
 > >Looking at your patch I made some modifications.
 > >
 > >Is there a specific reason why you're not using the standard options
 > >descriptions from ports/Mk/bsd.options.desc.mk?
 > >
 > >While not strictly mandatory, unless you need to insert a very specific
 > >content in the description it's preferred to use those for generic
 > >"support" toggles.
 > >
 > >Please revise the attached patch, if it is acceptable to you.
 > >
 > >Thanks!
 > >
 > 
 > Originally I figured that the descriptions in bsd.options.desc.mk
 > would lead to more confusion when someone looked at the options for
 > transcode, that is why I overrode them in the port.  I know that
 > using the pre-set descriptions may be preferred, but I still tried
 > to make sure that the overridden descriptions were not ambiguous.
 
 I see. I'd like to note that the "Enable" word at the start of every
 description is a little redundant, since the checkbox is there to shouw
 if that option is enablesd or not. "Enable" words where intentionally
 removed from the descriptions in various instances as redundant.
 
 See this commit:
 
 http://svnweb.freebsd.org/ports?view=revision&revision=299905
 
 Once the "Enable" word is removed some of the descriptions are almost
 the same as the global ones.
 
 Also I renamed some of the toggles to match the common ones, this is
 best practice, so that people can override things globally from their
 make.conf or command line.
 
 I don't mean to force you to change this, but the enable wod goes
 against common practice int he ports collection and should be avoided.
 
 -- 
 Guido Falsi <madpilot@FreeBSD.org>

From: Naram Qashat <cyberbotx@cyberbotx.com>
To: Guido Falsi <madpilot@FreeBSD.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/172516: [MAINTAINER] multimedia/transcode: Update to OptionsNG
Date: Tue, 16 Oct 2012 07:46:04 -0400

 On 10/16/12 05:24, Guido Falsi wrote:
 > On Mon, Oct 15, 2012 at 03:30:55PM -0400, Naram Qashat wrote:
 >> On 10/15/12 15:19, Guido Falsi wrote:
 >>> Hi,
 >>>
 >>> Looking at your patch I made some modifications.
 >>>
 >>> Is there a specific reason why you're not using the standard options
 >>> descriptions from ports/Mk/bsd.options.desc.mk?
 >>>
 >>> While not strictly mandatory, unless you need to insert a very specific
 >>> content in the description it's preferred to use those for generic
 >>> "support" toggles.
 >>>
 >>> Please revise the attached patch, if it is acceptable to you.
 >>>
 >>> Thanks!
 >>>
 >>
 >> Originally I figured that the descriptions in bsd.options.desc.mk
 >> would lead to more confusion when someone looked at the options for
 >> transcode, that is why I overrode them in the port.  I know that
 >> using the pre-set descriptions may be preferred, but I still tried
 >> to make sure that the overridden descriptions were not ambiguous.
 >
 > I see. I'd like to note that the "Enable" word at the start of every
 > description is a little redundant, since the checkbox is there to shouw
 > if that option is enablesd or not. "Enable" words where intentionally
 > removed from the descriptions in various instances as redundant.
 >
 > See this commit:
 >
 > http://svnweb.freebsd.org/ports?view=revision&revision=299905
 >
 > Once the "Enable" word is removed some of the descriptions are almost
 > the same as the global ones.
 >
 > Also I renamed some of the toggles to match the common ones, this is
 > best practice, so that people can override things globally from their
 > make.conf or command line.
 >
 > I don't mean to force you to change this, but the enable wod goes
 > against common practice int he ports collection and should be avoided.
 >
 
 In that case, the changes are fine.  Feel free to commit them.
 
 Thanks,
 Naram Qashat
State-Changed-From-To: open->closed 
State-Changed-By: madpilot 
State-Changed-When: Tue Oct 16 18:32:10 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172516 
>Unformatted:
